David Smith
f1697ec7c8
Refs #31026 -- Simplified BaseForm.get_context().
...
bf.errors returns an ErrorList. Access this directly and avoid creating
a new instance in BaseForm.get_context()
Calling str() on the ErrorList can also be deferred to when the
variable used in the template.
2023-11-20 08:57:03 +01:00
Mariusz Felisiak
ecfea054ee
Refs #34118 -- Doc'd Python 3.12 compatibility in Django 4.2.x.
2023-11-19 16:31:46 +01:00
Mariusz Felisiak
f955c90488
Refs #34118 -- Added Python 3.12 to classifiers and tox.ini.
2023-11-19 16:31:46 +01:00
Mariusz Felisiak
19c4052f98
Refs #34118 -- Used Python 3.12 for GitHub actions.
2023-11-18 16:58:25 +01:00
Simon Charette
911b1619ab
Refs #34975 -- Handled optional source expressions in Expression.get_refs().
...
While no code is directly exercising get_refs in a way that triggers
a crash some expressions such as Window stash None in source_expressions
which can obscure the origin of some bugs.
Handling None values like we do in other source_expression traversing
methods such as .contains_aggregates ensures we don't run into surprises
in the future where get_refs() might be used for a different purpose.
2023-11-18 15:41:59 +01:00
Simon Charette
d7a9f006ed
Refs #34717 -- Avoided computing aggregate refs twice.
2023-11-18 15:41:25 +01:00
Simon Charette
15cb3c262a
Refs #34975 -- Complemented rhs filtering aggregations for __in lookup.
...
While this isn't a regression it's clear that similar logic should be
applied when dealing with lists of expressions passed as a lookup value.
2023-11-18 15:40:52 +01:00
Simon Charette
7530cf3900
Fixed #34975 -- Fixed crash of conditional aggregate() over aggregations.
...
Adjustments made to solve_lookup_type to defer the resolving of
references for summarized aggregates failed to account for similar
requirements for lookup values which can also reference annotations
through Aggregate.filter.
Regression in b181cae2e3
.
Refs #25307 .
Thanks Sergey Nesterenko for the report.
2023-11-18 15:38:04 +01:00
Mariusz Felisiak
594873befb
Removed obsolete warnings about asgiref.sync adapters with sensitive variables.
...
Django 5.0+ required asgiref 3.7+, and this warning is obsolete for
asgiref 3.7+ since
be6635e0e7
.
2023-11-17 12:09:32 +01:00
Thibaud Colas
6daf86058b
Doc'd support for assistive technologies in the admin.
2023-11-17 09:29:24 +01:00
David Smith
eec7e9ba89
Refs #32819 -- Established relationship between form fieldsets and their help text.
...
This adds aria-describedby for widgets rendered in a fieldset such as
radios. aria-describedby for these widgets is added to the <fieldset>
element rather than each <input>.
2023-11-17 08:12:36 +01:00
David Smith
557fa51837
Refs #32819 -- Added aria-describedby test for widgets with custom id.
2023-11-17 05:43:33 +01:00
David Smith
292f1ea90f
Refs #32819 -- Used auto_id instead of id_for_label as unique identifier for the field.
...
`id_for_label` is blank for widgets with multiple inputs such as radios
and multiple checkboxes. Therefore , `help_text` for fields using these
widgets cannot currently be associated using `aria-describedby`.
`id_for_label` is being used as a guard to avoid incorrectly adding
`aria-describedby` to those widgets.
This change uses `auto_id` as the unique identified for the fields
`help_text`. A guard is added to avoid incorrectly adding
`aria-describedby` to inputs by checking the widget's `use_fieldset`
attribute. Fields rendered in a `<fieldset>` should have
`aria-describedby` added to the `<fieldset>` and not every `<input>`.
2023-11-16 12:23:42 +01:00
Markus Amalthea Magnuson
61c305f298
Fixed #34970 -- Clarified Password Validation docs regarding the password_changed callback.
2023-11-15 15:35:25 -03:00
Giannis Terzopoulos
36ed45d27c
Removed obsolete sentence in custom model field docs.
2023-11-15 13:48:45 +01:00
William Hayes
640283711e
Refs #33690 -- Added missing data-theme selector to example in theming support docs.
2023-11-15 05:26:44 +01:00
Mariusz Felisiak
c705625ebf
Refs #34944 -- Propagated system checks for GeneratedField.output_field.
2023-11-14 20:22:07 +01:00
Mariusz Felisiak
5875f03ce6
Fixed #34944 -- Made GeneratedField.output_field required.
...
Regression in f333e3513e
.
2023-11-14 20:22:07 +01:00
Mariusz Felisiak
de4884b114
Reverted "Refs #30446 , Refs #34944 -- Fixed crash when adding GeneratedField with string Value()."
...
This reverts commit 8b1acc0440
.
2023-11-14 15:45:43 +01:00
Simon Charette
6364b6ee10
Fixed #34955 -- Made Concat() use || operator on PostgreSQL.
...
This also avoids casting string based expressions in Concat() on
PostgreSQL.
2023-11-14 10:56:20 +01:00
jedidiah
bdf30b952c
Fixed #34919 -- Added scope attribute to admindocs model templates.
2023-11-14 05:34:56 +01:00
Andrew Cordery
ad41f1c53a
Fixed #34952 -- Copied dir list when processing locale folders to avoid missing entries during os.walk traversal.
...
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2023-11-13 14:03:48 -03:00
David Sanders
b863c5ffde
Fixed #34967 -- Fixed queryset crash when grouping by constants on SQLite < 3.39.
...
On SQLite < 3.39, this forces a GROUP BY clause with a HAVING clause
when no grouping is specified.
Co-authored-by: Simon Charette <charette.s@gmail.com>
2023-11-13 12:01:40 +01:00
nessita
1b56b24f81
Fixed #34958 -- Fixed isolation of messages_tests.tests.TestLevelTags.test_lazy.
2023-11-13 09:35:57 +01:00
Adam Johnson
f7389c4b07
Fixed #34457 -- Restored output for makemigrations --check.
...
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2023-11-09 10:03:19 -03:00
Jacob Walls
427f0ed98d
Fixed typos in docs/ref/models/fields.txt.
2023-11-09 09:58:06 +03:00
Simon Charette
8b1acc0440
Refs #30446 , Refs #34944 -- Fixed crash when adding GeneratedField with string Value().
...
This should allow smarter output_field inferring in functions dealing
with text expressions.
Regression in f333e3513e
.
2023-11-08 15:48:15 +03:00
Natalia
5f2f12f61c
Reverted "Fixed #34830 -- Added request to csrf_failure view's template context."
...
This reverts commit 535f7b5c6c
.
2023-11-08 08:50:55 -03:00
Prakhar
535f7b5c6c
Fixed #34830 -- Added request to csrf_failure view's template context.
...
Co-authored-by: nessita <124304+nessita@users.noreply.github.com>
2023-11-07 09:09:39 -03:00
Simon Charette
8a28e983df
Fixed #34946 -- Preserved db_default on combined default field addition.
...
Regression in 7414704e88
.
2023-11-07 13:32:34 +03:00
Mariusz Felisiak
656192c2c9
Fixed #34941 -- Fixed fetching decimal db_defaults for DecimalFields on Oracle.
...
This is a long standing bug in bc91f27a86
that began manifesting in 7414704e88
.
2023-11-03 16:28:04 +01:00
Mariusz Felisiak
7a09ba0962
Refs #34941 -- Skipped OperationTests.test_alter_field_change_nullable_to_decimal_database_default_not_null on Oracle.
2023-11-03 05:29:06 +01:00
David Sanders
797957fb48
Fixed #34936 -- Fixed migration crash for DecimalField with db_default on SQLite.
...
CAST() must be wrapped in parentheses to be recognized as an expression on SQLite.
Regression in 7414704e88
.
2023-11-02 17:57:39 +01:00
David Sanders
1944f490f9
Refs #34936 -- Added test for altering DecimalField with db_default to non-nullable.
2023-11-02 17:57:34 +01:00
Tim Graham
208870b612
Refs #31300 -- Allowed testing GeneratedField without collation.
...
CockroachDB and Snowflake don't support it.
2023-11-02 13:58:46 +01:00
Patrick Rauscher
116e225266
Fixed #34813 -- Doc'd usage of integrity HTML attribute with ManifestStaticFilesStorage.
2023-11-02 08:21:54 -03:00
Antoine Cheneau
65c283be16
Fixed #34927 -- Fixed admin system check for inlines with foreign keys to proxy models.
...
Follow up to 0e8be73812
.
2023-11-02 10:42:20 +01:00
Mariusz Felisiak
36173cf29d
Added stub release notes for 4.2.8.
2023-11-01 08:22:47 +01:00
Mariusz Felisiak
7caf262183
Added CVE-2023-46695 to security archive.
2023-11-01 08:16:14 +01:00
Mariusz Felisiak
05ba4130ee
Fixed CVE-2023-46695 -- Fixed potential DoS in UsernameField on Windows.
...
Thanks MProgrammer (https://hackerone.com/mprogrammer ) for the report.
2023-11-01 06:10:30 +01:00
Akash Kumar Sen
40b3975e7d
Fixed #34462 -- Made admin log actions in bulk.
...
This also deprecates ModelAdmin.log_deletion() and
LogEntryManager.log_action().
2023-10-31 18:06:44 +01:00
Akash Kumar Sen
45e0c5892f
Refs #34462 -- Moved ModelAdmin.log_deletion() test to a separate test case.
2023-10-31 10:36:23 +01:00
Ben Cail
523fed1d2f
Fixed #32106 -- Preserved HTTP_HOST in test Client when following redirects.
...
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
2023-10-31 05:29:43 +01:00
Natalia
9b18af4f6f
Refs #30601 -- Fixed typos in docs/topics/db/transactions.txt.
2023-10-30 10:35:44 -03:00
Natalia
b412e5645a
Refs #15578 -- Made cosmetic edits to fixtures docs.
2023-10-30 10:29:37 -03:00
Sarah Boyce
e4d012ca05
Refs #29850 -- Added exclusion support to window frames.
2023-10-30 12:04:55 +01:00
Tom Carrick
34b411762b
Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.
...
Regression in f3f9d03edf
(4.2) and
8ed25d65ea
(5.0).
2023-10-30 07:37:40 +01:00
Mariusz Felisiak
46df3ab244
Fixed typo in docs/topics/forms/index.txt.
2023-10-30 05:16:40 +01:00
Sarah Boyce
6375cee490
Refs #29850 -- Added RowRange support for positive integer start and negative integer end.
2023-10-28 15:16:07 +02:00
ksg
a6c7db1d1d
Fixed #34943 -- Made EmailValidator.__eq__() ignore domain_allowlist ordering.
...
Signed-off-by: ksg97031 <ksg97031@gmail.com>
2023-10-28 14:35:25 +02:00