1
0
mirror of https://github.com/django/django.git synced 2025-03-14 11:20:46 +00:00

13488 Commits

Author SHA1 Message Date
Simon Charette
8488074fe3 [5.1.x] Fixed #36197 -- Fixed improper many-to-many count() and exists() for non-pk to_field.
Regression in 66e47ac69a7e71cf32eee312d05668d8f1ba24bb.

Thanks mfontana-elem for the report and Sarah for the tests.

Backport of c3a23aa02faa1cf1d32e43d66858e793cd9ecac4 from main.
2025-02-18 11:45:45 +01:00
Gaël Utard
a9d03c4094 [5.1.x] Fixed #36191 -- Truncated the overwritten file content in FileSystemStorage.
Backport of 0d1dd6bba0c18b7feb6caa5cbd8df80fbac54afd from main.
2025-02-17 14:06:03 +01:00
Sarah Boyce
65113401f1 [5.1.x] Fixed #36182 -- Returned "?" if all parameters are removed in querystring template tag.
Thank you to David Feeley for the report and Natalia Bidart for the review.

Backport of 05002c153c5018e4429a326a6699c7c45e5ea957 from main.
2025-02-13 15:57:56 +01:00
nessita
8552eef95e [5.1.x] Fixed #36140 -- Allowed BaseUserCreationForm to define non required password fields.
Regression in e626716c28b6286f8cf0f8174077f3d2244f3eb3.

Thanks buffgecko12 for the report and Sarah Boyce for the review.

Backport of d15454a6e84a595ffc8dc1b926282f484f782a8f from main.
2025-02-01 22:51:06 -03:00
Mariusz Felisiak
c81669cb54 [5.1.x] Fixed #36098 -- Fixed validate_ipv6_address()/validate_ipv46_address() crash for non-string values.
Regression in ca2be7724e1244a4cb723de40a070f873c6e94bf.

Backport of b3c5830769d8a5dbf2f974da7116fe503c9454d9 from main.
2025-01-15 13:47:13 -03:00
Michael Manfre
4806731e58 [5.1.x] Fixed CVE-2024-56374 -- Mitigated potential DoS in IPv6 validation.
Thanks Saravana Kumar for the report, and Sarah Boyce and Mariusz
Felisiak for the reviews.

Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2025-01-14 08:44:20 -03:00
Andrés Reverón Molina
2ee6ca6d35 [5.1.x] Fixed #34856 -- Fixed references to index_together in historical migrations.
While AlterUniqueTogether has been documented to be still allowed in historical
migrations for the foreseeable future it has been crashing since 2abf417c815c20
was merged because the latter removed support for Meta.index_together which the
migration framework uses to render models to perform schema changes.

CreateModel(options["unique_together"]) was also affected.

Refs #27236.

Co-authored-by: Simon Charette <charette.s@gmail.com>

Backport of b44efdfe543c9b9f12690b59777e6b275cb08103 from main.
2024-12-17 10:01:51 +01:00
Tim Graham
6f42b675c7 [5.1.x] Refs #29850 -- Removed obsolete test_window_frame_raise_not_supported_error.
This NotSupportedError was removed in 6375cee490725969b4f67b3c988ef01350c1ad6d
because it will never be reached due to the same exception raised by
Window.as_sql().

Backport of 94436dee57ce677e6ffcbb0438e0441d5c261d62 from main.
2024-12-16 13:43:56 +01:00
Simon Charette
6943d61818 [5.1.x] Fixed CVE-2024-53908 -- Prevented SQL injections in direct HasKeyLookup usage on Oracle.
Thanks Seokchan Yoon for the report, and Mariusz Felisiak and Sarah
Boyce for the reviews.
2024-12-04 13:47:31 +01:00
Sarah Boyce
bbc74a7f7e [5.1.x] Fixed CVE-2024-53907 -- Mitigated potential DoS in strip_tags().
Thanks to jiangniao for the report, and Shai Berger and Natalia Bidart
for the reviews.
2024-12-04 13:47:21 +01:00
Adam Johnson
6e3e7353e0 [5.1.x] Fixed #35950 -- Restored refreshing of relations when fields deferred.
Thank you to Simon Charette and Sarah Boyce for the review.

Regression in 73df8b54a2fab53bec4c7573cda5ad8c869c2fd8.

Backport of 2f6b096b83c55317c7ceef2d8d5dc3bee33293dc from main.
2024-12-02 16:05:11 +01:00
Tommy Allen
4b262408aa [5.1.x] Fixed #35942 -- Fixed createsuperuser crash on Python 3.13+ when username is unavailable.
Thanks Mariusz Felisiak and Jacob Tyler Walls for reviews.

Backport of c635decb00ac957daf81c08541cdc9cf46f6d86d from main.
2024-11-26 17:16:30 -03:00
Sarah Boyce
9fa2d235c9 [5.1.x] Fixed #35876 -- Displayed non-ASCII fieldset names when rendering ModelAdmin.fieldsets.
Thank you to Namhong Kim for the report, and to Mariusz Felisiak and Marijke Luttekes for the review.

Regression in 01ed59f753139afb514170ee7f7384c155ecbc2d.

Backport of 2c029c718f45341cdd43ee094c24488743c633e6 from main.
2024-10-31 06:41:10 +01:00
Tainara Palmeira
b57a8395b5 [5.1.x] Refs #35844 -- Expanded compatibility for expected error messages in command tests on Python 3.12 and 3.13.
Updated CommandTests.test_subparser_invalid_option and CommandDBOptionChoiceTests.test_invalid_choice_db_option to use assertRaisesRegex() for compatibility with modified error messages in Python 3.12, 3.13, and 3.14+..

Backport of fc22fdd34f1e55adde161f5f2dca8db90bbfce80 from main.
2024-10-30 11:03:51 +01:00
Nick Pope
51eb666758 [5.1.x] Fixed #35841 -- Restored support for DB-IP databases in GeoIP2.
Thanks Felix Farquharson for the report and Claude Paroz for the
review.

Regression in 40b5b1596f7505416bd30d5d7582b5a9004ea7d5.

Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>

Backport of 3fad712a91a8a8f6f6f904aff3d895e3b06b24c7 from main.
2024-10-17 21:42:06 -03:00
Nick Pope
434cf004b8 [5.1.x] Refs #35841 -- Adjusted GeoIP2 tests for easier test case extension.
These changes will make it easier to introduce tests for alternate
databases that may have different results without the need to duplicate
lots of the tests definition.

Backport of 5873f10177ebda66d38e698218cf85dc6397e7d9 from main.
2024-10-17 21:42:00 -03:00
Nick Pope
d1b63c26cc [5.1.x] Refs #35841 -- Updated GeoIP2 test database files.
The mmdb files were taken from
679e37e18a.

Backport of c37f249ffa4b735d1492cda11981dedb947ee437 from main.
2024-10-17 21:41:52 -03:00
Justin Thurman
3ba8b0dae8 [5.1.x] Fixed #35845 -- Updated DomainNameValidator to require entire string to be a valid domain name.
Bug in 4971a9afe5642569f3dcfcd3972ebb39e88dd457.

Thank you to kazet for the report and Claude Paroz for the review.

Backport of 99dcc59237f384d7ade98acfd1cae8d90e6d60ab from main.
2024-10-17 17:00:35 +02:00
nessita
17fa7592af [5.1.x] Fixed #35809 -- Set background color for selected rows in the admin's form select widget.
Regression in b47bdb4cd9149ee2a39bf1cc9996a36a940bd7d9.

Thank you Giannis Terzopoulos for the review, and Tom Carrick and Sarah Boyce
for the review.

Backport of 679d57816d716cbc7cff3b364ae265d70444ebd9 from main.
2024-10-08 10:02:33 -03:00
Gastón Avila
590f5e09f0 [5.1.x] Fixed #35732 -- Wrapped ConcatPair expression in parentheses to ensure operator precedence.
When ConcatPair was updated to use || this lost the implicit wrapping from CONCAT(...).
This broke the WHERE clauses when used in combination with PostgreSQL trigram similarity.

Regression in 6364b6ee1071381eb3a23ba6b821fc0d6f0fce75.

Backport of c3ca6075cc0ad425bcf905fe14062f38eb9fbcbf from main.

Co-authored-by: Emiliano Cuenca <106986074+emicuencac@users.noreply.github.com>
2024-09-11 14:40:48 +02:00
Wassef Ben Ahmed
33cd593420 [5.1.x] Fixed #32831 -– Allowed cache tests to be retried via a new "retry" decorator.
Backport of 957c54d945fedb58febff05e4ce82377cc43f9f4 from main.
2024-09-05 18:26:03 -03:00
Natalia
3c733c78d6 [5.1.x] Fixed CVE-2024-45231 -- Avoided server error on password reset when email sending fails.
On successful submission of a password reset request, an email is sent
to the accounts known to the system. If sending this email fails (due to
email backend misconfiguration, service provider outage, network issues,
etc.), an attacker might exploit this by detecting which password reset
requests succeed and which ones generate a 500 error response.

Thanks to Thibaut Spriet for the report, and to Mariusz Felisiak, Adam
Johnson, and Sarah Boyce for the reviews.
2024-09-03 09:24:21 -03:00
Sarah Boyce
022ab0a75c [5.1.x] Fixed CVE-2024-45230 -- Mitigated potential DoS in urlize and urlizetrunc template filters.
Thanks MProgrammer (https://hackerone.com/mprogrammer) for the report.
2024-09-03 09:24:13 -03:00
Sarah Boyce
6203965960 [5.1.x] Fixed #35716 -- Fixed VariableDoesNotExist when rendering admin fieldsets.
Regression in 01ed59f753139afb514170ee7f7384c155ecbc2d.

Thank you to Fábio Domingues and Marijke Luttekes for the report,
and thank you to Natalia Bidart for the review.

Backport of fd1dd767783b5a7ec1a594fcc5885e7e4178dd26 from main.
2024-08-30 20:52:41 +02:00
Sarah Boyce
26c06671d9 [5.1.x] Fixed #35688 -- Restored timezone and role setters to be PostgreSQL DatabaseWrapper methods.
Following the addition of PostgreSQL connection pool support in
Refs #33497, the methods for configuring the database role and timezone
were moved to module-level functions. This change prevented subclasses
of DatabaseWrapper from overriding these methods as needed, for example,
when creating wrappers for other PostgreSQL-based backends.

Thank you Christian Hardenberg for the report and to
Florian Apolloner and Natalia Bidart for the review.

Regression in fad334e1a9b54ea1acb8cce02a25934c5acfe99f.

Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>

Backport of 7380ac57340653854bc2cfe0ed80298cdac6061d from main.
2024-08-28 19:25:55 -03:00
Simon Charette
9a461cae3e [5.1.x] Fixed #35666 -- Documented stacklevel usage and testing, and adjusted test suite accordingly.
Over the years we've had multiple instances of hit and misses when
emitting warnings: either setting the wrong stacklevel or not setting
it at all.

This work adds assertions for the existing warnings that were declaring
the correct stacklevel, but were lacking tests for it.

Backport of 57307bbc7d88927989cf5b314f16d6e13ade04e6 from main.
2024-08-28 11:47:15 -03:00
Simon Charette
dd58edcc37 [5.1.x] Refs #35405 -- Adjusted deprecation warning stacklevel in FieldCacheMixin.get_cache_name().
Backport of 39abd56a7fb1e2f735040df0fdfc08f57d91a49b from main.
2024-08-28 11:46:49 -03:00
Simon Charette
8f5d2c374a [5.1.x] Refs #35326 -- Adjusted deprecation warning stacklevel in FileSystemStorage.OS_OPEN_FLAGS.
Backport of 47f18a722624527cc72eef44cfc9d1e07ea4b4e0 from main.
2024-08-28 11:46:23 -03:00
Simon Charette
c87007ab60 [5.1.x] Refs #35060 -- Adjusted deprecation warning stacklevel in Model.save()/asave().
Backport of 52ed2b645e1dd8c9a874cfd21c4c9f2500032626 from main.
2024-08-28 11:45:35 -03:00
Mariusz Felisiak
e435b44be6 [5.1.x] Refs #34900 -- Updated requirements for Python 3.13.
Backport of 07a4d23283586bc4578eb9c82a7ad14af3724057 from main.
2024-08-28 10:10:05 -03:00
Adam Johnson
03e0ab5c64 [5.1.x] Refs #34609 -- Fixed deprecation warning stack level in format_html().
Co-authored-by: Simon Charette <charette.s@gmail.com>

Backport of 2b71b2c8dcd40f2604310bb3914077320035b399 from main.
2024-08-27 15:17:47 -03:00
Sarah Boyce
c9a8d005ee [5.1.x] Improved test coverage of urlize.
Backport of c6d1f98d2685f34e009e0fffdcff4ad275e55879 from main.
2024-08-26 13:16:05 -03:00
Natalia
da22e6cb3c [5.1.x] Fixed #35678 -- Removed "usable_password" field from BaseUserCreationForm.
Refs #34429: Following the implementation allowing the setting of
unusable passwords via the admin site, the `BaseUserCreationForm` and
`UserCreationForm` were extended to include a new field for choosing
whether password-based authentication for the new user should be enabled
or disabled at creation time.
Given that these forms are designed to be extended when implementing
custom user models, this branch ensures that this new field is moved to
a new, admin-dedicated, user creation form `AdminUserCreationForm`.

Regression in e626716c28b6286f8cf0f8174077f3d2244f3eb3.

Thanks Simon Willison for the report, Fabian Braun and Sarah Boyce for
the review.

Backport of 0ebed5fa95f53b87383901bbd9341ef3c974344f from main.
2024-08-19 12:41:23 -03:00
Natalia
cfad0655c2 [5.1.x] Refs #35678 -- Split tests for BaseUserCreationForm when using a custom User model.
This work also allows to subclass BaseUserCreationFormTest to reuse the
tests and assertions for testing forms that extend BaseUserCreationForm,
which is now used for UserCreationFormTest, increasing its coverage.

Backport of b60fd8722f305ec29c87f34d3fea262e56394ebd from main.
2024-08-19 12:40:57 -03:00
Simon Charette
df236b0bcb [5.1.x] Fixed #35665 -- Fixed a crash when passing an empty order_by to Window.
This also caused un-ordered sliced prefetches to crash as they rely on Window.

Regression in e16d0c176e9b89628cdec5e58c418378c4a2436a that made OrderByList
piggy-back ExpressionList without porting the empty handling that the latter
provided.

Supporting explicit empty ordering on Window functions and slicing is arguably
a foot-gun design due to how backends will return undeterministic results but
this is a problem that requires a larger discussion.

Refs #35064.

Thanks Andrew Backer for the report and Mariusz for the review.

Backport of 602fe961e6834d665f2359087a1272e9f9806b71 from main.
2024-08-13 11:28:03 +02:00
Mariusz Felisiak
d9aeb23edb [5.1.x] Fixed #35661 -- Fixed test_too_many_digits_to_rander() test crash on PyPy.
Thanks Michał Górny for the report.

Backport of 7fb15ad5bcae05324ee8913e4b2c6c982e8f2de0 from main.
2024-08-08 09:55:21 +02:00
Natalia
d5ad743e79 [5.1.x] Fixed i18n.tests.TranslationTests.test_plural to use correct French translation. 2024-08-07 09:56:31 -03:00
Simon Charette
e2583fbc2e [5.1.x] Fixed CVE-2024-42005 -- Mitigated QuerySet.values() SQL injection attacks against JSON fields.
Thanks Eyal (eyalgabay) for the report.
2024-08-06 08:51:22 +02:00
Mariusz Felisiak
bd807c0c25 [5.1.x] Fixed CVE-2024-41991 -- Prevented potential ReDoS in django.utils.html.urlize() and AdminURLFieldWidget.
Thanks Seokchan Yoon for the report.

Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-08-06 08:51:22 +02:00
Sarah Boyce
0c1a890916 [5.1.x] Fixed CVE-2024-41990 -- Mitigated potential DoS in urlize and urlizetrunc template filters.
Thanks to MProgrammer for the report.
2024-08-06 08:51:22 +02:00
Sarah Boyce
0504af6429 [5.1.x] Fixed CVE-2024-41989 -- Prevented excessive memory consumption in floatformat.
Thanks Elias Myllymäki for the report.

Co-authored-by: Shai Berger <shai@platonix.com>
2024-08-06 08:51:22 +02:00
Sarah Boyce
2ba4f4b0b5 [5.1.x] Fixed #35657 -- Made FileField handle db_default values.
Backport of 8deb6bb1fc427762d56646bf7306cbd11fb5bb68 from main.
2024-08-05 16:37:26 -03:00
David Sanders
aed4ffe189 [5.1.x] Fixed #35638 -- Updated validate_constraints to consider db_default.
Backport of 509763c79952cde02d9f5b584af4278bdbed77b2 from main.
2024-08-05 17:36:15 +02:00
John Parton
88ebcb1856 [5.1.x] Fixed #35628 -- Allowed compatible GeneratedFields for ModelAdmin.date_hierarchy.
Backport of 7f8d839722b72aeb3ec5a4278ae57c18283acacd from main.
2024-08-05 15:28:40 +02:00
Simon Charette
55f5292701 [5.1.x] Fixed #35643 -- Fixed a crash when ordering a QuerySet by a reference containing "__".
Regression in b0ad41198b3e333f57351e3fce5a1fb47f23f376.

Refs #34013. The initial logic did not consider that annotation aliases
can include lookup or transform separators.

Thanks Gert Van Gool for the report and Mariusz Felisiak for the review.
Backport of a16f13a8661297eda12c4177bb01fa2e5b5ccc56 from main.
2024-08-02 16:22:05 -03:00
Tim Graham
e9d4b03680 [5.1.x] Added missing skips in constraint tests.
Backport of b6ad8b687adf011245270df17a38c1a42792e3d7 from main.
2024-07-26 17:02:04 +02:00
nessita
694c45118a [5.1.x] Added dedicated test for invalid inputs in floatformat template filter tests.
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>

Backport of 1b277b45cc4059760072095f3bd6e8a4e4c4d406 from main.
2024-07-25 16:17:56 -03:00
Lorenzo Peña
741f33eaf1 [5.1.x] Fixed #35627 -- Raised a LookupError rather than an unhandled ValueError in get_supported_language_variant().
LocaleMiddleware didn't handle the ValueError raised by
get_supported_language_variant() when language codes were
over 500 characters.

Regression in 9e9792228a6bb5d6402a5d645bc3be4cf364aefb.

Backport of 0e94f292cda632153f2b3d9a9037eb0141ae9c2e from main.
2024-07-25 09:40:49 +02:00
Simon Charette
d8116bf7f5 [5.1.x] Fixed #35625 -- Fixed a crash when adding a field with db_default and check constraint.
This is the exact same issue as refs #30408 but for creating a model with a
constraint containing % escapes instead of column addition. All of these issues
stem from a lack of SQL and parameters separation from the BaseConstraint DDL
generating methods preventing them from being mixed with other parts of the
schema alteration logic that do make use of parametrization on some backends
(e.g. Postgres, MySQL for DEFAULT).

Prior to the addition of Field.db_default and GeneratedField in 5.0
parametrization of DDL was never exercised on model creation so this is
effectively a bug with db_default as the GeneratedField case was addressed by
refs #35336.

Thanks Julien Chaumont for the report and Mariusz Felisiak for the review.

Backport of f359990e4909db8722820849d61a6f5724338723 from main.
2024-07-25 07:51:45 +02:00
Sarah Boyce
e42defb63b [5.1.x] Fixed #35604, Refs #35326 -- Made FileSystemStorage.exists() behaviour independent from allow_overwrite.
Partially reverts 0b33a3abc2ca7d68a24f6d0772bc2b9fa603744e.

Storage.exists(name) was documented to "return False if
the name is available for a new file." but return True if
the file exists. This is ambiguous in the overwrite file
case. It will now always return whether the file exists.

Thank you to Natalia Bidart and Josh Schneier for the
review.

Backport of 8d6a20b656ff3fa18e36954668a44a831c2f6ddd from main.
2024-07-24 14:58:57 +02:00