Carl Meyer
a9cced7aec
Fix another flake8 warning.
...
I don't agree with flake8 here about the right indentation, but as long as
we're using it, we should stick to it. I don't want to disable its hanging
indent checks just because of this case.
2014-11-22 14:21:32 -07:00
Berker Peksag
da2a35cf9e
Silenced a flake8 warning.
...
../tests/shortcuts/views.py:45:1: E302 expected 2 blank lines, found 1
2014-11-22 21:39:06 +02:00
Aymeric Augustin
7331788300
Avoided rewrapping Contexts in render_to_response.
...
This change preserves backwards-compatibility for a very common misuse
of render_to_response which even occurred in the official documentation.
It fixes that misuse wherever it happened in the code base and docs.
Context.__init__ is documented as accepting a dict and nothing else.
Since Context is dict-like, Context(Context({})) could work to some
extent. However, things get complicated with RequestContext and that
gets in the way of refactoring the template engine. This is the real
rationale for this change.
2014-11-22 17:58:38 +01:00
Aymeric Augustin
bf1bd0fbc9
Moved tests for render shortcuts to their own app.
2014-11-22 17:52:43 +01:00
Claude Paroz
b38637d581
Fixed #23887 -- Returned Bad Request for multipart parsing fails
...
Thanks Antti Häyrynen and Tim Graham for the report, and Aymeric
Augustin for the review.
2014-11-22 14:23:37 +01:00
Claude Paroz
b0a58b9085
Updated an old note about GEOSGeometry.transform
2014-11-22 12:20:17 +01:00
Collin Anderson
d4ea4eea79
Fixed #23889 -- Added more usage of quote_name_unless_alias() to avoid deprecation warnings.
2014-11-21 16:44:50 -05:00
Simon Charette
c7087bc777
Fixed #23862 -- Made ManyToManyRel.get_related_field() respect to_field.
2014-11-21 16:02:31 -05:00
Simon Charette
a7c3d0f288
Fixed typo in forms/models.py comment.
2014-11-21 15:59:09 -05:00
Stanislas Guerra
06726965c3
Fixed #23778 -- Added a doc section on using the Django runner for reusable apps.
2014-11-21 12:53:36 -07:00
Berker Peksag
343162410f
Fixed #21753 -- Raised exception when both form_class
and fields
are specified.
2014-11-21 14:23:17 -05:00
Alasdair Nicol
5b26a014a8
Fixed #23865 -- documented how to assign errors to a field in Model.clean()
...
Also added a unit test wit the simpler syntax which we have documented,
where the dictionary values are strings.
2014-11-21 13:01:28 -05:00
Tom V
a3aeba0f95
Fixed typo in docs/internals/release-process.txt.
2014-11-21 11:47:31 -05:00
Simon Charette
8330b50c85
Fixed #23863 -- Made runtests accept the keepdb option.
...
refs #20550
2014-11-21 11:41:13 -05:00
Andrzej Pragacz
72729f844e
Fixed #23794 -- Fixed migrations crash when removing a field that's part of index/unique_together.
2014-11-21 10:55:19 -05:00
Jay
f957e2b04c
Added a test for model pre/post_init signals.
2014-11-21 10:39:37 -05:00
Sergey Fedoseev
f1783ee479
Corrected Permission.max_length in docs; refs #8162 .
2014-11-21 08:20:48 -05:00
Tim Heap
5b17dcd8ef
Fixed #23883 -- Stopped flatatt modifying its argument
2014-11-21 09:45:08 +01:00
Anssi Kääriäinen
d8f00e1918
Added a comment for test of refs #20278 .
2014-11-20 16:26:25 -05:00
Markus Holtermann
4c709cc0ef
Fixed duplicate index error on Oracle; refs #23859 .
...
Refers to regression introduced in 7b4a994599
2014-11-20 14:42:39 -05:00
Brad Walker
54d3dcbc51
Removed reduce() usage in makemigrations; refs #23796 .
...
A lambda all_items_equal() replaced a reduce() that was broken for potential
3+-way merges. A reduce(operator.eq, ...) accumulates bools and can't
generically check equality of all items in a sequence:
>>> bool(reduce(operator.eq, [('migrations', '0001_initial')] * 3))
False
The code now counts the number of common ancestors to calculate slice offsets
for the branches. Each branch shares the same number of common ancestors.
The common_ancestor for loop statement had incomplete branch coverage.
2014-11-20 14:33:30 -05:00
Brad Walker
cfa26f29bd
Reduced reduce() usage; refs #23796 .
...
django.core.exceptions.ValidationError.messages() and
django.db.backends.schema.BaseDatabaseSchemaEditor._alter_field():
Replaced reduce(operator.add, ...) w/uncoupled, explicit sum()
2014-11-20 14:31:14 -05:00
Brad Walker
f273cedc76
Added test for ValidationError.messages
2014-11-20 14:31:14 -05:00
Anssi Kääriäinen
5c481db295
Fixed #23605 -- Fixed nested subquery regression
...
Added relabeled_clone() method to sql.Query to fix the problem. It
manifested itself in rare cases where at least double nested subquery's
filter condition might target non-existing alias.
Thanks to Trac alias ris for reporting the problem.
2014-11-20 13:38:08 -05:00
Patryk Zawadzki
21e21c7bc2
Fixed #23844 -- Used topological sort for migration operation dependency resolution.
...
This removes the concept of equality between operations to guarantee
compatilibity with Python 3.
Python 3 requires equality to result in identical object hashes. It's
impossible to implement a unique hash that preserves equality as
operations such as field creation depend on being able to accept
arbitrary dicts that cannot be hashed reliably.
Thanks Klaas van Schelven for the original patch in
13d613f800
.
2014-11-20 12:49:49 -05:00
Tim Graham
53908c1f93
Added some directories on Jenkins to flake8 exclude.
2014-11-20 11:58:24 -05:00
Alasdair Nicol
38ab0f13fa
Added missing backticks to form validation docs
2014-11-20 11:09:21 -05:00
Claude Paroz
1a63093e22
Added AutoField introspection for PostgreSQL
...
Refs #23748 .
2014-11-20 16:13:58 +01:00
Claude Paroz
11662022be
Added AutoField introspection for MySQL
...
Refs #23748 .
2014-11-20 16:13:58 +01:00
Michal Petrucha
327df551e8
Fixed #23817 -- Updated docs on QuerySet evaluation
...
Removed inaccurate info about partial evaluation after refs #18702 .
Added information on modifying sliced QuerySets; refs #22503 .
2014-11-20 09:33:32 -05:00
Berker Peksag
788fa9fffa
Fixed #12098 -- Simplified HttpRequest.__repr__().
2014-11-20 08:45:11 -05:00
Carl Meyer
d6e2bbe734
Fixed #23876 -- Removed dead code in SQLAggregateCompiler.
2014-11-20 04:18:08 -07:00
Carl Meyer
51f2de1530
Added another migration-executor test to avoid regressions.
2014-11-19 19:43:12 -07:00
Carl Meyer
d2bcb05980
Fixed #23873 -- Improved GIS error message when GEOS is not installed.
...
Thanks Claude for writing the patch.
2014-11-19 19:23:13 -07:00
Carl Meyer
ab2819aa7b
Fixed #23410 -- Avoided unnecessary rollbacks in related apps when migrating backwards.
2014-11-19 16:11:44 -07:00
Carl Meyer
e7b9a58b08
Fixed #21794 -- Removed deprecation warning for abstract models outside an app.
2014-11-19 15:56:04 -07:00
Carl Meyer
47b7f601ee
Fixed #23872 -- Removed sensitivity of migrations tests to CWD.
2014-11-19 15:03:47 -07:00
Carl Meyer
4932a7b8e0
Fixed GIS tests to again skip without error when GEOS is not installed.
2014-11-19 14:29:05 -07:00
Tim Graham
5bcd292098
Fixed #23871 -- Removed promotion of MySQL warnings to errors in DEBUG mode.
2014-11-19 16:07:49 -05:00
Aymeric Augustin
45db7f7db8
Replaced caching of a property with @cached_property.
2014-11-19 21:53:24 +01:00
Aymeric Augustin
9d3d1a0321
Simplified caching of supported languages.
2014-11-19 21:35:40 +01:00
Aymeric Augustin
0900815097
Simplified caching of the default exception reporter filter.
...
Also simplified the logic under the assumption that a false-ish object
won't have an exception_reporter_filter attribute.
2014-11-19 21:35:40 +01:00
Aymeric Augustin
b69b4008d1
Removed usage of a global variable.
2014-11-19 21:35:40 +01:00
Aymeric Augustin
f88ad710fa
Simplified caching of template context processors.
2014-11-19 21:35:39 +01:00
Aymeric Augustin
a97e72aaab
Simplified caching of templatetags modules.
2014-11-19 21:35:39 +01:00
Aymeric Augustin
e23240474b
Simplified caching of get_default_timezone().
2014-11-19 21:35:39 +01:00
Aymeric Augustin
dca33ac15d
Simplified caching of password hashers.
...
load_hashers cached its result regardless of its password_hashers
argument which required fragile cache invalidation. Remove that
argument in favor of @override_settings and triggering cache
invalidation with a signal.
2014-11-19 21:35:39 +01:00
Markus Holtermann
2331650835
Cleaned up and reformatted autodetector tests
2014-11-19 11:09:38 -05:00
Markus Holtermann
f17acd5930
Formatted model states in autodetector tests
2014-11-19 11:09:38 -05:00
Carl Meyer
0eba8bd8f6
Fixed GeoSQLCompiler to pass itself correctly to column as_sql.
2014-11-19 08:33:38 -07:00