1
0
mirror of https://github.com/django/django.git synced 2025-01-15 12:52:31 +00:00

32116 Commits

Author SHA1 Message Date
Sarah Boyce
9fe12b0f36 [5.0.x] Refs #34995 -- Made Selenium tests more robust for admin_views and admin_widgets suites.
Depending on screen sizes, the selenium tests that would "click" or interact
with an element outside the scope of the visible window would produce test
failures (raising ElementNotInteractableException in CI runs).

This branch switches those to using ActionChains, which ensures that the click
(or other interaction) is performed only after successfully completing the
move to the relevant element.

Co-authored-by: Tom Carrick <tom@carrick.eu>

Backport of af2fd368156439b79e4c1eb2278c433246771e44 from main
2023-11-30 17:09:09 -03:00
Mariusz Felisiak
7f1dc67f53 [5.0.x] Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_comment on SQLite.
Thanks Юрий for the report.

Regression in 78f163a4fb3937aca2e71786fbdd51a0ef39629e.
Backport of 37fc832a54ad37e75a898a2c8f9ab0820617c4af from main
2023-11-30 10:11:02 +01:00
Mark Walker
a4a0f66570 [5.0.x] Improved structure of Contributing Guide start page.
Backport of 6ab0f8ae52ae63808071be90ac48b39d3c75bc98 from main
2023-11-30 09:32:34 +01:00
KimSia Sim
b4a29210cf [5.0.x] Updated conditions to retrieve primary keys in bulk_create() docs.
Backport of c9ce764f59c1e809b210337980ae10c4b1d0f9be from main.
2023-11-29 13:00:32 +01:00
Adam Johnson
0216d82066 [5.0.x] Removed link to lawrence.com in contrib.sites docs.
lawrence.com has since become a redirect to LJWorld.com,
making the link pointless.
Backport of 9e7ac5890147a8271eb5eb19bb88ab93dadc6c6d from main
2023-11-28 20:11:48 +01:00
Mariusz Felisiak
92af3d4d23 [5.0.x] Refs #34380 -- Added FORMS_URLFIELD_ASSUME_HTTPS transitional setting.
This allows early adoption of the new default "https".

Backport of a4931cd75a1780923b02e43475ba5447df3adb31 from main.
2023-11-28 20:08:10 +01:00
Tom Carrick
432bfa2615 [5.0.x] Fixed #34982 -- Fixed admin's read-only password widget and help texts alignment for tablet screen size.
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>

Backport of 729266c6f29c7a0677b24926a86a767ef3078b26 from main
2023-11-27 15:20:22 -03:00
Mariusz Felisiak
cbd1e913ef [5.0.x] Fixed #34978, Refs #31331 -- Added backward incompatibility note about raw aggregations on MySQL.
Thanks Matthew Somerville for the report.

Backport of a652f0759651dd7103ed04336ef85dc410f680c1 from main
2023-11-27 12:45:23 -03:00
Nathaniel Conroy
d9ba8fa397 [5.0.x] Fixed #34992 -- Fixed DatabaseFeatures.allows_group_by_selected_pks on MariaDB with ONLY_FULL_GROUP_BY sql mode.
Regression in 041551d716b69ee7c81199eee86a2d10a72e15ab.

Backport of 0257426fe1fe9d146fd5813f09d909917ff59360 from main
2023-11-27 10:34:42 +01:00
Adam Johnson
4c74dff759 [5.0.x] Refs #34380 -- Improved docs for forms.URLField.assume_scheme.
Backport of 0203771b626c27c1af24cdeb0e425ccca3d19ad5 from main
2023-11-25 18:53:34 +01:00
Tom Carrick
4d33816ca6 [5.0.x] Fixed #34994 -- Fixed checkbox layout in admin's change page for narrow screen widths.
Regression in d687febce5868545f99974d2499a91f81a32fef5.

Backport of a89c715c3bcf7ab1a90747cf8658ebce6304b6e4 from main
2023-11-23 16:56:29 -03:00
Tom Carrick
15d49c8082 [5.0.x] Fixed #34991 -- Fixed pagination links and input layout in admin's change list page when using list_editable.
Regression in b4817d20b9e55df30be0b1b2ca8c8bb6d61aab07.

Thanks Tom Carrick for the report and fix.

Backport of 4eb9c3d90aff55182151b6be0122f7d0b28832fd from main
2023-11-23 10:23:31 -03:00
Simon Charette
95dec210e8 [5.0.x] Fixed #34987 -- Fixed queryset crash when mixing aggregate and window annotations.
Regression in f387d024fc75569d2a4a338bfda76cc2f328f627.

Just like `OrderByList` the `ExpressionList` expression used to wrap
`Window.partition_by` must implement `get_group_by_cols` to ensure the
necessary grouping when mixing window expressions with aggregate
annotations is performed against the partition members and not the
partition expression itself.

This is necessary because while `partition_by` is implemented as
a source expression of `Window` it's actually a fragment of the WINDOW
expression at the SQL level and thus it should result in a group by its
members and not the sum of them.

Thanks ElRoberto538 for the report.
Backport of e76cc93b0168fa3abbafb9af1ab4535814b751f0 from main
2023-11-23 06:09:58 +01:00
Tim Schilling
06bdf62b56 [5.0.x] Fixed #34990 -- Changed link to OWASP in CSRF docs.
The OWASP site is the standard resource for web application
security information.
Backport of aceee39d44994df20d13104e55ae61845d7a1e95 from main
2023-11-23 05:28:15 +01:00
Mariusz Felisiak
48eebdc63c [5.0.x] Fixed #34985 -- Fixed GeneratedFields.contribute_to_class() crash when apps are not populated.
Thanks Paolo Melchiorre for the report.

Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.
Backport of 101a85a5a06585ba16ecb25860146d034a8a55ec from main
2023-11-22 13:49:59 +01:00
Sarah Boyce
0c6ca52226 [5.0.x] Fixed #34984 -- Skipped GeneratedFields when remaking tables on SQLite.
Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.t

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>

Backport of 828082dad954e87d09a99b53424e6faa1860ccc7 from main
2023-11-22 13:27:40 +01:00
Thibaud Colas
6692b0ecce [5.0.x] Added VoiceOver iOS and macOS separately in admin FAQ.
Follow up to 6daf86058bb6fb922eb3fe3abae6f5c0e645020c.
Backport of a2769a68ea27242dc70ec7734c4ed38932fe46da from main
2023-11-21 05:46:49 +01:00
Natalia Bidart
e61ae5e106 [5.0.x] Bumped version for 5.0 release candidate 1. 5.0rc1 2023-11-20 09:24:16 -03:00
Natalia Bidart
efd6cbfadf [5.0.x] Updated man page for Django 5.0 rc1. 2023-11-20 08:46:20 -03:00
Mariusz Felisiak
f721fb937c [5.0.x] Refs #34118 -- Doc'd Python 3.12 compatibility in Django 4.2.x.
Backport of ecfea054ee2b8ddfa027459ff8b6aecba05facf7 from main
2023-11-19 16:33:01 +01:00
Mariusz Felisiak
c342b58243 [5.0.x] Refs #34118 -- Added Python 3.12 to classifiers and tox.ini.
Backport of f955c90488e1f32e6e38b3c956e937579d389fb2 from main
2023-11-19 16:32:55 +01:00
Simon Charette
49f1ced863 [5.0.x] Fixed #34975 -- Fixed crash of conditional aggregate() over aggregations.
Adjustments made to solve_lookup_type to defer the resolving of
references for summarized aggregates failed to account for similar
requirements for lookup values which can also reference annotations
through Aggregate.filter.

Regression in b181cae2e3697b2e53b5b67ac67e59f3b05a6f0d.

Refs #25307.

Thanks Sergey Nesterenko for the report.

Backport of 7530cf3900ab98104edcde69e8a2a415e82b345a from main
2023-11-18 16:52:54 +01:00
Mariusz Felisiak
8fb92dc96a [5.0.x] Removed obsolete warnings about asgiref.sync adapters with sensitive variables.
Django 5.0+ required asgiref 3.7+, and this warning is obsolete for
asgiref 3.7+ since
be6635e0e7.
Backport of 594873befbbec13a2d9a048a361757dd3cf178da from main
2023-11-17 12:09:58 +01:00
Thibaud Colas
0923472aa2 [5.0.x] Doc'd support for assistive technologies in the admin.
Backport of 6daf86058bb6fb922eb3fe3abae6f5c0e645020c from main
2023-11-17 11:20:54 +01:00
David Smith
7f0275d8cb [5.0.x] Refs #32819 -- Used auto_id instead of id_for_label as unique identifier for the field.
`id_for_label` is blank for widgets with multiple inputs such as radios
and multiple checkboxes. Therefore , `help_text` for fields using these
widgets cannot currently be associated using `aria-describedby`.
`id_for_label` is being used as a guard to avoid incorrectly adding
`aria-describedby` to those widgets.

This change uses `auto_id` as the unique identified for the fields
`help_text`. A guard is added to avoid incorrectly adding
`aria-describedby` to inputs by checking the widget's `use_fieldset`
attribute. Fields rendered in a `<fieldset>` should have
`aria-describedby` added to the `<fieldset>` and not every `<input>`.

Backport of 292f1ea90f90ff140617299a25884c8fda24aa64 from main
2023-11-16 13:27:18 +01:00
Markus Amalthea Magnuson
8c88ae8251 [5.0.x] Fixed #34970 -- Clarified Password Validation docs regarding the password_changed callback.
Backport of 61c305f298da1b4079a80721c861d0663dc8717e from main
2023-11-15 21:52:11 -03:00
Giannis Terzopoulos
a5ee682baf [5.0.x] Removed obsolete sentence in custom model field docs.
Backport of 36ed45d27cb97fe3a41eca219ba75ff69f16b93c from main
2023-11-15 13:49:17 +01:00
William Hayes
effd704a1c [5.0.x] Refs #33690 -- Added missing data-theme selector to example in theming support docs.
Backport of 640283711e6c8d25ad0e3c97453cd178a3e4d6a6 from main
2023-11-15 05:27:51 +01:00
Mariusz Felisiak
fcc55f8c26 [5.0.x] Refs #34944 -- Propagated system checks for GeneratedField.output_field.
Backport of c705625ebff0141ed2b95dd3c8174bda8270a47f from main
2023-11-14 20:22:41 +01:00
Mariusz Felisiak
ddbe5c86e8 [5.0.x] Fixed #34944 -- Made GeneratedField.output_field required.
Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.

Backport of 5875f03ce61b85dfd9ad34f7b871c231c358d432 from main
2023-11-14 20:22:33 +01:00
Mariusz Felisiak
5b1d0a6be0 [5.0.x] Reverted "Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value()."
This reverts commit 8b1acc0440418ac8f45ba48e2dfcf5126c83341b.

Backport of de4884b114534f43c49cf8c5b7f10181e737f4e9 from main
2023-11-14 15:46:23 +01:00
nessita
7a21ea5464 [5.0.x] Fixed #34958 -- Fixed isolation of messages_tests.tests.TestLevelTags.test_lazy.
Backport of 1b56b24f81a2e64b4bd3059abad9b6fd0c801c66 from main
2023-11-13 09:38:00 +01:00
Adam Johnson
8eba6efbf0 [5.0.x] Fixed #34457 -- Restored output for makemigrations --check.
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>

Backport of f7389c4b07ceeb036436e065898e411b247bca78 from main
2023-11-09 10:44:07 -03:00
Jacob Walls
97a78121b3 [5.0.x] Fixed typos in docs/ref/models/fields.txt.
Backport of 427f0ed98d7ecf4381cebd4f7773f761e2446851 from main
2023-11-09 09:58:53 +03:00
Simon Charette
73869a5163 [5.0.x] Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value().
This should allow smarter output_field inferring in functions dealing
with text expressions.

Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.

Backport of 8b1acc0440418ac8f45ba48e2dfcf5126c83341b from main
2023-11-08 16:18:00 +03:00
Simon Charette
0265eaa500 [5.0.x] Fixed #34946 -- Preserved db_default on combined default field addition.
Regression in 7414704e88d73dafbcfbb85f9bc54cb6111439d3.
Backport of 8a28e983df091d94eaba77cb82fbe3ef60a80799 from main
2023-11-07 13:33:24 +03:00
Mariusz Felisiak
1383dc75eb [5.0.x] Fixed #34941 -- Fixed fetching decimal db_defaults for DecimalFields on Oracle.
This is a long standing bug in bc91f27a86090b4c688b56cd4e37f95eebe6e969
that began manifesting in 7414704e88d73dafbcfbb85f9bc54cb6111439d3.
Backport of 656192c2c96bb955a399d92f381e38fe2254fe17 from main
2023-11-03 16:29:49 +01:00
Mariusz Felisiak
e2330ccd10 [5.0.x] Refs #34941 -- Skipped OperationTests.test_alter_field_change_nullable_to_decimal_database_default_not_null on Oracle.
Backport of 7a09ba0962e0eaf4ad396475b392ba3234bf60ee from main
2023-11-03 05:30:08 +01:00
David Sanders
8dde0504f3 [5.0.x] Fixed #34936 -- Fixed migration crash for DecimalField with db_default on SQLite.
CAST() must be wrapped in parentheses to be recognized as an expression on SQLite.

Regression in 7414704e88d73dafbcfbb85f9bc54cb6111439d3.

Backport of 797957fb48f63760442d3d4c8985fd94f8602d5e from main
2023-11-02 19:59:39 +01:00
Tim Graham
b735b90f43 [5.0.x] Refs #31300 -- Allowed testing GeneratedField without collation.
CockroachDB and Snowflake don't support it.

Backport of 208870b6122c4cbc39c3b2432e13db54c920db51 from main
2023-11-02 15:48:31 +01:00
Patrick Rauscher
bf8aac3679 [5.0.x] Fixed #34813 -- Doc'd usage of integrity HTML attribute with ManifestStaticFilesStorage.
Backport of 116e225266c511dfc0bfc96c8497e9c8aaa4d004 from main
2023-11-02 08:26:27 -03:00
Mariusz Felisiak
fd593db2fa [5.0.x] Added stub release notes for 4.2.8.
Backport of 36173cf29d6ad0b0f0cd24326834dddfff2db7f3 from main
2023-11-01 08:25:18 +01:00
Mariusz Felisiak
2d929dd2cc [5.0.x] Added CVE-2023-46695 to security archive.
Backport of 7caf2621833a45cdfe7e6e305e4885ecc8d79744 from main
2023-11-01 08:17:30 +01:00
Mariusz Felisiak
bb71d34551 [5.0.x] Fixed CVE-2023-46695 -- Fixed potential DoS in UsernameField on Windows.
Thanks MProgrammer (https://hackerone.com/mprogrammer) for the report.
2023-11-01 06:18:00 +01:00
Natalia
acd4595ab0 [5.0.x] Refs #30601 -- Fixed typos in docs/topics/db/transactions.txt.
Backport of 9b18af4f6f12b9d25157e0b5afc3dca198f6dd06 from main
2023-10-30 13:49:12 -03:00
Natalia
c8bc72462d [5.0.x] Refs #15578 -- Made cosmetic edits to fixtures docs.
Backport of b412e5645a65a632f0147e50ceecb60acd33bb4d from main
2023-10-30 10:33:08 -03:00
Tom Carrick
602835202d [5.0.x] Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.
Regression in f3f9d03edf17ccfa17263c7efa0b1350d1ac9278 (4.2) and
8ed25d65ea7546fafd808086fa07e7e5bb5428fc (5.0).

Backport of 34b411762b50883d768d7b67e0a158ec39da8b09 from main
2023-10-30 11:08:03 +01:00
Mariusz Felisiak
329ae408bf [5.0.x] Fixed typo in docs/topics/forms/index.txt.
Backport of 46df3ab244e1688bd186f0bfbfea6a354097a910 from main
2023-10-30 05:17:55 +01:00
Sarah Boyce
dfdca516ea [5.0.x] Fixed typos in docs/ref/models/expressions.txt.
Backport of 8992a0489c01ac8ab7283264a315c005511323e2 from main
2023-10-28 14:22:00 +02:00
lufafajoshua
c8ac50c201 [5.0.x] Fixed #30601 -- Doc'd the need to manually revert all app state on transaction rollbacks.
Backport of aa80b357fbef46e5b6faa08d63bcfd4fe21f3776 from main
2023-10-27 23:33:16 -03:00