1
0
mirror of https://github.com/django/django.git synced 2024-12-28 12:06:22 +00:00
Commit Graph

32104 Commits

Author SHA1 Message Date
Simon Charette
95dec210e8 [5.0.x] Fixed #34987 -- Fixed queryset crash when mixing aggregate and window annotations.
Regression in f387d024fc.

Just like `OrderByList` the `ExpressionList` expression used to wrap
`Window.partition_by` must implement `get_group_by_cols` to ensure the
necessary grouping when mixing window expressions with aggregate
annotations is performed against the partition members and not the
partition expression itself.

This is necessary because while `partition_by` is implemented as
a source expression of `Window` it's actually a fragment of the WINDOW
expression at the SQL level and thus it should result in a group by its
members and not the sum of them.

Thanks ElRoberto538 for the report.
Backport of e76cc93b01 from main
2023-11-23 06:09:58 +01:00
Tim Schilling
06bdf62b56 [5.0.x] Fixed #34990 -- Changed link to OWASP in CSRF docs.
The OWASP site is the standard resource for web application
security information.
Backport of aceee39d44 from main
2023-11-23 05:28:15 +01:00
Mariusz Felisiak
48eebdc63c [5.0.x] Fixed #34985 -- Fixed GeneratedFields.contribute_to_class() crash when apps are not populated.
Thanks Paolo Melchiorre for the report.

Regression in f333e3513e.
Backport of 101a85a5a0 from main
2023-11-22 13:49:59 +01:00
Sarah Boyce
0c6ca52226 [5.0.x] Fixed #34984 -- Skipped GeneratedFields when remaking tables on SQLite.
Regression in f333e3513e8bdf5ffeb6eeb63021c230082e6f95.t

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>

Backport of 828082dad9 from main
2023-11-22 13:27:40 +01:00
Thibaud Colas
6692b0ecce [5.0.x] Added VoiceOver iOS and macOS separately in admin FAQ.
Follow up to 6daf86058b.
Backport of a2769a68ea from main
2023-11-21 05:46:49 +01:00
Natalia Bidart
e61ae5e106 [5.0.x] Bumped version for 5.0 release candidate 1. 2023-11-20 09:24:16 -03:00
Natalia Bidart
efd6cbfadf [5.0.x] Updated man page for Django 5.0 rc1. 2023-11-20 08:46:20 -03:00
Mariusz Felisiak
f721fb937c [5.0.x] Refs #34118 -- Doc'd Python 3.12 compatibility in Django 4.2.x.
Backport of ecfea054ee from main
2023-11-19 16:33:01 +01:00
Mariusz Felisiak
c342b58243 [5.0.x] Refs #34118 -- Added Python 3.12 to classifiers and tox.ini.
Backport of f955c90488 from main
2023-11-19 16:32:55 +01:00
Simon Charette
49f1ced863 [5.0.x] Fixed #34975 -- Fixed crash of conditional aggregate() over aggregations.
Adjustments made to solve_lookup_type to defer the resolving of
references for summarized aggregates failed to account for similar
requirements for lookup values which can also reference annotations
through Aggregate.filter.

Regression in b181cae2e3.

Refs #25307.

Thanks Sergey Nesterenko for the report.

Backport of 7530cf3900 from main
2023-11-18 16:52:54 +01:00
Mariusz Felisiak
8fb92dc96a [5.0.x] Removed obsolete warnings about asgiref.sync adapters with sensitive variables.
Django 5.0+ required asgiref 3.7+, and this warning is obsolete for
asgiref 3.7+ since
be6635e0e7.
Backport of 594873befb from main
2023-11-17 12:09:58 +01:00
Thibaud Colas
0923472aa2 [5.0.x] Doc'd support for assistive technologies in the admin.
Backport of 6daf86058b from main
2023-11-17 11:20:54 +01:00
David Smith
7f0275d8cb [5.0.x] Refs #32819 -- Used auto_id instead of id_for_label as unique identifier for the field.
`id_for_label` is blank for widgets with multiple inputs such as radios
and multiple checkboxes. Therefore , `help_text` for fields using these
widgets cannot currently be associated using `aria-describedby`.
`id_for_label` is being used as a guard to avoid incorrectly adding
`aria-describedby` to those widgets.

This change uses `auto_id` as the unique identified for the fields
`help_text`. A guard is added to avoid incorrectly adding
`aria-describedby` to inputs by checking the widget's `use_fieldset`
attribute. Fields rendered in a `<fieldset>` should have
`aria-describedby` added to the `<fieldset>` and not every `<input>`.

Backport of 292f1ea90f from main
2023-11-16 13:27:18 +01:00
Markus Amalthea Magnuson
8c88ae8251 [5.0.x] Fixed #34970 -- Clarified Password Validation docs regarding the password_changed callback.
Backport of 61c305f298 from main
2023-11-15 21:52:11 -03:00
Giannis Terzopoulos
a5ee682baf [5.0.x] Removed obsolete sentence in custom model field docs.
Backport of 36ed45d27c from main
2023-11-15 13:49:17 +01:00
William Hayes
effd704a1c [5.0.x] Refs #33690 -- Added missing data-theme selector to example in theming support docs.
Backport of 640283711e from main
2023-11-15 05:27:51 +01:00
Mariusz Felisiak
fcc55f8c26 [5.0.x] Refs #34944 -- Propagated system checks for GeneratedField.output_field.
Backport of c705625ebf from main
2023-11-14 20:22:41 +01:00
Mariusz Felisiak
ddbe5c86e8 [5.0.x] Fixed #34944 -- Made GeneratedField.output_field required.
Regression in f333e3513e.

Backport of 5875f03ce6 from main
2023-11-14 20:22:33 +01:00
Mariusz Felisiak
5b1d0a6be0 [5.0.x] Reverted "Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value()."
This reverts commit 8b1acc0440.

Backport of de4884b114 from main
2023-11-14 15:46:23 +01:00
nessita
7a21ea5464 [5.0.x] Fixed #34958 -- Fixed isolation of messages_tests.tests.TestLevelTags.test_lazy.
Backport of 1b56b24f81 from main
2023-11-13 09:38:00 +01:00
Adam Johnson
8eba6efbf0 [5.0.x] Fixed #34457 -- Restored output for makemigrations --check.
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>

Backport of f7389c4b07 from main
2023-11-09 10:44:07 -03:00
Jacob Walls
97a78121b3 [5.0.x] Fixed typos in docs/ref/models/fields.txt.
Backport of 427f0ed98d from main
2023-11-09 09:58:53 +03:00
Simon Charette
73869a5163 [5.0.x] Refs #30446, Refs #34944 -- Fixed crash when adding GeneratedField with string Value().
This should allow smarter output_field inferring in functions dealing
with text expressions.

Regression in f333e3513e.

Backport of 8b1acc0440 from main
2023-11-08 16:18:00 +03:00
Simon Charette
0265eaa500 [5.0.x] Fixed #34946 -- Preserved db_default on combined default field addition.
Regression in 7414704e88.
Backport of 8a28e983df from main
2023-11-07 13:33:24 +03:00
Mariusz Felisiak
1383dc75eb [5.0.x] Fixed #34941 -- Fixed fetching decimal db_defaults for DecimalFields on Oracle.
This is a long standing bug in bc91f27a86
that began manifesting in 7414704e88.
Backport of 656192c2c9 from main
2023-11-03 16:29:49 +01:00
Mariusz Felisiak
e2330ccd10 [5.0.x] Refs #34941 -- Skipped OperationTests.test_alter_field_change_nullable_to_decimal_database_default_not_null on Oracle.
Backport of 7a09ba0962 from main
2023-11-03 05:30:08 +01:00
David Sanders
8dde0504f3 [5.0.x] Fixed #34936 -- Fixed migration crash for DecimalField with db_default on SQLite.
CAST() must be wrapped in parentheses to be recognized as an expression on SQLite.

Regression in 7414704e88.

Backport of 797957fb48 from main
2023-11-02 19:59:39 +01:00
Tim Graham
b735b90f43 [5.0.x] Refs #31300 -- Allowed testing GeneratedField without collation.
CockroachDB and Snowflake don't support it.

Backport of 208870b612 from main
2023-11-02 15:48:31 +01:00
Patrick Rauscher
bf8aac3679 [5.0.x] Fixed #34813 -- Doc'd usage of integrity HTML attribute with ManifestStaticFilesStorage.
Backport of 116e225266 from main
2023-11-02 08:26:27 -03:00
Mariusz Felisiak
fd593db2fa [5.0.x] Added stub release notes for 4.2.8.
Backport of 36173cf29d from main
2023-11-01 08:25:18 +01:00
Mariusz Felisiak
2d929dd2cc [5.0.x] Added CVE-2023-46695 to security archive.
Backport of 7caf262183 from main
2023-11-01 08:17:30 +01:00
Mariusz Felisiak
bb71d34551 [5.0.x] Fixed CVE-2023-46695 -- Fixed potential DoS in UsernameField on Windows.
Thanks MProgrammer (https://hackerone.com/mprogrammer) for the report.
2023-11-01 06:18:00 +01:00
Natalia
acd4595ab0 [5.0.x] Refs #30601 -- Fixed typos in docs/topics/db/transactions.txt.
Backport of 9b18af4f6f from main
2023-10-30 13:49:12 -03:00
Natalia
c8bc72462d [5.0.x] Refs #15578 -- Made cosmetic edits to fixtures docs.
Backport of b412e5645a from main
2023-10-30 10:33:08 -03:00
Tom Carrick
602835202d [5.0.x] Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.
Regression in f3f9d03edf (4.2) and
8ed25d65ea (5.0).

Backport of 34b411762b from main
2023-10-30 11:08:03 +01:00
Mariusz Felisiak
329ae408bf [5.0.x] Fixed typo in docs/topics/forms/index.txt.
Backport of 46df3ab244 from main
2023-10-30 05:17:55 +01:00
Sarah Boyce
dfdca516ea [5.0.x] Fixed typos in docs/ref/models/expressions.txt.
Backport of 8992a0489c from main
2023-10-28 14:22:00 +02:00
lufafajoshua
c8ac50c201 [5.0.x] Fixed #30601 -- Doc'd the need to manually revert all app state on transaction rollbacks.
Backport of aa80b357fb from main
2023-10-27 23:33:16 -03:00
Marc Gibbons
4e1bb31b39 [5.0.x] Doc'd writing integration tests for the system check framework.
Backport of 8d9c0e4e24 from main
2023-10-27 11:44:40 +02:00
Izzy Hyman
a71f611a9e [5.0.x] Fixed typo in docs/ref/contrib/gis/geos.txt.
Backport of c42250a703 from main
2023-10-27 05:32:03 +02:00
Leo Suarez
89e539488a [5.0.x] Fixed #15578 -- Stated the processing order of fixtures in the fixtures docs.
Also, added details about loading multiple fixtures and unified line wrapping
at 79 cols.

Co-Authored-By: Aniketh Babu <anikethbabu@gmail.com>
Co-Authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-Authored-By: Natalia Bidart <124304+nessita@users.noreply.github.com>

Backport of 334dc073b1 from main
2023-10-26 21:51:40 -03:00
Mariusz Felisiak
415ef34c4c [5.0.x] Added missing pycon directives in various docs.
Backport of 718b32c691 from main
2023-10-25 12:27:56 +02:00
Tim Bell
8b18e0bb3b [5.0.x] Fixed #27403 -- Doc'd that QuerySet.prefetch_related() doesn't guarantee transactional consistency.
Added a note about the potential race condition in prefetch_related()
that could produce an inconsistent result, one that does not correspond
to any point in the database history.

Backport of ee104251c4 from main
2023-10-25 10:22:56 +02:00
Mariusz Felisiak
3361668ff4 [5.0.x] Added stub release notes and release date for 4.2.7, 4.1.13, and 3.2.23.
Backport of fdd1323b9c from main
2023-10-25 05:43:00 +02:00
Mariusz Felisiak
00805ff436 [5.0.x] Fixed #34923 -- Avoided initializing LEVEL_TAGS when importing django.contrib.messages.
Regression in b7fe36ad37.

Thanks James Gillard for the report.

Backport of 311718feb5 from main
2023-10-24 14:12:40 -03:00
Natalia
25fec8940b [5.0.x] Bumped version for 5.0 beta 1. 2023-10-23 15:41:31 -03:00
Nick Pope
cc5901fa8e [5.0.x] Fixed #34899 -- Added blank choice to forms' callable choices lazily.
Backport of 171f91d9ef from main
2023-10-23 14:54:37 -03:00
Nick Pope
bbe90f3c00 [5.0.x] Refs #34899 -- Extracted Field.flatchoices to flatten_choices helper function.
Co-authored-by: Natalia Bidart <124304+nessita@users.noreply.github.com>

Backport of 74afcee234 from main
2023-10-23 14:53:13 -03:00
Nick Pope
711c054722 [5.0.x] Refs #31262 -- Added __eq__() and __getitem__() to BaseChoiceIterator.
This makes it easier to work with lazy iterators used for callables,
etc. when extracting items or comparing to lists, e.g. during testing.

Also added `BaseChoiceIterator.__iter__()` to make it clear that
subclasses must implement this and added `__all__` to the module.

Co-authored-by: Adam Johnson <me@adamj.eu>
Co-authored-by: Natalia Bidart <124304+nessita@users.noreply.github.com>

Backport of 07fa79ef2b from main
2023-10-23 14:51:27 -03:00
David Sanders
08aa336af4 [5.0.x] Fixed #34903, Refs #34825 -- Made workers initialization respect empty set of used connections.
Thanks to David Smith for the investigation & patch.

Regression in 2128a73713.
Follow up to a5905b164d.

Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Backport of 68d0159b6d from main
2023-10-23 05:42:39 +02:00