mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-11-18 07:26:04 +00:00
Code Issues 24 Releases Wiki Activity
25,002 Commits 28 Branches 423 Tags 636 MiB
86367a11d3
Commit Graph

9125 Commits

Author SHA1 Message Date
Wil Tan
b94d99af5b Refs #28280 -- Added more tests for utils.numberformat.format(). 2017-06-29 13:31:41 -04:00
Tim Graham
0b00a8988b Fixed crash in i18n tests skip condition if gettext isn't installed. 2017-06-29 13:09:16 -04:00
Mariusz Felisiak
6e228d0b65 Fixed #28277 -- Added validation of QuerySet.annotate() and aggregate() args. 
Thanks Tim Graham and Nick Pope for reviews.
 2017-06-29 18:25:36 +02:00
Anssi Kääriäinen
f7f5edd50d Removed obsolete Query.tables attribute. 
Obsolete since Query.alias_map became an OrderedDict (refs #26522).
 2017-06-29 11:09:11 -04:00
Mads Jensen
550cb3a365 Fixed #27818 -- Replaced try/except/pass with contextlib.suppress(). 2017-06-28 14:07:55 -04:00
Daniel Hahler
43a4835edf Fixed #27473 -- Added DurationField support to Extract. 2017-06-28 10:10:09 -04:00
Mariusz Felisiak
3297dede7f Fixed #28046 -- Added the db_tablespace parameter to class-based indexes. 
Thanks Markus Holtermann and Tim Graham for reviews.
 2017-06-27 21:15:15 +02:00
michaldabski
d381914aef Fixed #28313 -- Added model name max length check of 100 characters in contrib.contentttypes. 2017-06-26 18:12:35 -04:00
Sergey Fedoseev
44a7b98abb Fixed #27964 -- Made MySQL backend raise exception if spatial transformation is needed for query. 2017-06-26 15:10:55 -04:00
Paulo Alvarado
c432927160 Fixed #26362 -- Fixed update of the inherited id field of an object when its parent changes. 2017-06-26 12:11:20 -04:00
Jon Dufresne
fa283067c9 Removed unnecessary empty parentheses in class definitions. 2017-06-26 10:31:32 -04:00
Mariusz Felisiak
081e787160 Refs #23919 -- Stopped inheriting from object to define new style classes. 
Tests and docs complement to cecc079168.
 2017-06-26 10:30:31 -04:00
Josh Schneier
fba0eaa5d6 Fixed #28298 -- Prevented a primary key alteration from adding a foreign key constraint if db_constraint=False. 2017-06-22 21:31:56 -04:00
Flávio Juvenal
0af14b2eaa Refs #16870 -- Doc'd that CSRF protection requires the Referer header. 2017-06-22 11:50:00 -04:00
Tim Graham
e1cd5a76d7 Cosmetic edits to tests/view_tests/tests/test_csrf.py. 2017-06-22 09:30:40 -04:00
Mariusz Felisiak
8cb1b1fd8e Reorganized backends tests. 2017-06-21 12:00:47 -04:00
Mariusz Felisiak
0f91ba1adc Fixed #28329 -- Fixed Cast() with Big/Small/Positive/PositiveSmallIntegerField on MySQL. 2017-06-21 10:16:53 -04:00
Andrew Pinkham
a96b981d84 Fixed #28127 -- Allowed UserCreationForm's password validation to check all user fields. 2017-06-21 09:22:15 -04:00
Simon Charette
b1cbbe9267 Refs #25530 -- Deleted deferred SQL references on delete operation. 2017-06-21 00:26:30 -04:00
Simon Charette
b50815ee41 Refs #25530 -- Renamed deferred SQL references on rename operation. 2017-06-21 00:26:30 -04:00
Simon Charette
3b429c9673 Refs #25530 -- Tracked references of deferred SQL statements. 2017-06-21 00:03:31 -04:00
Simon Charette
ea91ad4c13 Refs #25530 -- Changed _create_index_name to take a table as first parameter. 2017-06-20 22:59:22 -04:00
Mads Jensen
de42adf4ff Fixed #27869 -- Added fastupdate and gin_pending_list_limit params to GinIndex. 
Thanks Tim Graham and Markus Holtermann for review.
 2017-06-20 10:54:39 -04:00
Georg Sauthoff
d0f59054d0 Fixed #28324 -- Made feedgenerators write feeds with deterministically ordered attributes. 2017-06-20 05:38:41 -04:00
Paul Tiplady
335a8d7895 Fixed #28322 -- Added dbshell support for MySQL client TLS certs. 2017-06-19 18:11:25 -04:00
Anton Samarchyan
a469e158a9 Added tests for PermissionDenied in admin's delete_selected() view. 2017-06-19 16:01:48 -04:00
Tim Graham
7d52de31af Moved admin's action view tests to a separate file. 2017-06-19 16:00:06 -04:00
Anton Samarchyan
57f4b3ce37 Added tests for AdminSite's add/disable/get action methods. 2017-06-19 15:53:51 -04:00
Anton Samarchyan
90294cc2ae Added a test for ModelAdmin.__str__(). 2017-06-19 15:33:21 -04:00
Anton Samarchyan
0b9ccf9e60 Completed test coverage for admin's LogEntry model. 2017-06-19 14:12:38 -04:00
Marti Raudsepp
fda55c71a8 Fixed #27858 -- Prevented read-only management commands from creating the django_migrations table. 
MigrationRecorder now assumes that if the django_migrations table
doesn't exist, then no migrations are applied.

Reverted documentation change from refs #23808.
 2017-06-19 13:04:57 -04:00
Tim Graham
d1d7348001 Refs #25809 -- Removed BrinIndex.__repr__(). 
In retrospect, implementing a __repr__() for index subclasses doesn't
seem worthwhile.
 2017-06-17 18:41:53 -04:00
Tim Graham
221e6e1817 Fixed #28176 -- Restored the uncasted option value in ChoiceWidget template context. 2017-06-17 18:17:23 -04:00
Maciej Jaworski
dc63ad7ac0 Fixed #28319 -- Made TextField with choices use a Select widget. 2017-06-17 08:23:32 -04:00
Tim Graham
3b050fd0d0 Fixed #28303 -- Prevented localization of attribute values in the DTL attrs.html widget template. 2017-06-17 08:12:05 -04:00
Chandrakant Kumar
2b09e4c88e Fixed #27787 -- Made call_command() validate the options it receives. 2017-06-16 21:28:38 -04:00
reficul31
92e286498a Fixed #27539 -- Made TransactionTestCase._pre_setup() clear the queries_log so it's less likely to overflow. 
TransactionTestCase.assertNumQueries() fails in an overflow situation.
 2017-06-16 21:06:13 -04:00
Daniel Wiesmann
6f44f714c9 Fixed #28300 -- Allowed GDALRasters to use the vsimem filesystem. 
Thanks Tim Graham for the review and edits.
 2017-06-16 12:09:05 -04:00
Chandrakant Kumar
f6800a081a Refs #27787 -- Corrected or removed invalid call_command() options. 2017-06-16 11:06:01 -04:00
Pavel Rybintsev
874b1f2cac Fixed #26936 -- Fixed stale ContentType deletion in apps without models. 2017-06-16 09:22:47 -04:00
Claude Paroz
ceca221b31 Fixed #28304 -- Kept SafeData type for pgettext-translated strings 2017-06-15 21:00:50 +02:00
Claude Paroz
a6b5321ce9 Refs #24423 -- Readded inadvertently deleted i18n tests. 
Mistake in 97c1931c4f.
 2017-06-14 21:34:33 -04:00
Lincoln Smith
15b465c584 Fixed #27998 -- Made ManyToManyField changes logged in admin's object history. 2017-06-14 13:07:06 -04:00
chillaranand
fb0f987f7d Fixed #27914 -- Added support for nested classes in Field.deconstruct()/__repr__(). 2017-06-14 10:10:17 -04:00
Adam Bogdał
bd0c9388c0 Added additional field_construction tests for related fields. 2017-06-14 08:57:43 -04:00
Adam Bogdał
cd2fe829dd Fixed #24195 -- Deconstructed the limit_choices_to option of related fields. 
Migrations will now be created for changes to limit_choices_to.
 2017-06-14 08:57:24 -04:00
Romulo Furtado
9dd2443942 Fixed #27161 -- Fixed form validation when an ArrayField's base_field has choices. 2017-06-13 19:44:24 -04:00
John D'Ambrosio
be68c0bf63 Fixed #28071 -- Fixed {% extends %} origin history. 2017-06-13 12:50:54 -04:00
chillaranand
08bda82c23 Fixed #27830 -- Used distutils.version.LooseVersion for version parsing. 2017-06-13 10:53:39 -04:00
Mikhail Golubev
e7dc39fb65 Fixed #28229 -- Fixed the value of LoginView's "next" template variable. 2017-06-13 09:13:22 -04:00
orf
a118287bca Fixed #28284 -- Prevented Paginator's unordered object list warning from evaluating a QuerySet. 2017-06-13 08:13:17 -04:00
Mariusz Felisiak
82175ead72 Fixed #28293 -- Fixed union(), intersection(), and difference() when combining with an EmptyQuerySet. 
Thanks Jon Dufresne for the report and Tim Graham for the review.
 2017-06-13 08:16:16 +02:00
Paulo
9dc83c356d Fixed #27967 -- Fixed KeyError in admin's inline form with inherited non-editable pk. 
Thanks Robin Anupol for the initial report and workaround.
 2017-06-12 21:12:54 -04:00
Tim Graham
3d0a0ecd2c Refs #23919 -- Removed support for broken Model.__str__() in Model.__repr__(). 
Returning invalid bytestrings in __str__() is unlikely in Python 3.
 2017-06-11 15:52:19 -04:00
Tom
3eb3907bb1 Refs #23919 -- Replaced stray super(ClassName, self) with super(). 2017-06-10 20:46:43 -04:00
Collin Anderson
1a49b89470 Fixed #27953 -- Added instance's pk to Model.__str__(). 2017-06-09 13:42:53 -04:00
Collin Anderson
7c9cb1ed37 Refs #27953 -- Removed hardcoded uses of Model.__str__() in tests. 2017-06-09 13:28:50 -04:00
Mads Jensen
c7f6ffbdcf Fixed #28103 -- Added quarter extract, truncation, and lookup. 
Thanks Mariusz Felisiak, Tim Graham, and Adam Johnson for review.
 2017-06-08 15:15:29 -04:00
Thomas Khyn
f6bd00131e Fixed #28241 -- Allowed module_has_submodule()'s module_name arg to be a dotted path. 2017-06-08 14:34:20 -04:00
Daniel Wiesmann
fe5e34a295 Fixed #28288 -- Allowed passing papsz options to GDALRaster initialization. 2017-06-08 12:44:26 -04:00
Jon Dufresne
0c3c37a376 Fixed #28282 -- Fixed class-based indexes name for models that only inherit Model. 2017-06-08 09:36:12 -04:00
Arne de Laat
681d2599ee Fixed #28165 -- Ignored case in FileExtensionValidator's allowed_extensions. 2017-06-07 16:53:36 -04:00
Arne de Laat
b137add6cf Added FileExtensionValidator tests for uppercase and missing file extensions. 2017-06-07 16:53:10 -04:00
Claude Paroz
2862760894 Fixed #28257 -- Confirmed support for GDAL 2.2 
Additionally, a test has been updated to account for small SRS WKT differences.
Thanks Tim Graham for writing the doc part.
 2017-06-07 21:26:04 +02:00
Daniel Wiesmann
e0b456bee7 Fixed #28232 -- Made raster metadata readable and writable on GDALRaster/Band. 2017-06-07 11:30:35 -04:00
kakulukia
525dc283a6 Fixed #28278 -- Fixed invalid HTML for a required AdminFileWidget. 2017-06-06 15:41:23 -04:00
Josh Schneier
37c9b81ebc Fixed #28104 -- Prevented condition decorator from setting ETag/Last-Modified headers for non-safe requests. 2017-06-06 15:37:14 -04:00
Claude Paroz
23142eea85 Fixed #18394 -- Added error for invalid JavaScriptCatalog packages 
Thanks Tim Graham for the review.
 2017-06-06 18:02:22 +02:00
Paulo
4ad2f86284 Fixed #28202 -- Fixed FieldListFilter.get_queryset() crash on invalid input. 2017-06-06 07:54:31 -04:00
Claude Paroz
d02fc8dfd3 Refs #21286 -- Enabled serializer tests with date/datetime pk model 2017-06-05 21:36:25 +02:00
partizan
ff099f9db8 Fixed #28271 -- Added charset to technical_500_response() AJAX response. 2017-06-05 14:43:40 -04:00
Claude Paroz
6352d06cd0 Fixed #26651 -- Kept original file suffix in TemporaryUploadedFile name 
Thanks Tim Graham for the review.
 2017-06-05 18:55:44 +02:00
Paulo
b7f99f84bc Fixed #28262 -- Fixed incorrect DisallowedModelAdminLookup when a nested reverse relation is in list_filter. 2017-06-05 10:29:54 -04:00
Jon Dufresne
a0f8c52ae2 Fixed ResourceWarnings in tests/servers/tests.py. 
e.g. ResourceWarning: unclosed <socket.socket [closed] fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6>
 2017-06-05 09:56:51 -04:00
Adam Johnson
ed244199c7 Fixed #28269 -- Fixed Model.__init__() crash on models with a field that has an instance only descriptor. 
Regression in d2a26c1a90.
 2017-06-05 08:40:43 -04:00
Adam Johnson
36f09c8a29 Added a test for Model._meta._property_names. 2017-06-05 08:28:33 -04:00
Jon Dufresne
0a66aa158a Refs #27308, #27753 -- Removed obsolete cookie test mixing bytes with str. 
Python 3's SimpleCookie treats all values as strings. Passing a bytes
object coerces to the repr value.
 2017-06-03 21:07:11 -04:00
Claude Paroz
43b574007e Fixed #28192 -- Required passing optional form field args as keyword args. 2017-06-03 10:49:01 -04:00
Claude Paroz
54caca2d34 Refs #28192 -- Fixed documentation of ChoiceField choices requirement 
Thanks Tim Graham for noticing the issue.
 2017-06-03 16:17:03 +02:00
Anton Samarchyan
0c1355e9bb Completed test coverage for RedirectFallbackMiddleware. 2017-06-02 20:10:27 -04:00
Anton Samarchyan
2b53c8377d Improved test coverage of contrib/admin/checks.py. 2017-06-02 18:47:07 -04:00
Tim Graham
0841a31baf Fixed admin_views IntegrityError test failure. 
Regression in 38a5a23c32.
 2017-06-02 14:59:01 -04:00
Tim Graham
38a5a23c32 Fixed admin_views test when run in reverse. 
Modifying self.s1 created in setUpTestData() leaked state.

Regression in 45585d3cbb.
 2017-06-02 13:35:03 -04:00
Tim Graham
45585d3cbb Removed pk hardcoding in admin_views tests. 2017-06-02 10:01:41 -04:00
Jon Dufresne
29a518006f Fixed #28265 -- Prevented renderer warning on Widget.render() with **kwargs. 2017-06-02 09:46:43 -04:00
Jon Dufresne
2c69824e5a Refs #23968 -- Removed unnecessary lists, generators, and tuple calls. 2017-06-01 19:08:59 -04:00
François Freitag
edee5a8de6 Fixed #27639 -- Added chunk_size parameter to QuerySet.iterator(). 2017-06-01 17:50:41 -04:00
Mariusz Felisiak
924a89e135 Fixed #26682 -- Added support for Oracle identity columns. 
Thanks Shai Berger and Tim Graham for reviews.
 2017-06-01 19:33:48 +02:00
Tim Graham
cde31daf88 Sorted imports per isort 4.2.9. 2017-06-01 13:23:48 -04:00
Manatsawin Hanmongkolchai
a0c07d77fc Fixed #28242 -- Moved ImageField file extension validation to the form field. 2017-06-01 10:13:23 -04:00
Ingo Klöcker
6bb3b2bff4 Refs #27777 -- Improved docs/added test for File context manager change. 2017-05-31 21:02:58 -04:00
Matthias Erll
eee34ef64c Fixed #22550 -- Prohibited QuerySet.last()/reverse() after slicing. 2017-05-31 19:34:56 -04:00
Tim Graham
84fb50df67 Fixed a forms test after updated translations. 2017-05-31 19:29:34 -04:00
Derrick Jackson
789c290150 Fixed #28170 -- Fixed file_move_safe() crash when moving files to a CIFS mount. 2017-05-31 14:52:40 -04:00
Chris Lamb
2ec56bb782 Fixed #26755 -- Fixed test_middleware_classes_headers if Django source isn't writable. 2017-05-31 10:25:09 -04:00
Robert Rollins
b6d4b6e544 Fixed #28212 -- Allowed customizing the port that LiveServerTestCase uses. 
Forwardport of 877d7b71ae from stable/1.11.x
 2017-05-30 18:49:10 -04:00
Tim Graham
4a251f8bce Fixed AppRegistryNotReady error when running gis_tests in isolation on PostGIS. 
Regression in 890537253c.
 2017-05-30 15:14:32 -04:00
Adit Biswas
c2eea61dff Fixed #28209 -- Made date-based generic views return a 404 rather than crash when given an out of range date. 2017-05-30 13:20:35 -04:00
Adam Johnson
b3e55109bd Improved test coverage for startapp/startproject management commands. 2017-05-30 09:40:32 -04:00
Adam Johnson
9509268cea Refs #23804 -- Improved value validation in GDALRaster.geotransform setter. 2017-05-30 09:02:50 -04:00
Mariusz Felisiak
037d6540ec Fixed gis_tests.geoapp test with incorrect geodetic coordinates. 
The latitude coordinates exceed -90, 90 bounds and caused a test failure
on Oracle 12.2.

Thanks Michał Wierzbowski for help preparing the patch.
 2017-05-30 08:22:40 -04:00
Tim Graham
f04495521a Fixed #28199 -- Fixed Subquery generating unnecessary/invalid CAST. 
Thanks Simon Charette for the fix.
 2017-05-30 06:40:41 -04:00
Linus Lewandowski
eedc88bd4a Fixed #26823 -- Prevented update_last_login signal receiver from crashing if User model doesn't have last_login field. 2017-05-29 17:31:18 -04:00
Nick Zaccardi
95993a89ce Fixed #28248 -- Fixed password reset tokens being valid for 1 day longer than PASSWORD_RESET_TIMEOUT_DAYS. 2017-05-29 09:22:22 -04:00
Jon Dufresne
21046e7773 Fixed #28249 -- Removed unnecessary dict.keys() calls. 
iter(dict) is equivalent to iter(dict.keys()).
 2017-05-27 19:08:46 -04:00
Jon Dufresne
2a5708a304 Fixed a test's dict_keys/list comparison that always evaluated as False. 2017-05-27 18:37:16 -04:00
Tom
7afb476469 Fixed #28226 -- Replaced use of str.join() with concatenation. 2017-05-27 13:59:05 -04:00
Alex
37ab3c3f9d Fixed #28222 -- Allowed settable properties in QuerySet.update_or_create()/get_or_create() defaults. 2017-05-27 12:41:38 -04:00
Tim Heap
5b6181f4d5 Fixed #27922 -- Added ErrorDict.get_json_data(). 2017-05-27 09:19:42 -04:00
Chris Lamb
2f09a28558 Fixed #27881 -- Added diffsettings --output option. 
Thanks Haris Ibrahim K. V. for writng docs.
 2017-05-27 09:00:06 -04:00
Pavel Kulikov
af1fa5e7da Fixed #27978 -- Allowed loaddata to read data from stdin. 
Thanks Squareweave for the django-loaddata-stdin project from which this
is adapted.
 2017-05-26 19:54:21 -04:00
jannh
c930c241f8 Fixed #28017 -- Allowed customizing PasswordResetTokenGenerator's secret. 2017-05-26 07:37:36 -04:00
Claude Paroz
2cbb095bec Fixed #28221 -- Fixed plural fallback translations in JavaScriptCatalog view 
Thanks Waldemar Kornewald for the report and initial patch.
 2017-05-25 22:47:21 +02:00
Tom
bb0b6e5263 Fixed #28211 -- Prevented ORing an empty Q() from reducing query join efficiency. 2017-05-25 09:06:25 -04:00
Tim Graham
1c3a6cec2a Refs #28211 -- Added a test for ANDing empty Q()'s. 
This test passes to due some logic in Node.add().
 2017-05-25 09:02:13 -04:00
Rajesh Veeranki
67e1afb4a8 Fixed #28224 -- Tested for SuspiciousOperation subclasses in Django's tests. 2017-05-25 08:19:01 -04:00
Mariusz Felisiak
663d1c3160 Simplified schema.tests with assertForeignKeyExists()/assertForeignKeyNotExists(). 
Thanks Tim Graham for the review.
 2017-05-24 16:43:56 +02:00
Bruno Alla
6092ea8fa6 Refs #27804 -- Used subTest() in several tests. 2017-05-24 08:36:34 -04:00
Mariusz Felisiak
91b2bc3e70 Fixed #27860 -- Dropped varchar_pattern_ops/text_pattern_ops index before altering char/text field in PostgreSQL. 
Thanks Tim Graham for the review.
 2017-05-24 07:25:59 +02:00
Mariusz Felisiak
538bf43458 Fixed #27859 -- Ignored db_index for TextField/BinaryField on Oracle and MySQL. 
Thanks Zubair Alam for the initial patch and Tim Graham for the review.
 2017-05-23 17:02:40 +02:00
Mariusz Felisiak
b3eb6eaf1a Refs #27859 -- Added DatabaseWrapper.display_name. 
Thanks Tim Graham for the review.
 2017-05-23 09:09:35 -04:00
R3turnz
502f03d897 Fixed #28112 -- Added 'time_zone' in GeoIP2.city() dict. 2017-05-22 21:07:14 -04:00
Daniel Hahler
a3ba2662cd Refs #28207 -- Fixed contrib.auth.authenticate() if 'backend' is in the credentials. 
Regression in 3008f30f19.
 2017-05-22 12:24:38 -04:00
Ling-Xiao Yang
04ab96ec4f Fixed #28015 -- Added makemessages --add-location option. 
Thanks François Freitag for review.
 2017-05-22 09:03:53 -04:00
Claude Paroz
43c65e0eb0 Fixed #28180 -- Numbered queries in assertNumQueries failure output 
Thanks Tim Graham for the test part.
 2017-05-20 15:11:09 +02:00
Tim Graham
59ab1b2683 Fixed #28210 -- Fixed Model._state.adding on MTI parent model after saving child model. 
Regression in 38575b007a.
 2017-05-19 13:22:17 -04:00
Mariusz Felisiak
99df304c85 Fixed #28206 -- Fixed RawQuerySet crash on a model with a mixed case db_column pk on Oracle. 
Thanks Tim Graham for the review.
 2017-05-18 19:11:23 +02:00
François Freitag
98b3b14a64 Fixed #28203 -- Ignored connection configuration queries in assertNumQueries(). 2017-05-18 11:48:03 -04:00
Jon Dufresne
f599747fc8 Fixed #28152 -- Made migrations serialize sets as set literals rather than set(). 2017-05-18 09:33:40 -04:00
Claude Paroz
912ef7f49d Fixed validity of test django_js.po files 2017-05-18 14:33:18 +02:00
Tim Graham
650bf6714d Refs #27996 -- Skipped RandomUUID test on PostgreSQL 9.3. 2017-05-15 09:26:38 -04:00
Tim Schneider
3a5299c19c Fixed #28197 -- Fixed introspection of index field ordering on PostgreSQL. 2017-05-15 08:33:31 -04:00
Tamas Szabo
3008f30f19 Fixed #28207 -- Fixed contrib.auth.authenticate() if multiple auth backends don't accept a request. 2017-05-15 07:48:15 -04:00
Danilo Bargen
a7975260b5 Fixed #28195 -- Added OSMWidget.default_zoom attribute. 2017-05-14 14:31:17 -04:00
Tim Graham
d3209bf09c Simplified test for OSMWidget.default_lon/lat. 2017-05-14 13:02:09 -04:00
Sławek Ehlert
faaf62f616 Improved test coverage for createsuperuser command. 2017-05-12 10:29:56 -04:00
Simon Charette
4acae21846 Fixed #24254 -- Fixed queries using the __in lookup with querysets using distinct() and order_by(). 
Thanks Tim for the review.
 2017-05-11 21:50:07 -04:00
Tim Graham
a9874d48b1 Fixed #28188 -- Fixed crash when pickling model fields. 
Regression in d2a26c1a90.

Thanks Adam Alton for the report and test, and Adam Johnson for
suggesting the fix.
 2017-05-11 21:04:52 -04:00
Simon Charette
daf2bd3efe Fixed #28107 -- Disabled grouping of selected primary keys for unmanaged models. 
The grouping caused an issue with database views as PostgreSQL's query planer
isn't smart enough to introspect primary keys through views. Django doesn't
support database views but documents that unmanaged models should be used to
query them.

Thanks powderflask for the detailed report and investigation.
 2017-05-11 20:00:57 -04:00
Alexander Allakhverdiyev
a7c6c705e8 Fixed #28129 -- Allowed custom template tags to use keyword-only arguments. 2017-05-11 10:09:44 -04:00
Claude Paroz
d1e5516c06 Complemented message storage test with explicit None extra_tags value 2017-05-10 22:38:46 +02:00
Florian Apolloner
d611a89238 Decreased max_length for char fields unless absolutely needed. (#8485) 2017-05-10 17:33:46 +02:00
Florian Apolloner
60f5129076 Fixed db backend discovery in admin_scripts tests. 
Not all backends have dots in them.
 2017-05-10 09:47:20 -04:00
UmanShahzad
856072dd4a Fixed #28142 -- Fixed is_safe_url() crash on invalid IPv6 URLs. 2017-05-10 09:02:20 -04:00
Markus Holtermann
8e352876c3
Refs #22397 -- Removed model in test cleanup 
The test was failing when using --keepdb due to a pre-existing
PonyStables model.

Thanks Florian Apolloner for the report
 2017-05-09 11:15:41 +02:00
Claude Paroz
a87189fc5e Fixed #28164 -- Improved float conversions in DecimalField.to_python 
Thanks Tim Graham and Adam Johnson for the reviews.
 2017-05-09 08:40:08 +02:00
Claude Paroz
d842ada305 Refs #27795 -- Stopped converting integer format settings to str in JS/JSON i18n views 
Thanks Tim Graham for the review.
 2017-05-08 19:32:03 +02:00
Claude Paroz
e3a88c7797 Renamed django.views.i18n test cases 2017-05-08 19:29:27 +02:00
Josh Schneier
5df0ff4155 Fixed #28089 -- Removed requirement to implement get_short_name() and get_full_name() in AbstractBaseUser subclasses. 2017-05-06 17:05:42 -04:00
François Freitag
88336fdbb5 Fixed #28062 -- Added a setting to disable server-side cursors on PostgreSQL. 
When a connection pooler is set up in transaction pooling mode, queries
relying on server-side cursors fail. The DISABLE_SERVER_SIDE_CURSORS
setting in DATABASES disables server-side cursors for this use case.
 2017-05-06 06:59:04 -04:00
Raphael Michel
504e7782fe Refs #22654 -- Added additional tests and amended release note. 2017-05-05 18:45:07 -04:00
Tim Graham
d66378a8b2 Fixed #28175 -- Fixed __in lookups on a foreign key when using the foreign key's parent model as the lookup value. 
Thanks Simon Charette for review.
 2017-05-05 18:35:08 -04:00
Tim Graham
b014de011b Removed obsolete HAS_GEOS variable for test skipping. 2017-05-04 20:45:18 -04:00
Tim Graham
2dc3280254 Fixed #28160 -- Prevented hiding GDAL exceptions when it's not installed. 2017-05-04 20:45:18 -04:00
Tim Graham
890537253c Made runtests.py run gis_tests only when using a GIS database backend. 
This facilitates other changes like refs #28160.
 2017-05-04 20:29:19 -04:00
François Freitag
ec05ff086c Refs #25546 -- Added detailed comments for prefetch_related test. 2017-05-04 09:19:54 -04:00
François Freitag
c0a2b9508a Fixed #27554 -- Fixed prefetch_related() crash when fetching relations in nested Prefetches. 2017-05-04 09:17:29 -04:00
Simon Charette
b91868507a Fixed #28161 -- Fixed return type of ArrayField(CITextField()). 
Thanks Tim for the review.
 2017-05-04 00:02:14 -04:00
Simon Charette
f37467ec7a Added a test for ArrayField(HStoreField()). 2017-05-03 23:53:08 -04:00
Tim Graham
67702f3505 Converted sessions_tests to use assertIs() rather than assertTrue/False(). 2017-05-03 20:21:39 -04:00
Tim Graham
578e576c31 Fixed #28167 -- Fixed cache backend's SessionStore.exists() if session_key is None. 2017-05-03 12:39:07 -04:00
Tim Graham
584e10c76e Fixed #28166 -- Fixed Model._state.db on MTI parent model after saving child model. 
Regression in 38575b007a.
 2017-05-03 12:14:15 -04:00
Alexander Kavanaugh
362fba87c9 Fixed #28159 -- Fixed BaseInlineFormSet._construct_form() crash when using save_as_new. 
Regression in 4a246a02bd.
 2017-05-03 07:45:51 -04:00
Tim Graham
d302e2c09c Fixed #28157 -- Fixed choice ordering in form fields with grouped and non-grouped options. 
Regression in b52c73008a.
 2017-05-03 07:21:44 -04:00
Tim Graham
d0e43f225f Refs #28052 -- Cleaned up some indexes in schema tests. 2017-05-01 22:19:05 -04:00
Markus Holtermann
663e48947f Fixed #28052 -- Prevented dropping Meta.indexes when changing db_index to False. 
Thanks Marc Tamlyn for the report and Ian Foote/Tim Graham for review.
 2017-05-01 11:31:48 -04:00
Ian Foote
63afe3a2bf Fixed #28043 -- Prevented AddIndex and RemoveIndex from mutating model state. 2017-05-01 09:32:44 -04:00
Jon Dufresne
b39aabc6c6 Refs #27795 -- Reworked get_or_create test erroneously mixing bytes and str. 
As CharField.to_python() now always calls str(), assigning bytes to a
CharField is no longer correct usage. Doing so results in a warning:

  django/db/models/fields/__init__.py:1061: BytesWarning: str() on a bytes instance

Use a unique constraint violation to trigger the database error instead.

Warning introduced in 301de774c2.
 2017-05-01 08:47:49 -04:00
Dylan Verheul
75aeebebfe Fixed #28105 -- Fixed crash in BaseGeometryWidget.get_context() when overriding existing attrs. 2017-04-30 20:19:12 -04:00
Tim Graham
1ebd295082 Fixed #28040 -- Updated SplitArrayWidget to use template-based widget rendering. 
Thanks Preston Timmons for review.
 2017-04-29 19:00:21 -04:00
Tim Graham
c920db1e57 Removed blank line in tests/model_fields/test_decimalfield.py per isort. 2017-04-29 07:42:12 -04:00
Tim Graham
f04a404917 Fixed #28130 -- Fixed formset min_num validation with initial, unchanged forms. 
Regression in f5c6295797.
 2017-04-28 09:32:40 -04:00
Mariusz Felisiak
f32ee6d0ec Refs #6767 -- Added test for fetching decimal values without rounding error on Oracle. 2017-04-28 06:07:28 +02:00
Tim Graham
309c10c2cb Refs #20094 -- Removed obsolete tests/utils_tests/test_itercompat.py 
The is_iterator() function was removed in 2456ffa42c.
 2017-04-26 10:54:06 -04:00
Paolo Melchiorre
fcb5dbfec0 Fixed #27996 -- Added RandomUUID function and CryptoExtension to contrib.postgres. 2017-04-25 20:21:36 -04:00
Paolo Melchiorre
a78fd2abd4 Alphabetized CITextExtension in test migration. 2017-04-25 19:32:39 -04:00
Tim Graham
56970c5b61 Fixed #28122 -- Fixed crash when overriding views.static.directory_index()'s template. 2017-04-25 11:01:21 -04:00
Mariusz Felisiak
562bca67b9 Added test for reraising backend-specific database exceptions. 2017-04-25 08:03:48 +02:00
Mariusz Felisiak
e776dd2db6 Fixed #28116 -- Used error code filtering in PostgreSQL test database creation. 
Thanks Claude Paroz and Tim Graham for reviews.
 2017-04-25 06:01:25 +02:00
Michiel Beijen
5e8625ba64 Renamed "Mac OS X" to "macOS" in docs. 2017-04-24 20:16:09 -04:00
Carles Pina Estany
9f2e8b5bb7 Fixed #28120 -- Checked that CharField.max_length is not a boolean. 2017-04-24 18:49:31 -04:00
Tim Graham
851874fe0a Removed obsolete Widget.format_output() in tests. 
Obsolete since b52c73008a.
 2017-04-24 13:41:34 -04:00
Simon Charette
8ef35468b6 Fixed #28101 -- Fixed a regression with nested __in subquery lookups and to_field. 
Thanks Kristian Klette for the report and Tim for the help.
 2017-04-23 00:21:27 -04:00
Claude Paroz
3f1ba76851 Fixed #28115 -- Fixed IP address validation in geoip2 module 
Regression in 277a4dd4b4.
Thanks Tim Graham for the test.
 2017-04-22 20:10:24 +02:00
Simon Charette
c0f12a098c Fixed #28109 -- Corrected the stack level of unordered queryset pagination warnings. 
Refs #26290.

Thanks Tim for the review.
 2017-04-22 14:08:57 -04:00
Jon Dufresne
581879a510 Fixed #28075 -- Prevented ChoiceWidget from localizing option values. 2017-04-21 12:14:40 -04:00
Tim Graham
d2cb7a2bc1 Fixed #28039 -- Fixed crash in BaseGeometryWidget.subwidgets(). 2017-04-20 11:36:40 -04:00
Tim Graham
af1f986360 Fixed #28059 -- Restored class attribute in <ul> of widgets that use multiple_input.html. 
Regression in b52c73008a
 2017-04-20 10:06:34 -04:00
Claude Paroz
43b4a1618e Fixed #28096 -- Allowed prefetch calls with ModelIterable subclasses 
Regression in 7ec330eeb9.
Thanks Tim Graham for the review.
 2017-04-19 19:32:46 +02:00
Tim Graham
dff559ff83 Fixed #28097 -- Fixed layout of ReadOnlyPasswordHashWidget. 2017-04-19 12:59:30 -04:00
Mariusz Felisiak
81f8449402 Refs #28066 -- Fixed nondeterministic ordering test failure in sessions_tests. 
Thanks Tim Graham for the review.
 2017-04-18 17:56:59 +02:00
InvalidInterrupt
dda596ca32 Fixed #28066 -- Prevented SessionBase.cycle_key() from discarding data. 2017-04-17 09:58:19 -04:00
Tim Graham
c09bf8d767 Fixed #28058 -- Restored empty BoundFields evaluating to True. 
Regression in b52c73008a
 2017-04-17 08:32:29 -04:00
Tim Graham
8c6a3062dd Fixed #28079 -- Restored "No POST data" (rather than an empty table) in HTML debug page. 
Regression in 7b6dccc82f
 2017-04-15 09:21:35 -04:00
Mariusz Felisiak
e1253bc26f Refs #25406 -- Removed exception hiding in MySQL test database creation during --keepdb. 
Thanks Adam Johnson, Simon Charette and Tim Graham for reviews.
 2017-04-13 20:20:01 +02:00
Claude Paroz
ea542a9c72 Fixed #28007 -- Moved debug templates to the filesystem 
Thanks Tim Graham for the review.
 2017-04-12 11:36:47 -04:00
Claude Paroz
2eb1f15f62 Tested template info in debug view's text traceback 2017-04-12 10:38:50 -04:00
petedmarsh
14671affc3 Fixed #28064 -- Removed double-quoting of key names in MultiValueDictKeyError. 2017-04-11 12:44:52 -04:00
Ran Benita
2a6b4e6521 Updated docs after changing select_for_update() to raise NotSupportedError. 
Follow up to 054a44d6f0.
 2017-04-11 11:52:53 -04:00
Sergey Fedoseev
e7afef13f5 Fixed #26788 -- Fixed QuerySet.update() crash when updating a geometry to another one. 2017-04-10 13:26:26 -04:00
Mariusz Felisiak
64264c9a19 Fixed #25406 -- Removed exception hiding in PostgreSQL test database creation during --keepdb. 
Thanks Markus Holtermann and Tim Graham for reviews.
 2017-04-10 13:04:00 -04:00
Mariusz Felisiak
054a44d6f0 Used NotSupportedError instead of DatabaseError in SQLCompiler.as_sql(). 2017-04-10 12:49:27 -04:00
Tim Graham
fce7827101 Fixed #28047 -- Fixed QuerySet.filter() crash when it uses the name of a OneToOneField pk. 
Regression in 1bc249c2a6.
 2017-04-10 09:51:51 -04:00
Collin Anderson
a19b373d89 Changed assertQuerysetEqual()s that use default Model.__str__() to assertSequenceEqual(). 2017-04-10 08:59:29 -04:00
Tim Graham
eb9a3bd63a Refs #26605 -- Isolated a migrations state test. 2017-04-10 08:13:45 -04:00
kalombo
dd00184892 Fixed #28042 -- Fixed crash when using a two-tuple in EmailMessage's attachments arg. 2017-04-07 18:02:34 -04:00
kalombo
aedfe0ddd7 Tested EmailMessage(attachments=[MIMEText]) 2017-04-07 18:01:31 -04:00
Simon Charette
a354c69055 Fixed #28038 -- Restored casting to text of builtin lookups on PostgreSQL. 
Reverted 658f1e8 which broke code using __icontains's implicit cast to ::text
on ArrayField.

Thanks Peter J. Farrell for the report.
 2017-04-07 16:47:52 -04:00
Ingo Klöcker
67b2b1f116 Refs #26605 -- Added migrations state test for a swappable model inheriting an abstract model inheriting concrete model. 
Thanks Sébastien Diemer for the report and test.
 2017-04-07 13:41:07 -04:00
Markus Holtermann
d3cf75ec6f Fixed #28051 -- Made migrations respect Index's name argument. 
Thanks Marc Tamlyn for the report and Tim Graham for the review.
 2017-04-07 11:47:53 -04:00
Ingo Klöcker
c4536c4a54 Fixed #27777 -- Made File.open() work with the with statement (#8310) 
Fixed #27777 -- Made File.open() work with the with statement
 2017-04-07 14:21:06 +02:00
Mariusz Felisiak
695d4dd790 Fixed #23147 -- Disabled a limit/offset on a query with select_for_update on Oracle. 
Thanks Shai Berger and Tim Graham for the reviews.
 2017-04-07 14:08:07 +02:00
Raphael Michel
bde814142a Fixed #22654 -- Broken decimal validation 2017-04-07 12:45:08 +02:00
Sergey Fedoseev
fd892f3443 Fixed #28006 -- Allowed using D with lookups on Distance annotations. 2017-04-06 19:27:45 -04:00
kapil garg
dbfcedb499 Fixed #28001 -- Updated comment and tested context popping in ForNode.render(). 2017-04-06 19:04:29 -04:00
Tim Graham
5ea48a70af Fixed #27912, CVE-2017-7233 -- Fixed is_safe_url() with numeric URLs. 
This is a security fix.
 2017-04-04 10:42:06 -04:00
Tim Graham
a1f948b468 Fixed CVE-2017-7234 -- Fixed open redirect vulnerability in views.static.serve(). 
This is a security fix.
 2017-04-04 10:42:06 -04:00
Claude Paroz
389c3ffc04 Updated tests after French translation update 2017-04-04 13:07:47 +02:00
kapil garg
002fe07622 Fixed #27974 -- Kept resolved templates constant during one rendering cycle. 
Thanks Florian Apolloner for the initial patch.
 2017-04-03 22:29:39 -04:00
Adam Johnson
7f8a924b45 Refs #27834 -- Removed Value wrapping from StrIndex's substring param. 2017-04-03 08:39:57 -04:00
Tim Graham
d4d79d0f20 Refs #27025 -- Fixed "invalid escape sequence" warning in auth_tests on Python 3.6. 2017-04-02 20:02:55 -04:00
Sergey Fedoseev
898e623db0 Fixed #27573 -- Made Distance on geodetic coordinates return a raw value on MySQL. 2017-04-02 17:06:01 -04:00
Simon Charette
35c0025151 Fixed #27928 -- Avoided SET/DROP DEFAULT unless a field changes from null to non-null. 
Thanks Christophe Pettus, Matteo Pietro Russo for reports and Tim for review.
 2017-04-02 16:34:03 -04:00
Sergey Fedoseev
5e710cf4a5 Fixed #11854 -- Added Azimuth GIS function. (#8286) 2017-04-02 14:24:06 -04:00
Claude Paroz
4f99ba84b3 Removed unused code in i18n view_tests 
Unused since 2b20e4148f.
 2017-04-02 19:58:18 +02:00
Chris Sinchok
66150f7cf6 Fixed #27954 -- Allowed keyboard interrupt to abort queries in PostgreSQL dbshell. 
Thanks Tim Martin for review.
 2017-04-01 21:01:08 -04:00
Jon Dufresne
7bbb5161ea Removed implicit default store_true/false argparse args. 
argparse automatically sets the default value for store_true/false
arguments to its opposite.
 2017-04-01 20:03:56 -04:00
Stefan Wehrmeyer
1aa8e8605c Fixed #27989 -- Preserved empty QueryDicts for form's data/files args. 2017-04-01 18:43:39 -04:00
Sergey Fedoseev
24023c6a8f Fixed #25874 -- Made GEOSGeometry read SRID from GeoJSON input. 2017-04-01 15:35:30 -04:00
Sergey Fedoseev
ede4f6d48c Fixed #12410 -- Added LineLocatePoint GIS function. 2017-04-01 15:02:09 -04:00
Sergey Fedoseev
0a13b249e2 Fixed #26967 -- Added MySQL support for AsGeoJSON, GeoHash, IsValid functions, and isvalid lookup. 2017-04-01 13:43:53 -04:00
Claude Paroz
9a9e228321 Fixed #27848 -- Prevented crash when attaching a .eml file to a message 
Thanks Sébastien Ramage for the report.
 2017-04-01 16:19:03 +02:00
Sergey Fedoseev
bde86ce9ae Fixed #25605 -- Made GIS DB functions accept geometric expressions, not only values, in all positions. 2017-04-01 09:47:49 -04:00
Claude Paroz
e487ffd3f0 Fixed #27866 -- Made ChoiceWidget.format_value() return a list 
Thanks Tim Graham for the review.
 2017-04-01 12:24:05 +02:00
Carlton Gibson
6b3724fa11 Fixed #27359 -- Made Engine.get_default() return the first DjangoTemplates engine if multiple are defined. 2017-03-31 17:26:42 -04:00
Carlton Gibson
7019724101 Added tests for template's Engine.get_default(). 2017-03-31 10:59:00 -04:00
heathervm
7d1e237753 Fixed #27993 -- Fixed model form default fallback for SelectMultiple. 2017-03-31 10:10:08 -04:00
Sergey Fedoseev
6ecccad711 Fixed #25873 -- Made GEOSGeometry handle the srid parameter more predictably. 2017-03-30 09:38:26 -04:00
Sergey Fedoseev
068d75688f Refs #18247 -- Fixed SQLite QuerySet filtering on decimal result of Least and Greatest. 2017-03-29 13:29:53 -04:00
Sergey Fedoseev
4bc355079c Fixed #27973 -- Fixed GeoJSON representation of LinearRing and custom GEOSGeometry subclasses. 2017-03-29 13:17:31 -04:00
Sergey Fedoseev
9cd6ba991f Made isvalid lookup use IsValid function to decrease code redundancy. 2017-03-29 08:56:58 -04:00
Mariusz Felisiak
1d070d027c Fixed #25414 -- Fixed QuerySet.annotate() with pk in values() on MySQL. 
Thanks Tim Graham and Simon Charette for the reviews.
 2017-03-29 06:47:07 +02:00
Sergey Fedoseev
d47de2e09d Refs #27736 -- Used decorators for GIS lookup registration. 2017-03-27 22:20:18 -04:00
Mariusz Felisiak
1b6f05e91f Fixed #21160 -- Fixed QuerySet.in_bulk() crash on SQLite when requesting more than 999 ids. 
Thanks Andrei Picus and Anssi Kääriäinen for the initial patch
and Tim Graham for the review.
 2017-03-27 18:43:40 +02:00
Tim Graham
e643ba8bcf Fixed #27956 -- Fixed display of errors in an {% extends %} child. 
Thanks Ling-Xiao Yang for the report and test, and
Preston Timmons for the fix.
 2017-03-25 08:22:12 -04:00
Mariusz Felisiak
f42c7cc87b Refs #21160 -- Replaced DatabaseFeatures.supports_1000_query_parameters by a DatabaseFeatures.max_query_params. 2017-03-24 18:37:03 +01:00
Sergey Fedoseev
1b1ea63f6a Fixed #27962 -- Allowed lookups on Area annotations. 2017-03-23 20:06:16 -04:00
Sergey Fedoseev
e9149d3eb0 Fixed #27603 -- Fixed AsKML when queryset is evaluated more than once. 2017-03-23 19:09:04 -04:00
Kapil Garg
7e09fa7f51 Fixed #27969 -- Fixed models.Field.formfield() setting 'disabled' for fields with choices. 2017-03-23 13:22:04 -04:00
James Beith
216bb2e8fb Fixed #27975 -- Fixed crash if ModelChoiceField's queryset=None. 
Regression in 9153d8fbd6385db9f48793662de789fc3d686841.
 2017-03-22 08:51:12 -04:00