mirror of
https://github.com/django/django.git
synced 2024-12-23 01:25:58 +00:00
Refs #27795 -- Reworked get_or_create test erroneously mixing bytes and str.
As CharField.to_python() now always calls str(), assigning bytes to a
CharField is no longer correct usage. Doing so results in a warning:
django/db/models/fields/__init__.py:1061: BytesWarning: str() on a bytes instance
Use a unique constraint violation to trigger the database error instead.
Warning introduced in 301de774c2
.
This commit is contained in:
parent
9ae4362bec
commit
b39aabc6c6
@ -6,10 +6,8 @@ from threading import Thread
|
||||
from django.core.exceptions import FieldError
|
||||
from django.db import DatabaseError, IntegrityError, connection
|
||||
from django.test import (
|
||||
SimpleTestCase, TestCase, TransactionTestCase, ignore_warnings,
|
||||
skipUnlessDBFeature,
|
||||
SimpleTestCase, TestCase, TransactionTestCase, skipUnlessDBFeature,
|
||||
)
|
||||
from django.utils.encoding import DjangoUnicodeDecodeError
|
||||
|
||||
from .models import (
|
||||
Author, Book, DefaultPerson, ManualPrimaryKeyTest, Person, Profile,
|
||||
@ -203,22 +201,18 @@ class GetOrCreateTestsWithManualPKs(TestCase):
|
||||
formatted_traceback = traceback.format_exc()
|
||||
self.assertIn('obj.save', formatted_traceback)
|
||||
|
||||
# MySQL emits a warning when broken data is saved
|
||||
@ignore_warnings(module='django.db.backends.mysql.base')
|
||||
def test_savepoint_rollback(self):
|
||||
"""
|
||||
Regression test for #20463: the database connection should still be
|
||||
usable after a DataError or ProgrammingError in .get_or_create().
|
||||
The database connection is still usable after a DatabaseError in
|
||||
get_or_create() (#20463).
|
||||
"""
|
||||
try:
|
||||
Person.objects.get_or_create(
|
||||
birthday=date(1970, 1, 1),
|
||||
defaults={'first_name': b"\xff", 'last_name': b"\xff"})
|
||||
except (DatabaseError, DjangoUnicodeDecodeError):
|
||||
Person.objects.create(
|
||||
first_name="Bob", last_name="Ross", birthday=date(1950, 1, 1))
|
||||
else:
|
||||
self.skipTest("This backend accepts broken utf-8.")
|
||||
Tag.objects.create(text='foo')
|
||||
with self.assertRaises(DatabaseError):
|
||||
# pk 123456789 doesn't exist, so the tag object will be created.
|
||||
# Saving triggers a unique constraint violation on 'text'.
|
||||
Tag.objects.get_or_create(pk=123456789, defaults={'text': 'foo'})
|
||||
# Tag objects can be created after the error.
|
||||
Tag.objects.create(text='bar')
|
||||
|
||||
def test_get_or_create_empty(self):
|
||||
"""
|
||||
|
Loading…
Reference in New Issue
Block a user