Mike Edmunds
78298b5162
Refs #36500 -- Corrected rewrapped long lines fixed via a script.
...
Manually reformatted some comments and docstrings where autofix_w505.py
changed the meaning of the formatting.
2025-07-23 20:17:55 -03:00
django-bot
69a93a88ed
Refs #36500 -- Rewrapped long docstrings and block comments via a script.
...
Rewrapped long docstrings and block comments to 79 characters + newline
using script from https://github.com/medmunds/autofix-w505 .
2025-07-23 20:17:55 -03:00
Simon Charette
760121dcb1
Fixed #35801 -- Prevented collision of senders with non-overlapping lifetimes.
...
As documented, the id() function can return the same value for distinct
objects with non-overlapping lifetimes which can result in signals being
sent to the wrong receivers if two distinct senders happen to have a
colliding id() value.
Since reproduction of the issue requires memory constrained
circumstances where the same exact id() is reused for two senders of the
same signal the test opt to simulate the collision by systematically
making the same id for Sender instances.
Note that we explicitly avoid keeping a strong reference to senders that
cannot be weakly referenced as that would unexpectedly prevent them from
being garbage collected. This means that id(sender) collisions could
still occur for such objects but Django itself doesn't make use of them.
Thanks Sjoerd Job Postmus for the reduced test case and Mariusz for the
review.
Co-authored-by: And Clover <and@doxdesk.com>
2025-04-23 13:09:46 +01:00
Vašek Dohnal
1b5338d03e
Fixed #35174 -- Fixed Signal.asend()/asend_robust() crash when all receivers are asynchronous.
...
Regression in e83a88566a71a2353cebc35992c110be0f8628af.
2024-02-08 11:36:28 +01:00
Jon Janzen
e83a88566a
Fixed #32172 -- Adapted signals to allow async handlers.
...
co-authored-by: kozzztik <kozzztik@mail.ru>
co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2023-03-07 08:39:25 +01:00
django-bot
9c19aff7c7
Refs #33476 -- Reformatted code with Black.
2022-02-07 20:37:05 +01:00
Mateo Radman
8a7ac78b70
Refs #32508 -- Raised ImproperlyConfigured/TypeError instead of using "assert" in various code.
2021-06-25 06:55:47 +02:00
Mariusz Felisiak
1adcf20385
Refs #31327 -- Removed providing_args argument for Signal per deprecation timeline.
2021-01-14 17:50:04 +01:00
Ayush Bansal
b960e4ed72
Fixed #32261 -- Added error logging to Signal.send_robust().
2020-12-15 11:00:26 +01:00
Jon Dufresne
769cee5252
Fixed #31327 -- Deprecated providing_args argument for Signal.
2020-03-05 09:38:52 +01:00
Jon Dufresne
e90af8bad4
Capitalized "Python" in docs and comments.
2018-10-09 09:26:07 -04:00
Brett Cannon
64b74804c5
Fixed #29334 -- Updated pypi.python.org URLs to pypi.org.
2018-04-17 20:24:27 -04:00
Tim Graham
acc8dd4142
Fixed #28984 -- Made assorted code simplifications.
2018-01-03 13:24:02 -05:00
Дилян Палаузов
4c599ece57
Fixed #28930 -- Simplified code with any() and all().
2017-12-26 17:11:15 -05:00
Anton Samarchyan
3eb679a869
Refs #27656 -- Updated django.forms/http docstring verbs according to PEP 257.
2017-02-20 19:57:33 -05:00
Tim Graham
435e4bf38e
Refs #23919 -- Removed __traceback__ setting needed for Python 2.
...
Partially reverted refs #25761 and refs #16245 .
2017-01-24 08:31:58 -05:00
Simon Charette
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
Claude Paroz
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
Claude Paroz
c716fe8782
Refs #23919 -- Removed six.PY2/PY3 usage
...
Thanks Tim Graham for the review.
2017-01-18 16:21:28 +01:00
Tim Graham
03087f80d1
Refs #24205 -- Removed Signal.disconnect()'s weak argument.
...
Per deprecation timeline.
2017-01-17 14:09:28 -05:00
Adam Chainz
22a60f8d0b
Fixed #27513 -- Made Signal.send()/send_robust() a tiny bit faster.
2016-11-22 09:30:14 -05:00
Ramin Farajpour Cami
967be82443
Fixed E305 flake8 warnings.
2016-11-14 12:30:46 -05:00
Berker Peksag
995d09ead4
Fixed #13080 -- Corrected accepted values of sender parameter in Signal.connect() docstring.
2016-05-30 08:17:42 -04:00
Tim Graham
df8d8d4292
Fixed E128 flake8 warnings in django/.
2016-04-08 09:51:06 -04:00
Jarek Glowacki
c68ce18712
Corrected a few typos in Signal.send() docstring.
2016-01-12 08:27:02 -05:00
Tim Graham
17e2edf113
Moved and updated Python license.
2015-09-28 09:53:37 -04:00
Maxime Lorant
5153a3bfdc
Fixed #25331 -- Removed trailing blank lines in docstrings.
2015-08-31 17:37:21 -04:00
Tim Graham
aaacaeb096
Renamed RemovedInDjangoXYWarnings for new roadmap.
...
Forwardport of ae1d663b7913f6da233c55409c4973248372d302
from stable/1.8.x plus more.
2015-06-24 16:08:20 -04:00
Tim Graham
7f1168e387
Removed support for Python 3.3.
2015-06-18 08:36:50 -04:00
Tim Graham
3872a33132
Fixed #24979 -- Removed usage of inspect.getargspec().
2015-06-15 13:43:22 -04:00
Tim Graham
0ed7d15563
Sorted imports with isort; refs #23860 .
2015-02-06 08:16:28 -05:00
Florian Apolloner
16ee52d21d
Fixed #24205 -- Deprecated Signal.disconnect weak parameter.
2015-01-23 14:37:12 -05:00
Tim Graham
851f5bd413
Clarified docstring in dispatch/dispatcher.py
2015-01-23 12:59:59 -05:00
Andriy Sokolovskiy
23f1a8dad2
Added return value to Signal.disconnect().
2015-01-02 12:00:41 -05:00
Michael Hall
895dc880eb
Fixed #23812 -- Changed django.utils.six.moves.xrange imports to range
2014-12-13 12:45:58 -05:00
jerry dumblauskas
5760fe66df
Fixed typo in django/dispatch/dispatcher.py docstring.
2014-12-02 07:26:45 -05:00
Unai Zalakain
ebb0279f4a
Fixed #16245 -- Included traceback in send_robust()'s response
...
Exceptions from the (receiver, exception) tuples returned by
``send_robust()`` now have always their traceback attached as their
``__traceback__`` argument.
2014-05-16 18:41:40 -04:00
Rodolfo Carvalho
0d91225892
Fixed many typos in comments and docstrings.
...
Thanks Piotr Kasprzyk for help with the patch.
2014-03-03 07:38:09 -05:00
Florian Apolloner
297c009cf2
Simplified signal code.
...
Refs #21952
2014-02-05 20:57:40 +01:00
Anssi Kääriäinen
c29d6f7676
Fixed #21952 -- signals deadlock due to locking + weakref interaction
2014-02-05 20:57:40 +01:00
Simon Charette
c726598c3d
Fixed flake8 issues.
2014-01-12 13:40:37 -05:00
Florian Apolloner
7959aff8be
Added license info for the weakref backports
2014-01-12 18:35:15 +01:00
Florian Apolloner
52cad43bc3
Fixed removal of signal receivers in Python 3.4
...
Make use of `weakref.finalize` and `weakref.WeakMethod` on python 3.4.
Simplified the removal of receivers, the old function looked overly
complicated.
Many thanks go to Antoine Pitrou for helping me to debug and explain all
the failures I ran into while writing that patch.
2014-01-09 09:27:54 +01:00
Loic Bistuer
6685713869
Fixed E127 pep8 warnings.
2013-12-14 11:59:15 -05:00
Claude Paroz
42fef29446
Fixed #21486 -- Prevented settings config in signal connection
...
This was particularly problematic in the chain get_wsgi_application
-> db.connections import -> signal connection -> settings configuration.
Thanks Jon Dufresne for the report.
2013-11-23 18:47:47 +01:00
xuxiang
4cfe6ba6a3
Use classmethod as a decorator.
2013-11-19 23:08:21 -05:00
Milton Mazzarri
cbc7cbbc5b
Fixed flake8 E251 violations
2013-11-03 03:22:11 -06:00
Alex Gaynor
7548aa8ffd
More attacking E302 violators
2013-11-02 13:12:09 -07:00
Tim Graham
36ded01527
Fixed #21302 -- Fixed unused imports and import *.
2013-11-02 15:24:56 -04:00
Alex Gaynor
f2d8027c9a
Fixed up some more flake8 violations (this particular violation still has many occurrences in the tests/ dir so it can't be removed from setup.cfg yet)
2013-10-26 10:50:40 -07:00
