mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-30 13:05:45 +00:00
Code Issues 30 Releases Wiki Activity
32,019 Commits 28 Branches 426 Tags 621 MiB
33ca9f91c2
Commit Graph

114 Commits

Author SHA1 Message Date
Gregor Jerše
966ecdd482 Fixed #32819 -- Established relationship between form fields and their help text. 
Thanks Nimra for the initial patch.

Thanks Natalia Bidart, Thibaud Colas, David Smith, and Mariusz Felisiak
for reviews.
 2023-07-06 08:03:19 +02:00
Tom Carrick
d687febce5 Fixed #34383 -- Fixed layout of admin fieldsets with multiple fields on the same line. 
Thanks Antonio Candido Nazareth junior for the report.

Regression in 96a598356a.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2023-03-27 14:05:24 +02:00
David Smith
097e3a70c1 Refs #33476 -- Applied Black's 2023 stable style. 
Black 23.1.0 is released which, as the first release of the year,
introduces the 2023 stable style. This incorporates most of last year's
preview style.

https://github.com/psf/black/releases/tag/23.1.0
 2023-02-01 11:04:38 +01:00
Nick Pope
d3cb91db87 Used more augmented assignment statements. 
Identified using the following command:

$ git grep -I '\(\<[_a-zA-Z0-9]\+\>\) *= *\1 *[-+/*^%&|<>@]'
 2022-10-31 12:30:13 +01:00
Tom Carrick
bd36023100 Used CSS flex for admin's submit row. 2022-08-18 12:29:40 +02:00
David Smith
6991880109 Refs #31617 -- Added an id for helptext in admin forms. 2022-04-06 12:42:43 +02:00
Mariusz Felisiak
445b075def
Fixed #33547 -- Fixed error when rendering invalid inlines with readonly fields in admin. 
Regression in de95c82667.

Thanks David Glenck for the report.
 2022-03-01 08:09:58 +01:00
Nick Pope
847f46e9bf
Removed redundant QuerySet.all() calls in docs and tests. 
Most QuerySet methods are mapped onto the Manager and, in general,
it isn't necessary to call .all() on the manager.
 2022-02-22 10:29:38 +01:00
Mariusz Felisiak
7119f40c98 Refs #33476 -- Refactored code to strictly match 88 characters line length. 2022-02-07 20:37:05 +01:00
django-bot
9c19aff7c7 Refs #33476 -- Reformatted code with Black. 2022-02-07 20:37:05 +01:00
Carlton Gibson
2ccc0b22db Fixed #33211 -- Updated tests for Selenium 4.0.0. 
Replaced deprecated `find_element[s]_by_*()` usages, in favour of
`find_element[s]()` with an explicit `By`.
 2021-10-21 14:37:16 +02:00
Carlton Gibson
8fa974fcdd Refs #33211 -- Added assertCountSeleniumElements() test helper. 2021-10-21 14:37:16 +02:00
Carlton Gibson
e0a56ad3c8
Removed blocking wait in admin inlines selenium test. 
find_elements_by_css_selector() implicitly waits the default timeout
(10 seconds) looking for missing elements.
 2021-09-22 08:17:48 +02:00
Hasan Ramezani
2f0f30f973 Fixed #33111 -- Fixed passing object to ModelAdmin.get_inlines() when editing in admin change view. 
ModelAdmin.get_inlines() should get an unmutated object when creating
formsets during POST request.
 2021-09-21 13:12:09 +02:00
Claude Paroz
676bd084f2 Fixed #32873 -- Deprecated settings.USE_L10N. 
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2021-09-14 12:05:43 +02:00
antoinehumbert
de95c82667 Fixed #31867 -- Made TabularInline handling of hidden fields with view-only permissions consistent with StackedInline. 2021-09-10 10:10:53 +02:00
Siburg
46c8df640c Fixed #32219 -- Made InlineModelAdmin.verbose_name_plural fallback to its verbose_name. 2021-09-08 13:20:13 +02:00
Siburg
1bd6a7a0ac Refs #32219 -- Added admin model inline tests for verbose names. 
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2021-09-08 11:32:06 +02:00
luzpaz
bbf09254a3
Fixed typos in test comments. 2021-06-07 20:54:28 +02:00
David Smith
96a5093400
Refs #30231 -- Fixed SeleniumTests.test_inlines_verbose_name with headless mode. 
Horizontal scrollbar doesn't appear with the headless mode on small
windows, that's why window.scrollTo() is not an option for these tests
even after fixing #32459.
 2021-02-19 07:15:54 +01:00
Teresa Partida
45bef6706a Fixed #30231 -- Fixed admin filter horizontal/vertical verbose_name generation. 
Co-authored-by: David Smith <smithdc@gmail.com>
 2021-02-16 14:26:53 +01:00
Timothy McCurrach
0aff3fd711 Fixed #18549 -- Fixed heading for inlines with a OneToOneField. 
Used verbose_name instead of verbose_name_plural.
 2021-01-18 08:12:19 +01:00
Timothy McCurrach
13409a0c0d Refs #18549 -- Added test for heading of foreign key inlines. 2021-01-18 07:38:12 +01:00
Jon Dufresne
cee93c6ba1 Refs #25780 -- Removed redundant status code assertions from tests. 2020-10-28 12:26:49 +01:00
Jon Dufresne
81ffedaacc Fixed #31524 -- Removed minified static assets from the admin. 2020-05-14 16:07:56 +02:00
Tom Carrick
d24ba1be7a Fixed #31034 -- Added a navigation sidebar to the admin. 
Co-authored-by: elky <elky@users.noreply.github.com>
Co-authored-by: Goetz <goetz.buerkle@gmail.com>
 2020-05-11 18:16:38 +02:00
François Freitag
9ef4a18dbe Changed django.forms.ValidationError imports to django.core.exceptions.ValidationError. 
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2020-04-28 10:49:00 +02:00
Jon Dufresne
d15d824deb
Refs #29892 -- Fixed selenium test test_inline_formset_error_input_border on Firefox. 
Firefox does not include shorthand properties, such as "border", in the
computed CSS properties object. This is documented at MDN:

https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle

> The returned CSSStyleDeclaration object contains active values for CSS
> property longhand names. For example, border-bottom-width instead of
> the border-width and border shorthand property names. It is safest to
> query values with only longhand names like font-size. Shorthand names
> like font will not work with most browsers.

This difference between Firefox and Chrome is also discussed in the
stackoverflow thread at:

https://stackoverflow.com/a/32296604
 2020-04-22 12:32:35 +02:00
Hasan Ramezani
96c6f9c61c Fixed #31441 -- Ensured TabluarInline expands when child inputs have errors. 2020-04-16 12:17:49 +02:00
Hasan Ramezani
b4e7bf5284 Refs #31441 -- Added red border to inputs with errors for TabluarInline. 2020-04-16 12:17:49 +02:00
Jon Dufresne
eb77e80de0 Fixed #31349 -- Used :nth-child() CSS pseudo-class to style alternative rows in admin. 2020-03-09 12:34:32 +01:00
Carlton Gibson
6410d38ca7
Moved selenium import to nested scope. 2019-12-05 12:47:31 +01:00
Carlton Gibson
11c5e0609b Fixed CVE-2019-19118 -- Required edit permissions on parent model for editable inlines in admin. 
Thank you to Shen Ying for reporting this issue.
 2019-12-02 08:56:08 +01:00
Johannes Hoppe
69dbb6b708 Fixed #30973 -- Converted selenium tests wait_page_loaded to context manager. 2019-11-27 14:36:26 +01:00
Carlton Gibson
24e540fbd7 Fixed #29087 -- Added delete buttons for unsaved admin inlines on validation error. 2019-10-25 13:28:08 +02:00
Jones Ambrosi
f9561144d7 Fixed #30520 -- Fixed crash of admin model inlines on custom fields without labels. 2019-06-04 10:27:12 +02:00
Claude Paroz
e286987a27 Fixed #30459 -- Delegated hide/show JS toggle to parent div. 
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
 2019-05-17 07:46:45 +02:00
Tim Graham
8335d59200 Fixed #30289 -- Prevented admin inlines for a ManyToManyField's implicit through model from being editable if the user only has the view permission. 2019-03-30 16:49:16 -04:00
Matthias Kestenholz
231b513926 Fixed #30179 -- Fixed form Media merging when pairwise merging is insufficient. 
Thanks gasman for the tests, and codingjoe and timgraham for the review.
 2019-02-27 16:39:17 -05:00
Tim Graham
043bd70942 Updated test URL patterns to use path() and re_path(). 2018-12-31 10:47:32 -05:00
Simon Charette
0f212db29d Made reused RequestFactory instances class attributes. 2018-11-27 09:49:02 -05:00
Simon Charette
7f63b894c0 Adjusted code style of a few test data setup methods. 
Thanks Mariusz for suggesting it.
 2018-11-27 09:48:22 -05:00
Simon Charette
84e7a9f4a7 Switched setUp() to setUpTestData() where possible in Django's tests. 2018-11-27 09:35:17 -05:00
redodo
2e4776196d Fixed #29953 -- Added CSS class to column headers in tabular inlines. 
The class name is the same as one given to the fields in the change list.
 2018-11-20 18:17:53 -05:00
Clément Mangin
64e1a271f5 Fixed #29637 -- Fixed admin change form crash if the user doesn’t have the add permission to a TabularInline. 
Regression in 825f0beda8.
 2018-08-10 11:20:43 -04:00
Paulo Alvarado
ffb72a95bc Fixed #29414 -- Restored form inputs on admin inlines when the user doesn't have the change permission. 
Regression in 825f0beda8.
 2018-05-18 19:50:58 -04:00
Hasan Ramezani
274e3e27f3 Fixed #29184 -- Made TabularInline respect model form's Meta.labels and help_texts. 2018-03-17 20:51:24 -04:00
Jon Dufresne
ff05de760c Fixed #29038 -- Removed closing slash from HTML void tags. 2018-01-21 02:09:10 -05:00
Vasiliy Bolshakov
03974d8122 Fixed #28866 -- Made InlineAdminFormSet include InlineModelAdmin's Media before its formset's Media. 
This provides better backwards compatibility following refs #28377.
 2017-11-30 20:15:28 -05:00
Paulo
9dc83c356d Fixed #27967 -- Fixed KeyError in admin's inline form with inherited non-editable pk. 
Thanks Robin Anupol for the initial report and workaround.
 2017-06-12 21:12:54 -04:00