mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-23 01:25:58 +00:00
Code Issues 25 Releases Wiki Activity
32,573 Commits 28 Branches 426 Tags 666 MiB
2be37b2533
Commit Graph

526 Commits

Author SHA1 Message Date
Mariusz Felisiak
3bbe22dafc
Fixed #34233 -- Dropped support for Python 3.8 and 3.9. 2023-01-18 09:46:01 +01:00
Mariusz Felisiak
e6f82438d4 Refs #32365 -- Removed support for pytz timezones per deprecation timeline. 2023-01-17 11:49:15 +01:00
Mariusz Felisiak
29b6a177d8
Fixed AdminViewDeletedObjectsTest.test_cyclic failure when using --keepdb. 
This changes to hardcoded pks when hardcoded fks are used.
 2022-12-06 11:14:32 +01:00
Rasmus Magnell
c4aac2ac1e Fixed #34042 -- Improved accessibility of admin's navigation sidebar. 2022-10-12 10:21:17 +02:00
Gregor Gärtner
564b317fb5 Refs #33990 -- Renamed SimpleTestCase.assertFormsetError() to assertFormSetError(). 
Co-Authored-By: Michael Howitz <mh@gocept.com>
 2022-10-07 11:22:16 +02:00
David Sanders
9976f3d4b8 Fixed #34025 -- Fixed selecting ModelAdmin.autocomplete_fields after adding/changing related instances via popups. 
Regression in c72f6f36c1.

Thanks Alexandre da Silva for the report.
 2022-09-28 11:28:01 +02:00
Mariusz Felisiak
6e891a1722
Removed obsolete test_skip_link_is_skipped_when_there_is_searchbar test. 
searchbar doesn't have autofocus since
d938b3b257.
 2022-09-28 11:27:11 +02:00
Florian Perucki
872b61193b Refs #34041 -- Added navigation landmark to breadcrumbs in admin. 
Thanks Thibaud Colas for pair programming.
 2022-09-26 08:51:15 +02:00
Mariusz Felisiak
a2e580acf6
Refs #24179 -- Fixed selenium tests for offset of admin selector boxes in fieldset. 
Regression in be63c78760.
 2022-09-07 12:02:08 +02:00
Tom Carrick
d46cc15c51 Fixed #33878 -- Switched to system fonts in CSS. 2022-08-17 10:19:00 +02:00
Fab
0756c61f2a Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double submission of admin forms." 
Regression in fe7dbef586.
 2022-08-05 16:38:52 +02:00
Mariusz Felisiak
c18861804f Fixed warnings per flake8 5.0.0. 2022-07-31 08:16:19 +02:00
Marcelo Galigniana
564437f767 Fixed #33726 -- Added skip-link to admin for keyboard navigation. 2022-07-28 11:52:48 +02:00
Mariusz Felisiak
1733c888f4
Refs #33725 -- Replaced deprecated find_element_by_css_selector() with find_elements(By.CSS_SELECTOR, …). 
Follow up to 90dcf27114 and
2ccc0b22db.
 2022-05-23 06:06:37 +02:00
Sankalp
90dcf27114 Fixed #33725 -- Made hidden quick filter in admin's navigation sidebar not focusable. 
Regression in d915dd1c58.

Follow up to 780473d756.
 2022-05-21 13:37:53 +02:00
Daniel Hahler
dddc8bc47d Fixed #33679 -- Fixed the last inline's id in admin for users without add permissions. 2022-05-06 08:36:04 +02:00
Mariusz Felisiak
8e89dfe1c2 Fixed various tests on MySQL with MyISAM storage engine. 2022-04-18 07:05:52 +02:00
Mariusz Felisiak
331a460f8f Fixed DatabaseFeatures.uses_savepoints/can_release_savepoints and related tests with MyISAM storage engine. 2022-04-18 07:05:52 +02:00
mgaligniana
c72f6f36c1 Fixed #11803 -- Allowed admin select widgets to display new related objects. 
Adjusted admin javascript to add newly created related objects to
already loaded select widgets.

In this version, applies only where limit_choices_to is not set.
 2022-04-15 07:46:37 +02:00
David Smith
6991880109 Refs #31617 -- Added an id for helptext in admin forms. 2022-04-06 12:42:43 +02:00
Baptiste Mispelon
50e1e7ef8e Fixed #33348 -- Changed SimpleTestCase.assertFormError()/assertFormsetErrors() to take form/formset. 
Instead of taking a response object and a context name for
the form/formset, the two methods now take the object directly.
 2022-04-06 07:58:52 +02:00
adontz
2bee0b4328 Fixed #7497 -- Allowed overriding the order of apps and models in admin. 2022-03-25 10:33:44 +01:00
Mariusz Felisiak
d44951b36e Refs #7497 -- Added assertion for the default order of models in AdminSite.app_index(). 2022-03-25 10:29:59 +01:00
Mariusz Felisiak
94d8ed55fa
Refs #15619 -- Logged out with POST requests in admin. 2022-03-24 17:41:53 +01:00
Stefan Wehrmeyer
561761c660 Fixed #33592 -- Fixed "View on Site" links in custom admin site. 2022-03-21 10:07:32 +01:00
mgaligniana
fe7dbef586 Fixed #28889 -- Prevented double submission of admin forms. 
Added a JavaScript confirm() to catch double-submissions, when the
change form has already been submitted.

Thanks to Adam Johnson, Claude Paroz, Keryn Knight, and Thibaud Colas
for review.
 2022-02-23 14:57:34 +01:00
Nick Pope
847f46e9bf
Removed redundant QuerySet.all() calls in docs and tests. 
Most QuerySet methods are mapped onto the Manager and, in general,
it isn't necessary to call .all() on the manager.
 2022-02-22 10:29:38 +01:00
Baptiste Mispelon
261885e4c1 Simplified SimpleTestCase.assertFormError()/assertFormsetErrors() calls in admin_views tests. 2022-02-14 11:34:58 +01:00
Baptiste Mispelon
1f749d6f12 Fixed field name in admin_views.tests.UserAdminTest.test_password_mismatch() assertion. 2022-02-14 11:29:45 +01:00
Mariusz Felisiak
7119f40c98 Refs #33476 -- Refactored code to strictly match 88 characters line length. 2022-02-07 20:37:05 +01:00
django-bot
9c19aff7c7 Refs #33476 -- Reformatted code with Black. 2022-02-07 20:37:05 +01:00
Mariusz Felisiak
0a4a5e5bac
Refs #32681 -- Fixed VariableDoesNotExist when rendering some admin template. 
Regression in 84609b3205.

Follow up to 4e5bbb6ef2.

Thanks Sourav Kumar for the report.
 2022-01-13 10:10:48 +01:00
Shubh1815
aecfc40c88 Fixed #33300 -- Ensured hidden elements are not displayed on small screens. 2021-12-30 07:57:36 +01:00
David Smith
950d697b95
Refs #31617 -- Removed redundant title text in filter.html. 
Unnecessary since 269a767146.

Title text should provide advisory information and should not be the
same or very similar to the element text.
 2021-12-28 13:42:35 +01:00
mgaligniana
ac5cc6cf01 Fixed #33316 -- Added pagination to admin history view. 2021-12-15 10:54:08 +01:00
Shubh1815
51c24d8799 Fixed #33024 -- Fixed height of admin selector boxes in collapsed fieldset. 
Thanks Tom Carrick for the review.
 2021-11-25 07:57:19 +01:00
Shubh1815
bb223c6f78 Fixed #28357 -- Fixed ModelAdmin.prepopulated_fields on newly added stacked inline. 
Thanks Jakob Köhler for the initial patch.
 2021-11-16 12:24:56 +01:00
Mariusz Felisiak
c3e0dfe4cc
Fixed isolation of admin_views.tests.ValidXHTMLTests. 2021-11-02 07:03:11 +01:00
Carlton Gibson
2ccc0b22db Fixed #33211 -- Updated tests for Selenium 4.0.0. 
Replaced deprecated `find_element[s]_by_*()` usages, in favour of
`find_element[s]()` with an explicit `By`.
 2021-10-21 14:37:16 +02:00
Carlton Gibson
8fa974fcdd Refs #33211 -- Added assertCountSeleniumElements() test helper. 2021-10-21 14:37:16 +02:00
David Smith
7ef0bc922c Refs #32956 -- Capitalized HTTP/HTTPS in comments, docs, and docstrings. 2021-10-20 08:40:19 +02:00
Carlton Gibson
402ae37873 Refs #33029 -- Fixed popups Selenium tests in headless mode. 
Co-authored-by: Yash Jhunjhunwala <yash@jhunjhunwalaadvisors.com>
 2021-10-06 12:00:19 +02:00
Maxim Milovanov
1c802ca2a9
Fixed #33156 -- Used sessionStorage to preserve quick filter for admin's navigation sidebar. 2021-10-06 09:01:31 +02:00
Yash Jhunjhunwala
492ed60f23 Fixed #33029 -- Allowed multiple popups for self-related fields in admin. 2021-09-30 15:42:30 +02:00
David Smith
456466d932 Fixed #31026 -- Switched form rendering to template engine. 
Thanks Carlton Gibson, Keryn Knight, Mariusz Felisiak, and Nick Pope
for reviews.

Co-authored-by: Johannes Hoppe <info@johanneshoppe.com>
 2021-09-20 15:50:18 +02:00
Ken Whitesell
0a9aa02e6f Fixed #33077 -- Fixed links to related models for admin's readonly fields in custom admin site. 2021-09-18 12:27:28 +02:00
Carlton Gibson
306607d5b9 Fixed #32365 -- Made zoneinfo the default timezone implementation. 
Thanks to Adam Johnson, Aymeric Augustin, David Smith, Mariusz Felisiak, Nick
Pope, and Paul Ganssle for reviews.
 2021-09-16 12:11:05 +02:00
Claude Paroz
676bd084f2 Fixed #32873 -- Deprecated settings.USE_L10N. 
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2021-09-14 12:05:43 +02:00
Hasan Ramezani
d1216e126f Fixed #33051 -- Fixed highlighting the current model in admin's sidebar with non-ASCII model names. 2021-08-27 07:31:05 +02:00
Mart Sõmermaa
9b1158a7e0 Fixed #32993 -- Added AutocompleteJsonView.serialize_result() to allow customization. 2021-08-10 07:44:37 +02:00
Ties Jan Hefting
84400d2e9d Fixed #32905 -- Added CSS class for non-form errors of formsets. 2021-07-15 07:00:39 +02:00
saeedblanchette
66ed03e7c9 Refs #24121 -- Added __repr__() to AdminForm, BlockContext, BlockTranslateNode, and IncludeNode. 2021-06-10 12:47:53 +02:00
David Sanders
2978c63a34 Fixed #32771 -- Used IS_POPUP_VAR constant instead of hard-coded value. 2021-05-20 07:04:26 +02:00
Slava Skvortsov
f7691d4812 Fixed #32754 -- Made AdminSite.catch_all_view() respect SCRIPT_NAME. 
Regression in ba31b01034.
 2021-05-18 09:14:05 +02:00
Raffaele Salmaso
3733ae8957 Fixed #32031 -- Added model class for each model to AdminSite.each_context(). 2021-05-13 06:57:09 +02:00
Nick Pope
2161db0792
Fixed capitalization of "ECMAScript" and "JavaScript". 2021-04-29 20:29:08 +02:00
Mariusz Felisiak
cd74aad90e Refs #32682 -- Renamed use_distinct variable to may_have_duplicates. 
QuerySet.distinct() is not the only way to avoid duplicate, it's also
not preferred.
 2021-04-27 10:34:47 +02:00
Zain Patel
4e5bbb6ef2 Fixed #32681 -- Fixed VariableDoesNotExist when rendering some admin template. 
Regression in 84609b3205.
 2021-04-26 07:08:16 +02:00
Mariusz Felisiak
23fa29f6a6
Fixed #32649 -- Fixed ModelAdmin.search_fields crash when searching against phrases with unbalanced quotes. 
Thanks Dlis for the report.

Regression in 26a413507a.
 2021-04-14 12:23:47 +02:00
Maxim Milovanov
d915dd1c58 Fixed #32204 -- Added quick filter to admin's navigation sidebar. 2021-03-31 09:31:37 +02:00
Johannes Maron
03d0f12c82 Fixed #32466 -- Corrected autocomplete to_field resolution for complex cases. 
In MTI or ForeignKey as primary key cases, it is required to fetch the attname
from the field instance on the remote model in order to reliably resolve the
to_field_name.

Co-authored-by: Johannes Maron <info@johanneshoppe.com>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
 2021-03-18 11:21:23 +01:00
Johannes Maron
0b120f5d64 Refs #29138 -- Added extra tests for autocomplete FK to_field variations. 2021-03-18 11:14:18 +01:00
Mariusz Felisiak
a6a94fb966
Removed unnecessary lines in test_has_view_or_change_permission_required(). 
AutocompleteJsonViewTests.user is already a staff member.
 2021-03-10 15:37:28 +01:00
François Freitag
7ca7f4495b Refs #21429 -- Added SimpleTestCase.assertNoLogs() on Python < 3.10. 2021-03-02 20:35:33 +01:00
Jacob Walls
9d7e31cc74
Removed unused code in admin_views tests. 
Unused since its introduction in 7b21bfc074
and 1e4ad6f118.
 2021-02-26 20:49:21 +01:00
Amir Ajorloo
1710cdbe79
Fixed #32443 -- Removed "shifted" CSS class when admin's sidebar is disabled. 2021-02-18 09:18:19 +01:00
manav014
3119a6deca Fixed #26607 -- Allowed customizing formset kwargs with ModelAdmin.get_formset_kwargs(). 
Thanks Nick Pope for reviews.
 2021-02-15 11:37:35 +01:00
Paul Ganssle
10d1261984 Refs #32365 -- Allowed use of non-pytz timezone implementations. 2021-01-19 11:59:37 +01:00
Nick Pope
9204485396
Fixed #16117 -- Added decorators for admin action and display functions. 
Refs #25134, #32099.
 2021-01-13 17:19:22 +01:00
Jon Dufresne
ba31b01034
Fixed #31747 -- Fixed model enumeration via admin URLs. 
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
 2021-01-12 14:37:56 +01:00
Johannes Maron
3071660acf
Fixed #29010, Fixed #29138 -- Added limit_choices_to and to_field support to autocomplete fields. 
* Fixed #29010 -- Added limit_choices_to support to autocomplete fields.
* Fixed #29138 -- Allowed autocomplete fields to target a custom
  to_field rather than the PK.
 2021-01-12 11:37:38 +01:00
Nick Pope
9ef0394b54
Fixed typo in tests/admin_views/test_history_view.py test name. 2020-12-18 09:23:22 +01:00
Claude Paroz
187482d743
Avoided direct styles in admin templates. 
Direct styles might be forbidden by Content Security Policies.
 2020-11-10 21:32:15 +01:00
Jon Dufresne
cee93c6ba1 Refs #25780 -- Removed redundant status code assertions from tests. 2020-10-28 12:26:49 +01:00
Tim Graham
83a8da576d
Fixed admin_views's test_history_view on databases that don't use serial pks. 2020-10-26 10:44:55 +01:00
Tim Graham
78eeb24774
Made test_change_list_sorting_model_admin_reverse's assertions more specific. 
The test could fail on databases like CockroachDB that use non-serial
primary keys if the numbers (2000, etc.) appeared in the pk values.
 2020-10-18 19:48:06 +02:00
Tim Schilling
b7da588e88 Fixed #32091 -- Fixed admin search bar width on filtered admin page. 2020-10-09 11:39:22 +02:00
Julien Rebetez
b790883065 Fixed #31181 -- Added links to related models for admin's readonly fields. 2020-10-08 19:53:49 +02:00
Raffaele Salmaso
666f2e8acd Refs #32034 -- Added test for title on admin app index view. 2020-09-23 10:01:03 +02:00
Tom Carrick
bcc2befd0e Fixed #31789 -- Added a new headers interface to HttpResponse. 2020-09-14 08:41:59 +02:00
Jon Dufresne
84609b3205 Fixed #31993 -- Added subtitles to admin change/view pages. 2020-09-11 06:28:45 +02:00
Jon Dufresne
cbe34dc8ec Refs #31993 -- Added more titles assertions for admin views. 2020-09-10 13:21:08 +02:00
Mariusz Felisiak
6a881197e9
Refs #31901 -- Fixed SeleniumTests.test_list_editable_popups with headless mode. 2020-09-02 15:16:03 +02:00
Carlton Gibson
0aeb802cf0 Fixed #31865 -- Adjusted admin nav sidebar template to reduce debug logging. 
Thanks to Mariusz Felisiak for review.
 2020-08-11 11:42:15 +02:00
Nick Pope
b203ec70fd Refs #25513 -- Adjusted admin pagination to be 1-indexed. 2020-08-06 12:38:56 +02:00
Jon Dufresne
feb6581993
Fixed the centering of the "Log in" button on admin login page. 
Previously, the button's container had a padding of 9.4em which was
approximately center but not precisely. Now, the container uses
'align:text-center' to let the browser center the button.
 2020-06-26 06:59:33 +02:00
Jon Dufresne
60db8b7b37 Removed unnecessary admin CSS. 
The "object-tools" container is never rendered as a descendant of
.form-row.

The "golink" CSS class is unused.

A <label> element has not been included in the login .submit-row since
5869afe32b.

The "help" CSS class from login.css has been unused since
0e5faf225c.

The <label> color in login.css is already inherited from the <body>
element and so does not need to be re-specified.

The #content-main container already has the property 'width: 100%' from
base.css and so does not need to be re-specified in login.css.

The <td> and <th> font-family property is inherited from the <body>
element and so does not need to be re-specified.

The <html> element has the attribute dir which automatically sets
the text direction in the layout. Adding the direction CSS property was
necessary to support IE which does not support the dir attribute, but IE
is no longer supported, so drop the direction property.

The 'font-size: 1em' property re-specifies the same font size. It
creates no visual difference.

The 'font-size: 14px' property often re-specifies the inherited value.
Avoid re-specifying it.
 2020-06-25 11:46:05 +02:00
Hasan Ramezani
fbe82f8255 Refs #26761 -- Removed extra space in admin change list result header. 2020-06-25 06:33:12 +02:00
Alix
26a413507a Fixed #6933 -- Added support for searching against quoted phrases in ModelAdmin.search_fields. 2020-06-18 20:17:20 +02:00
David Smith
10df5b7177
Refs #31670 -- Removed whitelist/blacklist terminology in docs and comments. 2020-06-17 13:15:56 +02:00
Tom Carrick
780473d756 Refs #31034 -- Improved accessibility of admin navigation sidebar. 2020-05-28 10:16:20 +02:00
Scott Cranfill
62f1655a64 Fixed #11157 -- Stopped removing stop words in admin's prepopulated_fields. 
Co-Authored-By: Andy Chosak <andy@chosak.org>
 2020-05-27 12:32:56 +02:00
kjpc-tech
099bce1bf0 Fixed #31590 -- Fixed ModelAdmin.date_hierarchy crash with an empty QuerySet. 
Regression in 55cdf6c52d.
 2020-05-15 06:35:10 +02:00
Jon Dufresne
81ffedaacc Fixed #31524 -- Removed minified static assets from the admin. 2020-05-14 16:07:56 +02:00
Jon Dufresne
d522b51c40 Fixed #31575 -- Added system check for admin sidebar request context processor dependency. 
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
 2020-05-14 11:00:51 +02:00
Tom Carrick
d24ba1be7a Fixed #31034 -- Added a navigation sidebar to the admin. 
Co-authored-by: elky <elky@users.noreply.github.com>
Co-authored-by: Goetz <goetz.buerkle@gmail.com>
 2020-05-11 18:16:38 +02:00
Jon Dufresne
d6aff369ad Refs #30116 -- Simplified regex match group access with Match.__getitem__(). 
The method has been available since Python 3.6. The shorter syntax is
also marginally faster.
 2020-05-11 12:01:28 +02:00
Nick Pope
8f10ceaa90 Changed '%s' % value pattern to str(value). 2020-05-04 08:27:18 +02:00
François Freitag
9ef4a18dbe Changed django.forms.ValidationError imports to django.core.exceptions.ValidationError. 
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2020-04-28 10:49:00 +02:00
François Freitag
abea86f9e4 Removed unnecessary tuple wrapping of single format string argument. 2020-04-27 08:30:16 +02:00