mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-26 19:16:11 +00:00
Code Issues 27 Releases Wiki Activity
19,119 Commits 28 Branches 426 Tags 667 MiB
05e0e4674c
Commit Graph

2509 Commits

Author SHA1 Message Date
Jorge C. Leitão
8780849da0 Fixed #22812 -- Refactored lookup API documentation. 
Thanks Anssi and Tim for reviews.
 2014-07-08 20:05:49 -04:00
Andrew Godwin
503e59c9b0 Document -l as well as --list on migrate 2014-07-08 10:30:11 -07:00
Anubhav Joshi
75ff7b8fb8 Fixed #21832 -- Updated prompt, tests, and docs to show that USERNAME_FIELD supports FK after 9bc2d76. 
Also added get_input_data() hook in createsuperuser.

Thanks Chris Jerdonek and Tim Graham for review.
 2014-07-08 08:21:41 -04:00
Collin Anderson
2c1384fbac Fixed a few PEP8 errors in settings doc. 2014-07-06 18:31:10 -04:00
Andrew Godwin
32fefc6f70 Document --fake and --list on migrate command 2014-07-06 00:30:18 -07:00
Tim Graham
7fd55c3481 Fixed #20631 -- Increased the default EmailField max_length to 254. 
Thanks pmartin for the report.
 2014-07-04 14:15:00 -04:00
Tim Graham
814bcc3395 Fixed #22924 -- Added a note about MEDIA_URL in templates. 
Thanks raphael.herouart at gmail.com
 2014-07-03 09:21:20 -04:00
LarryBrid
a93ee5112d Fixed #22941 - Added support for domain-only links with chars after the TLD to urlize. 
It now works with something like google.com/foo/bar
 2014-07-02 20:36:53 -04:00
Tim Graham
42f5c8f397 Fixed typo in docs/ref/models/instances.txt 2014-07-02 13:21:34 -04:00
Tim Graham
db9a1a0c47 Fixed #13755 -- Added a tip for caching responses that vary on AJAX. 
Thanks mila for the suggestion.
 2014-07-01 17:32:14 -04:00
Anssi Kääriäinen
0b6f05ede6 Fixed #19501 -- added Model.from_db() method 
The Model.from_db() is intended to be used in cases where customization
of model loading is needed. Reasons can be performance, or adding custom
behavior to the model (for example "dirty field tracking" to issue
automatic update_fields when saving models).

A big thank you to Tim Graham for the review!
 2014-07-01 16:31:01 +03:00
Curtis
71461b14ab Fixed #22691 -- Added aliasing to cached_property. 2014-07-01 06:32:53 -04:00
Tim Graham
81edf2d006 Fixed non-multiple of 4 indentation in docs/ref/request-response.txt. 2014-06-30 19:47:19 -04:00
Tim Graham
bbf0a9545b Fixed #22482 -- Recommended using data migrations in contrib.sites docs. 
Thanks scibi for the report.
 2014-06-30 18:48:49 -04:00
Tim Graham
874053edf9 Fixed #21942 -- Moved Form.clean() to form API docs. 
Thanks cjerdonek for the suggestion.
 2014-06-30 16:30:57 -04:00
Claude Paroz
0b5bafe993 Removed reference to old middleware 2014-06-30 20:36:18 +02:00
Tim Graham
5359188b08 Fixed docs/ref/contrib/auth.txt so that sphinx links work properly. 2014-06-30 14:20:51 -04:00
Éric Araujo
e9c730f6be Fixed copy/paste typos in StreamingHttpResponse doc. 2014-06-26 07:27:13 -04:00
Duncan Parkes
d68987ae25 Fixed #22897 -- Made QueryDict query_string argument optional. 
Now QueryDict() is equivalent to QueryDict('') or QueryDict(None).
 2014-06-24 22:02:03 -04:00
Duncan Parkes
7f4e2ef1e9 Improved documentation for QueryDict. 2014-06-24 21:40:21 -04:00
Daniele Procida
cd20b5d186 Fixed #22796 -- Added a more basic explanations of forms. 
Thanks bmispelon, kezabelle, jorgecarleitao, and timgraham for reviews.
 2014-06-24 14:55:22 -04:00
Tim Graham
150d88cc2c Restored is_anonymous() check in ModelBackend permission checking removed in refs #17903. 
Thanks Florian Apolloner for raising the issue.
 2014-06-24 07:09:38 -04:00
Jorge C. Leitão
c33447a50c Fixed #17903 -- Modified ModelBackend to eliminate permissions on inactive users. 
Thanks to @SmileyChris for the report and @timgraham for review.
 2014-06-23 19:57:20 -04:00
Claude Paroz
9618d68b34 Fixed #8033 -- Explained app registry error during translation setup 
Thanks Tim Graham and Aymeric Augustin for the review.
 2014-06-23 09:31:45 +02:00
Luan Pablo
407d070329 Fixed #22782 -- Added i18n attr to Sitemap class 
It makes possible to have your sitemap in multiple languages when
using i18n in URLs.
 2014-06-20 13:04:41 -04:00
Huu Nguyen
fbb684d95e Fixed #22862 -- Added --noinput option to makemigrations. 
Thanks artortenburger for the report.
 2014-06-20 08:55:02 -04:00
Andrew Godwin
08221d1b5c Fixed #22874: Document that AUTH_USER_MODEL must be in first migration 2014-06-19 23:48:29 -07:00
Tim Graham
63670a474c Removed a CSRF example for jQuery < 1.5. 2014-06-18 14:58:50 -04:00
Tim Graham
0be4d64487 Fixed #22859 -- Improved crossDomain technique in CSRF example. 
Thanks flisky for the report.
 2014-06-18 14:35:38 -04:00
Renaud Parent
87d0a3384c Fixed #22778 -- Added a model Meta option to define default_related_name. 
Thanks jorgecarleitao and mmardini for reviews.
 2014-06-18 13:53:07 -04:00
Jorge C. Leitão
de90129070 Fixed #14481 -- Documented implicit "through" class created by ManyToManyField. 
Thanks to jonathanmorgan for the report and initial patch.
 2014-06-18 12:30:10 -04:00
Andrew Godwin
8d2ac948a9 Fixed #22853: Swapped models are now ignored for migration operations. 2014-06-17 17:45:38 -07:00
Anubhav Joshi
91f1b6dcdc Fixed #13711 -- Model check added to ensure that auto-generated column name is within limits of the database. 
Thanks russellm for report and Tim Graham for review.
 2014-06-17 16:16:02 -04:00
Tim Graham
95cc0e15b4 Fixed #22819 -- Renamed output_type -> output_field in query expression API. 
Thanks jorgecarleitao for the suggestion.
 2014-06-17 11:57:16 -04:00
Andrew Godwin
a8ce5fdc28 Fixed #22470: Full migration support for order_with_respect_to 2014-06-15 14:56:51 -07:00
Andrew Godwin
24afb1d7a7 Fixed #22660: Doc'd you can't have unmigrated apps depend on migrated 2014-06-15 11:47:23 -07:00
Claude Paroz
c281831a5c Complemented dwithin docs about using geographic geometries 
Refs #22830. Thanks django@gfairchild.com for the suggestion.
 2014-06-14 20:52:37 +02:00
mlavin
4696cd9671 Fixed #22477 -- Removed contrib middleware from the global settings defaults. 
Also added a compatibility check for changed middleware defaults.

Forwardport of d94de802d3 from stable/1.7.x
 2014-06-13 12:45:56 -04:00
Jorge C. Leitão
cc35bd461d Fixed #7599 -- Added get_user_permissions to ModelBackend. 
Thanks to @gdub for the report and intial patch and
@charettes and @timgraham for the review.
 2014-06-13 09:34:04 -04:00
Maxime Turcotte
504c89e800 Fixed #6327 -- Added has_module_permission method to BaseModelAdmin 
Thanks chrj for the suggestion.
 2014-06-13 09:31:40 -04:00
Tim Graham
1c58cabad7 Fixed #22811 -- Allowed setting both the old and new TEST database settings. 
An ImproperlyConfigured exception will be raised they mismatch.
 2014-06-12 08:17:49 -04:00
Claude Paroz
dfa3505ff1 Fixed #22813 -- Updated Pillow URL in documentation 2014-06-12 08:53:36 +02:00
Maxime Lorant
c307383ec9 Fixed typo in docs/ref/forms/validation.txt. 2014-06-11 17:17:21 -04:00
Anubhav Joshi
42736ac8e8 Fixed #21430 -- Added a RuntimeWarning when unpickling Models and QuerySets from a different Django version. 
Thanks FunkyBob for the suggestion, prasoon2211 for the initial patch,
and akaariai, loic, and charettes for helping in shaping the patch.
 2014-06-11 10:03:34 -04:00
Maxime Turcotte
f97c53c098 Fixed #22801 -- Added 'www.' to diveintopython.net links 2014-06-10 15:38:25 -04:00
Tim Graham
93d05536fd Fixed #22770 -- Removed create_superuser from post_migrate signals. 
Moved logic to syncdb command for backwards compatibility.
 2014-06-10 14:37:37 -04:00
Andreas Damgaard Pedersen
9560dac3c0 Close autoescape tag in template documentation. 2014-06-10 11:48:08 +01:00
Aymeric Augustin
df09d85482 Fixed #17552 -- Removed a hack for IE6 and earlier. 
It prevented the GZipMiddleware from compressing some data types even on
more recent version of IE where the corresponding bug was fixed.

Thanks Aaron Cannon for the report and Tim Graham for the review.
 2014-06-10 08:42:31 +02:00
Tim Graham
bc0aba7786 Dropped support for SpatiaLite < 2.4. 2014-06-09 17:53:25 -04:00
Tim Graham
c17cd151d8 Doc edits for refs #22487. 2014-06-09 12:09:16 -04:00
Tim Graham
dd55132643 Removed extras/csrf_migration_helper.py 2014-06-09 11:53:09 -04:00
Andrew Godwin
8c12d51ea2 Fixed #22487: Optional rollback emulation for migrated apps 2014-06-08 19:30:15 -07:00
Tim Graham
5472bf4df0 Added formatting and line wrapping to checks reference doc. 2014-06-06 15:19:20 -04:00
Susan Tan
484f3edf1e Fixed #18400 -- Modified length template filter to return 0 for unknown variables. 
Thanks Florian for the bug report, luyikei for the initial code patch, and
Bouke for the code review feedback.
 2014-06-05 15:41:56 -04:00
Guillaume Pannatier
7f27cca5c5 Fixed #22710 -- Amended aggregation note for empty QuerySets 
Thanks smeaton for report and Joël Rochat for spell check
 2014-06-04 12:44:58 -04:00
gyx1000
7e2c87809c Fixed #22684 -- Amended SelectDateWidget.empty_label to accept a tuple of values. 
Thanks danielsamuels for the report
 2014-06-04 07:23:25 -04:00
INADA Naoki
7be646425f Updated current state of MySQL Connector/Python. 2014-06-03 08:10:07 -04:00
Tim Graham
593b3c32bd Merge pull request #2756 from tubaman/return_unicode 
Unicode method on model should return unicode
 2014-06-03 07:38:12 -04:00
Tim Graham
4445d36d47 Fixed #22384 -- Deprecated reversing URLs by dotted path. 2014-06-03 07:30:14 -04:00
Ryan Nowakowski
f39b8867a1 Unicode method on model should return unicode 
The example of a __unicode__ model method should return a unicode value
instead of a string.
 2014-06-02 22:49:43 -05:00
Bryce Nesbitt
e020894470 Fixed #22753 -- Documented ability to use a note with the {% comment %} tag. 2014-06-02 18:50:50 -04:00
Tim Graham
a00efa30d6 Fixed #22748 -- Corrected post_migrate usage example. 
Thanks Rudolph for the report.
 2014-06-02 11:35:20 -04:00
Craig de Stigter
ce993efda8 Fixed #22690 -- Added a check for proxy models containing fields. 
Removed the FieldError raised by ModelBase.__new__ in this case.
 2014-06-02 09:32:38 -04:00
Jonathan Lindén
5b98ba08e2 Fixed #21938 -- Moved documentation for error views to reference guide. 2014-06-01 13:05:19 -04:00
Aymeric Augustin
2a5c750ad1 Merge pull request #2726 from gchp/ticket-20550 
Fixed #20550 -- Added ability to preserve test db between runs
 2014-06-01 17:26:56 +02:00
Guillaume Pannatier
7c6e96ec1f Fixed #22710 -- Documented aggregation behavior for empty QuerySets. 
Thanks matklad for the report.
 2014-05-30 08:01:21 -04:00
Moayad Mardini
56cfa508c7 Fixed #22682 -- makemigrations will create MIGRATION_MODULES package 
`makemigrations` will automatically create the package specified
in `MIGRATION_MODULES` if it doesn't already exist.

Thanks ovidiuc4 for the report.
 2014-05-30 01:23:09 +03:00
Guillaume Pannatier
32586b0ba4 Fixed #22684 -- Added empty_label option on django.forms.extras.widets.SelectDateWidget 
Thanks danielsamuels for the report
 2014-05-28 13:23:28 -04:00
Greg Chapple
b7aa7c4ab4 Fixed #20550 -- Added ability to preserve test db between runs 2014-05-28 16:22:46 +01:00
Tim Graham
4b57e203fe Fixed spelling in docs. 2014-05-27 19:46:48 -04:00
Moayad Mardini
2e613ea5c5 Fixed #22675 -- makemigrations --dry-run to output migrations to stdout. 
`makemigrations --dry-run` will output the complete migrations file
that would be written if it's used along with `--verbosity 3`.
 2014-05-27 00:40:55 +03:00
Marc Tamlyn
b625e861e5 Fix an error in a documented lookup example. 2014-05-26 14:44:50 +01:00
Moayad Mardini
e98d303562 Fixed #22692 -- Added docs for makemigrations two command options. 
Added documentation about `--dry-run` and `--merge`.
 2014-05-25 19:34:20 -04:00
Matthew Schinckel
2b432d4634 Fixed typo in docs/ref/models/custom-lookups.txt. 2014-05-25 19:01:51 -04:00
Claude Paroz
b8fc167b32 Fixed #22688 -- Documented ready() may be called more than once 2014-05-24 15:58:57 +02:00
Marc Tamlyn
9fb0f5dddc Fixed #22510 -- Harden field removal to only None. 
Refs #8620.

If we allow any value to remove form fields then we get name clashes
with method names, media classes etc. There was a backwards
incompatibility introduced meaning ModelForm subclasses with declared
fields called media or clean would lose those fields.

Field removal is now only permitted by using the sentinel value None.
The docs have been slightly reworded to refer to removal of fields
rather than shadowing.

Thanks to gcbirzan for the report and initial patch, and several of the
core team for opinions.
 2014-05-24 13:10:50 +01:00
Claude Paroz
756c390fb5 Fixed #20816 -- Added hints about Django middleware ordering 
Thanks gthb Trac user for the report, kolypto StackOverflow
user for the initial list and Tim Graham for the review.
 2014-05-22 18:33:10 +02:00
Flavio Curella
beec05686c Fixed #22667 -- Replaced leader/follower terminology with primary/replica 2014-05-22 11:59:17 -04:00
Marc Tamlyn
48348782e6 Added omitted documentation for ArrayField__len. 2014-05-22 13:50:13 +01:00
Marc Tamlyn
604162604b Added array field support for PostgreSQL. 
The first part of django.contrib.postgres, including model and two form
fields for arrays of other data types.

This commit is formed of the following work:

    Add shell of postgres app and test handling.

    First draft of array fields.

    Use recursive deconstruction.

    Stop creating classes at lookup time.

    Add validation and size parameter.

    Add contained_by lookup.

    Add SimpleArrayField for forms.

    Add SplitArrayField (mainly for admin).

    Fix prepare_value for SimpleArrayField.

    Stop using MultiValueField and MultiWidget.

    They don't play nice with flexible sizes.

    Add basics of admin integration.

    Missing:
    - Tests
    - Fully working js

    Add reference document for django.contrib.postgres.fields.ArrayField.

    Various performance and style tweaks.

    Fix internal docs link, formalise code snippets.

    Remove the admin code for now.

    It needs a better way of handing JS widgets in the admin as a whole
    before it is easy to write. In particular there are serious issues
    involving DateTimePicker when used in an array.

    Add a test for nested array fields with different delimiters.

    This will be a documented pattern so having a test for it is useful.

    Add docs for SimpleArrayField.

    Add docs for SplitArrayField.

    Remove admin related code for now.

    definition -> description

    Fix typo.

    Py3 errors.

    Avoid using regexes where they're not needed.

    Allow passing tuples by the programmer.

    Add some more tests for multidimensional arrays.

    Also fix slicing as much as it can be fixed.

    Simplify SplitArrayWidget's data loading.

    If we aren't including the variable size one, we don't need to search
    like this.
 2014-05-22 09:53:26 +01:00
Martin Brochhaus
bb0a9a070b Fixed #20477: Allowed list of modules for FORMAT_MODULE_PATH 
Previously the FORMAT_MODULE_PATH setting only accepted one string (dotted
module path). A feature has been added to also allow a list of strings.

This is useful when using several reusable third party apps that define new
formats. We can now use them all and we can even override some of the formats
by providing a project-wide format module.
 2014-05-21 07:35:47 -04:00
Alex Gaynor
8a95b4fca7 Merge pull request #2692 from fcurella/patch-5 
#22667 replaced occurrences of master/slave terminology with leader/follower
 2014-05-20 09:37:04 -07:00
Flavio Curella
73a57b06f9 replaced occurrences of master/slave terminology with leader/follower 2014-05-20 11:35:16 -05:00
Moayad Mardini
2f43229c2f Fixed #22655 -- Fixed GeoQuerySet doc about strictly_below 
The paragraph was a copy of strictly_above.
 2014-05-19 09:50:23 -04:00
Tim Graham
5abc811a40 Revert "Fixed #20477: Allowed settings.FORMAT_MODULE_PATH to be a list of modules." 
This reverts commit 950b6de16a.
 2014-05-19 08:22:46 -04:00
Martin Brochhaus
950b6de16a Fixed #20477: Allowed settings.FORMAT_MODULE_PATH to be a list of modules. 
Previously the FORMAT_MODULE_PATH setting only accepted one string (dotted
module path).

This is useful when using several reusable third party apps that define new
formats. We can now use them all and we can even override some of the formats
by providing a project-wide format module.
 2014-05-19 07:59:13 -04:00
Moayad Mardini
bfac6bef83 Fixed #22368 -- clarified connecting to Oracle DB using service name 
Used the official terminology listed in
http://docs.oracle.com/cd/B19306_01/network.102/b14212/glossary.htm#i997309

Thanks michael.cherkasov for the report.
 2014-05-19 07:42:11 -04:00
Esau Rodriguez
ec9043ab2f Fixed #21799 - Modified loaddata --ignorenonexistent to ignore models. 2014-05-18 15:52:07 -04:00
Erik Romijn
727d048f09 Fixed #22644 -- Clarified documentation for NamedUrlWizardView 2014-05-17 15:08:49 +02:00
Aliaksandr Semianiuk
5b185ecc68 Fixed #22019 -- Added Model.objects reference documentation. 2014-05-17 08:32:05 -04:00
Florian Apolloner
11932e978f Merge pull request #2346 from Markush2010/ticket21905 
Fixed #21905 -- Add info message if DateField or TimeField use a fixed value
 2014-05-17 12:09:04 +02:00
Markus Holtermann
9d8c73f6a1 Fixed #21905 -- Add info message if DateField or TimeField use a fixed value 2014-05-16 18:59:31 +02:00
Moritz
e7ffba8f78 Fixed #22167 -- Improved documentation on context processors 
Clarified the explanation on the order in which user provided variables
to render_to_response, RequestContext and context processors are
loaded.
 2014-05-16 18:26:37 +02:00
Russell Keith-Magee
2c176eb95c Refs #21798 - Modified error number to provide room for future expansion. 2014-05-16 15:41:17 +02:00
Daniel Pyrathon
cb15231888 Fixed #21798 -- Added check for DateTime mutually exclusive options 
Added DateTimeCheckMixin to avoid the use of default, auto_now, and
auto_now_add options together. Added the fields.E151 Error that is raised
if one or more of these options are used together.
 2014-05-16 05:57:19 -04:00
Claude Paroz
e520a73eee Harmonized some PEP 0263 coding preambles 2014-05-15 19:58:41 +02:00
Anders Steinlein
4ef10f245a Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin. 
Thanks Stephen Burrows for work on the patch as well.

Forwardport of 2914f66983 from stable/1.7.x
 2014-05-15 07:25:35 -04:00
Éric Araujo
5ab95168cc Fix typo that disabled code example highlighting 2014-05-14 18:34:59 -04:00
Tim Graham
a06808d370 Removed an unnecessary anchor in the docs. 2014-05-13 20:54:32 -04:00
Julen Ruiz Aizpuru
5eb81ce445 Fixed #22533 -- Added label_suffix parameter to form fields. 
Fields can now receive the `label_suffix` attribute, which will override
a form's `label_suffix`.

This enhances the possibility to customize form's `label_suffix`, allowing
to use such customizations while using shortcuts such as
`{{ form.as_p }}`.

Note that the field's own customization can be overridden at runtime by
using the `label_prefix` parameter to `BoundField.label_tag()`.

Refs #18134.
 2014-05-13 09:09:33 -04:00
Tim Graham
57296b4162 Removed some references to django.contrib.comments which has been removed. 2014-05-13 07:24:28 -04:00
Tim Graham
c501662f3c Fixed #22618 -- Improved import_string example. 
Thanks ewjoachim for the sugggestion.
 2014-05-13 07:04:49 -04:00
Tim Graham
986bd41f8a Fixed #22613 -- Added formfield_for_choice_field() to the list of methods that InlineModelAdmin supports. 2014-05-12 06:59:23 -04:00
Alex Gaynor
b57ee15b12 Merge pull request #2639 from alimony/patch-1 
Insert space
 2014-05-07 16:43:57 -07:00
Andrew Godwin
5a917cfef3 Fixed #22496: Data migrations get transactions again! 2014-05-07 14:28:34 -07:00
Markus Amalthea Magnuson
8eb51a8cf6 Insert space. 2014-05-07 21:16:43 +02:00
Claude Paroz
7951f125e7 Updated the messages context processor docs 
Refs #20610.
 2014-05-06 20:37:52 +02:00
Tim Graham
fb7c347f7b Fixed #1349 -- Clarified docs on serving files from STATIC/MEDIA_URL. 2014-05-05 07:36:53 -04:00
Loic Bistuer
d1799233f4 Fixed clash caused by the newly introduced -e shorthand for makemessages --exclude. 
This fixes a regression caused by 0707b82. Refs #22328.
 2014-05-02 23:07:17 +07:00
Simon Charette
24ec9538b7 Fixed #19195 -- Allow explicit ordering by a relation _id field. 
Thanks to chrisedgemon for the report and shaib, akaariai and
timgraham for the review.
 2014-04-30 14:23:19 -04:00
Mike Fogel
7fd1b35ed7 Fixed #22537 -- Add tests and improved docs for field subclass with choices. 2014-04-30 07:56:52 -04:00
Tim Graham
ab8d8e00c9 Improved formatting and links of migration docs. 2014-04-27 15:05:41 -04:00
Aymeric Augustin
58ed387db3 Documented django.setup(). 
Thanks Eric Holscher and Tim Graham for the review.
 2014-04-26 20:13:59 +02:00
Aymeric Augustin
8b5b199e20 Fixed #3214 -- Stopped parsing SQL with regex. 
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.

Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.

sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.

Many people contributed to both tickets, thank you all, and especially
Claude for the review.

Refs #22401.
 2014-04-26 17:46:23 +02:00
Claude Paroz
680a0f08b1 Updated doc links to point to Python 3 documentation 2014-04-26 16:02:53 +02:00
Ana Krivokapic
0707b824fe Fixed #22328 -- Added --exclude option to compilemessages and makemessages. 2014-04-26 17:07:44 +07:00
Aymeric Augustin
0315f01087 Fixed a confusing heading in applications docs. 
Refs #22422.
 2014-04-25 17:39:49 +02:00
Víðir Valberg Guðmundsson
deb561bbe2 Fixed #22422 -- Moved information about the application loading process to refs/applications.txt. 2014-04-25 10:12:31 -04:00
Moayad Mardini
3776926cfe Fixed #22493 - Added warnings to raw() and extra() docs about SQL injection 
Thanks Erik Romijn for the suggestion.
 2014-04-25 09:54:49 -04:00
Marti Raudsepp
11d453bcad Various documentation typo/spelling fixes 
Errors detected by Topy (https://github.com/intgr/topy), all changes
verified by hand.
 2014-04-23 02:31:49 +03:00
Erik Romijn
75c0d4ea3a Fixed queries that may return unexpected results on MySQL due to typecasting. 
This is a security fix; disclosure to follow shortly.
 2014-04-21 18:11:26 -04:00
Matt Lauber
b2514c02e1 Corrected the section identifier for MySQL unicode reference. 2014-04-21 13:19:46 -04:00
Aymeric Augustin
bbe818b23c Changed paths in docs that referred to Python 2. 2014-04-20 08:34:01 +02:00
Tim Graham
26d118c3fe Moved RemoteUserBackend documentation to reference guide. 2014-04-18 16:06:26 -04:00
Moayad Mardini
11ac50b18e Fixed #22458 -- Added a note about MySQL utf8_unicode_ci collation 
Thanks tobami at gmail.com for the report.
 2014-04-18 15:10:21 -04:00
Tim Graham
b43bbd6d39 Fixed #22473 -- Emphasized that Model.clean() is not called from Model.save(). 2014-04-18 15:00:26 -04:00
Claude Paroz
3cea917e3e Confirmed support for PostGIS 2.1 and GDAL 1.10 
Refs #22456.
 2014-04-17 21:23:14 +02:00
chriscauley
66ec9ee441 Fixed #22378 -- Updated \d to [0-9]+ in urlpatterns of docs and tests. 
Thanks tomwys for the suggestion.
 2014-04-16 20:36:29 -04:00
Ben Davis
030dd4f72c Fixed #22220 -- Added more examples to reverse() documention. 
Thanks EvilDMP for the suggestions.
 2014-04-16 20:29:17 -04:00
Tim Graham
b5ce21accb Fixed spelling errors in documentation. 2014-04-16 09:39:00 -04:00
Tim Graham
465980d070 Added RemoteUserMiddleware to middleware reference page. 2014-04-16 07:22:15 -04:00
Marc Egli
0bcc92c691 Fixed #22356 -- Added a check to make sure unique_together fields are local. 2014-04-14 16:49:40 -04:00
Andrew Godwin
09af48c70f Improve migrations/schema docs 2014-04-14 13:07:02 -04:00
arachnegl
8da86fd19b Fixed #22398 -- Added detail about callable in KEY_FUNCTION docs 2014-04-13 18:52:43 -04:00
Tim Graham
d5031ecf88 Fixed #21353 -- Noted that description is ignored for TabularInlines. 
Thanks nofinator for the report.
 2014-04-10 13:31:59 -04:00
Tim Graham
395d75ea6b Fixed #22194 -- Added --list-tags option to check command. 
Thanks Elvard for the patch.
 2014-04-10 09:43:55 -04:00
Shai Berger
59b1d3098f Documentation fixes for the select_for_update change. 
Refs #22343; thanks Tim Graham for the fixes.
 2014-04-10 03:40:33 +03:00
Shai Berger
f095356ba2 Fixed #22343 -- Disallowed select_for_update in autocommit mode 
The ticket was originally about two failing tests, which are
fixed by putting their queries in transactions.

Thanks Tim Graham for the report, Aymeric Augustin for the fix,
and Simon Charette, Tim Graham & Loïc Bistuer for review.
 2014-04-10 03:04:51 +03:00
ejstronge
5ca522b9ed Fixed small typo in django-admin.txt 
The word 'by' seemed to be missing from the first line of the compilemessages command.
 2014-04-08 23:58:40 -04:00
Tim Graham
868f37183b Fixed some spelling issues in docs. 2014-04-08 10:08:25 -04:00
Anubhav Joshi
c8c2b8a638 Fixed #9535 -- Added a reference guide for file upload classes. 2014-04-08 09:52:07 -04:00
Anubhav Joshi
36de29200e Fixed #22405 -- Fixed string error in models/queries docs. 2014-04-08 13:33:40 +02:00
Yin Jifeng
d6c9bdd825 Added missing request parameter to get_current_site(). 2014-04-07 09:54:34 -04:00
Tim Graham
d2f4553d70 Fixed #22216 -- Added Form.non_field_errors to form API doc. 2014-04-05 18:16:01 -04:00
Tim Graham
fd23c06023 Fixed #21649 -- Added optional invalidation of sessions when user password changes. 
Thanks Paul McMillan, Aymeric Augustin, and Erik Romijn for reviews.
 2014-04-05 12:50:51 -04:00
Claude Paroz
9494f29d4f Fixed case in form widgets docs 2014-04-05 16:26:11 +02:00
Claude Paroz
248b9bb554 Merge pull request #2514 from vlal/ticket_22380 
Fixed #22380 -- Missing SECRET_KEY variable in sample settings file for ...
 2014-04-04 09:47:27 +02:00
Vishal Lal
8f621b83e9 Fixed #22380 -- Missing SECRET_KEY variable in sample settings file for testing 2014-04-04 07:25:55 +00:00
Vishal Lal
a8e2ec0e82 Fixed #22372 -- Improved description of WizardView.get_context_data(). 
Thanks simon29 for the report.
 2014-04-03 08:25:11 -04:00
Tim Graham
d73d0e071c Fixed #22218 -- Deprecated django.conf.urls.patterns. 
Thanks Carl Meyer for the suggestion and Alex Gaynor and Carl for reviews.
 2014-04-03 07:28:10 -04:00
Vishal Lal
ca93f02c62 Fixed #22347 -- Unified FileSystemStorage documentation. 
Thanks nliberg for the report.
 2014-04-02 12:58:37 -04:00
Tim Graham
981b864fbd Replaced urllib/urlparse imports with from django.utils.six.moves. 2014-03-31 07:54:22 -04:00
Claude Paroz
41903d025a Dropped support for GDAL 1.6 2014-03-29 11:08:52 +01:00
Claude Paroz
c5d1df70a4 Dropped support for GEOS 3.1 2014-03-29 11:08:52 +01:00
Claude Paroz
c6ffa4cab6 Added note in geo library docs 2014-03-29 11:08:52 +01:00
Claude Paroz
e62dea9ad5 Confirmed Spatialite 4 support 2014-03-29 11:08:52 +01:00
Claude Paroz
0f1f12c564 Confirmed GEOS 3.4 support 2014-03-29 11:08:52 +01:00
Tim Martin
a779757706 Fixed #21941 -- Documented the kwargs param of django.conf.urls.url(). 
Thanks cjerdonek for the report.
 2014-03-27 07:01:47 -04:00
Tim Graham
5233b36693 Fixed #22029 -- Removed obsolete advice on registering migrate/syncdb signal handlers. 
All signals should now be registered in AppConfig.ready().

Thanks un33k for the report.
 2014-03-26 10:39:52 -04:00
Tim Graham
9b7ba8af1b Fixed #22322 -- Fixed incorrect explanation of what managed=False does. 
refs #14305.

Thanks Adrian Klaver for the report.
 2014-03-25 14:01:37 -04:00
Tim Graham
e3c4205b79 flake8 and doc fixes for refs #22257. 2014-03-25 09:44:59 -04:00
Marc Tamlyn
09ab447d08 Merge pull request #2465 from coder9042/ticket_22258 
Fixed #22257 -- Added file output option to dumpdata command.
 2014-03-25 11:42:03 +00:00
Anubhav Joshi
f34e8fc890 Fixed #22257 -- Added file output option to dumpdata command. 2014-03-25 13:47:03 +05:30
Tim Graham
51c8045145 Removed versionadded/changed annotations for 1.6. 2014-03-24 11:42:56 -04:00
Adam Kaliński
ec08d62a20 Fixed #22048 - Enhanced docs to cover nonexistent one-to-one relationships. 
Thanks EvilDMP for the suggestion.
 2014-03-24 09:41:04 -04:00
Anubhav Joshi
416a858023 Fixed #17922 -- Added required_css_class to form label. 
Thanks hanson2010 for the suggestion.
 2014-03-24 08:11:54 -04:00
Loic Bistuer
7ac8380799 Fixed #22318 -- Added Form.has_error() to easily check if a given error has happened. 2014-03-24 07:21:32 -04:00
Claude Paroz
3f7615cddc Fixed #22317 -- Fixed documented handler400 default value 2014-03-23 21:18:39 +01:00
Simon Charette
fa8b473528 Fixed #22299 -- Cleanup wizard temp files when possible. 
Thanks to @erikr for the review.
 2014-03-22 17:48:12 -04:00
Claude Paroz
3a97f992fb Fixed #22313 -- Removed 'u' prefixes from documentation 2014-03-22 21:32:20 +01:00
Claude Paroz
74b3467646 Removed GeoRSSSitemap 
Refs #18531.
 2014-03-22 19:58:50 +01:00
Loic Bistuer
e61d99d96d Fixed #20684 -- Added support for HTML5 boolean attributes to form widgets. 2014-03-22 14:28:12 -04:00
Claude Paroz
bc315266c8 Fixed #22294 -- Prevented converting length filter output to string 
Thanks Steve Pike for the report.
 2014-03-22 16:39:46 +01:00
Tim Graham
ee4edb1eda Made ModelForms raise ImproperlyConfigured if the list of fields is not specified. 
Also applies to modelform(set)_factory and generic model views.

refs #19733.
 2014-03-22 07:56:48 -04:00
Claude Paroz
6ca6c36f82 Improved strip_tags and clarified documentation 
The fact that strip_tags cannot guarantee to really strip all
non-safe HTML content was not clear enough. Also see:
https://www.djangoproject.com/weblog/2014/mar/22/strip-tags-advisory/
 2014-03-22 10:59:18 +01:00
Aymeric Augustin
253e8ac29f Removed django.middleware.doc. Refs #20126. 
Small doc changes missed in 66076268.
 2014-03-21 22:07:39 +01:00
Aymeric Augustin
06160cb945 Removed deprecated TRANSACTIONS_MANAGED setting. 2014-03-21 21:34:47 +01:00
Thomas Schreiber
907ac64641 Fixed typos in docs (django.contrib.site) 2014-03-21 19:56:31 +01:00
Tim Graham
bf5430a20b Removed django.test.simple and django.test._doctest per deprecation timeline. 
refs #17365, #17366, #18727.
 2014-03-21 13:36:46 -04:00
Tim Graham
1ea44a3abd Switched {% cycle %} and {% firstof %} tags to auto-escape their variables per deprecation timeline. 
refs #17906.
 2014-03-21 13:17:10 -04:00
Tim Graham
4965a77407 Removed PIL compatability layer per deprecation timeline. 
refs #19934.
 2014-03-21 10:54:53 -04:00
Tim Graham
f567d04b24 Removed settings.CACHE_MIDDLEWARE_ANONYMOUS_ONLY per deprecation timeline. 
refs #15201.
 2014-03-21 09:46:17 -04:00
Tim Graham
8b81dee60c Removed fix_ampersands template filter per deprecation timeline. 
Also removed related utility functions:
* django.utils.html.fix_ampersands
* django.utils.html.clean_html
 2014-03-21 08:50:43 -04:00
Tim Graham
11e22129d5 Removed settings.SEND_BROKEN_LINK_EMAILS per deprecation timeline. 2014-03-21 07:15:58 -04:00
Tim Graham
aa93a1890f Removed contrib.comments per deprecation timeline. 2014-03-21 07:05:36 -04:00
Dejan Noveski
4d0c5f6142 Fixed #22255 -- Added support for specifying re flags in RegexValidator 2014-03-21 11:12:36 +01:00
Bryan Helmig
f2eea960e0 Fixed minor syntax error in Queryset docs 2014-03-21 11:02:15 +01:00
Daniel Hahler
ac9c7701a7 Replaced reference to ModelAdmin.get_formsets() (deprecated) with get_formsets_with_inlines(). 2014-03-19 20:37:00 -04:00
zedr
fad47367bf Fixed #21179 -- Added a StreamingHttpResponse example for CSV files. 
Thanks charettes for the suggestion.
 2014-03-17 07:22:27 -04:00
Anubhav Joshi
ad43fdaa00 Fixed #21860 -- Added to_field_name to ModelChoiceField docs. 
Thanks Keryn Knight for the suggestion.
 2014-03-16 15:40:52 -04:00
Daniel Pyrathon
885e7adf56 Fixed #22242 -- Documented common cookie size limit. 2014-03-16 10:40:59 -04:00
Akis Kesoglou
aaad3e27ac Fixed #22217 - ManyToManyField.through_fields fixes. 
- Docs description of arguments mix up.
- Keep it from erroneously masking E332 check.
- Add checks E338 and E339, tweak message of E337.
 2014-03-11 19:33:04 -03:00
Tim Graham
ce3d9f847d Fixed typo in docs/ref/django-admin.txt 
Thanks Wes Kendall for the report.
 2014-03-11 08:09:44 -04:00
Aymeric Augustin
3315535ae8 Fixed an example to match the code. 2014-03-09 21:20:34 +01:00
Shai Berger
41afae4ce9 Reorganized the database test settings 
Change database test settings from "TEST_"-prefixed entries in the
database settings dictionary to setting in a dictionary that is itself
an entry "TEST" in the database settings.

Refs #21775

Thanks Josh Smeaton for review.
 2014-03-09 03:57:18 +02:00
Russell Keith-Magee
70ec4d776e Fixed #22034 -- Added a specific set of relation checks for GenericInlineModelAdmin. 
Thanks to jwa for the report.
 2014-03-08 11:25:23 +08:00
Anssi Kääriäinen
219d928852 Fixed #21863 -- supplemented get_lookup() with get_transform() 
Also fixed #22124 -- Expanded explanation of exactly what is going on in
as_sql() methods.
 2014-03-07 14:52:13 +00:00
Tim Graham
8f9c3d0565 Fixed typo in docs/ref/checks.txt 2014-03-07 09:18:06 -05:00
Roger Hu
9b729ddd8f Fixed #22185 -- Added settings.CSRF_COOKIE_AGE 
Thanks Paul McMillan for the review.
 2014-03-06 08:28:43 -05:00
Claude Paroz
06efeae598 Added --previous flag to msgmerge command used by makemessages 
Also took the opportunity to slightly refactor gettext options
so as to ease customization by subclassing the command.
Thanks Michal Čihař for the report and initial patch.
 2014-03-06 10:20:01 +01:00
Gabe Jackson
b77f26313c Fixed #22207 -- Added support for GenericRelation reverse lookups 
GenericRelation now supports an optional related_query_name argument.
Setting related_query_name adds a relation from the related object back to
the content type for filtering, ordering and other query operations.

Thanks to Loic Bistuer for spotting a couple of important issues in
his review.
 2014-03-05 22:37:53 +02:00
Akis Kesoglou
c627da0ccc Fixed #14549 - Removed restriction of single FKs on intermediary tables 
Thanks to Loic Bistuer for review. Minor changes to error messages
done by committer.
 2014-03-05 22:33:58 +02:00
Chris Wilson
95c74b9d69 Fixed #22206 -- Passed models.TextField.max_length to forms.CharField.maxlength 2014-03-05 20:09:28 +01:00
zedr
6fe22b30e0 Fixed #22085 -- Added a feature for setting non-expiring keys as the default. 
This feature allows the default `TIMEOUT` Cache argument to be set to `None`,
so that cache instances can set a non-expiring key as the default,
instead of using the default value of 5 minutes.

Previously, this was possible only by passing `None` as an argument to
the set() method of objects of type `BaseCache` (and subtypes).
 2014-03-04 21:16:35 +01:00
Loic Bistuer
7bbb6958dc Allowed custom querysets when prefetching single valued relations 
The original patch for custom prefetches didn't allow usage of custom
queryset for single valued relations (along ForeignKey or OneToOneKey).
Allowing these enables calling performance oriented queryset methods like
select_related or defer/only.

Thanks @akaariai and @timgraham for the reviews. Refs #17001.
 2014-03-03 21:35:19 +02:00
Tim Graham
5a4f1298cf Fixed #21908 -- Added example usage for ModelAdmin.get_inline_instances(). 
Thanks matt at schinckel.net for the suggestion.
 2014-03-03 10:40:06 -05:00
Tim Graham
eae4f16177 Removed doc newlines added in previous commit that caused build errors. 2014-03-03 08:49:18 -05:00
Rodolfo Carvalho
2b6436e2d5 Fixed some typos and formatting issues in docs. 2014-03-03 08:37:17 -05:00
Greg Chapple
6acaa52386 Fixed #22135 -- Added ModelAdmin.get_changeform_initial_data(). 
Allows custom behavior for setting initial form data in ModelAdmin.
By default, initial data is set via GET params. The new method allows
this behavior to be overridden.

Thanks egasimus for the suggestion.
 2014-03-03 07:28:24 -05:00
Russell Keith-Magee
c41335fa27 Added backwards compatibliity checks to reference documentation. 2014-03-03 19:20:48 +08:00
Russell Keith-Magee
5679fce87c Added first cut at reference documentation for the checks framework. 2014-03-03 18:56:11 +08:00
Baptiste Mispelon
ea4da8e63c Fixed some typos in the documentation. 
Thanks to Rodolfo Carvalho and Piotr Kasprzyk
for the patch.
 2014-03-02 17:05:57 +01:00
Anubhav Joshi
bb2ca9fe6c Fixed #22172 -- Allowed index_together to be a single list (rather than list of lists).. 
Thanks EmilStenstrom for the suggestion.
 2014-03-01 15:44:42 -05:00
Erik Romijn
775975f15d Fixed #22130 -- Deprecated fix_ampersands, removed utils.clean_html() 2014-03-01 14:07:57 +01:00
Sergey Kolosov
8c98f39624 Fixed #15318 -- Added settings for language cookie max-age, path, domain 
Introduced a number of settings to configure max-age, path, and domain
for the language cookie: LANGUAGE_COOKIE_AGE, LANGUAGE_COOKIE_PATH and
LANGUAGE_COOKIE_DOMAIN.

Thanks sahid for the suggestion.
 2014-03-01 07:52:45 -05:00
Tim Graham
1f5f015c32 Fixed spelling mistakes in docs. 2014-02-28 21:03:46 -05:00
Alex de Landgraaf
ea869b5148 Fixed #21948 -- Noted TEMPLATE_LOADERS requirement when overriding admin templates. 
Thanks django at patjack.co.uk for the suggestion.
 2014-02-28 16:38:25 -05:00
Tim Graham
7f2505ad9e Fixed doc typos. 2014-02-28 11:44:03 -05:00
Tim Graham
55fb162588 Fixed #22028 -- Documented that database signals aren't emitted for apps that laack a models module. 
Thanks un33k for the suggestion and donjpacheco for the draft patch.
 2014-02-28 09:22:33 -05:00
vvojvoda
c23b3717be Fixed #21962 -- Added escape_html flag to ErrorDict.as_json() 2014-02-28 07:05:55 -05:00
navneet suman
3390550f6f Fixed #22145 -- Clarified docs on Field.blank and Field.null options. 
Thanks skipjack at peru.com for the suggestion.
 2014-02-25 20:59:34 -05:00
Szczepan Cieślik
e816198034 Fixed docs typos. 2014-02-25 10:28:32 -05:00
Iacopo Spalletti
65b4626528 Fixed #22142 -- Documented PostGIS 2 database creation during tests 2014-02-25 13:41:50 +01:00
Alex de Landgraaf
b645be80e9 Fixed #22063 -- Added reference to NoReverseMatch from the reverse() documentation 2014-02-23 13:45:52 +01:00
Baptiste Mispelon
072fb923e1 Fixed #21881 -- Clarify behavior of {% ssi %} template tag. 
When using the `parsed` option, {% ssi %} has the same limitation
as {% include %}, namely that the rendering of the included
template is done separately.

Thanks to trac user nagyv for the report and to alextreme for
the patch.
 2014-02-23 12:00:24 +01:00
Marcin Sokół
b887408486 Fixed #22113 -- changed object_name to model_name in CBV docs. 
Thanks to trac user nikunj.sg for the report.
 2014-02-22 23:36:54 +01:00
Baptiste Mispelon
1d3ae4760b Fixed warnings when building the documentation. 2014-02-22 21:43:50 +01:00
Greg Chapple
ede99f0ec3 Fixed #22032 -- added documentation for settings.MIGRATION_MODULES 2014-02-22 20:14:41 +01:00
Jochem Oosterveen
271929dd9d Fixed #22092 -- Documented ResolverMatch.view_name 2014-02-22 18:31:40 +01:00
Erik Romijn
8cd32f0965 Fixed #22120 -- Documented persistent activation of languages and cleaned up language session key use 2014-02-22 18:29:06 +01:00
Marcin Sokół
09b725f51b Fixed #21902 -- Documented search order for list_display. 2014-02-22 18:11:43 +01:00
Alasdair Nicol
462edd22e5 Fixed #22112 -- Added RedirectView.pattern_name to CBV flattened index 
Also moved accessor method get_redirect_url next to its attribute url
for consistency with the other views.

Thanks nikunj.sg for the report
 2014-02-21 22:23:06 +01:00
Artur Frysiak
faf6a911ad Fixed #22023 -- Raised an error for values() followed by defer() or only(). 
Previously, doing so resulted in invalid data or crash.

Thanks jtiai for the report and Karol Jochelson,
Jakub Nowak, Loic Bistuer, and Baptiste Mispelon for reviews.
 2014-02-17 14:46:13 -05:00
Marek Wywiał
8274fa60f8 Made the new template.Context.flatten() method a public API. 
That method was introduced in 9db4271bd1.

Refs #21765.
 2014-02-16 15:18:45 +01:00
Zbigniew Siciarz
94b5bc361a Fixed #22002 -- Documented avoiding database interaction in AppConfig.ready(). 
Thanks Marc Tamlyn for the suggestion.
 2014-02-15 13:50:31 -05:00
Zbigniew Siciarz
44814e78cc Fixed #22013 -- Documented difference between SERVER_EMAIL and DEFAULT_FROM_EMAIL. 2014-02-15 19:11:46 +01:00
chomik
985ae732b2 Fixed #21884 -- Mentioned that exact is the defaut QuerySet lookup type 
Thanks to cjerdonek for the suggestion.
 2014-02-15 17:17:58 +01:00
Michal Prusek
00da02cbfd Fixed #22052 -- Corrected a misspelling of ellipsoid 2014-02-15 13:02:16 +01:00
djendrju
4ac4c98cbd Fixed #22049 -- Corrected a misspelling of dimensional 2014-02-15 12:08:01 +01:00
Klemens Mantzos
f683cb90be Fixed #21924 -- Added the ability to specify a reverse order for admin_order_field. 
Thanks Klemens Mantzos for the report and initial patch.
 2014-02-14 19:53:44 -05:00
Lukasz Balcerzak
0242134d32 Fixed #17942 -- Added a JsonResponse class to more easily create JSON encoded responses. 
Thanks leahculver for the suggestion and Erik Romijn,
Simon Charette, and Marc Tamlyn for the reviews.
 2014-02-14 18:25:19 -05:00
Loic Bistuer
2e4200b5c7 Fixed #21654 -- Documented a use-case for Form.errors.as_data(). 
Thanks selwin for the suggestion.
 2014-02-14 06:52:50 -05:00
Simon Meers
007c5cd367 Updated docs that misreported django.apps.apps.ready as being a method. 2014-02-14 12:50:27 +11:00
Jeremy
f94f466cd3 Fixed #19496 -- Added truncatechars_html filter. 
Thanks esevece for the suggestion and  Nick Sandford and Martin Warne
for the inital work on the patch.
 2014-02-13 10:27:27 -05:00
Alasdair Nicol
8aa1efff6d Fixed #21951 -- Updated docs to use __str__ for Python 3 
Thanks Tim Graham for the report and recommendations
 2014-02-13 07:12:40 -05:00
Andrew Godwin
dbe82e74f2 Add reference documentation for operations and stubs for schemaeditor. 2014-02-12 18:53:35 +00:00
Christopher Adams
eefc88feef Fixed #2445 -- Allowed limit_choices_to attribute to be a callable. 
ForeignKey or ManyToManyField attribute ``limit_choices_to`` can now
be a callable that returns either a ``Q`` object or a dict.

Thanks michael at actrix.gen.nz for the original suggestion.
 2014-02-11 14:05:12 -05:00
Julian Wachholz
9a4ee8ddb8 Fixed #21994 -- Added form_dict argument to calls of WizardView.done() 
Added an additional keyword argument ``form_dict`` to calls of
WizardView.done() implementations which allows easier access to validated
forms by their step name.
 2014-02-10 07:28:39 -05:00
Si Feng
b102c27ff4 Fixed #20784 -- Added inverse_match parameter to RegexValidator. 2014-02-10 05:38:43 -05:00
Tim Graham
29345390b8 Minor edits to new findstatic functionality; refs #19879. 
Hopefully fixes a test failure on Jenkins.
 2014-02-09 15:39:04 -05:00