mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-01-03 15:06:09 +00:00
Code Issues 30 Releases Wiki Activity

Fixed #19523 -- Improved performance of Django's bash completion

Browse Source 
Previous version took about 150ms to source, even on a warm cache,
primarily because it forks+execs /usr/bin/basename 44 times.
This patch makes it faster by a factor of 5 (and I imagine that a little
more thought would reduce the time to effectively zero).
This commit is contained in:
Anders Kaseorg 2013-01-22 13:46:42 +01:00 committed by Claude Paroz
parent cc4de61a2b
commit e535da6865
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
extras/django_bash_completion
View File

@ -42,10 +42,10 @@ complete -F _django_completion -o default django-admin.py manage.py django-admin
_python_django_completion() _python_django_completion()
{ {
if [[ ${COMP_CWORD} -ge 2 ]]; then if [[ ${COMP_CWORD} -ge 2 ]]; then
PYTHON_EXE=$( basename -- ${COMP_WORDS[0]} ) PYTHON_EXE=${COMP_WORDS[0]##*/}
echo $PYTHON_EXE | egrep "python([2-9]\.[0-9])?" >/dev/null 2>&1 echo $PYTHON_EXE | egrep "python([2-9]\.[0-9])?" >/dev/null 2>&1
if [[ $? == 0 ]]; then if [[ $? == 0 ]]; then
PYTHON_SCRIPT=$( basename -- ${COMP_WORDS[1]} ) PYTHON_SCRIPT=${COMP_WORDS[1]##*/}
echo $PYTHON_SCRIPT | egrep "manage\.py|django-admin(\.py)?" >/dev/null 2>&1 echo $PYTHON_SCRIPT | egrep "manage\.py|django-admin(\.py)?" >/dev/null 2>&1
if [[ $? == 0 ]]; then if [[ $? == 0 ]]; then
COMPREPLY=( $( COMP_WORDS="${COMP_WORDS[*]:1}" \ COMPREPLY=( $( COMP_WORDS="${COMP_WORDS[*]:1}" \
@ -61,7 +61,7 @@ unset pythons
if command -v whereis &>/dev/null; then if command -v whereis &>/dev/null; then
python_interpreters=$(whereis python | cut -d " " -f 2-) python_interpreters=$(whereis python | cut -d " " -f 2-)
for python in $python_interpreters; do for python in $python_interpreters; do
pythons="${pythons} $(basename -- $python)" pythons="${pythons} ${python##*/}"
done done
pythons=$(echo $pythons | tr " " "\n" | sort -u | tr "\n" " ") pythons=$(echo $pythons | tr " " "\n" | sort -u | tr "\n" " ")
else else