mirror of
https://github.com/django/django.git
synced 2024-12-22 09:05:43 +00:00
Fixed #19523 -- Improved performance of Django's bash completion
Previous version took about 150ms to source, even on a warm cache, primarily because it forks+execs /usr/bin/basename 44 times. This patch makes it faster by a factor of 5 (and I imagine that a little more thought would reduce the time to effectively zero).
This commit is contained in:
parent
cc4de61a2b
commit
e535da6865
@ -42,10 +42,10 @@ complete -F _django_completion -o default django-admin.py manage.py django-admin
|
||||
_python_django_completion()
|
||||
{
|
||||
if [[ ${COMP_CWORD} -ge 2 ]]; then
|
||||
PYTHON_EXE=$( basename -- ${COMP_WORDS[0]} )
|
||||
PYTHON_EXE=${COMP_WORDS[0]##*/}
|
||||
echo $PYTHON_EXE | egrep "python([2-9]\.[0-9])?" >/dev/null 2>&1
|
||||
if [[ $? == 0 ]]; then
|
||||
PYTHON_SCRIPT=$( basename -- ${COMP_WORDS[1]} )
|
||||
PYTHON_SCRIPT=${COMP_WORDS[1]##*/}
|
||||
echo $PYTHON_SCRIPT | egrep "manage\.py|django-admin(\.py)?" >/dev/null 2>&1
|
||||
if [[ $? == 0 ]]; then
|
||||
COMPREPLY=( $( COMP_WORDS="${COMP_WORDS[*]:1}" \
|
||||
@ -61,7 +61,7 @@ unset pythons
|
||||
if command -v whereis &>/dev/null; then
|
||||
python_interpreters=$(whereis python | cut -d " " -f 2-)
|
||||
for python in $python_interpreters; do
|
||||
pythons="${pythons} $(basename -- $python)"
|
||||
pythons="${pythons} ${python##*/}"
|
||||
done
|
||||
pythons=$(echo $pythons | tr " " "\n" | sort -u | tr "\n" " ")
|
||||
else
|
||||
|
Loading…
Reference in New Issue
Block a user