mirror of
https://github.com/django/django.git
synced 2024-12-22 17:16:24 +00:00
Fixed #31990 -- Fixed QuerySet.ordered for GROUP BY queries on models with Meta.ordering.
Regression in 0ddb4ebf7b
.
Thanks Julien Dutriaux for the report.
This commit is contained in:
parent
5fab16392f
commit
e11d05e0b4
@ -1224,7 +1224,12 @@ class QuerySet:
|
||||
return True
|
||||
if self.query.extra_order_by or self.query.order_by:
|
||||
return True
|
||||
elif self.query.default_ordering and self.query.get_meta().ordering:
|
||||
elif (
|
||||
self.query.default_ordering and
|
||||
self.query.get_meta().ordering and
|
||||
# A default ordering doesn't affect GROUP BY queries.
|
||||
not self.query.group_by
|
||||
):
|
||||
return True
|
||||
else:
|
||||
return False
|
||||
|
@ -11,3 +11,8 @@ Bugfixes
|
||||
|
||||
* Fixed a bug in Django 3.1 where ``FileField`` instances with a callable
|
||||
storage were not correctly deconstructed (:ticket:`31941`).
|
||||
|
||||
* Fixed a regression in Django 3.1 where the :attr:`.QuerySet.ordered`
|
||||
attribute returned incorrectly ``True`` for ``GROUP BY`` queries (e.g.
|
||||
``.annotate().values()``) on models with ``Meta.ordering``. A model's
|
||||
``Meta.ordering`` doesn't affect such queries (:ticket:`31990`).
|
||||
|
@ -2084,6 +2084,16 @@ class QuerysetOrderedTests(unittest.TestCase):
|
||||
self.assertIs(qs.ordered, False)
|
||||
self.assertIs(qs.order_by('num_notes').ordered, True)
|
||||
|
||||
def test_annotated_default_ordering(self):
|
||||
qs = Tag.objects.annotate(num_notes=Count('pk'))
|
||||
self.assertIs(qs.ordered, False)
|
||||
self.assertIs(qs.order_by('name').ordered, True)
|
||||
|
||||
def test_annotated_values_default_ordering(self):
|
||||
qs = Tag.objects.values('name').annotate(num_notes=Count('pk'))
|
||||
self.assertIs(qs.ordered, False)
|
||||
self.assertIs(qs.order_by('name').ordered, True)
|
||||
|
||||
|
||||
@skipUnlessDBFeature('allow_sliced_subqueries_with_in')
|
||||
class SubqueryTests(TestCase):
|
||||
|
Loading…
Reference in New Issue
Block a user