mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-22 17:16:24 +00:00
Code Issues 25 Releases Wiki Activity

Fixed #35099 -- Prevented mutating queryset when combining with & and | operators.

Browse Source 
Thanks Alan for the report.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
This commit is contained in:
Hisham Mahmood 2024-02-06 19:40:01 +05:00 committed by Mariusz Felisiak
parent 6ee37ada32
commit d79fba7d8e
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
django/db/models/sql/query.py
View File

@ -696,6 +696,7 @@ class Query(BaseExpression):
# except if the alias is the base table since it must be present in the
# query on both sides.
initial_alias = self.get_initial_alias()
rhs = rhs.clone()
rhs.bump_prefix(self, exclude={initial_alias})
# Work out how to relabel the rhs aliases, if necessary.

18
tests/queries/tests.py
View File

@ -1357,6 +1357,24 @@ class Queries1Tests(TestCase):
)
self.assertSequenceEqual(Note.objects.exclude(negate=True), [self.n3])
def test_combining_does_not_mutate(self):
all_authors = Author.objects.all()
authors_with_report = Author.objects.filter(
Exists(Report.objects.filter(creator__pk=OuterRef("id")))
)
authors_without_report = all_authors.exclude(pk__in=authors_with_report)
items_before = Item.objects.filter(creator__in=authors_without_report)
self.assertCountEqual(items_before, [self.i2, self.i3, self.i4])
# Combining querysets doesn't mutate them.
all_authors | authors_with_report
all_authors & authors_with_report
authors_without_report = all_authors.exclude(pk__in=authors_with_report)
items_after = Item.objects.filter(creator__in=authors_without_report)
self.assertCountEqual(items_after, [self.i2, self.i3, self.i4])
self.assertCountEqual(items_before, items_after)
class Queries2Tests(TestCase):
@classmethod