mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-06-05 11:39:13 +00:00
Code Issues 32 Releases Wiki Activity

Fixed SeleniumTests.test_related_object_update_with_camel_casing() assert.

Browse Source 
A selenium web element was compared to a string rather than its innerHTML.
This commit is contained in:
Sarah Boyce 2024-04-03 08:41:38 +02:00
parent 8665cf03d7
commit 89403dbedd
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/admin_views/test_related_object_lookups.py
View File

@ -80,9 +80,6 @@ class SeleniumTests(AdminSeleniumTestCase):
def test_related_object_update_with_camel_casing(self): def test_related_object_update_with_camel_casing(self):
from selenium.webdriver.common.by import By from selenium.webdriver.common.by import By
def _get_HTML_inside_element_by_id(id_):
return self.selenium.find_element(By.ID, id_).get_attribute("innerHTML")
add_url = reverse("admin:admin_views_camelcaserelatedmodel_add") add_url = reverse("admin:admin_views_camelcaserelatedmodel_add")
self.selenium.get(self.live_server_url + add_url) self.selenium.get(self.live_server_url + add_url)
interesting_name = "A test name" interesting_name = "A test name"
@ -105,15 +102,17 @@ class SeleniumTests(AdminSeleniumTestCase):
# Check that both the "Available" m2m box and the "Fk" dropdown now # Check that both the "Available" m2m box and the "Fk" dropdown now
# include the newly added CamelCaseModel instance. # include the newly added CamelCaseModel instance.
fk_dropdown = self.selenium.find_element(By.ID, "id_fk")
self.assertHTMLEqual( self.assertHTMLEqual(
self.selenium.find_element(By.ID, "id_fk"), fk_dropdown.get_attribute("innerHTML"),
f""" f"""
<option value="" selected="">---------</option> <option value="" selected="">---------</option>
<option value="1" selected>{interesting_name}</option> <option value="1" selected>{interesting_name}</option>
""", """,
) )
m2m_box = self.selenium.find_element(By.ID, "id_m2m_from")
self.assertHTMLEqual( self.assertHTMLEqual(
self.selenium.find_element(By.ID, "id_m2m_from"), m2m_box.get_attribute("innerHTML"),
f""" f"""
<option value="1">{interesting_name}</option> <option value="1">{interesting_name}</option>
""", """,