From 89403dbedd2797324ce3097e4b4a4853d0e6daa9 Mon Sep 17 00:00:00 2001
From: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
Date: Wed, 3 Apr 2024 08:41:38 +0200
Subject: [PATCH] Fixed
SeleniumTests.test_related_object_update_with_camel_casing() assert.
A selenium web element was compared to a string rather than its innerHTML.
---
tests/admin_views/test_related_object_lookups.py | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/tests/admin_views/test_related_object_lookups.py b/tests/admin_views/test_related_object_lookups.py
index 955bebea9e..c10a5568d5 100644
--- a/tests/admin_views/test_related_object_lookups.py
+++ b/tests/admin_views/test_related_object_lookups.py
@@ -80,9 +80,6 @@ class SeleniumTests(AdminSeleniumTestCase):
def test_related_object_update_with_camel_casing(self):
from selenium.webdriver.common.by import By
- def _get_HTML_inside_element_by_id(id_):
- return self.selenium.find_element(By.ID, id_).get_attribute("innerHTML")
-
add_url = reverse("admin:admin_views_camelcaserelatedmodel_add")
self.selenium.get(self.live_server_url + add_url)
interesting_name = "A test name"
@@ -105,15 +102,17 @@ class SeleniumTests(AdminSeleniumTestCase):
# Check that both the "Available" m2m box and the "Fk" dropdown now
# include the newly added CamelCaseModel instance.
+ fk_dropdown = self.selenium.find_element(By.ID, "id_fk")
self.assertHTMLEqual(
- self.selenium.find_element(By.ID, "id_fk"),
+ fk_dropdown.get_attribute("innerHTML"),
f"""
""",
)
+ m2m_box = self.selenium.find_element(By.ID, "id_m2m_from")
self.assertHTMLEqual(
- self.selenium.find_element(By.ID, "id_m2m_from"),
+ m2m_box.get_attribute("innerHTML"),
f"""
""",