mirrors
/
django
mirror of https://github.com/django/django.git
1
0
Fork 0
Code Issues 24 Releases Wiki Activity

Improved ExplainTests.test_basic(). 

QuerySet.select_for_update() is not supported by all databases.
Moreover it cannot be used outside of a transaction.
This commit is contained in:
Mariusz Felisiak 2022-04-13 10:17:14 +02:00 committed by GitHub
parent 27d52158b2
commit 0b63124c84
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/queries/test_explain.py
View File

@ -20,8 +20,9 @@ class ExplainTests(TestCase):
Tag.objects.filter(name="test").annotate(Count("children")),
Tag.objects.filter(name="test").values_list("name"),
Tag.objects.order_by().union(Tag.objects.order_by().filter(name="test")),
Tag.objects.select_for_update().filter(name="test"),
]
if connection.features.has_select_for_update:
querysets.append(Tag.objects.select_for_update().filter(name="test"))
supported_formats = connection.features.supported_explain_formats
all_formats = (
(None,)
@ -31,13 +32,19 @@ class ExplainTests(TestCase):
for idx, queryset in enumerate(querysets):
for format in all_formats:
with self.subTest(format=format, queryset=idx):
with self.assertNumQueries(1), CaptureQueriesContext(
connection
) as captured_queries:
result = queryset.explain(format=format)
with CaptureQueriesContext(connection) as captured_queries:
if queryset.query.select_for_update:
with transaction.atomic():
result = queryset.explain(format=format)
else:
result = queryset.explain(format=format)
self.assertEqual(len(captured_queries), 1)
self.assertTrue(
captured_queries[0]["sql"].startswith(
connection.ops.explain_prefix
any(
captured_query["sql"].startswith(
connection.ops.explain_prefix
)
for captured_query in captured_queries
)
)
self.assertIsInstance(result, str)