mirror of
https://github.com/django/django.git
synced 2024-12-25 02:26:12 +00:00
4e9a74b81d
Thanks to Jeremy Dunck for pointing out the problem with this change. If in a
single transaction, the master deletes a record and then get_or_creates a
similar record, under the new behavior the get_or_create would find the record
in the slave db and fail to re-create it, leaving the record nonexistent, which
violates the contract of get_or_create that the record should always exist
afterwards. We need to do everything against the master here in order to ensure
correctness.
This reverts commit 901af86550.
67 lines
2.4 KiB
Python
67 lines
2.4 KiB
Python
from __future__ import absolute_import
|
|
|
|
from datetime import date
|
|
import traceback
|
|
|
|
from django.db import IntegrityError
|
|
from django.test import TestCase
|
|
|
|
from .models import Person, ManualPrimaryKeyTest
|
|
|
|
|
|
class GetOrCreateTests(TestCase):
|
|
def test_get_or_create(self):
|
|
p = Person.objects.create(
|
|
first_name='John', last_name='Lennon', birthday=date(1940, 10, 9)
|
|
)
|
|
|
|
p, created = Person.objects.get_or_create(
|
|
first_name="John", last_name="Lennon", defaults={
|
|
"birthday": date(1940, 10, 9)
|
|
}
|
|
)
|
|
self.assertFalse(created)
|
|
self.assertEqual(Person.objects.count(), 1)
|
|
|
|
p, created = Person.objects.get_or_create(
|
|
first_name='George', last_name='Harrison', defaults={
|
|
'birthday': date(1943, 2, 25)
|
|
}
|
|
)
|
|
self.assertTrue(created)
|
|
self.assertEqual(Person.objects.count(), 2)
|
|
|
|
# If we execute the exact same statement, it won't create a Person.
|
|
p, created = Person.objects.get_or_create(
|
|
first_name='George', last_name='Harrison', defaults={
|
|
'birthday': date(1943, 2, 25)
|
|
}
|
|
)
|
|
self.assertFalse(created)
|
|
self.assertEqual(Person.objects.count(), 2)
|
|
|
|
# If you don't specify a value or default value for all required
|
|
# fields, you will get an error.
|
|
self.assertRaises(IntegrityError,
|
|
Person.objects.get_or_create, first_name="Tom", last_name="Smith"
|
|
)
|
|
|
|
# If you specify an existing primary key, but different other fields,
|
|
# then you will get an error and data will not be updated.
|
|
m = ManualPrimaryKeyTest.objects.create(id=1, data="Original")
|
|
self.assertRaises(IntegrityError,
|
|
ManualPrimaryKeyTest.objects.get_or_create, id=1, data="Different"
|
|
)
|
|
self.assertEqual(ManualPrimaryKeyTest.objects.get(id=1).data, "Original")
|
|
|
|
# get_or_create should raise IntegrityErrors with the full traceback.
|
|
# This is tested by checking that a known method call is in the traceback.
|
|
# We cannot use assertRaises/assertRaises here because we need to inspect
|
|
# the actual traceback. Refs #16340.
|
|
try:
|
|
ManualPrimaryKeyTest.objects.get_or_create(id=1, data="Different")
|
|
except IntegrityError as e:
|
|
formatted_traceback = traceback.format_exc()
|
|
self.assertIn('obj.save', formatted_traceback)
|
|
|