mirror of
https://github.com/django/django.git
synced 2024-11-19 16:04:13 +00:00
4bff194633
This is a BACKWARDS INCOMPATIBLE change, because it removes the flawed 'auto_adapt_to_methods' decorator, and replaces it with 'method_decorator' which must be applied manually when necessary, as described in the 1.2 release notes. For users of 1.1 and 1.0, this affects the decorators: * login_required * permission_required * user_passes_test For those following trunk, this also affects: * csrf_protect * anything created with decorator_from_middleware If a decorator does not depend on the signature of the function it is supposed to decorate (for example if it only does post-processing of the result), it will not be affected. git-svn-id: http://code.djangoproject.com/svn/django/trunk@12399 bcc190cf-cafb-0310-a4f2-bffc1f526a37
138 lines
4.9 KiB
Python
138 lines
4.9 KiB
Python
from unittest import TestCase
|
|
from sys import version_info
|
|
try:
|
|
from functools import wraps
|
|
except ImportError:
|
|
from django.utils.functional import wraps # Python 2.3, 2.4 fallback.
|
|
|
|
from django.http import HttpResponse, HttpRequest
|
|
from django.utils.functional import allow_lazy, lazy, memoize
|
|
from django.views.decorators.http import require_http_methods, require_GET, require_POST
|
|
from django.views.decorators.vary import vary_on_headers, vary_on_cookie
|
|
from django.views.decorators.cache import cache_page, never_cache, cache_control
|
|
from django.utils.decorators import method_decorator
|
|
from django.contrib.auth.decorators import login_required, permission_required, user_passes_test
|
|
from django.contrib.admin.views.decorators import staff_member_required
|
|
|
|
def fully_decorated(request):
|
|
"""Expected __doc__"""
|
|
return HttpResponse('<html><body>dummy</body></html>')
|
|
fully_decorated.anything = "Expected __dict__"
|
|
|
|
# django.views.decorators.http
|
|
fully_decorated = require_http_methods(["GET"])(fully_decorated)
|
|
fully_decorated = require_GET(fully_decorated)
|
|
fully_decorated = require_POST(fully_decorated)
|
|
|
|
# django.views.decorators.vary
|
|
fully_decorated = vary_on_headers('Accept-language')(fully_decorated)
|
|
fully_decorated = vary_on_cookie(fully_decorated)
|
|
|
|
# django.views.decorators.cache
|
|
fully_decorated = cache_page(60*15)(fully_decorated)
|
|
fully_decorated = cache_control(private=True)(fully_decorated)
|
|
fully_decorated = never_cache(fully_decorated)
|
|
|
|
# django.contrib.auth.decorators
|
|
# Apply user_passes_test twice to check #9474
|
|
fully_decorated = user_passes_test(lambda u:True)(fully_decorated)
|
|
fully_decorated = login_required(fully_decorated)
|
|
fully_decorated = permission_required('change_world')(fully_decorated)
|
|
|
|
# django.contrib.admin.views.decorators
|
|
fully_decorated = staff_member_required(fully_decorated)
|
|
|
|
# django.utils.functional
|
|
fully_decorated = memoize(fully_decorated, {}, 1)
|
|
fully_decorated = allow_lazy(fully_decorated)
|
|
fully_decorated = lazy(fully_decorated)
|
|
|
|
|
|
class DecoratorsTest(TestCase):
|
|
|
|
def test_attributes(self):
|
|
"""
|
|
Tests that django decorators set certain attributes of the wrapped
|
|
function.
|
|
"""
|
|
# Only check __name__ on Python 2.4 or later since __name__ can't be
|
|
# assigned to in earlier Python versions.
|
|
if version_info[0] >= 2 and version_info[1] >= 4:
|
|
self.assertEquals(fully_decorated.__name__, 'fully_decorated')
|
|
self.assertEquals(fully_decorated.__doc__, 'Expected __doc__')
|
|
self.assertEquals(fully_decorated.__dict__['anything'], 'Expected __dict__')
|
|
|
|
def test_user_passes_test_composition(self):
|
|
"""
|
|
Test that the user_passes_test decorator can be applied multiple times
|
|
(#9474).
|
|
"""
|
|
def test1(user):
|
|
user.decorators_applied.append('test1')
|
|
return True
|
|
|
|
def test2(user):
|
|
user.decorators_applied.append('test2')
|
|
return True
|
|
|
|
def callback(request):
|
|
return request.user.decorators_applied
|
|
|
|
callback = user_passes_test(test1)(callback)
|
|
callback = user_passes_test(test2)(callback)
|
|
|
|
class DummyUser(object): pass
|
|
class DummyRequest(object): pass
|
|
|
|
request = DummyRequest()
|
|
request.user = DummyUser()
|
|
request.user.decorators_applied = []
|
|
response = callback(request)
|
|
|
|
self.assertEqual(response, ['test2', 'test1'])
|
|
|
|
def test_cache_page_new_style(self):
|
|
"""
|
|
Test that we can call cache_page the new way
|
|
"""
|
|
def my_view(request):
|
|
return "response"
|
|
my_view_cached = cache_page(123)(my_view)
|
|
self.assertEqual(my_view_cached(HttpRequest()), "response")
|
|
my_view_cached2 = cache_page(123, key_prefix="test")(my_view)
|
|
self.assertEqual(my_view_cached2(HttpRequest()), "response")
|
|
|
|
def test_cache_page_old_style(self):
|
|
"""
|
|
Test that we can call cache_page the old way
|
|
"""
|
|
def my_view(request):
|
|
return "response"
|
|
my_view_cached = cache_page(my_view, 123)
|
|
self.assertEqual(my_view_cached(HttpRequest()), "response")
|
|
my_view_cached2 = cache_page(my_view, 123, key_prefix="test")
|
|
self.assertEqual(my_view_cached2(HttpRequest()), "response")
|
|
|
|
|
|
# For testing method_decorator, a decorator that assumes a single argument.
|
|
# We will get type arguments if there is a mismatch in the number of arguments.
|
|
def simple_dec(func):
|
|
def wrapper(arg):
|
|
return func("test:" + arg)
|
|
return wraps(func)(wrapper)
|
|
|
|
simple_dec_m = method_decorator(simple_dec)
|
|
|
|
|
|
class MethodDecoratorTests(TestCase):
|
|
"""
|
|
Tests for method_decorator
|
|
"""
|
|
def test_method_decorator(self):
|
|
class Test(object):
|
|
@simple_dec_m
|
|
def say(self, arg):
|
|
return arg
|
|
|
|
self.assertEqual("test:hello", Test().say("hello"))
|