mirror of
https://github.com/django/django.git
synced 2024-12-22 17:16:24 +00:00
467 lines
16 KiB
Python
467 lines
16 KiB
Python
from django.conf import settings
|
|
from django.core.checks.security import base, csrf, sessions
|
|
from django.test import SimpleTestCase
|
|
from django.test.utils import override_settings
|
|
|
|
|
|
class CheckSessionCookieSecureTest(SimpleTestCase):
|
|
@override_settings(
|
|
SESSION_COOKIE_SECURE=False,
|
|
INSTALLED_APPS=["django.contrib.sessions"],
|
|
MIDDLEWARE=[],
|
|
)
|
|
def test_session_cookie_secure_with_installed_app(self):
|
|
"""
|
|
Warn if SESSION_COOKIE_SECURE is off and "django.contrib.sessions" is
|
|
in INSTALLED_APPS.
|
|
"""
|
|
self.assertEqual(sessions.check_session_cookie_secure(None), [sessions.W010])
|
|
|
|
@override_settings(
|
|
SESSION_COOKIE_SECURE=False,
|
|
INSTALLED_APPS=[],
|
|
MIDDLEWARE=['django.contrib.sessions.middleware.SessionMiddleware'],
|
|
)
|
|
def test_session_cookie_secure_with_middleware(self):
|
|
"""
|
|
Warn if SESSION_COOKIE_SECURE is off and
|
|
"django.contrib.sessions.middleware.SessionMiddleware" is in
|
|
MIDDLEWARE.
|
|
"""
|
|
self.assertEqual(sessions.check_session_cookie_secure(None), [sessions.W011])
|
|
|
|
@override_settings(
|
|
SESSION_COOKIE_SECURE=False,
|
|
INSTALLED_APPS=["django.contrib.sessions"],
|
|
MIDDLEWARE=['django.contrib.sessions.middleware.SessionMiddleware'],
|
|
)
|
|
def test_session_cookie_secure_both(self):
|
|
"""
|
|
If SESSION_COOKIE_SECURE is off and we find both the session app and
|
|
the middleware, provide one common warning.
|
|
"""
|
|
self.assertEqual(sessions.check_session_cookie_secure(None), [sessions.W012])
|
|
|
|
@override_settings(
|
|
SESSION_COOKIE_SECURE=True,
|
|
INSTALLED_APPS=["django.contrib.sessions"],
|
|
MIDDLEWARE=['django.contrib.sessions.middleware.SessionMiddleware'],
|
|
)
|
|
def test_session_cookie_secure_true(self):
|
|
"""
|
|
If SESSION_COOKIE_SECURE is on, there's no warning about it.
|
|
"""
|
|
self.assertEqual(sessions.check_session_cookie_secure(None), [])
|
|
|
|
|
|
class CheckSessionCookieHttpOnlyTest(SimpleTestCase):
|
|
@override_settings(
|
|
SESSION_COOKIE_HTTPONLY=False,
|
|
INSTALLED_APPS=["django.contrib.sessions"],
|
|
MIDDLEWARE=[],
|
|
)
|
|
def test_session_cookie_httponly_with_installed_app(self):
|
|
"""
|
|
Warn if SESSION_COOKIE_HTTPONLY is off and "django.contrib.sessions"
|
|
is in INSTALLED_APPS.
|
|
"""
|
|
self.assertEqual(sessions.check_session_cookie_httponly(None), [sessions.W013])
|
|
|
|
@override_settings(
|
|
SESSION_COOKIE_HTTPONLY=False,
|
|
INSTALLED_APPS=[],
|
|
MIDDLEWARE=['django.contrib.sessions.middleware.SessionMiddleware'],
|
|
)
|
|
def test_session_cookie_httponly_with_middleware(self):
|
|
"""
|
|
Warn if SESSION_COOKIE_HTTPONLY is off and
|
|
"django.contrib.sessions.middleware.SessionMiddleware" is in
|
|
MIDDLEWARE.
|
|
"""
|
|
self.assertEqual(sessions.check_session_cookie_httponly(None), [sessions.W014])
|
|
|
|
@override_settings(
|
|
SESSION_COOKIE_HTTPONLY=False,
|
|
INSTALLED_APPS=["django.contrib.sessions"],
|
|
MIDDLEWARE=['django.contrib.sessions.middleware.SessionMiddleware'],
|
|
)
|
|
def test_session_cookie_httponly_both(self):
|
|
"""
|
|
If SESSION_COOKIE_HTTPONLY is off and we find both the session app and
|
|
the middleware, provide one common warning.
|
|
"""
|
|
self.assertEqual(sessions.check_session_cookie_httponly(None), [sessions.W015])
|
|
|
|
@override_settings(
|
|
SESSION_COOKIE_HTTPONLY=True,
|
|
INSTALLED_APPS=["django.contrib.sessions"],
|
|
MIDDLEWARE=['django.contrib.sessions.middleware.SessionMiddleware'],
|
|
)
|
|
def test_session_cookie_httponly_true(self):
|
|
"""
|
|
If SESSION_COOKIE_HTTPONLY is on, there's no warning about it.
|
|
"""
|
|
self.assertEqual(sessions.check_session_cookie_httponly(None), [])
|
|
|
|
|
|
class CheckCSRFMiddlewareTest(SimpleTestCase):
|
|
@override_settings(MIDDLEWARE=[])
|
|
def test_no_csrf_middleware(self):
|
|
"""
|
|
Warn if CsrfViewMiddleware isn't in MIDDLEWARE.
|
|
"""
|
|
self.assertEqual(csrf.check_csrf_middleware(None), [csrf.W003])
|
|
|
|
@override_settings(MIDDLEWARE=['django.middleware.csrf.CsrfViewMiddleware'])
|
|
def test_with_csrf_middleware(self):
|
|
self.assertEqual(csrf.check_csrf_middleware(None), [])
|
|
|
|
|
|
class CheckCSRFCookieSecureTest(SimpleTestCase):
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.csrf.CsrfViewMiddleware"],
|
|
CSRF_COOKIE_SECURE=False,
|
|
)
|
|
def test_with_csrf_cookie_secure_false(self):
|
|
"""
|
|
Warn if CsrfViewMiddleware is in MIDDLEWARE but
|
|
CSRF_COOKIE_SECURE isn't True.
|
|
"""
|
|
self.assertEqual(csrf.check_csrf_cookie_secure(None), [csrf.W016])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.csrf.CsrfViewMiddleware"],
|
|
CSRF_USE_SESSIONS=True,
|
|
CSRF_COOKIE_SECURE=False,
|
|
)
|
|
def test_use_sessions_with_csrf_cookie_secure_false(self):
|
|
"""
|
|
No warning if CSRF_COOKIE_SECURE isn't True while CSRF_USE_SESSIONS
|
|
is True.
|
|
"""
|
|
self.assertEqual(csrf.check_csrf_cookie_secure(None), [])
|
|
|
|
@override_settings(MIDDLEWARE=[], CSRF_COOKIE_SECURE=False)
|
|
def test_with_csrf_cookie_secure_false_no_middleware(self):
|
|
"""
|
|
No warning if CsrfViewMiddleware isn't in MIDDLEWARE, even if
|
|
CSRF_COOKIE_SECURE is False.
|
|
"""
|
|
self.assertEqual(csrf.check_csrf_cookie_secure(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.csrf.CsrfViewMiddleware"],
|
|
CSRF_COOKIE_SECURE=True,
|
|
)
|
|
def test_with_csrf_cookie_secure_true(self):
|
|
self.assertEqual(csrf.check_csrf_cookie_secure(None), [])
|
|
|
|
|
|
class CheckSecurityMiddlewareTest(SimpleTestCase):
|
|
@override_settings(MIDDLEWARE=[])
|
|
def test_no_security_middleware(self):
|
|
"""
|
|
Warn if SecurityMiddleware isn't in MIDDLEWARE.
|
|
"""
|
|
self.assertEqual(base.check_security_middleware(None), [base.W001])
|
|
|
|
@override_settings(MIDDLEWARE=['django.middleware.security.SecurityMiddleware'])
|
|
def test_with_security_middleware(self):
|
|
self.assertEqual(base.check_security_middleware(None), [])
|
|
|
|
|
|
class CheckStrictTransportSecurityTest(SimpleTestCase):
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_HSTS_SECONDS=0,
|
|
)
|
|
def test_no_sts(self):
|
|
"""
|
|
Warn if SECURE_HSTS_SECONDS isn't > 0.
|
|
"""
|
|
self.assertEqual(base.check_sts(None), [base.W004])
|
|
|
|
@override_settings(MIDDLEWARE=[], SECURE_HSTS_SECONDS=0)
|
|
def test_no_sts_no_middleware(self):
|
|
"""
|
|
Don't warn if SECURE_HSTS_SECONDS isn't > 0 and SecurityMiddleware isn't
|
|
installed.
|
|
"""
|
|
self.assertEqual(base.check_sts(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_HSTS_SECONDS=3600,
|
|
)
|
|
def test_with_sts(self):
|
|
self.assertEqual(base.check_sts(None), [])
|
|
|
|
|
|
class CheckStrictTransportSecuritySubdomainsTest(SimpleTestCase):
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_HSTS_INCLUDE_SUBDOMAINS=False,
|
|
SECURE_HSTS_SECONDS=3600,
|
|
)
|
|
def test_no_sts_subdomains(self):
|
|
"""
|
|
Warn if SECURE_HSTS_INCLUDE_SUBDOMAINS isn't True.
|
|
"""
|
|
self.assertEqual(base.check_sts_include_subdomains(None), [base.W005])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=[],
|
|
SECURE_HSTS_INCLUDE_SUBDOMAINS=False,
|
|
SECURE_HSTS_SECONDS=3600,
|
|
)
|
|
def test_no_sts_subdomains_no_middleware(self):
|
|
"""
|
|
Don't warn if SecurityMiddleware isn't installed.
|
|
"""
|
|
self.assertEqual(base.check_sts_include_subdomains(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_SSL_REDIRECT=False,
|
|
SECURE_HSTS_SECONDS=None,
|
|
)
|
|
def test_no_sts_subdomains_no_seconds(self):
|
|
"""
|
|
Don't warn if SECURE_HSTS_SECONDS isn't set.
|
|
"""
|
|
self.assertEqual(base.check_sts_include_subdomains(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_HSTS_INCLUDE_SUBDOMAINS=True,
|
|
SECURE_HSTS_SECONDS=3600,
|
|
)
|
|
def test_with_sts_subdomains(self):
|
|
self.assertEqual(base.check_sts_include_subdomains(None), [])
|
|
|
|
|
|
class CheckStrictTransportSecurityPreloadTest(SimpleTestCase):
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_HSTS_PRELOAD=False,
|
|
SECURE_HSTS_SECONDS=3600,
|
|
)
|
|
def test_no_sts_preload(self):
|
|
"""
|
|
Warn if SECURE_HSTS_PRELOAD isn't True.
|
|
"""
|
|
self.assertEqual(base.check_sts_preload(None), [base.W021])
|
|
|
|
@override_settings(MIDDLEWARE=[], SECURE_HSTS_PRELOAD=False, SECURE_HSTS_SECONDS=3600)
|
|
def test_no_sts_preload_no_middleware(self):
|
|
"""
|
|
Don't warn if SecurityMiddleware isn't installed.
|
|
"""
|
|
self.assertEqual(base.check_sts_preload(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_SSL_REDIRECT=False,
|
|
SECURE_HSTS_SECONDS=None,
|
|
)
|
|
def test_no_sts_preload_no_seconds(self):
|
|
"""
|
|
Don't warn if SECURE_HSTS_SECONDS isn't set.
|
|
"""
|
|
self.assertEqual(base.check_sts_preload(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_HSTS_PRELOAD=True,
|
|
SECURE_HSTS_SECONDS=3600,
|
|
)
|
|
def test_with_sts_preload(self):
|
|
self.assertEqual(base.check_sts_preload(None), [])
|
|
|
|
|
|
class CheckXFrameOptionsMiddlewareTest(SimpleTestCase):
|
|
@override_settings(MIDDLEWARE=[])
|
|
def test_middleware_not_installed(self):
|
|
"""
|
|
Warn if XFrameOptionsMiddleware isn't in MIDDLEWARE.
|
|
"""
|
|
self.assertEqual(base.check_xframe_options_middleware(None), [base.W002])
|
|
|
|
@override_settings(MIDDLEWARE=["django.middleware.clickjacking.XFrameOptionsMiddleware"])
|
|
def test_middleware_installed(self):
|
|
self.assertEqual(base.check_xframe_options_middleware(None), [])
|
|
|
|
|
|
class CheckXFrameOptionsDenyTest(SimpleTestCase):
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.clickjacking.XFrameOptionsMiddleware"],
|
|
X_FRAME_OPTIONS='SAMEORIGIN',
|
|
)
|
|
def test_x_frame_options_not_deny(self):
|
|
"""
|
|
Warn if XFrameOptionsMiddleware is in MIDDLEWARE but
|
|
X_FRAME_OPTIONS isn't 'DENY'.
|
|
"""
|
|
self.assertEqual(base.check_xframe_deny(None), [base.W019])
|
|
|
|
@override_settings(MIDDLEWARE=[], X_FRAME_OPTIONS='SAMEORIGIN')
|
|
def test_middleware_not_installed(self):
|
|
"""
|
|
No error if XFrameOptionsMiddleware isn't in MIDDLEWARE even if
|
|
X_FRAME_OPTIONS isn't 'DENY'.
|
|
"""
|
|
self.assertEqual(base.check_xframe_deny(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.clickjacking.XFrameOptionsMiddleware"],
|
|
X_FRAME_OPTIONS='DENY',
|
|
)
|
|
def test_xframe_deny(self):
|
|
self.assertEqual(base.check_xframe_deny(None), [])
|
|
|
|
|
|
class CheckContentTypeNosniffTest(SimpleTestCase):
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_CONTENT_TYPE_NOSNIFF=False,
|
|
)
|
|
def test_no_content_type_nosniff(self):
|
|
"""
|
|
Warn if SECURE_CONTENT_TYPE_NOSNIFF isn't True.
|
|
"""
|
|
self.assertEqual(base.check_content_type_nosniff(None), [base.W006])
|
|
|
|
@override_settings(MIDDLEWARE=[], SECURE_CONTENT_TYPE_NOSNIFF=False)
|
|
def test_no_content_type_nosniff_no_middleware(self):
|
|
"""
|
|
Don't warn if SECURE_CONTENT_TYPE_NOSNIFF isn't True and
|
|
SecurityMiddleware isn't in MIDDLEWARE.
|
|
"""
|
|
self.assertEqual(base.check_content_type_nosniff(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_CONTENT_TYPE_NOSNIFF=True,
|
|
)
|
|
def test_with_content_type_nosniff(self):
|
|
self.assertEqual(base.check_content_type_nosniff(None), [])
|
|
|
|
|
|
class CheckSSLRedirectTest(SimpleTestCase):
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_SSL_REDIRECT=False,
|
|
)
|
|
def test_no_ssl_redirect(self):
|
|
"""
|
|
Warn if SECURE_SSL_REDIRECT isn't True.
|
|
"""
|
|
self.assertEqual(base.check_ssl_redirect(None), [base.W008])
|
|
|
|
@override_settings(MIDDLEWARE=[], SECURE_SSL_REDIRECT=False)
|
|
def test_no_ssl_redirect_no_middleware(self):
|
|
"""
|
|
Don't warn if SECURE_SSL_REDIRECT is False and SecurityMiddleware isn't
|
|
installed.
|
|
"""
|
|
self.assertEqual(base.check_ssl_redirect(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=["django.middleware.security.SecurityMiddleware"],
|
|
SECURE_SSL_REDIRECT=True,
|
|
)
|
|
def test_with_ssl_redirect(self):
|
|
self.assertEqual(base.check_ssl_redirect(None), [])
|
|
|
|
|
|
class CheckSecretKeyTest(SimpleTestCase):
|
|
@override_settings(SECRET_KEY=('abcdefghijklmnopqrstuvwx' * 2) + 'ab')
|
|
def test_okay_secret_key(self):
|
|
self.assertEqual(len(settings.SECRET_KEY), base.SECRET_KEY_MIN_LENGTH)
|
|
self.assertGreater(len(set(settings.SECRET_KEY)), base.SECRET_KEY_MIN_UNIQUE_CHARACTERS)
|
|
self.assertEqual(base.check_secret_key(None), [])
|
|
|
|
@override_settings(SECRET_KEY='')
|
|
def test_empty_secret_key(self):
|
|
self.assertEqual(base.check_secret_key(None), [base.W009])
|
|
|
|
@override_settings(SECRET_KEY=None)
|
|
def test_missing_secret_key(self):
|
|
del settings.SECRET_KEY
|
|
self.assertEqual(base.check_secret_key(None), [base.W009])
|
|
|
|
@override_settings(SECRET_KEY=None)
|
|
def test_none_secret_key(self):
|
|
self.assertEqual(base.check_secret_key(None), [base.W009])
|
|
|
|
@override_settings(SECRET_KEY=('abcdefghijklmnopqrstuvwx' * 2) + 'a')
|
|
def test_low_length_secret_key(self):
|
|
self.assertEqual(len(settings.SECRET_KEY), base.SECRET_KEY_MIN_LENGTH - 1)
|
|
self.assertEqual(base.check_secret_key(None), [base.W009])
|
|
|
|
@override_settings(SECRET_KEY='abcd' * 20)
|
|
def test_low_entropy_secret_key(self):
|
|
self.assertGreater(len(settings.SECRET_KEY), base.SECRET_KEY_MIN_LENGTH)
|
|
self.assertLess(len(set(settings.SECRET_KEY)), base.SECRET_KEY_MIN_UNIQUE_CHARACTERS)
|
|
self.assertEqual(base.check_secret_key(None), [base.W009])
|
|
|
|
|
|
class CheckDebugTest(SimpleTestCase):
|
|
@override_settings(DEBUG=True)
|
|
def test_debug_true(self):
|
|
"""
|
|
Warn if DEBUG is True.
|
|
"""
|
|
self.assertEqual(base.check_debug(None), [base.W018])
|
|
|
|
@override_settings(DEBUG=False)
|
|
def test_debug_false(self):
|
|
self.assertEqual(base.check_debug(None), [])
|
|
|
|
|
|
class CheckAllowedHostsTest(SimpleTestCase):
|
|
@override_settings(ALLOWED_HOSTS=[])
|
|
def test_allowed_hosts_empty(self):
|
|
self.assertEqual(base.check_allowed_hosts(None), [base.W020])
|
|
|
|
@override_settings(ALLOWED_HOSTS=['.example.com'])
|
|
def test_allowed_hosts_set(self):
|
|
self.assertEqual(base.check_allowed_hosts(None), [])
|
|
|
|
|
|
class CheckReferrerPolicyTest(SimpleTestCase):
|
|
@override_settings(
|
|
MIDDLEWARE=['django.middleware.security.SecurityMiddleware'],
|
|
SECURE_REFERRER_POLICY=None,
|
|
)
|
|
def test_no_referrer_policy(self):
|
|
self.assertEqual(base.check_referrer_policy(None), [base.W022])
|
|
|
|
@override_settings(MIDDLEWARE=[], SECURE_REFERRER_POLICY=None)
|
|
def test_no_referrer_policy_no_middleware(self):
|
|
"""
|
|
Don't warn if SECURE_REFERRER_POLICY is None and SecurityMiddleware
|
|
isn't in MIDDLEWARE.
|
|
"""
|
|
self.assertEqual(base.check_referrer_policy(None), [])
|
|
|
|
@override_settings(MIDDLEWARE=['django.middleware.security.SecurityMiddleware'])
|
|
def test_with_referrer_policy(self):
|
|
tests = (
|
|
'strict-origin',
|
|
'strict-origin,origin',
|
|
'strict-origin, origin',
|
|
['strict-origin', 'origin'],
|
|
('strict-origin', 'origin'),
|
|
)
|
|
for value in tests:
|
|
with self.subTest(value=value), override_settings(SECURE_REFERRER_POLICY=value):
|
|
self.assertEqual(base.check_referrer_policy(None), [])
|
|
|
|
@override_settings(
|
|
MIDDLEWARE=['django.middleware.security.SecurityMiddleware'],
|
|
SECURE_REFERRER_POLICY='invalid-value',
|
|
)
|
|
def test_with_invalid_referrer_policy(self):
|
|
self.assertEqual(base.check_referrer_policy(None), [base.E023])
|