mirror of
https://github.com/django/django.git
synced 2024-11-18 07:26:04 +00:00
7cb3a48843
Reverted "Fixes #24727 -- Prevented ClearableFileInput from masking
exceptions on Python 2" and added a regression test.
This reverts commit 5c412dd8a7
.
108 lines
3.7 KiB
Python
108 lines
3.7 KiB
Python
from django.core.files.uploadedfile import SimpleUploadedFile
|
|
from django.forms import ClearableFileInput
|
|
from django.utils import six
|
|
from django.utils.encoding import python_2_unicode_compatible
|
|
|
|
from .base import WidgetTest
|
|
|
|
|
|
@python_2_unicode_compatible
|
|
class FakeFieldFile(object):
|
|
"""
|
|
Quacks like a FieldFile (has a .url and unicode representation), but
|
|
doesn't require us to care about storages etc.
|
|
"""
|
|
url = 'something'
|
|
|
|
def __str__(self):
|
|
return self.url
|
|
|
|
|
|
class ClearableFileInputTest(WidgetTest):
|
|
widget = ClearableFileInput()
|
|
|
|
def test_clear_input_renders(self):
|
|
"""
|
|
A ClearableFileInput with is_required False and rendered with an
|
|
initial value that is a file renders a clear checkbox.
|
|
"""
|
|
self.check_html(self.widget, 'myfile', FakeFieldFile(), html=(
|
|
"""
|
|
Currently: <a href="something">something</a>
|
|
<input type="checkbox" name="myfile-clear" id="myfile-clear_id" />
|
|
<label for="myfile-clear_id">Clear</label><br />
|
|
Change: <input type="file" name="myfile" />
|
|
"""
|
|
))
|
|
|
|
def test_html_escaped(self):
|
|
"""
|
|
A ClearableFileInput should escape name, filename, and URL
|
|
when rendering HTML (#15182).
|
|
"""
|
|
@python_2_unicode_compatible
|
|
class StrangeFieldFile(object):
|
|
url = "something?chapter=1§=2©=3&lang=en"
|
|
|
|
def __str__(self):
|
|
return '''something<div onclick="alert('oops')">.jpg'''
|
|
|
|
widget = ClearableFileInput()
|
|
field = StrangeFieldFile()
|
|
output = widget.render('my<div>file', field)
|
|
self.assertNotIn(field.url, output)
|
|
self.assertIn('href="something?chapter=1&sect=2&copy=3&lang=en"', output)
|
|
self.assertNotIn(six.text_type(field), output)
|
|
self.assertIn('something<div onclick="alert('oops')">.jpg', output)
|
|
self.assertIn('my<div>file', output)
|
|
self.assertNotIn('my<div>file', output)
|
|
|
|
def test_clear_input_renders_only_if_not_required(self):
|
|
"""
|
|
A ClearableFileInput with is_required=False does not render a clear
|
|
checkbox.
|
|
"""
|
|
widget = ClearableFileInput()
|
|
widget.is_required = True
|
|
self.check_html(widget, 'myfile', FakeFieldFile(), html=(
|
|
"""
|
|
Currently: <a href="something">something</a> <br />
|
|
Change: <input type="file" name="myfile" />
|
|
"""
|
|
))
|
|
|
|
def test_clear_input_renders_only_if_initial(self):
|
|
"""
|
|
A ClearableFileInput instantiated with no initial value does not render
|
|
a clear checkbox.
|
|
"""
|
|
self.check_html(self.widget, 'myfile', None, html='<input type="file" name="myfile" />')
|
|
|
|
def test_clear_input_checked_returns_false(self):
|
|
"""
|
|
ClearableFileInput.value_from_datadict returns False if the clear
|
|
checkbox is checked, if not required.
|
|
"""
|
|
value = self.widget.value_from_datadict(
|
|
data={'myfile-clear': True},
|
|
files={},
|
|
name='myfile',
|
|
)
|
|
self.assertEqual(value, False)
|
|
|
|
def test_clear_input_checked_returns_false_only_if_not_required(self):
|
|
"""
|
|
ClearableFileInput.value_from_datadict never returns False if the field
|
|
is required.
|
|
"""
|
|
widget = ClearableFileInput()
|
|
widget.is_required = True
|
|
field = SimpleUploadedFile('something.txt', b'content')
|
|
|
|
value = widget.value_from_datadict(
|
|
data={'myfile-clear': True},
|
|
files={'myfile': field},
|
|
name='myfile',
|
|
)
|
|
self.assertEqual(value, field)
|