mirror of
https://github.com/django/django.git
synced 2024-12-25 02:26:12 +00:00
10e3faf191
It contained models, forms and admin objects causing undesirable import side effects. Refs #16368. Thanks to Ramiro, Carl and Loïc for the review.
434 lines
20 KiB
Python
434 lines
20 KiB
Python
# -*- coding: utf-8 -*-
|
|
from __future__ import unicode_literals
|
|
import warnings
|
|
|
|
from django.contrib import admin
|
|
from django.contrib.admin.sites import AdminSite
|
|
from django.contrib.contenttypes.admin import GenericTabularInline
|
|
from django.contrib.contenttypes.forms import generic_inlineformset_factory
|
|
from django.forms.formsets import DEFAULT_MAX_NUM
|
|
from django.forms.models import ModelForm
|
|
from django.test import TestCase, override_settings
|
|
|
|
# local test models
|
|
from .admin import MediaInline, MediaPermanentInline
|
|
from .models import (Episode, EpisodeExtra, EpisodeMaxNum, Media,
|
|
EpisodePermanent, Category)
|
|
|
|
|
|
@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',),
|
|
TEMPLATE_DEBUG=True)
|
|
class GenericAdminViewTest(TestCase):
|
|
urls = "generic_inline_admin.urls"
|
|
fixtures = ['users.xml']
|
|
|
|
def setUp(self):
|
|
# set TEMPLATE_DEBUG to True to ensure {% include %} will raise
|
|
# exceptions since that is how inlines are rendered and #9498 will
|
|
# bubble up if it is an issue.
|
|
|
|
self.client.login(username='super', password='secret')
|
|
|
|
# Can't load content via a fixture (since the GenericForeignKey
|
|
# relies on content type IDs, which will vary depending on what
|
|
# other tests have been run), thus we do it here.
|
|
e = Episode.objects.create(name='This Week in Django')
|
|
self.episode_pk = e.pk
|
|
m = Media(content_object=e, url='http://example.com/podcast.mp3')
|
|
m.save()
|
|
self.mp3_media_pk = m.pk
|
|
|
|
m = Media(content_object=e, url='http://example.com/logo.png')
|
|
m.save()
|
|
self.png_media_pk = m.pk
|
|
|
|
def tearDown(self):
|
|
self.client.logout()
|
|
|
|
def testBasicAddGet(self):
|
|
"""
|
|
A smoke test to ensure GET on the add_view works.
|
|
"""
|
|
response = self.client.get('/generic_inline_admin/admin/generic_inline_admin/episode/add/')
|
|
self.assertEqual(response.status_code, 200)
|
|
|
|
def testBasicEditGet(self):
|
|
"""
|
|
A smoke test to ensure GET on the change_view works.
|
|
"""
|
|
response = self.client.get('/generic_inline_admin/admin/generic_inline_admin/episode/%d/' % self.episode_pk)
|
|
self.assertEqual(response.status_code, 200)
|
|
|
|
def testBasicAddPost(self):
|
|
"""
|
|
A smoke test to ensure POST on add_view works.
|
|
"""
|
|
post_data = {
|
|
"name": "This Week in Django",
|
|
# inline data
|
|
"generic_inline_admin-media-content_type-object_id-TOTAL_FORMS": "1",
|
|
"generic_inline_admin-media-content_type-object_id-INITIAL_FORMS": "0",
|
|
"generic_inline_admin-media-content_type-object_id-MAX_NUM_FORMS": "0",
|
|
}
|
|
response = self.client.post('/generic_inline_admin/admin/generic_inline_admin/episode/add/', post_data)
|
|
self.assertEqual(response.status_code, 302) # redirect somewhere
|
|
|
|
def testBasicEditPost(self):
|
|
"""
|
|
A smoke test to ensure POST on edit_view works.
|
|
"""
|
|
post_data = {
|
|
"name": "This Week in Django",
|
|
# inline data
|
|
"generic_inline_admin-media-content_type-object_id-TOTAL_FORMS": "3",
|
|
"generic_inline_admin-media-content_type-object_id-INITIAL_FORMS": "2",
|
|
"generic_inline_admin-media-content_type-object_id-MAX_NUM_FORMS": "0",
|
|
"generic_inline_admin-media-content_type-object_id-0-id": "%d" % self.mp3_media_pk,
|
|
"generic_inline_admin-media-content_type-object_id-0-url": "http://example.com/podcast.mp3",
|
|
"generic_inline_admin-media-content_type-object_id-1-id": "%d" % self.png_media_pk,
|
|
"generic_inline_admin-media-content_type-object_id-1-url": "http://example.com/logo.png",
|
|
"generic_inline_admin-media-content_type-object_id-2-id": "",
|
|
"generic_inline_admin-media-content_type-object_id-2-url": "",
|
|
}
|
|
url = '/generic_inline_admin/admin/generic_inline_admin/episode/%d/' % self.episode_pk
|
|
response = self.client.post(url, post_data)
|
|
self.assertEqual(response.status_code, 302) # redirect somewhere
|
|
|
|
def testGenericInlineFormset(self):
|
|
EpisodeMediaFormSet = generic_inlineformset_factory(Media, can_delete=False, exclude=['description', 'keywords'], extra=3)
|
|
e = Episode.objects.get(name='This Week in Django')
|
|
|
|
# Works with no queryset
|
|
formset = EpisodeMediaFormSet(instance=e)
|
|
self.assertEqual(len(formset.forms), 5)
|
|
self.assertHTMLEqual(formset.forms[0].as_p(), '<p><label for="id_generic_inline_admin-media-content_type-object_id-0-url">Url:</label> <input id="id_generic_inline_admin-media-content_type-object_id-0-url" type="url" name="generic_inline_admin-media-content_type-object_id-0-url" value="http://example.com/podcast.mp3" maxlength="200" /><input type="hidden" name="generic_inline_admin-media-content_type-object_id-0-id" value="%s" id="id_generic_inline_admin-media-content_type-object_id-0-id" /></p>' % self.mp3_media_pk)
|
|
self.assertHTMLEqual(formset.forms[1].as_p(), '<p><label for="id_generic_inline_admin-media-content_type-object_id-1-url">Url:</label> <input id="id_generic_inline_admin-media-content_type-object_id-1-url" type="url" name="generic_inline_admin-media-content_type-object_id-1-url" value="http://example.com/logo.png" maxlength="200" /><input type="hidden" name="generic_inline_admin-media-content_type-object_id-1-id" value="%s" id="id_generic_inline_admin-media-content_type-object_id-1-id" /></p>' % self.png_media_pk)
|
|
self.assertHTMLEqual(formset.forms[2].as_p(), '<p><label for="id_generic_inline_admin-media-content_type-object_id-2-url">Url:</label> <input id="id_generic_inline_admin-media-content_type-object_id-2-url" type="url" name="generic_inline_admin-media-content_type-object_id-2-url" maxlength="200" /><input type="hidden" name="generic_inline_admin-media-content_type-object_id-2-id" id="id_generic_inline_admin-media-content_type-object_id-2-id" /></p>')
|
|
|
|
# A queryset can be used to alter display ordering
|
|
formset = EpisodeMediaFormSet(instance=e, queryset=Media.objects.order_by('url'))
|
|
self.assertEqual(len(formset.forms), 5)
|
|
self.assertHTMLEqual(formset.forms[0].as_p(), '<p><label for="id_generic_inline_admin-media-content_type-object_id-0-url">Url:</label> <input id="id_generic_inline_admin-media-content_type-object_id-0-url" type="url" name="generic_inline_admin-media-content_type-object_id-0-url" value="http://example.com/logo.png" maxlength="200" /><input type="hidden" name="generic_inline_admin-media-content_type-object_id-0-id" value="%s" id="id_generic_inline_admin-media-content_type-object_id-0-id" /></p>' % self.png_media_pk)
|
|
self.assertHTMLEqual(formset.forms[1].as_p(), '<p><label for="id_generic_inline_admin-media-content_type-object_id-1-url">Url:</label> <input id="id_generic_inline_admin-media-content_type-object_id-1-url" type="url" name="generic_inline_admin-media-content_type-object_id-1-url" value="http://example.com/podcast.mp3" maxlength="200" /><input type="hidden" name="generic_inline_admin-media-content_type-object_id-1-id" value="%s" id="id_generic_inline_admin-media-content_type-object_id-1-id" /></p>' % self.mp3_media_pk)
|
|
self.assertHTMLEqual(formset.forms[2].as_p(), '<p><label for="id_generic_inline_admin-media-content_type-object_id-2-url">Url:</label> <input id="id_generic_inline_admin-media-content_type-object_id-2-url" type="url" name="generic_inline_admin-media-content_type-object_id-2-url" maxlength="200" /><input type="hidden" name="generic_inline_admin-media-content_type-object_id-2-id" id="id_generic_inline_admin-media-content_type-object_id-2-id" /></p>')
|
|
|
|
# Works with a queryset that omits items
|
|
formset = EpisodeMediaFormSet(instance=e, queryset=Media.objects.filter(url__endswith=".png"))
|
|
self.assertEqual(len(formset.forms), 4)
|
|
self.assertHTMLEqual(formset.forms[0].as_p(), '<p><label for="id_generic_inline_admin-media-content_type-object_id-0-url">Url:</label> <input id="id_generic_inline_admin-media-content_type-object_id-0-url" type="url" name="generic_inline_admin-media-content_type-object_id-0-url" value="http://example.com/logo.png" maxlength="200" /><input type="hidden" name="generic_inline_admin-media-content_type-object_id-0-id" value="%s" id="id_generic_inline_admin-media-content_type-object_id-0-id" /></p>' % self.png_media_pk)
|
|
self.assertHTMLEqual(formset.forms[1].as_p(), '<p><label for="id_generic_inline_admin-media-content_type-object_id-1-url">Url:</label> <input id="id_generic_inline_admin-media-content_type-object_id-1-url" type="url" name="generic_inline_admin-media-content_type-object_id-1-url" maxlength="200" /><input type="hidden" name="generic_inline_admin-media-content_type-object_id-1-id" id="id_generic_inline_admin-media-content_type-object_id-1-id" /></p>')
|
|
|
|
def testGenericInlineFormsetFactory(self):
|
|
# Regression test for #10522.
|
|
inline_formset = generic_inlineformset_factory(Media,
|
|
exclude=('url',))
|
|
|
|
# Regression test for #12340.
|
|
e = Episode.objects.get(name='This Week in Django')
|
|
formset = inline_formset(instance=e)
|
|
self.assertTrue(formset.get_queryset().ordered)
|
|
|
|
|
|
@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',))
|
|
class GenericInlineAdminParametersTest(TestCase):
|
|
urls = "generic_inline_admin.urls"
|
|
fixtures = ['users.xml']
|
|
|
|
def setUp(self):
|
|
self.client.login(username='super', password='secret')
|
|
|
|
def tearDown(self):
|
|
self.client.logout()
|
|
|
|
def _create_object(self, model):
|
|
"""
|
|
Create a model with an attached Media object via GFK. We can't
|
|
load content via a fixture (since the GenericForeignKey relies on
|
|
content type IDs, which will vary depending on what other tests
|
|
have been run), thus we do it here.
|
|
"""
|
|
e = model.objects.create(name='This Week in Django')
|
|
Media.objects.create(content_object=e, url='http://example.com/podcast.mp3')
|
|
return e
|
|
|
|
def testNoParam(self):
|
|
"""
|
|
With one initial form, extra (default) at 3, there should be 4 forms.
|
|
"""
|
|
e = self._create_object(Episode)
|
|
response = self.client.get('/generic_inline_admin/admin/generic_inline_admin/episode/%s/' % e.pk)
|
|
formset = response.context['inline_admin_formsets'][0].formset
|
|
self.assertEqual(formset.total_form_count(), 4)
|
|
self.assertEqual(formset.initial_form_count(), 1)
|
|
|
|
def testExtraParam(self):
|
|
"""
|
|
With extra=0, there should be one form.
|
|
"""
|
|
e = self._create_object(EpisodeExtra)
|
|
response = self.client.get('/generic_inline_admin/admin/generic_inline_admin/episodeextra/%s/' % e.pk)
|
|
formset = response.context['inline_admin_formsets'][0].formset
|
|
self.assertEqual(formset.total_form_count(), 1)
|
|
self.assertEqual(formset.initial_form_count(), 1)
|
|
|
|
def testMaxNumParam(self):
|
|
"""
|
|
With extra=5 and max_num=2, there should be only 2 forms.
|
|
"""
|
|
e = self._create_object(EpisodeMaxNum)
|
|
response = self.client.get('/generic_inline_admin/admin/generic_inline_admin/episodemaxnum/%s/' % e.pk)
|
|
formset = response.context['inline_admin_formsets'][0].formset
|
|
self.assertEqual(formset.total_form_count(), 2)
|
|
self.assertEqual(formset.initial_form_count(), 1)
|
|
|
|
|
|
@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',))
|
|
class GenericInlineAdminWithUniqueTogetherTest(TestCase):
|
|
urls = "generic_inline_admin.urls"
|
|
fixtures = ['users.xml']
|
|
|
|
def setUp(self):
|
|
self.client.login(username='super', password='secret')
|
|
|
|
def tearDown(self):
|
|
self.client.logout()
|
|
|
|
def testAdd(self):
|
|
category_id = Category.objects.create(name='male').pk
|
|
post_data = {
|
|
"name": "John Doe",
|
|
# inline data
|
|
"generic_inline_admin-phonenumber-content_type-object_id-TOTAL_FORMS": "1",
|
|
"generic_inline_admin-phonenumber-content_type-object_id-INITIAL_FORMS": "0",
|
|
"generic_inline_admin-phonenumber-content_type-object_id-MAX_NUM_FORMS": "0",
|
|
"generic_inline_admin-phonenumber-content_type-object_id-0-id": "",
|
|
"generic_inline_admin-phonenumber-content_type-object_id-0-phone_number": "555-555-5555",
|
|
"generic_inline_admin-phonenumber-content_type-object_id-0-category": "%s" % category_id,
|
|
}
|
|
response = self.client.get('/generic_inline_admin/admin/generic_inline_admin/contact/add/')
|
|
self.assertEqual(response.status_code, 200)
|
|
response = self.client.post('/generic_inline_admin/admin/generic_inline_admin/contact/add/', post_data)
|
|
self.assertEqual(response.status_code, 302) # redirect somewhere
|
|
|
|
|
|
class NoInlineDeletionTest(TestCase):
|
|
urls = "generic_inline_admin.urls"
|
|
|
|
def test_no_deletion(self):
|
|
fake_site = object()
|
|
inline = MediaPermanentInline(EpisodePermanent, fake_site)
|
|
fake_request = object()
|
|
formset = inline.get_formset(fake_request)
|
|
self.assertFalse(formset.can_delete)
|
|
|
|
|
|
class MockRequest(object):
|
|
pass
|
|
|
|
|
|
class MockSuperUser(object):
|
|
def has_perm(self, perm):
|
|
return True
|
|
|
|
request = MockRequest()
|
|
request.user = MockSuperUser()
|
|
|
|
|
|
class GenericInlineModelAdminTest(TestCase):
|
|
urls = "generic_inline_admin.urls"
|
|
|
|
def setUp(self):
|
|
self.site = AdminSite()
|
|
|
|
def test_get_formset_kwargs(self):
|
|
media_inline = MediaInline(Media, AdminSite())
|
|
|
|
# Create a formset with default arguments
|
|
formset = media_inline.get_formset(request)
|
|
self.assertEqual(formset.max_num, DEFAULT_MAX_NUM)
|
|
self.assertEqual(formset.can_order, False)
|
|
|
|
# Create a formset with custom keyword arguments
|
|
formset = media_inline.get_formset(request, max_num=100, can_order=True)
|
|
self.assertEqual(formset.max_num, 100)
|
|
self.assertEqual(formset.can_order, True)
|
|
|
|
def test_custom_form_meta_exclude_with_readonly(self):
|
|
"""
|
|
Ensure that the custom ModelForm's `Meta.exclude` is respected when
|
|
used in conjunction with `GenericInlineModelAdmin.readonly_fields`
|
|
and when no `ModelAdmin.exclude` is defined.
|
|
"""
|
|
class MediaForm(ModelForm):
|
|
|
|
class Meta:
|
|
model = Media
|
|
exclude = ['url']
|
|
|
|
class MediaInline(GenericTabularInline):
|
|
readonly_fields = ['description']
|
|
form = MediaForm
|
|
model = Media
|
|
|
|
class EpisodeAdmin(admin.ModelAdmin):
|
|
inlines = [
|
|
MediaInline
|
|
]
|
|
|
|
ma = EpisodeAdmin(Episode, self.site)
|
|
self.assertEqual(
|
|
list(list(ma.get_formsets_with_inlines(request))[0][0]().forms[0].fields),
|
|
['keywords', 'id', 'DELETE'])
|
|
|
|
def test_custom_form_meta_exclude(self):
|
|
"""
|
|
Ensure that the custom ModelForm's `Meta.exclude` is respected by
|
|
`GenericInlineModelAdmin.get_formset`, and overridden if
|
|
`ModelAdmin.exclude` or `GenericInlineModelAdmin.exclude` are defined.
|
|
Refs #15907.
|
|
"""
|
|
# First with `GenericInlineModelAdmin` -----------------
|
|
|
|
class MediaForm(ModelForm):
|
|
|
|
class Meta:
|
|
model = Media
|
|
exclude = ['url']
|
|
|
|
class MediaInline(GenericTabularInline):
|
|
exclude = ['description']
|
|
form = MediaForm
|
|
model = Media
|
|
|
|
class EpisodeAdmin(admin.ModelAdmin):
|
|
inlines = [
|
|
MediaInline
|
|
]
|
|
|
|
ma = EpisodeAdmin(Episode, self.site)
|
|
self.assertEqual(
|
|
list(list(ma.get_formsets_with_inlines(request))[0][0]().forms[0].fields),
|
|
['url', 'keywords', 'id', 'DELETE'])
|
|
|
|
# Then, only with `ModelForm` -----------------
|
|
|
|
class MediaInline(GenericTabularInline):
|
|
form = MediaForm
|
|
model = Media
|
|
|
|
class EpisodeAdmin(admin.ModelAdmin):
|
|
inlines = [
|
|
MediaInline
|
|
]
|
|
|
|
ma = EpisodeAdmin(Episode, self.site)
|
|
self.assertEqual(
|
|
list(list(ma.get_formsets_with_inlines(request))[0][0]().forms[0].fields),
|
|
['description', 'keywords', 'id', 'DELETE'])
|
|
|
|
def test_get_fieldsets(self):
|
|
# Test that get_fieldsets is called when figuring out form fields.
|
|
# Refs #18681.
|
|
class MediaForm(ModelForm):
|
|
class Meta:
|
|
model = Media
|
|
fields = '__all__'
|
|
|
|
class MediaInline(GenericTabularInline):
|
|
form = MediaForm
|
|
model = Media
|
|
can_delete = False
|
|
|
|
def get_fieldsets(self, request, obj=None):
|
|
return [(None, {'fields': ['url', 'description']})]
|
|
|
|
ma = MediaInline(Media, self.site)
|
|
form = ma.get_formset(None).form
|
|
self.assertEqual(form._meta.fields, ['url', 'description'])
|
|
|
|
def test_get_formsets_with_inlines(self):
|
|
"""
|
|
get_formsets() triggers a deprecation warning when get_formsets is
|
|
overridden.
|
|
"""
|
|
class MediaForm(ModelForm):
|
|
class Meta:
|
|
model = Media
|
|
exclude = ['url']
|
|
|
|
class MediaInline(GenericTabularInline):
|
|
exclude = ['description']
|
|
form = MediaForm
|
|
model = Media
|
|
|
|
class EpisodeAdmin(admin.ModelAdmin):
|
|
inlines = [
|
|
MediaInline
|
|
]
|
|
|
|
def get_formsets(self, request, obj=None):
|
|
return []
|
|
|
|
with warnings.catch_warnings(record=True) as w:
|
|
warnings.simplefilter("always")
|
|
ma = EpisodeAdmin(Episode, self.site)
|
|
list(ma.get_formsets_with_inlines(request))
|
|
# Verify that the deprecation warning was triggered when get_formsets was called
|
|
# This verifies that we called that method.
|
|
self.assertEqual(len(w), 1)
|
|
self.assertTrue(issubclass(w[0].category, PendingDeprecationWarning))
|
|
|
|
class EpisodeAdmin(admin.ModelAdmin):
|
|
inlines = [
|
|
MediaInline
|
|
]
|
|
with warnings.catch_warnings(record=True) as w:
|
|
warnings.simplefilter("always")
|
|
ma = EpisodeAdmin(Episode, self.site)
|
|
list(ma.get_formsets_with_inlines(request))
|
|
self.assertEqual(len(w), 0)
|
|
|
|
def test_get_formsets_with_inlines_returns_tuples(self):
|
|
"""
|
|
Ensure that get_formsets_with_inlines() returns the correct tuples.
|
|
"""
|
|
class MediaForm(ModelForm):
|
|
class Meta:
|
|
model = Media
|
|
exclude = ['url']
|
|
|
|
class MediaInline(GenericTabularInline):
|
|
form = MediaForm
|
|
model = Media
|
|
|
|
class AlternateInline(GenericTabularInline):
|
|
form = MediaForm
|
|
model = Media
|
|
|
|
class EpisodeAdmin(admin.ModelAdmin):
|
|
inlines = [
|
|
AlternateInline, MediaInline
|
|
]
|
|
ma = EpisodeAdmin(Episode, self.site)
|
|
inlines = ma.get_inline_instances(request)
|
|
for (formset, inline), other_inline in zip(ma.get_formsets_with_inlines(request), inlines):
|
|
self.assertIsInstance(formset, other_inline.get_formset(request).__class__)
|
|
|
|
class EpisodeAdmin(admin.ModelAdmin):
|
|
inlines = [
|
|
AlternateInline, MediaInline
|
|
]
|
|
|
|
def get_formsets(self, request, obj=None):
|
|
# Catch the deprecation warning to force the usage of get_formsets
|
|
with warnings.catch_warnings(record=True):
|
|
warnings.simplefilter("always")
|
|
return super(EpisodeAdmin, self).get_formsets(request, obj)
|
|
|
|
ma = EpisodeAdmin(Episode, self.site)
|
|
inlines = ma.get_inline_instances(request)
|
|
with warnings.catch_warnings(record=True):
|
|
warnings.simplefilter("always")
|
|
for (formset, inline), other_inline in zip(ma.get_formsets_with_inlines(request), inlines):
|
|
self.assertIsInstance(formset, other_inline.get_formset(request).__class__)
|