mirror of
https://github.com/django/django.git
synced 2025-10-31 09:41:08 +00:00
b64b1b2e1a
Previously, this test could modify global state by changing connection.settings_dict. This dict is a reference to the same dict as django.db.connections.databases['default'], which is thus also changed. The cleanup of this test would replace connection.settings_dic` with a saved copy, which would leave the dict itself modified. Additionally, create_test_db() would also modify these same dicts, as well as settings.databases['default']['NAME'] by adding a "test_" prefix, which is what can cause problems later. This patch: - makes a complete copy of the connection and work on that, to improve isolation. - calls destroy_test_db() to let that code clean up anything done by create_test_db().
76 lines
3.3 KiB
Python
76 lines
3.3 KiB
Python
import copy
|
|
from unittest import mock
|
|
|
|
from django.db import DEFAULT_DB_ALIAS, connection, connections
|
|
from django.db.backends.base.creation import (
|
|
TEST_DATABASE_PREFIX, BaseDatabaseCreation,
|
|
)
|
|
from django.test import SimpleTestCase
|
|
|
|
|
|
def get_connection_copy():
|
|
# Get a copy of the default connection. (Can't use django.db.connection
|
|
# because it'll modify the default connection itself.)
|
|
test_connection = copy.copy(connections[DEFAULT_DB_ALIAS])
|
|
test_connection.settings_dict = copy.deepcopy(
|
|
connections[DEFAULT_DB_ALIAS].settings_dict
|
|
)
|
|
return test_connection
|
|
|
|
|
|
class TestDbSignatureTests(SimpleTestCase):
|
|
def test_default_name(self):
|
|
# A test db name isn't set.
|
|
prod_name = 'hodor'
|
|
test_connection = get_connection_copy()
|
|
test_connection.settings_dict['NAME'] = prod_name
|
|
test_connection.settings_dict['TEST'] = {'NAME': None}
|
|
signature = BaseDatabaseCreation(test_connection).test_db_signature()
|
|
self.assertEqual(signature[3], TEST_DATABASE_PREFIX + prod_name)
|
|
|
|
def test_custom_test_name(self):
|
|
# A regular test db name is set.
|
|
test_name = 'hodor'
|
|
test_connection = get_connection_copy()
|
|
test_connection.settings_dict['TEST'] = {'NAME': test_name}
|
|
signature = BaseDatabaseCreation(test_connection).test_db_signature()
|
|
self.assertEqual(signature[3], test_name)
|
|
|
|
def test_custom_test_name_with_test_prefix(self):
|
|
# A test db name prefixed with TEST_DATABASE_PREFIX is set.
|
|
test_name = TEST_DATABASE_PREFIX + 'hodor'
|
|
test_connection = get_connection_copy()
|
|
test_connection.settings_dict['TEST'] = {'NAME': test_name}
|
|
signature = BaseDatabaseCreation(test_connection).test_db_signature()
|
|
self.assertEqual(signature[3], test_name)
|
|
|
|
|
|
@mock.patch.object(connection, 'ensure_connection')
|
|
@mock.patch('django.core.management.commands.migrate.Command.handle', return_value=None)
|
|
class TestDbCreationTests(SimpleTestCase):
|
|
def test_migrate_test_setting_false(self, mocked_migrate, mocked_ensure_connection):
|
|
test_connection = get_connection_copy()
|
|
test_connection.settings_dict['TEST']['MIGRATE'] = False
|
|
creation = test_connection.creation_class(test_connection)
|
|
old_database_name = test_connection.settings_dict['NAME']
|
|
try:
|
|
with mock.patch.object(creation, '_create_test_db'):
|
|
creation.create_test_db(verbosity=0, autoclobber=True, serialize=False)
|
|
mocked_migrate.assert_not_called()
|
|
finally:
|
|
with mock.patch.object(creation, '_destroy_test_db'):
|
|
creation.destroy_test_db(old_database_name, verbosity=0)
|
|
|
|
def test_migrate_test_setting_true(self, mocked_migrate, mocked_ensure_connection):
|
|
test_connection = get_connection_copy()
|
|
test_connection.settings_dict['TEST']['MIGRATE'] = True
|
|
creation = test_connection.creation_class(test_connection)
|
|
old_database_name = test_connection.settings_dict['NAME']
|
|
try:
|
|
with mock.patch.object(creation, '_create_test_db'):
|
|
creation.create_test_db(verbosity=0, autoclobber=True, serialize=False)
|
|
mocked_migrate.assert_called_once()
|
|
finally:
|
|
with mock.patch.object(creation, '_destroy_test_db'):
|
|
creation.destroy_test_db(old_database_name, verbosity=0)
|