This work allows to test three types of postgis Docker images to cover
a wider spectrum of geo libraries versions:
* `latest` (recommended upstream): uses latest stable Debian packages.
These versions are generally conservative, so they may lag behind.
* `alpine`: build PostGIS from source on Alpine, and ship newer
geospatial libs.
* `master`: provides development versions, therefore coverage for what's
coming. Future compatibility issues can be caught in advance.
This split is important because each image differs significantly in
GEOS/PROJ/GDAL versions, so testing all increases confidence in
compatibility. More info at https://hub.docker.com/r/postgis/postgis/.
For example, at the time of this branch:
* latest stable in debian:
* POSTGIS="3.5.2 dea6d0a"
* GEOS="3.9.0-CAPI-1.16.2"
* PROJ="7.2.1"
* latest stable in alpine:
* POSTGIS="3.5.3 0"
* GEOS="3.13.1-CAPI-1.19.2"
* PROJ="9.6.0
* latest development branch:
* POSTGIS="3.6.0dev 3.6.0beta1-29-g7c8cfe07d"
* GEOS="3.14.0beta2-CAPI-1.20.1"
* PROJ="9.7.0"
The `check` docs target now runs spelling, black, and lint, so all
current documentation quality checks can be run with a single command.
Also documented the lint-docs check's availability and usage.
The `pull_request` trigger runs in the context of the PR, and has
limited access to information stored in the base repo django/django.
As access is needed to the label "no ticket" in django/django, use the
`pull_request_target` trigger.
GitHub pull request descriptions are rendered as a comment. Comment
titles, which include the PR author, render in a h3. Hence, titles
within the comment body should be header level 4. This makes pull
request descriptions more accessible to screen readers.
Added a top-level directory in the zip archive that is the commit
hash which makes it easier when downloading multiple artifacts
for comparison. Updated the filenames of screenshots for easier
comparison between different cases. Added that an error is
raised if no screenshots uploaded in workflow.
Running `oxipng` over a set of screenshots from a previous run that were
1.9M in size resulted in a total size of 1.3M, a 31.5% reduction.
This can be useful to reduce the artifact size stored in GitHub and
locally if downloading screenshots from multiple runs.
See https://til.simonwillison.net/github-actions/oxipng
The id was used when we attempted to update comments in an early
version of the feature. Also removed the job summary as it
doesn't have the value that it did in the original version of
the feature.
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Co-authored-by: Paolo Melchiorre <paolo@melchiorre.org>
Co-authored-by: Adam Johnson <me@adamj.eu>
The original event trigger pull_request_target runs against the target branch (main), not the branch associated with the PR. Consequently, any new screenshots added in a PR are not captured, and the available screenshots reflect the state of the main branch code, not the code from the PR's branch.
This update addresses the issue by changing the event trigger to pull_request. However, it's important to note that this adjustment breaks the comments functionality since the action no longer has write permissions.
