1
0
mirror of https://github.com/django/django.git synced 2025-03-06 15:32:33 +00:00

33318 Commits

Author SHA1 Message Date
Simon Charette
76a0b6aa3a Refs #36050 -- Fixed OuterRef support for CompositePrimaryKey on Oracle.
Oracle doesn't support native tuple comparison so each as_oracle implementation
of tuple lookups must also perform right-hand-side sanitization.
2025-01-13 11:14:01 +01:00
Simon Charette
9e55201555 Fixed #36086 -- Fixed crash when using GeneratedField with non-AutoField pk.
The previous logic was systematically attempting to retrieve last_insert_id
even for models without an AutoField primary key when they had a GeneratedField
on backends that can't return columns from INSERT.

The issue affected MySQL, SQLite < 3.35, and Oracle when the use_returning_into
option was disabled and could result in either crashes when the non-auto
primary key wasn't an IntegerField subclass or silent misassignment of bogus
insert ids (0 or the previous auto primary key insert value) to the first
defined generated field value.
2025-01-13 11:13:29 +01:00
Simon Charette
20eb4bca7d Refs #373 -- Adjusted test allowing AutoField in composite primary keys.
This is not a properly supported feature yet and should be revisited by
refs #35957.
2025-01-13 11:13:29 +01:00
Simon Charette
bfcb34076e Refs #373 -- Removed unused composite pk code in SQLInsertCompiler.
This logic could only be exercised if the composite primary key included an
AutoField but it's not allowed yet (refs #35957).

It was also slightly broken as it expected the AutoField to always be the first
member of returning_fields.
2025-01-13 11:13:29 +01:00
Bendeguz Csirmaz
8bee7fa45c Fixed #36050 -- Added OuterRef support to CompositePrimaryKey. 2025-01-10 14:38:09 +01:00
antoliny0919
97ee8b82c2 Fixed #36032 -- Rendered URLField values as links in the admin. 2025-01-10 12:57:53 +01:00
Bendeguz Csirmaz
5851605863 Fixed #36064 -- Skipped an UPDATE when adding a model instance with a composite primary key with default values. 2025-01-10 11:43:38 +01:00
Bendeguz Csirmaz
8287fd4915 Refs #36064 -- Added test that falsey primary key default/db_default value skips an update query on save.
This adds test coverage for logic change in 9fa4d07ce0729850661a31a6b37c6b48f13d2266.
2025-01-10 11:43:38 +01:00
Simon Charette
9fa4d07ce0 Refs #36064 -- Added Model.has_db_default() to encapsulate NOT_PROVIDED checks.
This avoids many awkward checks against NOT_PROVIDED and provides symmetry
with Field.has_default() which is also the reason why it wasn't made a
property.
2025-01-10 08:31:15 +01:00
Jacob Walls
0fb51ec5a0 Fixed #36068 -- Raised ValueError when providing a composite PK field to bulk_create() update_fields. 2025-01-10 08:23:39 +01:00
Simon Charette
af6336f2c8 Fixed #36074 -- Excluded composite primary key fields on save() updates. 2025-01-09 17:38:42 +01:00
Salvo Polizzi
fc28550fe4
Fixed #35515 -- Added automatic model imports to shell management command.
Thanks to Bhuvnesh Sharma and Adam Johnson for mentoring this Google
Summer of Code 2024 project. Thanks to Sarah Boyce, David Smith, Jacob
Walls and Natalia Bidart for reviews.
2025-01-09 13:00:29 -03:00
Brock
8c118c0e00 Fixed #35940 -- Disabled SelectFilter add/remove buttons when appropriate. 2025-01-09 08:18:29 +01:00
antoliny0919
a9c79b4629 Fixed #36063 -- Made a FileField navigate to the object admin change page when in list_display_links. 2025-01-08 16:32:40 +01:00
Sarah Boyce
6a1a9c0ead Fixed #36062 -- Handled serialization of CompositePrimaryKeys. 2025-01-08 14:52:59 +01:00
Sarah Boyce
15e207ce80 Fixed #35999 -- Removed #django IRC channel references where appropriate.
Some references are replaced with links to the Django Discord server.
2025-01-08 10:24:52 +01:00
Carlton Gibson
007f143659 Strengthened wording on supported Python versions in FAQ. 2025-01-08 10:21:55 +01:00
Simon Charette
42e8f264ce Fixed #36065 -- Fixed ordering by expression referencing composite primary key.
Thanks Jacob Walls for the report and test and Csirmaz Bendegúz for the review.
2025-01-08 10:20:48 +01:00
Simon Charette
7617d5be94 Refs #36065 -- Extracted composite primary key order by tests. 2025-01-08 10:20:48 +01:00
Chaitanya Rahalkar
c068f000be Fixed #36014 -- Supported international domains in EmailValidator. 2025-01-08 10:20:11 +01:00
Natalia
53e21eebf2 Added stub release notes and release date for 5.1.5, 5.0.11, and 4.2.18. 2025-01-07 12:28:39 -03:00
Clifford Gama
095f5db060
Fixed typo in tutorial 5. 2025-01-07 10:47:56 -03:00
Jacob Walls
470e5545e5 Refs #36042 -- Raised ValueError when providing composite expressions to aggregates. 2025-01-07 11:42:06 +01:00
Jacob Walls
6eec703667 Fixed #36042 -- Raised ValueError when using CompositePrimaryKey as rhs. 2025-01-07 11:42:06 +01:00
Alex Vandiver
8914b571eb Fixed #36023 -- Handled controls chars in content_disposition_header.
To use the simple `filename="..."` form, the value must conform to the
official grammar from RFC6266[^1]:

    filename-parm       = "filename" "=" value
    value               = <value, defined in [RFC2616], Section 3.6>
                        ; token | quoted-string

The `quoted-string` definition comes from RFC 9110[^2]:

```
    quoted-string  = DQUOTE *( qdtext / quoted-pair ) DQUOTE
    qdtext         = HTAB / SP / %x21 / %x23-5B / %x5D-7E / obs-text

The backslash octet ("\") can be used as a single-octet quoting
mechanism within quoted-string and comment constructs. Recipients that
process the value of a quoted-string MUST handle a quoted-pair as if
it were replaced by the octet following the backslash.

    quoted-pair    = "\" ( HTAB / SP / VCHAR / obs-text )

A sender SHOULD NOT generate a quoted-pair in a quoted-string except
where necessary to quote DQUOTE and backslash octets occurring within
that string.
```

That is, quoted strings are able to express horizontal tabs, space
characters, and everything in the range from 0x21 to 0x7e, expect for
0x22 (`"`) and 0x5C (`\`), which can still be expressed but must be
escaped with their own `\`.

We ignore the case of `obs-text`, which is defined as the range
0x80-0xFF, since its presence is there for permissive parsing of
accidental high-bit characters, and it should not be generated by
conforming implementations.

Transform this character range into a regex and apply it in addition
to the "is ASCII" check.  This ensures that all simple filenames are
expressed in the simple format, and that all filenames with newlines
and other control characters are properly expressed with the
percent-encoded `filename*=...`form.

[^1]: https://datatracker.ietf.org/doc/html/rfc6266#section-4.1
[^2]: https://datatracker.ietf.org/doc/html/rfc9110#name-quoted-strings
2025-01-07 09:22:09 +01:00
John Parton
40d5516385 Fixed #35718 -- Add JSONArray to django.db.models.functions.
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2025-01-06 10:08:32 +01:00
Chris Muthig
d734f1651c Refs #35444 -- Deprecated contrib.postgres aggregates ordering for order_by.
Aligns the argument with SQL standards already used in Window.order_by and
sets up for adding support to Aggregate.
2025-01-06 09:39:21 +01:00
Jacob Walls
46b3e7dd8c Fixed #36048 -- Preferred ValueError to NotSupportedError for composite pk sanity checks.
These checks are not backend-dependent.
2025-01-06 09:33:27 +01:00
Adam Johnson
51df0dff3c
Fixed #36057 -- Enabled test runner to debug chained exceptions with --pdb on Python 3.13+. 2025-01-04 00:30:40 -03:00
Adam Johnson
ec0e784f91
Fixed #36056 -- Made OutputWrapper a virtual subclass of TextIOBase.
This fixes the ignored exception in self._out.flush() from
django.core.management.base.OutputWrapper:
`ValueError: I/O operation on closed file.`
2025-01-04 00:29:53 -03:00
Tim Graham
a4d3f2535e Removed stray comment in ArrayField.check(). 2025-01-03 17:10:24 +01:00
Jacob Walls
a8e4fd11ef Fixed #36052 -- Supported CompositePrimaryKey in inspectdb. 2025-01-03 16:28:21 +01:00
Raphael Gaschignard
ddefc3fed1 Fixed #35918 -- Added support for execute_sql to directly return row counts. 2025-01-03 15:07:02 +01:00
Chaitanya Rahalkar
d97cacc2ae Fixed #36026 -- Clarified that View.setup() sets the request, args, kwargs attributes. 2025-01-03 14:11:23 +01:00
YashRaj1506
083e623953 Fixed #35414 -- Used default headers in AsyncRequestFactory. 2025-01-03 08:41:34 +01:00
YashRaj1506
12f4f95405 Fixed #35740 -- Fixed FileFieldStorageTests.test_extended_length_storage when using bcachefs.
PC_NAME_MAX on bcachefs is 512, which was greater than the file field max_length.
2025-01-03 08:40:48 +01:00
Jacob Walls
c3a681659c Fixed #36029 -- Handled implicit exact lookups in condition depth checks for FilteredRelation. 2025-01-03 08:40:13 +01:00
Tim Graham
45dc2aaa2a
Added missing test for QuerySet.delete() when raising EmptyResultSet. 2025-01-02 23:49:49 -03:00
David Smith
987854ba44 Fixed #32819 -- Added aria-describedby to fields with errors. 2025-01-02 16:40:39 +01:00
Harsha Vardhan V
53df2ee7a4
Removed current year from Python license file.
The current year was removed from cpython's license in 91f4908798.
2025-01-02 11:50:14 -03:00
Ari Pollak
ad385ae163 Fixed #36037 -- Fixed default primary key type in docs.
BigAutoField is the default type for primary keys. In models.txt, the linked
anchor shows that the default primary key is a BigAutoField, so it now defers
to that section instead of duplicating an (incorrect) type.
2025-01-02 15:25:59 +01:00
Jacob Walls
82b913cd6c Fixed typo in django/db/models/fields/related_descriptors.py. 2025-01-02 13:12:35 +01:00
Jacob Walls
f14cab28a5 Fixed typo in django/db/models/query.py docstring. 2025-01-02 13:12:35 +01:00
Johannes Maron
989329344a Fixed #35886 -- Added support for object-based form media script assets. 2025-01-02 13:08:13 +01:00
Mariusz Felisiak
b322319f9d Fixed #36034 -- Added system check for ForeignKey/ForeignObject/ManyToManyField to CompositePrimaryKeys. 2025-01-02 13:06:47 +01:00
Jacob Walls
2a61b5f97c Refs #373 -- Errored when providing db_column to CompositePrimaryKey. 2025-01-02 13:03:49 +01:00
David Smith
8d9901c961
Fixed #35891 -- Confirmed support for GDAL 3.10. 2024-12-27 12:21:04 -03:00
Mariusz Felisiak
c534b6c493
Fixed #35991 -- Fixed crash when adding non-nullable field after renaming part of CompositePrimaryKey on SQLite. 2024-12-27 09:55:42 -03:00
Tim Graham
733d3998e2
Refs #373 -- Fixed false failure of test_error_on_comment_pk_conflict.
The test failed with "NOT NULL constraint failed" rather than
"UNIQUE constraint failed: tenant_id, comment_id".
2024-12-26 23:29:04 -03:00
Mariusz Felisiak
fcd9d08379 Refs #35844 -- Fixed OtherModelFormTests.test_prefetch_related_queryset() test on Python 3.14+.
5a23994a3d
2024-12-20 14:18:10 +01:00