ff05de760c
Fixed #29038 -- Removed closing slash from HTML void tags.
2018-01-21 02:09:10 -05:00
59b1aaa5a5
Added a couple tests for collectstatic.
2018-01-15 11:15:14 -05:00
83a36ac49a
Removed unnecessary trailing commas and spaces in various code.
2017-12-28 21:07:29 +01:00
6c0042430e
Fixed #28776 -- Fixed a/an/and typos in docs and comments.
2017-11-06 22:41:03 -05:00
6e4c6281db
Reverted "Fixed #27818 -- Replaced try/except/pass with contextlib.suppress()."
...
This reverts commit 550cb3a365
2017-09-07 08:16:21 -04:00
09b3e46635
Fixed #27796 -- Prevented middleware being loaded twice with runserver
...
Thanks Tim Graham for the review.
2017-08-23 23:05:18 +02:00
a51c4de194
Used assertRaisesMessage() to test Django's error messages.
2017-07-29 19:07:23 -04:00
550cb3a365
Fixed #27818 -- Replaced try/except/pass with contextlib.suppress().
2017-06-28 14:07:55 -04:00
cde31daf88
Sorted imports per isort 4.2.9.
2017-06-01 13:23:48 -04:00
b536dcf656
Fixed #27948 -- Removed incorrect unquote() in static serving views.
2017-03-17 07:55:00 -04:00
8e3f9d3ee2
Fixed #27741 -- Isolated TestCollectionHashedFilesCache in a tmpdir.
2017-02-03 18:49:08 -05:00
8838d4dd49
Refs #23919 -- Replaced kwargs.pop() with keyword-only arguments.
2017-02-01 11:41:56 -05:00
0ec4dc91e0
Fixed #27661 -- Moved FileSystemFinder's ImproperlyConfigured exceptions to system checks.
...
Thanks Simon Charette, Mariusz Felisiak, Tim Graham, and Adam Johnson
for review.
2017-02-01 09:48:24 -05:00
6478e07a62
Refs #23919 -- Replaced tempfile.mkdtemp() with TemporaryDirectory() context manager.
2017-01-26 13:54:16 -05:00
11856ea44e
Refs #27741 -- Fixed staticfiles_tests.test_views when run in isolation.
2017-01-25 13:53:38 -05:00
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
632c4ffd9c
Refs #23919 -- Replaced errno checking with PEP 3151 exceptions.
2017-01-25 10:13:08 -05:00
2366100872
Removed unneeded force_text calls in the test suite
2017-01-24 18:45:54 +01:00
7aba69145d
Refs #23919 -- Removed django.test.mock Python 2 compatibility shim.
2017-01-20 08:17:20 -05:00
4e729feaa6
Refs #23919 -- Removed django.utils._os.upath()/npath()/abspathu() usage.
...
These functions do nothing on Python 3.
2017-01-20 08:01:02 -05:00
5320fa77c3
Refs #23919 -- Removed obsolete contextlib.closing() calls (for Python 2).
2017-01-19 08:50:28 -05:00
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
7b2f2e74ad
Refs #23919 -- Removed six.<various>_types usage
...
Thanks Tim Graham and Simon Charette for the reviews.
2017-01-18 20:18:46 +01:00
c716fe8782
Refs #23919 -- Removed six.PY2/PY3 usage
...
Thanks Tim Graham for the review.
2017-01-18 16:21:28 +01:00
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
53bffe8d03
Fixed #24452 -- Fixed HashedFilesMixin correctness with nested paths.
2017-01-11 09:21:29 -05:00
c85831e4b7
Fixed #27658 -- Prevented collectstatic from overwriting newer files in remote storages.
...
Thanks revimi for the initial patch.
2017-01-04 12:50:31 -05:00
f60d4e704d
Tested collectstatic's deleting of files/symlinks when toggling --link.
2017-01-04 12:49:57 -05:00
bff4abacad
Refs #15035 -- Corrected a bug and improved comments for a staticfiles test.
2017-01-03 19:22:19 -05:00
e233f357bd
Refs #25484 -- Removed incorrect unquoting in {% static %}.
...
Regression in 374e6230ca
2016-12-19 16:18:06 -05:00
374e6230ca
Fixed #25484 -- Made {% static %} render escaped URLs.
2016-12-17 10:03:44 -05:00
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
8c054ed71d
Fixed #27108 -- Displayed collectstatic's delete/overwrite warnings only if some files exist in STATIC_ROOT.
2016-09-02 14:53:18 -04:00
3f2c945257
Added tests for collectstatic interactivity.
2016-09-01 19:46:03 -04:00
08ed3cc6d1
Fixed #26671 -- Made HashedFilesMixin ignore the 'chrome' scheme.
2016-07-12 08:20:39 -04:00
81cdcb66bc
Fixed #26791 -- Replaced LiveServerTestCase port ranges with binding to port 0.
2016-06-23 12:04:05 -04:00
17e661641d
Refs #26666 -- Added ALLOWED_HOSTS validation when running tests.
...
Also used ALLOWED_HOSTS to check for external hosts in assertRedirects().
2016-06-20 11:07:46 -04:00
4f336f6652
Fixed #26747 -- Used more specific assertions in the Django test suite.
2016-06-16 14:19:18 -04:00
359be1c870
Fixed #26691 -- Removed checking for a file's existence before deleting.
...
File operations always raise a ENOENT error when a file doesn't exist.
Checking the file exists before the operation adds a race condition
condition where the file could be removed between operations. As the
operation already raises an error on a missing file, avoid this race and
avoid checking the file exists twice. Instead only check a file exists
by catching the ENOENT error.
2016-05-31 12:03:27 -04:00
f4c2b8e04a
Fixed #20189 -- Allowed customizing staticfiles ignored_patterns list
...
Thanks Tim Graham for the review.
2016-04-22 09:56:06 +02:00
edcecaf0de
Fixed #19670 -- Applied CachedFilesMixin patterns to specific extensions
...
Thanks Simon Meers for the initial patch, and Tim Graham for the review.
2016-03-30 14:34:41 +02:00
859fc64338
Cleaned class inheritances in staticfiles tests
...
Thanks Tim Graham for precious inputs.
2016-03-28 19:46:03 +02:00
28bcff82c5
Fixed #26297 -- Fixed `collectstatic --clear` crash if storage doesn't implement path().
2016-03-17 09:49:57 -04:00
4e2da368db
Cleaned up TestStaticFilePermissions to use call_command().
2016-03-03 21:58:23 +01:00
1ff6e37de4
Fixed #23832 -- Added timezone aware Storage API.
...
New Storage.get_{accessed,created,modified}_time() methods convert the
naive time from now-deprecated {accessed,created_modified}_time()
methods into aware objects in UTC if USE_TZ=True.
2016-02-23 18:51:43 -05:00
7f6fbc906a
Prevented static file corruption when URL fragment contains '..'.
...
When running collectstatic with a hashing static file storage backend,
URLs referencing other files were normalized with posixpath.normpath.
This could corrupt URLs: for example 'a.css#b/../c' became just 'c'.
Normalization seems to be an artifact of the historical implementation.
It contained a home-grown implementation of posixpath.join which relied
on counting occurrences of .. and /, so multiple / had to be collapsed.
The new implementation introduced in the previous commit doesn't suffer
from this issue. So it seems safe to remove the normalization.
There was a test for this normalization behavior but I don't think it's
a good test. Django shouldn't modify CSS that way. If a developer has
rendundant /s, it's mostly an aesthetic issue and it isn't Django's job
to fix it. Conversely, if the user wants a series of /s, perhaps in the
URL fragment, Django shouldn't destroy it.
Refs #26249 .
2016-02-23 19:35:16 +01:00
706b33fef8
Fixed #26249 -- Fixed collectstatic crash for files in STATIC_ROOT referenced by absolute URL.
...
collectstatic crashed when:
* a hashing static file storage backend was used
* a static file referenced another static file located directly in
STATIC_ROOT (not a subdirectory) with an absolute URL (which must
start with STATIC_URL, which cannot be empty)
It seems to me that the current code reimplements relative path joining
and doesn't handle edge cases correctly. I suspect it assumes that
STATIC_URL is of the form r'/[^/]+/'.
Throwing out that code in favor of the posixpath module makes the logic
easier to follow. Handling absolute paths correctly also becomes easier.
2016-02-23 19:34:21 +01:00
269b5f262c
Used call_command return value in staticfiles tests
...
Refs #26190 .
2016-02-23 09:12:12 +01:00
26ad01719d
Refs #26022 -- Replaced six.assertRaisesRegex with assertRaisesMessage as appropriate.
2016-01-29 13:37:33 -05:00
Jon Dufresne
Mads Jensen
Mariusz Felisiak
Дилян Палаузов
Tim Graham
Claude Paroz
David Sanders
Vytis Banaitis
Ling-Xiao Yang
Chillar Anand
Simon Charette
alix-
za
François Freitag
Andrew Nester
Tobias McNulty
Berker Peksag
James Aylett
Aymeric Augustin
Hasan