mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-26 02:56:25 +00:00
Code Issues 25 Releases Wiki Activity
6,287 Commits 28 Branches 426 Tags 667 MiB
e972589f99
Commit Graph

1091 Commits

Author SHA1 Message Date
Karen Tracey
21fa517248 Fixed #9218 -- Simplified the fix from #9039 and added tests to ensure this case doesn't break again (and that the simplification didn't break anything). 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9341 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-11-05 19:47:44 +00:00
Karen Tracey
1515b13d1a Fixed #9418 -- When saving a model form, defer saving of file-type fields until after other fields, so that callable upload_to methods can use data from the other fields. Thanks to Bernd Schlapsi for the report and initial patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9334 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-11-04 19:48:35 +00:00
Brian Rosner
83af0b8ff3 Fixed #9494 -- Ensure the foreign key in an inline formset is always present on the forms. Thanks Fugazi for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9326 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-11-01 22:25:41 +00:00
Brian Rosner
0ea15f5650 Fixed #8882 -- When a foreign key is among the unique_together fields in an inline formset properly handle it. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9297 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-31 22:07:05 +00:00
Brian Rosner
524a44e20b Fixed #9462 -- Set the instance in an inline formset correctly so that None does not get passed through to the queryset. Thanks tobias and copelco for the ticket. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9293 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-28 20:01:03 +00:00
Karen Tracey
2026934600 Fixed #8966 -- Changed is_safe for length_is filter to False, since its return value is a boolean, not a string. 
Thanks Thomas Steinacher and carljm.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9291 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-28 19:00:49 +00:00
Karen Tracey
34acd39e5d Fixed #9039 take 2 -- Modified the new tests added in [9239] so they pass on Oracle. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9288 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-28 16:19:14 +00:00
Karen Tracey
03070a9955 Fixed #7179 -- Changed breadcrumbs on the add page so that a link to the change view is not included when the user doesn't have permission for that view. Also added tests to ensure the link is not there when it shouldn't be, and there when it should be. Thanks for the report & patch alen__ribic. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9276 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-24 19:14:24 +00:00
Malcolm Tredinnick
3b5d975ff6 Fixed #9411 -- Changed the test from r9081 to be more robust across different database backends. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9254 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-24 06:24:04 +00:00
Malcolm Tredinnick
9319dc496c Fixed #9406 -- Ensure that each database column is only represented once in the 
"ORDER BY" clause of an SQL statement.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9251 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-24 06:09:47 +00:00
Malcolm Tredinnick
e3aa9a2828 Fixed #9383 -- Don't open a network connection for sending email if there's 
nothing to send. Saves a bit of time when, for example, processing 500-error
emails with no ADMINs configured. Based on a patch from Jesse Young.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9248 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-24 04:38:43 +00:00
Karen Tracey
30241385d5 Fixed #9252 -- Moved the try/except protecting against incorrect lookup params to where the error is now raised, and added a test for this case. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9245 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-22 23:09:35 +00:00
Karen Tracey
ae43d11838 Fixed #3096 -- Make admin list_filters respect limit_choices_to. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9241 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-21 19:03:21 +00:00
Karen Tracey
49ef21d9ea Fixed #9039 -- Don't perform unique checks on NULL values, since NULL != NULL in SQL. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9239 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-21 14:04:24 +00:00
Jacob Kaplan-Moss
d7c829c98e Yet more file storage testing cleanup for the sake of buildbots; this should be the last of it, I hope. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9226 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-10 22:13:16 +00:00
Jacob Kaplan-Moss
b21ea0a836 More be-nice-to-the-buildbot: be better about cleaning up files created by the cache/session tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9224 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-10 21:41:12 +00:00
Jacob Kaplan-Moss
c185135068 Be nice to buildbots: switched modeltests/files to use a proper isolated directory for file storage 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9222 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-10 20:09:51 +00:00
Ian Kelly
9a72913edd Fixed .distinct() not working with slicing in Oracle, due to the 
row numbers necessarily being distinct.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9221 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-10 17:15:58 +00:00
Karen Tracey
05d695908c Fixed #9053 -- Allowed for sorting of callable and ModelAdmin methods specified in list_display (added in r8352). Previously attempting to sort on the former would raise an exception and the latter simply didn't sort. Also added tests for this function. Thanks rgl and jenan. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9211 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-08 14:47:01 +00:00
Malcolm Tredinnick
7e7a370e20 Fixed #9319 -- Fixed a crash when using the same model field in multiple 
unique_together constraints.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9208 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-08 10:09:44 +00:00
Malcolm Tredinnick
559aca7d78 A queryset that has had ordering removed (order_by()) can have ordering added 
again later (order_by('foo')). Or, at least, it can now. Thanks to Ilya
Novoselov for diagnosing the problem here.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9206 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-08 09:45:27 +00:00
Malcolm Tredinnick
44f228fd61 Fixed #6748 -- When printing the repr() of querysets, don't load or display 
more than 20 objects.

This means that accidentally executing HugeStoryArchive.objects.all() at the
interactive prompt (or in the debug template) won't try to load all 4,233,010
stories into memory and print them out. That would previously cause resource
starvation and other "interesting" crashes.

If you really, really want the previous behaviour (e.g. in a doctest that
prints more than 20 items), display "list(qs)" instead of just "qs".


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9202 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-08 08:38:33 +00:00
Malcolm Tredinnick
268ef594ac Applying a limit to a queryset that already had an upper limit of 0 wasn't 
working properly.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9201 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-08 08:37:35 +00:00
Malcolm Tredinnick
ce770aaecd The tests added in r9184 were altering the test environment in bad ways. Fixed 
this with proper setUp() and tearDown() methods.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9200 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-08 08:36:41 +00:00
Malcolm Tredinnick
70b6c4c015 Fixed #9233 -- Allow date and message-id headers to be passed in manually in 
email messages. Previously we were creating duplicate headers, which was bad.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9197 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-07 12:20:01 +00:00
Malcolm Tredinnick
cd8eeaacf5 Fixed #5888 -- Added methods to the test client to support HEAD, PUT, DELETE 
and OPTIONS support. Thanks Scott Barr and Leah Culver.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9188 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-07 09:23:40 +00:00
Malcolm Tredinnick
30b568226f Fixed #9199 -- We were erroneously only prepending "www" to the domain if we 
also needed to append a slash (when PREPEND_WWW=True).

Based on a patch and tests from gonz. Thanks.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9184 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-07 08:22:50 +00:00
Malcolm Tredinnick
8fb1459b52 Added some better error reporting and path handling when creating template paths. 
We now raise UnicodeDecodeError for non-UTF-8 bytestrings (thanks to Daniel
Pope for diagnosing this was being swallowed by ValueError) and allow UTF-8
bytestrings as template directories.

Refs #8965.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9161 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-06 06:34:54 +00:00
Malcolm Tredinnick
7cec38b076 Fixed #9259 -- Fixed a validation error for Spanish identity card numbers. 
Patch from Marc Garcia.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9129 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-05 05:59:04 +00:00
Malcolm Tredinnick
8524089769 Add internationalisation support to the comment templates. Fixed #8868, #8905 
Thanks to zgoda for a patch that did most of the internationalisation part.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9119 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-05 05:09:21 +00:00
Malcolm Tredinnick
227a93b64f Fixed #8803 -- Allow authenticated users without first_name/last_name values set to post comments. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9118 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-05 05:07:32 +00:00
Malcolm Tredinnick
d343aa3022 Altered a failing url template tag test to work more reliably. 
There's no guarantee about the order in which ambiguous patterns are resolved.
The solution is "don't do that" and avoid ambiguity.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9113 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-05 04:59:55 +00:00
Russell Keith-Magee
a855755711 Fixed #9293: Corrected expected test output for the admin_scripts tests, following the changes to --verbosity in 9110. Thanks to Alex for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9112 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-04 01:16:30 +00:00
Russell Keith-Magee
8d98e70e42 Promoted --verbosity to be a top level option for all management commands. Also added -v as a consistent short form of --verbosity. This is mostly to save Malcolm's poor arthritic fingers. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9110 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-10-02 12:57:13 +00:00
Malcolm Tredinnick
37ee86b7ee Fixed another case of reverse URL resolving that wasn't working. 
This is a similar situation to that fixed in r9087. We weren't merging
multiple levels of include() calls together correctly.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9099 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-30 05:52:35 +00:00
Malcolm Tredinnick
baa960209f Fixed Queryset.dates() in the presence of extra-select columns. 
Any extra(select=...) columns can be ignored in the SQL for dates, since we are
only interested in extracting distinct date values. We were previously
including them by accident and it was generating incorrect SQL.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9091 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-28 04:36:10 +00:00
Malcolm Tredinnick
15b0158e39 Fixed #9038 -- Correctly handle URL patterns with the same name (or view name), 
declared independently and that differ only by argument signatures.

Patch from Russell Keith-Magee.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9087 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-27 06:14:11 +00:00
Malcolm Tredinnick
6c7cf34d69 Fixed #9171 -- Fixed a few places where we were assuming lists instead of 
generic sequences in ModelForm structures. Patch from mrmachine.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9086 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-27 05:57:10 +00:00
Malcolm Tredinnick
922aba3def Fixed a missing variable initialisation deep in the Query bowels. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9081 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-22 00:31:22 +00:00
Malcolm Tredinnick
9931c9e132 Fixed #9125 -- When displaying errors for a form with only hidden fields, make sure the resulting XHTML is correct. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9067 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-18 07:16:08 +00:00
Malcolm Tredinnick
a27ff1c8ae Fixed #8865 -- Improved the robustness of some file path tests. 
Based on a patch from pythonhead@gentoo.org.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9065 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-17 09:32:36 +00:00
Adrian Holovaty
8efeaea9dd Fixed #9073 -- Fixed a unit test that broke after [9002]. Thanks, kratorius 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9046 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-16 05:52:29 +00:00
Malcolm Tredinnick
e47cc781d8 A bug from queryset-refactor days: although the Query class has "group_by" and 
"having" attributes, only the former was included in the resulting SQL, meaning
subclasses had to completely duplicate Query.as_sql() if they were using any
kind of grouping filtering on the results.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@9007 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-11 02:00:27 +00:00
Malcolm Tredinnick
d88688014f Fixed #7588 -- Inherit fields from concrete ancestor classes via abstract base 
classes. Based on a patch from emulbreh.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8932 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-03 18:38:43 +00:00
Malcolm Tredinnick
7bc5db3a88 Changed the tests added in r8898 very slightly so that they don't return 
unintended results. Doctests aren't self-contained yet when run as part of
the full suite. Refs #5624, #8835.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8930 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-03 17:59:09 +00:00
Malcolm Tredinnick
780f239fa7 Fixed #8825 -- Fixed a small error model field setup (on the model class) from 
r8855. Patch from Christofer Bernander. Test based on one from cgrady.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8908 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-03 05:53:50 +00:00
Malcolm Tredinnick
61cc4a1eee Fixed #8819 -- Don't include two copies of extra-select columns in the query. 
This was triggered by r8794, but was, in fact, fairly fragile before then. The
current fix is the correct way we should be doing this.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8898 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-03 03:48:25 +00:00
Malcolm Tredinnick
85ebb91846 Fixed #8669 -- Use a consistent version of create() across the board for 
model/field instance creation. Based on a patch from Richard Davies.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@8884 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-03 00:09:33 +00:00
Jacob Kaplan-Moss
0e5faf225c Security fix. Announcement forthcoming. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8877 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-02 21:10:00 +00:00
Brian Rosner
c1de41f4d2 Fixed #7973 -- Added exclude to BaseModelAdmin to make everything consistent with the form/formset factories. Refs #8071 to make it easier to get at exclude. Thanks julien for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8861 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2008-09-02 17:26:24 +00:00