mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-11-19 07:54:07 +00:00
Code Issues 24 Releases Wiki Activity
12,576 Commits 28 Branches 423 Tags 638 MiB
c1584890b1
Commit Graph

2649 Commits

Author SHA1 Message Date
Simon Meers
10f979fd92 Fixed #18700 -- Added URL reversal for i18n set_language view. 2012-08-04 20:57:12 +10:00
Aymeric Augustin
d01eaf7104 [py3] Removed uses of sys.maxint under Python 3. 
Also fixed #18706: improved exceptions raised by int_to_base36.
 2012-08-03 18:51:28 +02:00
Florian Apolloner
4129201c3e Fixed a security issue in http redirects. Disclosure and new release forthcoming. 2012-07-30 22:01:50 +02:00
Aymeric Augustin
ab6cd1c839 [py3] Updated dict-like data structures for Python 3. 
The keys/items/values methods return iterators in Python 3, and the
iterkeys/items/values methods don't exist in Python 3. The behavior
under Python 2 is unchanged.
 2012-07-25 22:58:48 +02:00
Marc Tamlyn
a875f612e0 Fixed #18634 -- Don't escape variables in the context for startproject/startapp. 
The & symbols which can come up in the secret key were
being escaped to &.
 2012-07-25 22:24:41 +02:00
Florian Apolloner
59d99772f0 Merge pull request #216 from ljosa/ticket_18644 
Fixed #18644 -- Made urlize trim trailing period followed by parenthesis
 2012-07-25 13:22:49 -07:00
Florian Apolloner
82292141a0 Made staticfiles tests independent of test execution order. 2012-07-25 10:00:23 +02:00
Ramiro Morales
f758bdab5e Fixed #18271 -- Changed stage at which TransactionTestCase flushes DB tables. 
Previously, the flush was done before the test case execution and now
it is performed after it.

Other changes to the testing infrastructure include:

* TransactionTestCase now doesn't reset autoincrement sequences either
  (previous behavior can achieved by using `reset_sequences`.)
  With this, no implicit such reset is performed by any of the provided
  TestCase classes.

* New ordering of test cases: All unittest tes cases are run first and
  doctests are run at the end.

THse changes could be backward-incompatible with test cases that relied
on some kind of state being preserved between tests. Please read the
relevant sections of the release notes and testing documentation for
further details.

Thanks Andreas Pelme for the initial patch. Karen Tracey and Anssi
Kääriäinen for the feedback and Anssi for reviewing.

This also fixes #12408.
 2012-07-24 17:24:16 -03:00
Alex Gaynor
38ce709fe4 Added tests for deprecation warnings and fixed the argument order for the warnings. 2012-07-24 07:01:57 -07:00
Aymeric Augustin
a84d79f572 [py3] Added Python 3 compatibility for xrange. 2012-07-22 09:29:56 +02:00
Aymeric Augustin
0d914d08a0 [py3] Updated urllib/urllib2/urlparse imports. 
Lots of functions were moved. Use explicit imports in all cases
to keey it easy to identify where the functions come from.
 2012-07-22 09:29:55 +02:00
Aymeric Augustin
bdca5ea345 [py3] Replaced unicode/str by six.text_type/bytes. 2012-07-22 09:29:54 +02:00
Aymeric Augustin
3cb2457f46 [py3] Replaced basestring by six.string_types. 2012-07-22 09:29:54 +02:00
Aymeric Augustin
cacd845996 [py3] Fixed remaining Python 3 syntax errors. 
django.utils.unittest.* weren't touched -- they're only imported on Python 2.6.
 2012-07-22 09:29:53 +02:00
Aymeric Augustin
56dbe924a6 [py3] Removed longs. 2012-07-22 09:29:53 +02:00
Julien Phalip
01c392623d Fixed #10057 -- Ensured that the 'show_delete' context variable in the admin's change view actually controls the display of the delete button. Thanks to rajeesh for the report, to patcoll for the patch, and to David Gouldin for the test. 2012-07-21 18:10:24 -07:00
Julien Phalip
1af0271d7c Fixed #6170 -- Ensured that a useful exception is raised when a regex is invalid in the URLConf. 
Thanks to abrahamson.j for the report, to guettli for initial work on the patch, and to David Gouldin for the new patch and test.
 2012-07-21 13:30:34 -07:00
Claude Paroz
9ecd978e26 Re-added Windows line ending stripped in previous commit 
Thanks Aymeric Augustin for noticing the issue.
 2012-07-21 15:38:28 +02:00
Claude Paroz
423244bc6b Fixed #4680 -- Improved initial_sql parsing 
In particular, allow the '--' sequence to be present in string
values without being interpreted as comment marker.
Thanks Tim Chase for the report and shaleh for the initial patch.
 2012-07-21 14:24:29 +02:00
Aymeric Augustin
324d48d0a7 Switched to Python 3-compatible octal notation. 2012-07-20 13:28:36 +02:00
Aymeric Augustin
85cd458944 Removed u prefixes on unicode strings. 
They break Python 3.
 2012-07-20 12:29:22 +02:00
Claude Paroz
c54905b359 Fixed #18479 -- Stopped makemessages raising error on gettext warnings 
Thanks Niels Busch for the initial patch.
 2012-07-18 20:43:35 +02:00
Claude Paroz
23f94f0741 Fixed #18561 -- Made HttpResponse.tell() support non-ascii chars 2012-07-17 22:00:54 +02:00
Vebjorn Ljosa
d5012d6371 Fixed #18644 -- Made urlize trim trailing period followed by parenthesis 2012-07-17 12:44:02 -04:00
Anssi Kääriäinen
29132ebdef Fixed #17788 -- Added batch_size argument to qs.bulk_create() 
The qs.bulk_create() method did not work with large batches together
with SQLite3. This commit adds a way to split the bulk into smaller
batches. The default batch size is unlimited except for SQLite3 where
the batch size is limited to 999 SQL parameters per batch.

Thanks to everybody who participated in the discussions at Trac.
 2012-07-17 15:24:41 +03:00
Anssi Kääriäinen
34340517fc Avoid using a column named "date" in tests 
Oracle can have problems with such columns. Fixed #17932 again.
Thanks to Vinay Sajip for the report.
 2012-07-15 12:30:27 +03:00
Alex Gaynor
c57abd3c29 Remove DotExpandedDict, which was undocumented and unused. 2012-07-14 19:04:37 -07:00
Alex Gaynor
8f002867b2 Cleaned up the QueryDict implementation. 
- Use super().
- Don't poke at internals.
- Don't override methods for no reason.
 2012-07-14 14:07:11 -07:00
Claude Paroz
d9db1d3373 Added supplementary check for CUIT number of ar localflavor 
Thanks Kevin Schaul for the initial patch.
 2012-07-09 14:10:54 +02:00
Claude Paroz
1d2982362d Fixed #18537 -- Fixed CUIT calculation in ar localflavor 
Thanks mmoya at 8ksoft.com.ar for the report and Kevin Shaul for the
initial patch.
 2012-07-09 14:10:54 +02:00
Jannis Leidel
1aa0d8ac4d Fixed #18487 -- Made sure that protocol-relative URLs aren't processed by the cached staticfiles storage. Thanks to LukaszBalcerzak for the patch. 2012-07-08 18:25:12 +02:00
Jannis Leidel
3047981517 Fixed #18050 -- Fixed a rather glaring bug in the handling of @import statements when using the cached staticfiles storage. 2012-07-08 18:17:53 +02:00
Jannis Leidel
3727f6d096 Fixed #18430 -- Use the FILE_CHARSET setting when reading from a file during post processing with the cached staticfiles storage. Thanks to Brant Young for initial debugging. 2012-07-08 12:56:49 +02:00
Jannis Leidel
0a68a2994b Fixed #18254 -- Added ability to the static template tags to store the result in a contextt variable. Many thanks to Andrei Antoukh for the initial patch. 2012-07-07 15:30:25 +02:00
Claude Paroz
86eb606b88 Used skipIf decorator to skip image tests when PIL is not available 2012-07-06 11:20:07 +02:00
Luke Plant
b0eee0ba4b Removed various unnecessary instances of mark_safe applied to URLs 
Also fixed some test breakages introduced in last commit
 2012-07-03 22:20:12 +01:00
Luke Plant
bee498f3a2 Added 'format_html' utility for formatting HTML fragments safely 2012-07-03 22:20:12 +01:00
Anssi Kääriäinen
925a6936b9 Stylistic cleanup of Postgres autocommit tests 
Cleaned up tests introduced in f572ee0c65.

Thanks to Claude Paroz for suggesting the changes.
 2012-07-03 10:22:13 +03:00
Julien Phalip
2cd4cf58d3 Fixed #18550 -- Ensured that the admin history view works with escaped primary keys. 
Thanks to josh.oosterman for the report and patch.
 2012-07-01 18:40:50 -07:00
Anssi Kääriäinen
e74787391e Fixed a regression introduced in where.as_sql() refactor 
At least Oracle needs parentheses in negated where conditions, even if
there is only single condition negated. Fixed this by reverting to old
logic in that part of as_sql() and adding a comment about this.

I did not investigate why the parentheses are needed. The original
offending commit was bd283aa844.
 2012-07-01 22:52:35 +03:00
Anssi Kääriäinen
f572ee0c65 Fixed #16047 -- Restore autocommit state correctly on psycopg2 
When the postgresql_psycopg2 backend was used with DB-level autocommit
mode enabled, after entering transaction management and then leaving
it, the isolation level was never set back to autocommit mode.

Thanks brodie for report and working on this issue.
 2012-07-01 19:36:43 +03:00
Anssi Kääriäinen
bd283aa844 Refactored the empty/full result logic in WhereNode.as_sql() 
Made sure the WhereNode.as_sql() handles various EmptyResultSet and
FullResultSet conditions correctly. Also, got rid of the FullResultSet
exception class. It is now represented by '', [] return value in the
as_sql() methods.
 2012-07-01 17:21:34 +03:00
Claude Paroz
deed192dda Removed usage of mimetype kwarg of HttpResponse 
Refs #16519.
 2012-06-30 21:19:07 +02:00
Claude Paroz
47da7b7a9a Fixed #18102 -- Defined min/max_length on French localflavor form fields 
Thanks mothsART for the report and the initial patch.
 2012-06-30 13:18:07 +02:00
Claude Paroz
26cb227cfe Fixed #15197 -- Fixed yaml serialization into HttpResponse 
Thanks fourga38 for the report and hirokiky at gmail.com for the
initial patch.
 2012-06-28 16:29:29 +02:00
Josh Smeaton
fa182e8ae8 Fixed #18465 -- Set date formats correctly on Oracle 
Correctly configure NLS_SESSION_PARAMETERS to format Date and DateTime
on Oracle backend.

Thanks to Josh Smeaton for report & patch.
 2012-06-26 19:39:14 +03:00
Claude Paroz
05d333ba3b Fixed #18515 -- Conditionally regenerated filename in FileField validation 
When a FileField value has been saved, a new validation should not
regenerate a new filename when checking the length. Refs #9893.
 2012-06-26 18:18:44 +02:00
Anssi Kääriäinen
b6c356b7bb Fixed #17485 -- Made defer work with select_related 
This commit tackles a couple of issues. First, in certain cases there
were some mixups if field.attname or field.name should be deferred.
Field.attname is now always used.

Another issue tackled is a case where field is both deferred by
.only(), and selected by select_related. This case is now an error.

A lot of thanks to koniiiik (Michal Petrucha) for the patch, and
to Andrei Antoukh for review.
 2012-06-26 18:08:42 +03:00
Claude Paroz
4b722b31e1 Fixed #16317 -- Fixed dumpdata for self-referencing models and natural keys 
Thanks aldaran for the patch.
 2012-06-24 19:54:56 +02:00
Alex Gaynor
e0fce8706d Switch to using context managers for acquiring and releasing locks. 2012-06-23 08:11:15 -07:00
Dmitry Medvinsky
d4da08375b Fixed #18454 -- Added ability to pass a list of signals to receiver. 
Added ability to use receiver decorator in the following way:

    @receiver([post_save, post_delete], sender=MyModel)
    def signals_receiver(sender, **kwargs):
        ...
 2012-06-23 16:31:16 +02:00
Luke Plant
a54a8bab0c Fixed #17776 - DoesNotExist is not picklable 
Thanks to ambv for the report
 2012-06-22 13:28:15 +01:00
Claude Paroz
f08fa5b555 Removed unneeded u prefixes 2012-06-19 17:37:28 +02:00
Chris Beaven
c57ba67331 Fixed #14502 again -- saner verbatim closing token 
Previously, the closing token for the verbatim tag was specified as the
first argument of the opening token. As pointed out by Jannis, this is
a rather major departure from the core tag standard.

The new method reflects how you can give a specific closing name to
{% block %} tags.
 2012-06-19 10:49:33 +12:00
Claude Paroz
fe873e2765 Fixed #12140 -- Fixed http.urlencode result for empty lists 
Thanks aneil for the report and the initial patch.
 2012-06-14 11:32:40 +02:00
Claude Paroz
a2022dae7f Removed escaping test of query content 
As the content of last_executed_query() is not under Django's control
for most backends, it is useless to test too specific aspects of it.
 2012-06-13 13:37:22 +02:00
Anssi Kääriäinen
86c20e39eb Fixed connection.queries encoding handling on Oracle 
In addition, removed a possibly problematic .filter() call from
backends.test_query_encoding test. It is possible the .filter could
cause collation problems on MySQL, and as it wasn't absolutely needed
for the test it seemed better to get rid of the call.

Refs #18461.
 2012-06-13 14:16:34 +03:00
Claude Paroz
e9ef9776d1 Fixed #18461 -- Ensured that last_executed_query returns Unicode 
Thanks Anssi Kääriäinen for the review.
 2012-06-13 12:04:46 +02:00
Claude Paroz
a7ef802fa4 Added missing encoding prefix in localflavor test 2012-06-12 14:25:51 +02:00
Claude Paroz
35f9c2c07a Cleaned up locale-related encoding issues 2012-06-12 14:23:41 +02:00
Claude Paroz
3dd5d726d1 Fixed #18463 -- Forced type() argument to be a byte string 2012-06-11 22:14:06 +02:00
Claude Paroz
ef906b1632 Removed test of connection features before setting up databases 2012-06-09 17:22:24 +02:00
Claude Paroz
ad47364dd3 Reverted 905e33f, now that DatabaseFeatures does not need confirm 
Connection.features does not need to be confirmed any more, after
commit aa42357, rendering obsolete the workaround when using
TEST_MIRROR (Refs #16885, #17760).
 2012-06-09 17:05:54 +02:00
Claude Paroz
aa423575e7 Fixed #17760 -- Implemented callable database features as cached properties 
This does remove the requirement to call features.confirm() method
before checking the properties.
Thanks cdestiger and Ramiro Morales for their work on the patch.
 2012-06-09 15:59:52 +02:00
Anssi Kääriäinen
484fcd34a4 Fixed #16418 -- Made generic views work with ModelForms 
Generic views assumed any object's _meta will be model Options. This
is not true for ModelForms for example. Took isinstance(obj, Model)
in use instead.
 2012-06-09 01:12:14 +03:00
Aymeric Augustin
23d230f058 Merge pull request #123 from apollo13/ticket18381 
Fixed #18381 -- Stopped escaping object ids

when passing them to the contenttypes.shortcut view.

Thanks apollo13 for the patch and dhepper for the review.
 2012-06-08 01:48:41 -07:00
Daniel Hepper
0ae727beda Fixed #18433 -- Fixed "View on Site" link in inline admin for models with custom PK 2012-06-07 21:08:36 +02:00
Jann Kleen
1a412dda62 Fixed #18432 -- Prevented the ForeignKey field from creating an invalid query when chained. Thanks, Jann Kleen. 2012-06-07 18:49:19 +02:00
Claude Paroz
4a103086d5 Fixed #18269 -- Applied unicode_literals for Python 3 compatibility. 
Thanks Vinay Sajip for the support of his django3 branch and
Jannis Leidel for the review.
 2012-06-07 18:08:47 +02:00
Florian Apolloner
e1643e3535 Don't escape object ids when passing to the contenttypes.shortcut view. 
This commit also changes the string pk to string_pk instead of id, to test
if the admin uses .pk throughout the codebase.
 2012-06-07 17:52:12 +02:00
Claude Paroz
6fd1950a4e Fixed #10200 -- Raised CommandError when errors happen in loaddata. 2012-06-07 10:32:10 +02:00
Aymeric Augustin
4464bbba15 Fixed #14502 -- Added a verbatim template tag. 
Thanks SmileyChris for the patch.
 2012-06-07 09:59:14 +02:00
Julien Phalip
f699641161 Fixed #17138 -- Made the sensitive_variables decorator work with object methods. 2012-06-03 23:44:13 -07:00
Honza Kral
a89034a2d8 Changed FilePathField tests to use it's own directory with test files. 
In previous version it used /django/forms/ which was fragile - for some
users .pyc files were not generated and this tests failed.
 2012-06-03 22:54:34 +02:00
Honza Kral
71d9a2a7fe Unittest2 style assertTrue instead of assert_ 2012-06-03 22:31:49 +02:00
Honza Kral
f823ae3b3e Fixed incorrect assert in test_filepathfield_folders 2012-06-03 21:46:14 +02:00
Claude Paroz
566ac30eb9 Fixed override_settings usage in test_client_regress 2012-06-02 19:50:24 +02:00
Claude Paroz
ade44b8d40 Fixed settings override in mail regression tests 
self.settings_override from test subclasses were overwriting parent
attribute.
 2012-06-02 19:44:15 +02:00
Ramiro Morales
d4648a3446 Removed debugging code added in last commit. 2012-06-01 21:50:06 -03:00
Ramiro Morales
72130385bf Made inspectdb tests deal with a smaller generated models.py file. 
Implemented this by adding a stealth table_name_filter option for the
command.
 2012-06-01 21:46:07 -03:00
Julien Phalip
f6fc83c975 Fixed #18409 -- Made RegexField work with unicode characters. 2012-05-31 11:45:35 -07:00
Claude Paroz
ea4e0aad9e Cleaned up test_client_regress tests 2012-05-31 17:43:21 +02:00
Claude Paroz
4553f51155 Moved test_client_regress tests from models.py to tests.py 2012-05-31 17:21:13 +02:00
Julien Phalip
432339a72c Fixed #18393 -- Prevented blocktrans to crash when a variable name is badly formatted. 2012-05-28 11:03:34 -07:00
Claude Paroz
a535040bfa Used call_command stdout parameter to capture output in staticfiles tests. 2012-05-28 11:55:38 +02:00
Claude Paroz
c3b56c7cdd Used call_command in i18n compilation tests. 
Now that call_command does not raise SystemExit any more, we can
use call_command again for testing compilemessages.
 2012-05-27 23:11:27 +02:00
Claude Paroz
cc4b4d9fd3 Used CommandError in createcachetable command. 
Raising CommandError whenever a management command meets an error
condition is the standard way to handle errors in commands.
 2012-05-27 23:03:21 +02:00
Michael Newman
4423757c0c Fixed #18135 -- Close connection used for db version checking 
On MySQL when checking the server version, a new connection could be
created but never closed. This could result in open connections on
server startup.
 2012-05-27 18:45:08 +03:00
Claude Paroz
7a4233b69c Removed a duplicate test in fixtures_regress. 
test_abort_loaddata_on_error was exactly the same test as
test_empty (error is tested in test_error_message).
 2012-05-26 16:42:28 +02:00
Claude Paroz
edfa95c22f Specified when open should use binary mode. 
Thanks Vinaj Sajip for the help of his django3 branch.
 2012-05-25 20:43:43 +02:00
Aymeric Augustin
e73838b6dd Fixed #17371 -- Made the test client more flexible 
The OPTIONS, PUT and DELETE methods no longer apply arbitrary
data encoding (in the query string or in the request body).
 2012-05-25 19:03:15 +02:00
Anssi Kääriäinen
323b414441 Added tests for nested exclude/negate queries 2012-05-25 14:10:45 +03:00
Anssi Kääriäinen
8c72aa2379 Fixed qs.order_by() join promotion for already existing joins 
When order_by causes new joins to be added to the query, the joins must
be LEFT OUTER joins for nullable relations, otherwise the order_by
could cause the results to be altered. This commit fixes the logic to
only promote new joins, previously all joins in the order_by lookup
path were promoted.

Thanks to Bruno Desthuilliers for spotting this corner case.
 2012-05-24 18:42:06 +03:00
Aymeric Augustin
3b2993ed04 Fixed #18353 -- Inconsistency in date-based CBVs. 2012-05-24 13:02:19 +02:00
Anssi Kääriäinen
0df4593f0e Fixed #18319 -- Added 'supports_sequence_reset' DB feature 
Added a new feature to allow 3rd party backends to skip tests which
test sequence resetting.

Thanks to manfre for report and patch.
 2012-05-22 23:51:05 +03:00
Anssi Kääriäinen
8ee1a664f9 Fixed #18318 -- Changed some tests to be 3rd party DB friendly 
Thanks to manfre for report and patch.
 2012-05-22 23:33:42 +03:00
Anssi Kääriäinen
459c3b67b7 Fixed #18317 -- Removed db specific raw SQL function from tests 
A test in model_fields used LEN() in raw SQL. This function is not
available on some 3rd party backends. I removed this function and
ensured that the test works correctly (breaks pre e9bbdb39de) with
the change.
 2012-05-22 23:16:24 +03:00
Aymeric Augustin
03f86a5adb Fixed #18354 -- Performance issue in CBV. 
Prevented repeating a query twice when the model isn't ordered by
-date_field (in Meta), allow_empty is False and pagination isn't
enabled.
 2012-05-20 13:18:42 +02:00
Claude Paroz
38408f8007 Marked bytestrings with b prefix. Refs #18269 
This is a preparation for unicode literals general usage in
Django (Python 3 compatibility).
 2012-05-19 17:43:34 +02:00
Claude Paroz
45f55a9fcc Fixed broken ES localflavor test after 4774875. 2012-05-18 13:45:42 +02:00