Brandon Adams
d8ee46afff
comment_will_be_sent can cause a 400, not a 403
...
Doc cleanup for django.contrib.comments.signals.comment_will_be_sent
If a receiver returns False, an HttpResponse with status code 400
is returned. A test case already exists confirming this behavior.
Updated docs to reflect reality.
2012-11-16 10:19:54 -05:00
Nicolas Ippolito
17b14d4819
Typo in comments doc
2012-11-12 22:15:41 +01:00
Tim Graham
fea0ca4334
Fixed #12871 - Documented creation of a comment form for authenticated users; thanks shacker for patch.
2012-09-28 17:36:53 -04:00
Tim Graham
837425b425
Fixed #18934 - Removed versionadded/changed annotations for Django 1.3
2012-09-20 19:06:55 -04:00
Aymeric Augustin
e69348b4e7
Avoided mixing dates and datetimes in the examples.
...
Refs #16023 .
2012-09-08 11:00:04 -04:00
Tim Graham
51ee850776
Fixed #9967 - Added a link to a bug that affects contrib.comments redirects.
2012-09-04 16:27:58 -04:00
Claude Paroz
542c20b382
Fixed #18713 -- Fixed custom comment app name in comments docs
...
Thanks Pratyush for the report.
2012-08-04 17:38:18 +02:00
Aymeric Augustin
fb46f243b4
Fixed #18625 -- Removed old-style use of url tag
...
from the documentation.
2012-07-15 11:19:50 +02:00
Aymeric Augustin
c28e700c7e
Removed references to changes made in 1.2.
...
Thanks Florian Apolloner for the patch.
2012-06-07 15:02:35 +02:00
Aymeric Augustin
58346e92fa
Fixed #17572 —— A few grammar errors in the comments framework example page.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17384 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-01-21 15:42:37 +00:00
Luke Plant
d1e5c55258
Fixed many more ReST indentation errors, somehow accidentally missed from [16955]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16983 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-14 00:12:01 +00:00
Luke Plant
c61987d75a
Removed use of non-standard indentation rules in docs, and the custom transform that supported them.
...
Doc writers should be aware that we are now back to normal ReST rules
regarding blockquotes.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16955 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-10 17:32:33 +00:00
Luke Plant
af244e47cc
Fixed a bunch of ReST errors that resulted in interpretation as block quotations
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16954 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-10 15:32:01 +00:00
Ramiro Morales
26b8122087
Fixed #14675 -- Completed removal of from django.conf.urls.default import *
usage.
...
This applies to both our own [test] code and documentation examples. Also:
* Moved the functions and handlers from `django.conf.urls.defaults` up to
`django.conf.urls` deprecating the former module.
* Added documentation for `handler403`.
* Tweaked the URLs topic document a bit.
Thanks to pupeno and cdestigter for their great work contributing patches.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16818 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-11 22:36:16 +00:00
Jannis Leidel
439cbeaa68
Fixed #16031 -- Corrected comments template examples. Thanks, teraom.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16412 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-16 16:34:02 +00:00
Russell Keith-Magee
2d352444b0
Fixed #14176 -- Added forwards compatibility to the legacy syndication feed view. This allows class-based feeds to be deployed using the old-style feed view, as long as the feed requires no arguments (i.e., get_object returns None). Thanks to psychcf for the report, cwhaines for the investigation, and Andrew Godwin for the assist.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@15189 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-01-13 14:51:34 +00:00
Simon Meers
5a7af25c7a
Fixed #12812 -- added warning about cyclic imports in contrib.comments. Thanks to Beetle_B, bjourne and philgyford for the reports, and Russ for the wording.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14810 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-12-04 11:35:22 +00:00
Jannis Leidel
9b7be918ed
Fixed #12325 -- Allows zero values for moderate_after and close_after fields of comment moderators. Thanks, Gabriel Hurley.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14556 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-11-13 18:42:56 +00:00
Russell Keith-Magee
a904e55859
Fixed #11509 -- Modified usage of "Web" to match our style guide in various documentation, comments and code. Thanks to timo and Simon Meers for the work on the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14069 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-09 08:12:50 +00:00
Jacob Kaplan-Moss
728effcfbd
Fixed #14141 : docs now use the :doc: construct for links between documents.
...
Thanks, Ramiro Morales.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@13608 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-08-19 19:27:44 +00:00
Karen Tracey
d69cdc6d70
Fixed #14100 : Corrected spelling error in description of user_email. Thanks tom_simpson.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@13574 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-08-12 10:48:24 +00:00
Jannis Leidel
d033dfd894
Added a few more versionadded directives to the documentation.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12248 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-17 22:29:50 +00:00
Adrian Holovaty
dd167aa91e
Fixed #11976 -- Ended our campaign to add the word 'valdation' to the English language
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12201 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-10 21:51:14 +00:00
Luke Plant
48edb177ed
Fixed #12053 - form examples don't validate according to w3c
...
Thanks to skyl for the report.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12086 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04 21:55:52 +00:00
Jannis Leidel
b9d698e9f2
Fixed #10285 - Added render_comment_list template tag to comments app. Thanks Kyle Fuller for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12082 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04 02:29:12 +00:00
Jannis Leidel
abcf997713
Fixed #11100 - Added get_comment_permalink template tag to comments app to be able to customize the anchor pattern of a comment from the template. Thanks to Idan Gazit for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12080 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04 02:28:09 +00:00
Jannis Leidel
936c99b7c7
Fixed #9819 - Added exemplary documentation for comments app. Thanks for the initial patch, Thejaswi Puthraya.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@12079 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-01-04 02:27:37 +00:00
Luke Plant
53b2c3867b
Fixed #12130 - documented need for csrf_protect on views that don't accept POST
...
Includes:
* proper documentation for csrf_protect
* notes in comments app.
* specific upgrade notes for comments app
Thanks to carljm for report and debugging.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11711 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-11-03 14:40:37 +00:00
Russell Keith-Magee
fc7ef1c86c
Fixed #11831 -- Corrected typo in comments docs. Thanks to gsf for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@11533 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-09-12 22:43:20 +00:00
James Bennett
bed1418034
Add a proper cross-reference to the mention of HttpRequest in the comment moderation docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10786 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-15 02:57:53 +00:00
Jacob Kaplan-Moss
d246401552
Fixed #11113 : fixed a couple of issues that slipped through the cracks when comment moderation was added to django.contrib.comments
.
...
The is a potentially backwards-incompatible change for users already relying on the internals of comment moderaration. To wit:
* The moderation system now listens to the new `comment_will_be_posted`/`comment_was_posted` signals instead of `pre/post_save`. This means that import request-based information is available to moderation as it should be.
* Some experimental code from `django.contrib.comments.moderation` has been removed. It was never intended to be merged into Django, and was completely untested and likely buggy.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10784 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-14 15:20:50 +00:00
Jacob Kaplan-Moss
d08339686b
Fixed #9675 : added note about upgrading the URLconf to the comment upgrade guide.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10746 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-05-12 17:23:43 +00:00
Russell Keith-Magee
565c190611
Fixed #10559 -- Clarified documentation on customization of comments pages. Thanks to Thejaswi Puthraya for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10566 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-16 12:48:16 +00:00
Jacob Kaplan-Moss
f8adf99cdb
Fixed #9268 : pass the "next" param through in the comment preview/post view. Also updated the docs to make this a bit clearer.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10418 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-07 19:28:13 +00:00
Jacob Kaplan-Moss
c6c25adf6d
Fixed a whole bunch of small docs typos, errors, and ommissions.
...
Fixes #8358 , #8396 , #8724 , #9043 , #9128 , #9247 , #9267 , #9267 , #9375 , #9409 , #9414 , #9416 , #9446 , #9454 , #9464 , #9503 , #9518 , #9533 , #9657 , #9658 , #9683 , #9733 , #9771 , #9835 , #9836 , #9837 , #9897 , #9906 , #9912 , #9945 , #9986 , #9992 , #10055 , #10084 , #10091 , #10145 , #10245 , #10257 , #10309 , #10358 , #10359 , #10424 , #10426 , #10508 , #10531 , #10551 , #10635 , #10637 , #10656 , #10658 , #10690 , #10699 , #19528 .
Thanks to all the respective authors of those tickets.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10371 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-04-03 18:30:54 +00:00
Jacob Kaplan-Moss
516051bfd2
A whole lotta documentation fixes: Fixes #8704 , #8826 , #8980 , #9243 , #9343 , #9529 ,
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10303 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-31 23:34:03 +00:00
Jacob Kaplan-Moss
f22418a6be
Oops, added missing file from [10122].
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10123 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-23 21:22:31 +00:00
Jacob Kaplan-Moss
f0560dfdb2
Fixed #9282 : added a generic comment moderation toolkit. See the documentation for details.
...
This began life as (part of) James Bennett's comment-utils app, and was adapted to be part of Django by Thejaswi Puthraya and Jannis Leidel. Thanks, all!
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10122 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-23 21:07:02 +00:00
Jacob Kaplan-Moss
231a7e0419
Fixed #9958 : split the CommentForm
into a set of smaller forms. This for better encapsulation, but also so that it's easier for subclasses to get at the pieces they might need. Thanks to Thejaswi Puthraya.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@10110 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-03-21 13:45:31 +00:00
Jacob Kaplan-Moss
63d85a684a
Fixed #8630 : finished the custom comment app API that was left out of 1.0. This means it's now possible to override any of the models, forms, or views used by the comment app; see the new custom comment app docs for details and an example. Thanks to Thejaswi Puthraya for the original patch, and to carljm for docs and tests.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9890 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-02-23 22:16:26 +00:00
Jacob Kaplan-Moss
ffeb1d0465
Fixed #9346 : fixed comment upgrade SQL in documentation. Thanks, mt.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9732 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-01-12 17:31:40 +00:00
Jacob Kaplan-Moss
3990d00f20
Fixed #9959 : fixed comment documentation example showing how to get a preview.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@9731 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2009-01-12 17:29:01 +00:00
Adrian Holovaty
74f386dba2
Fixed #8979 -- Made a bunch of typo/formatting fixes to the docs. Thanks, ramiro
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8987 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-09-09 01:54:20 +00:00
Jacob Kaplan-Moss
2e7a87c53c
Fixed a typo in comments upgrade guide.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8667 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28 16:27:19 +00:00
Russell Keith-Magee
545cd6d6f0
Fixed #8583 : Modified the migration SQL described in the comments upgrade docs to account for a problem found with freecomments using Postgres. Thanks to rajeshd for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8653 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28 11:43:54 +00:00
Russell Keith-Magee
ab28e72f31
Fixed #8590 : Added clarification that you need to install the new comments system before trying to port data. Thanks to julien for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8652 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-28 11:39:27 +00:00
Jacob Kaplan-Moss
52c3c3a349
Fixed an error in comment upgrade SQL.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8595 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26 19:59:54 +00:00
Jacob Kaplan-Moss
c5cc26ff99
Fixed some Sphinx markup in signals docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8591 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26 19:23:59 +00:00
Jacob Kaplan-Moss
6f29ad31b5
Fixed #8326 : added signals documentation.
...
Thanks to MercuryTide's signal whitepaper from 2006 (http://www.mercurytide.co.uk/whitepapers/django-signals/ ) for inspiration and ideas for organization, and to the folks who got the Signals wiki page together for some of the content.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8590 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26 19:04:52 +00:00
Jacob Kaplan-Moss
c5c61b261e
Fixed #8555 : corrected get_comment_form
tag documentation.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@8581 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2008-08-26 15:23:02 +00:00