7 Commits

Author	SHA1	Message	Date
Anssi Kääriäinen	8d65b6082c	Fixed #20955 -- select_related regression ... In cases where the same connection (from model A to model B along the same field) was needed multiple times in a select_related query, the join setup code mistakenly reused an existing join.	2013-08-22 10:51:07 +03:00
Anssi Kääriäinen	8dc76c4b91	Fixed test failure caused by different NULL ordering between backends	2013-08-20 11:33:44 +03:00
Anssi Kääriäinen	d3f00bd570	Refactored qs.add_q() and utils/tree.py ... The sql/query.py add_q method did a lot of where/having tree hacking to get complex queries to work correctly. The logic was refactored so that it should be simpler to understand. The new logic should also produce leaner WHERE conditions. The changes cascade somewhat, as some other parts of Django (like add_filter() and WhereNode) expect boolean trees in certain format or they fail to work. So to fix the add_q() one must fix utils/tree.py, some things in add_filter(), WhereNode and so on. This commit also fixed add_filter to see negate clauses up the path. A query like .exclude(Q(reversefk__in=a_list)) didn't work similarly to .filter(~Q(reversefk__in=a_list)). The reason for this is that only the immediate parent negate clauses were seen by add_filter, and thus a tree like AND: (NOT AND: (AND: condition)) will not be handled correctly, as there is one intermediary AND node in the tree. The example tree is generated by .exclude(~Q(reversefk__in=a_list)). Still, aggregation lost connectors in OR cases, and F() objects and aggregates in same filter clause caused GROUP BY problems on some databases. Fixed #17600, fixed #13198, fixed #17025, fixed #17000, fixed #11293.	2013-03-13 10:44:49 +02:00
Anssi Kääriäinen	d744c550d5	Fixed #19964 -- Removed relabel_aliases from some structs ... Before there was need to have both .relabel_aliases() and .clone() for many structs. Now there is only relabeled_clone() for those structs where alias is the only mutable attribute.	2013-03-12 21:33:47 +02:00
Loic Bistuer	6983a1a540	Fixed #15363 -- Renamed and normalized to `get_queryset` the methods that return a QuerySet.	2013-03-08 10:11:45 -05:00
Anssi Kääriäinen	06de130dae	Fixed #12823 -- Was already fixed in master, tests added ... Also added a little improvement to sql/query.py to get rid of non-necessary IS NOT NULL check.	2013-02-28 15:05:48 +02:00
Florian Apolloner	89f40e3624	Merged regressiontests and modeltests into the test root.	2013-02-26 14:36:57 +01:00