mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity
25,091 Commits 30 Branches 460 Tags
b40a1d774d6e7dc0a3663a69c3a8a9b8793d31ff
Commit Graph

157 Commits

Author SHA1 Message Date
Simon Charette
b40a1d774d [2.0.x] Fixed #28884 -- Fixed crash on SQLite when renaming a field in a model referenced by a ManyToManyField. 
Introspected database constraints instead of relying on _meta.related_objects
to determine whether or not a table or a column is referenced on rename
operations.

This has the side effect of ignoring both db_constraint=False and virtual
fields such as GenericRelation which aren't backend by database level
constraints and thus shouldn't prevent the rename operations from being
performed in a transaction.

Regression in 095c1aaa89.

Thanks Tim for the additional tests and edits, and Mariusz for the review.

Backport of 9f7772e098 from master
 2017-12-22 16:09:49 -05:00
Simon Charette
31d318d19c [2.0.x] Fixed #28849 -- Fixed referenced table and column rename on SQLite. 
Thanks Ramiro for the input and Tim for the review.

Backport of 095c1aaa89 from master
 2017-12-01 22:15:48 -05:00
Tim Graham
4dc35e126d [2.0.x] Fixed #28305 -- Fixed "Cannot change column 'x': used in a foreign key constraint" crash on MySQL with a sequence of AlterField or RenameField operations. 
Regression in 45ded053b1.

Backport of c3e0adcad8 from master
 2017-12-01 19:09:21 -05:00
Evan Grim
7937cc16f5 Fixed #28386 -- Made operations within non-atomic migrations honor the operation's atomic flag when migrating backwards. 2017-08-10 19:21:14 -04:00
Evan Grim
5893eaddf4 Added missing test for RunPython behavior when unapplying. 2017-08-10 19:19:48 -04:00
Mads Jensen
a51c4de194 Used assertRaisesMessage() to test Django's error messages. 2017-07-29 19:07:23 -04:00
Simon Charette
5cbcb36839 Fixed #28350 -- Fixed UnboundLocalError crash in RenameField with nonexistent field. 
Thanks Tim for the review.
 2017-06-30 12:50:37 -04:00
Jon Dufresne
21046e7773 Fixed #28249 -- Removed unnecessary dict.keys() calls. 
iter(dict) is equivalent to iter(dict.keys()).
 2017-05-27 19:08:46 -04:00
Markus Holtermann
8e352876c3 Refs #22397 -- Removed model in test cleanup 
The test was failing when using --keepdb due to a pre-existing
PonyStables model.

Thanks Florian Apolloner for the report
 2017-05-09 11:15:41 +02:00
Ian Foote
63afe3a2bf Fixed #28043 -- Prevented AddIndex and RemoveIndex from mutating model state. 2017-05-01 09:32:44 -04:00
Simon Charette
cecc079168 Refs #23919 -- Stopped inheriting from object to define new style classes. 2017-01-19 08:39:46 +01:00
Claude Paroz
d7b9aaa366 Refs #23919 -- Removed encoding preambles and future imports 2017-01-18 09:55:19 +01:00
Simon Charette
dc1193085d Made contenttypes and auth apps unavailable when not necessary in tests. 2017-01-13 08:50:03 -05:00
Simon Charette
ecd625e830 Fixed #27310 -- Stopped rendering apps in RenameModel.state_forwards. 
Thanks Tim for the review.
 2016-12-10 10:19:06 -05:00
za
321e94fa41 Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings. 2016-11-10 21:30:21 -05:00
Simon Charette
040bd7c938 Fixed #27279 -- Fixed a migration performance regression related to RenameModel operations. 
Thanks Trac alias mtomiyoshi for the report, Marten Kenbeek for the initial
patch and Tim for the review.
 2016-10-04 08:35:15 -04:00
Tim Graham
a44fc008c4 Fixed #27217 -- Fixed crash in CreateModel optimization with models that use mixins. 
Thanks Simon Charette for review.
 2016-09-28 10:04:52 -04:00
Akshesh
a71724cd04 Refs #26709 -- Added index name to AddIndex.describe(). 2016-08-16 09:11:33 -04:00
Akshesh
6a8372e6ec Fixed #26808 -- Added Meta.indexes for class-based indexes. 
* Added the index name to its deconstruction.
* Added indexes to sqlite3.schema._remake_table() so that indexes
  aren't dropped when _remake_table() is called.

Thanks timgraham & MarkusH for review and advice.
 2016-08-05 18:12:51 -04:00
premanand lakshmanan
5da7e3f7fd Fixed #26114 -- Fixed AlterModelTable.describe() if db_table is None. 2016-07-28 10:33:14 -04:00
Akshesh
fc3ac65735 Refs #26709 -- Checked allow_migrate_model() in Add/RemoveIndex operations. 2016-07-07 10:37:39 -04:00
Akshesh
b1e7d19d4c Refs #26709 -- Required a name for Indexes passed to AddIndex. 
Thanks to Markush for discussions.
 2016-07-07 07:31:23 -04:00
Akshesh
156e2d59cf Fixed #26709 -- Added class-based indexes. 
Added the AddIndex and RemoveIndex operations to use them in migrations.

Thanks markush, mjtamlyn, timgraham, and charettes for review and advice.
 2016-06-27 10:41:01 -04:00
Jon Dufresne
4f336f6652 Fixed #26747 -- Used more specific assertions in the Django test suite. 2016-06-16 14:19:18 -04:00
Vytis Banaitis
f1e408ff40 Fixed #25044 -- Fixed migrations for renaming ManyToManyField's through model. 2016-05-30 10:17:45 -04:00
Simon Charette
f951bb78cb Refs #26521 -- Adjusted CreateModel bases validation to account for mixins. 
Thanks Collin for the report.
 2016-04-28 18:20:48 -04:00
Simon Charette
a877a2f83d Refs #26521 -- Added the duplicated value to CreateModel validation messages. 
Thanks Tim for the suggestion.
 2016-04-27 16:17:22 -04:00
James Robert
417e083e55 Fixed #26521 -- Validated CreateModel bases, fields and managers for duplicates. 2016-04-27 12:43:56 -04:00
Tim Graham
87338198e9 Fixed #26320 -- Deprecated implicit OneToOnField parent_link. 2016-04-22 12:59:41 -04:00
Tim Graham
92053acbb9 Fixed E128 flake8 warnings in tests/. 2016-04-08 10:12:33 -04:00
Markus Holtermann
8b1110ddff Added missing primary keys to some OperationTests 
Thanks Common Code for financing the work on this commit.
 2016-04-03 01:40:46 +02:00
Hasan
26ad01719d Refs #26022 -- Replaced six.assertRaisesRegex with assertRaisesMessage as appropriate. 2016-01-29 13:37:33 -05:00
Simon Charette
729e0b086d Fixed #24109 -- Allowed RunSQL and RunPython operations to be elided. 
Thanks to Markus Holtermann and Tim Graham for their review.
 2016-01-23 14:19:03 -05:00
Alexander Sosnovskiy
2a7ce34600 Fixed #14286 -- Added models.BigAutoField. 2015-12-25 20:01:31 -05:00
Simon Charette
c4e372aaf4 Fixed #25852 -- Made sure AlterModelManager forces a reload of its model state. 
Thanks to Geoffrey Sechter and the Django NYC group for the report and Markus
for the review.
 2015-12-15 12:22:59 -05:00
Shai Berger
c8b3fbe21b Refs #25896 -- Fixed migration test failure on Oracle 
The test creates and deletes a model in the same migration, and the model
had an AutoField. On Oracle, AutoField's are set up using deferred SQL, which
in this case was trying to modify a table after it had dbeen removed.
 2015-12-10 02:12:04 +02:00
Amos Onn
542b7f6c50 Fixed #25896 -- Fixed state bug in SeparateDatabaseAndState.database_backwards(). 2015-12-09 11:06:57 -05:00
Dražen Odobašić
b1e33ceced Fixed #23395 -- Limited line lengths to 119 characters. 2015-09-12 11:40:50 -04:00
Simon Charette
12f91f6ebd Used skipUnlessDBFeature where appropriate. 2015-08-08 11:27:06 -04:00
Flavio Curella
c2e70f0265 Fixed #21127 -- Started deprecation toward requiring on_delete for ForeignKey/OneToOneField 2015-07-27 18:28:13 -04:00
Markus Holtermann
63f9b633f9 Fixed #24725 -- Allowed renaming of target models in ManyToMany relations 
This is a regression caused by introducing rendered migration states in
1aa3e09c20 and the _meta refactoring in fb48eb0581.

Thanks to Danilo Bargen for reporting the issue and Marten Kenbeek and
Tim Graham for triaging the bug and providing the initial test case.
 2015-04-30 13:27:29 +02:00
Claude Paroz
02260ea3f6 Fixed #24595 -- Prevented loss of null info in MySQL field alteration 
Thanks Simon Percivall for the report, and Simon Charette and Tim
Graham for the reviews.
 2015-04-17 10:25:15 +02:00
Anssi Kääriäinen
8f30556329 Renamed Field.rel attribute to remote_field 
Field.rel is now deprecated. Rel objects have now also remote_field
attribute. This means that self == self.remote_field.remote_field.

In addition, made the Rel objects a bit more like Field objects. Still,
marked ManyToManyFields as null=True.
 2015-03-25 08:16:12 -04:00
Matthew Wilkes
ae87ad005f Refs #24354 -- Prevented repointing of relations on superclasses when migrating a subclass's name change 
Forwardport of test and release note from stable/1.7.x
 2015-03-14 15:37:40 -04:00
Shai Berger
f7d34fe741 Fixed #24362: Made test run each migration operation in its own schema editor 
Thanks Tim Graham for pointing out the fix.
 2015-02-18 22:47:15 +02:00
Markus Holtermann
273bc4b667 Refs #24282 -- Added failing test case for assigning models of wrong type to FK 
Thanks Jeff Singer for the test case.
 2015-02-16 19:31:51 +01:00
Tim Graham
0ed7d15563 Sorted imports with isort; refs #23860. 2015-02-06 08:16:28 -05:00
Tim Graham
28db4af80a Fixed #24135 -- Made RenameModel rename many-to-many tables. 
Thanks Simon and Markus for reviews.
 2015-01-15 20:34:33 -05:00
Claude Paroz
68a439a18d Removed supports_binary_field flag as all backends support them 
It was mainly for MySQL on Python 3, but now the current
recommended MySQL driver for Python 3 (mysqlclient) does support
binary fields, it is unneeded. Refs #20377.
 2015-01-11 23:34:47 +01:00
Markus Holtermann
fdc2cc9487 Fixed #24110 -- Rewrote migration unapply to preserve intermediate states 2015-01-10 23:14:15 +01:00