Honza Král
f6a0b7cfe3
Fixed #14407 -- Simplified ManyToManyRawIdWidget.value_from_datadict, Thanks tyrion!
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14283 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 07:14:38 +00:00
Russell Keith-Magee
634d0a92b8
Migrated many-to-one doctests. Thanks to George Sakkis for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14281 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 04:58:59 +00:00
Ramiro Morales
bdaaac1254
Converted queries tests from doctests to unittests.
...
Thanks Russell and Alex for reviews and suggestions.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14279 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 04:07:22 +00:00
Russell Keith-Magee
5fadeb848c
Fixed #14494 -- Cleanup and typo in tutorial 4, introduced by class-based view changes. Thanks to Andrews Medina for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14278 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 04:03:07 +00:00
Gabriel Hurley
3739f89b44
Fixed #7616 -- Added advice on unix socket permissions and umasks to fastcgi deployment documentation. Thanks to Malcolm Tredinnick for the report and advice, and PaulM and cramm for reviewing the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14276 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 00:58:03 +00:00
Gabriel Hurley
7f9da79bac
Fixed #14464 -- Strengthened the admonition regarding documentation versions at the end of the install docs. Thanks to PaulM for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14274 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 00:26:39 +00:00
Russell Keith-Magee
3ecc84a83c
Added a logging call on HTTP 405 for class-based views. This is for consistency with function-based views.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14273 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 00:26:15 +00:00
Ramiro Morales
e1182306fd
Fixed a small typo introduced in r14139.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14272 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 00:14:41 +00:00
Gabriel Hurley
7baee5b953
Fixed #14426 -- Removed "mysite" import statements from examples that might teach people "bad habits" in regards to creating reusable apps.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14270 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-19 00:10:22 +00:00
Russell Keith-Magee
2790cf482d
Fixed #13842 -- Added tests to verify that XViewMiddleware works with class-based views.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14269 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 23:58:06 +00:00
Gabriel Hurley
cb33aa1cc8
Fixed a mistaken link at the top of both class-based-views docs, and a "content" vs. "context" typo in the topic guide. Thanks to SmileyChris and robhudson for the reports.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14268 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 23:26:16 +00:00
Gabriel Hurley
4b828a906a
Fixed three super() calls which used the wrong classes in the examples. Thanks to robhudson for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14267 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 23:11:14 +00:00
Gabriel Hurley
cc9e5213f8
Contains several fixes for docs/ref/class-based-views, as follows:
...
Restored the section headings which duplicate the class directives (removed in [14264]) so that a full table of contents is still generated. Thanks to Jacob for the suggestion.
Fixed a handful of typos, and corrected a method directive that was mistakenly labeled as an attribute.
Expanded method descriptions for SingleObjectMixin to better explain the default behaviors.
Reformatted ProcessFormView docs to be consistent.
Added missing description of MultipleObjectMixin.get_paginate_by.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14266 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 23:09:13 +00:00
Chris Beaven
c498d2f9b4
PEP8 fix for some class-based views examples. Thanks to Peter Baumgartner for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14265 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 22:28:38 +00:00
Alex Gaynor
7083bc5824
Remove duplicate titles in the class based views documentation and reflow the lines.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14264 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 21:39:30 +00:00
Gabriel Hurley
b05b8cf091
Small grammar, consistency, and import fixes for the new class-based-views topic guide.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14263 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 21:08:50 +00:00
Alex Gaynor
26e8e53cf4
Fixed #14490 -- fixed a typo in the docs. Thanks to gremmie for the report and fix.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14262 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 20:29:53 +00:00
Russell Keith-Magee
a6cafffbf7
Fixed #14489 -- Corrected code example in class-based views docs. Thanks to cwhaines for the report. Also includes title capitalization fix, reported by apollo13.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14261 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 16:35:37 +00:00
Russell Keith-Magee
2db34d2307
Fixed an naming problem with r14258. Thanks to Alex for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14260 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 16:08:25 +00:00
Russell Keith-Magee
f657079c70
Fixed #14486 -- Modified the import order for the bundled unittest so that a locally installed unittest2 (which will have more features) will supersede the Python 2.7 native version. Thanks to Michael Foord for the suggestion.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14259 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 16:01:11 +00:00
Russell Keith-Magee
8cb4bf5ef8
Fixed #14487 -- Prevented unittest from leaking into scope via a 'from django.test.testcases import *' import. Thanks to Jannis for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14258 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 15:53:55 +00:00
Russell Keith-Magee
4cd18ee32d
Improvements to examples and markup fixes for class-based view docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14257 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 15:53:31 +00:00
Russell Keith-Magee
2a9551a415
Corrected some Postgres test failures introduced by r14254.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14256 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 15:53:08 +00:00
Alex Gaynor
b514957850
Fixed #14488 -- corrected a typo in the docs. Thanks to Frank Wiles for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14255 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 15:51:18 +00:00
Russell Keith-Magee
0fcb094557
Fixed #6735 -- Added class-based views.
...
This patch is the result of the work of many people, over many years.
To try and thank individuals would inevitably lead to many people
being left out or forgotten -- so rather than try to give a list that
will inevitably be incomplete, I'd like to thank *everybody* who
contributed in any way, big or small, with coding, testing, feedback
and/or documentation over the multi-year process of getting this into
trunk.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14254 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 13:34:47 +00:00
Jannis Leidel
fa2159f85b
Fixed #14479 -- Added initial Punjabi (pa) translation. Thanks, A S Alam.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14253 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 11:23:07 +00:00
Honza Král
31560e31f9
Fixed #13790 -- auto detection of m2m fields to Site. Thanks, gabrielhurley!
...
Tests are placed in the test suite and not the contrib app since they require
models to work
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14251 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 04:56:27 +00:00
Honza Král
c5df329996
Fixed #12074 -- Adding .as_p and as_ul methods to FormSet. Thanks arthurdebert and dpn for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14250 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 04:44:49 +00:00
Honza Král
59952b6f9a
Fixed Indonesion localflavor tests, broken in r14195
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14249 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 04:41:22 +00:00
Alex Gaynor
df2d828d6c
Clarify in the documentation that we occasionally add APIs for newer Python versions. Thanks to Russell, Jannis, and Carl for help with the language.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14248 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-18 01:20:40 +00:00
Jannis Leidel
214dc97bf3
Fixed #13963 -- Use the correct verbose name of a reverse relation field in the admin. Thanks, sfllaw and d0ugal.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14244 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-17 15:17:52 +00:00
Russell Keith-Magee
400125d718
Corrected the skipIfDBFeature and skipUnlessDBFeature decorators to actually *run* the tests they decorate. Thanks to Alex for the report and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14243 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-17 04:26:47 +00:00
Alex Gaynor
cd63ce077d
Corrected a suite of test failures when running under postgres.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14241 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-17 01:49:36 +00:00
Jannis Leidel
d931f43b70
Fixed #14126 -- Fixed an issue with changes to the blocktrans tag introduced in r13967 related to multiple plural forms. Thanks, mark0978, svetlyak40wt and Ramiro.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14239 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-16 20:40:17 +00:00
Jannis Leidel
58e3849ec3
Fixed #14429 -- Updated German translation. Thanks, jnns.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14238 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-16 20:39:56 +00:00
Alex Gaynor
7408f5098b
Converted or_lookups tests from doctests to unittests. We have always been at war with doctests. Thanks to Paul Tax for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14236 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-16 17:00:11 +00:00
Gabriel Hurley
6c902c436e
Fixed #14307 -- Added a new crossref target to model field reference docs and fixed broken relative link in form field reference docs. Thanks to adamv for the report.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14234 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 20:13:22 +00:00
Luke Plant
d81b3aa739
Fixed Python 2.4 incompatibility introduced in [14218]
...
sha_constructor was incorrectly used instead of sha_hmac (which only made a
difference under 2.4).
Thanks to Steffan Kaminski for report and patch.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14233 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 11:11:08 +00:00
Gabriel Hurley
7f5698de1d
Fixed #14307 -- Linked ChoiceField.choices docs to Field.choices docs to explain the formatting options available. Thanks to adamv for the report and Russ for the suggested fix.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14231 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 10:21:46 +00:00
Gabriel Hurley
2197b56f30
Fixed #14376 -- added docs for previously undocumented Brazilian localflavor fields. Thanks to henriquebastos for the report and patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14229 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 09:30:42 +00:00
Alex Gaynor
c20f2f2ac9
Fixed #14473 -- converted the model_package tests from doctests to unitests. We have always been at war with doctests. Thanks to Gabriel Hurley for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14227 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 07:34:23 +00:00
Alex Gaynor
056659c1cf
Fixed #14472 -- converted generic_relations tests from doctests to unitests. We have always been at war with doctests. Thanks to Gabriel Hurley for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14225 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 06:52:35 +00:00
Alex Gaynor
5ee1d5ee31
Fixed some typos in the documentation that snuck in with [14223].
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14224 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 03:15:15 +00:00
Alex Gaynor
5a8e40a03f
Fixed #11350 -- added an Israeli localflavor. Thanks to Yuval and Idan Gazit for their work on the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14223 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 02:58:10 +00:00
Alex Gaynor
2e8bc8f986
Fixed #14454 -- converted admin_widgets tests from doctests to unittests. We have always been at war with doctests. Thanks to prestontimmons for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14221 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 02:35:51 +00:00
Chris Beaven
65b98c9b41
Change the stacklevel for Field deprecation warnings to correctly point to the source of the problem
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14220 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 02:09:11 +00:00
Chris Beaven
dfcb814a87
Fix the version which the safe argument for the urlencode filter was added. Thanks eternicode for pointing this out.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14219 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-15 00:41:37 +00:00
Luke Plant
45c7f427ce
Fixed #14445 - Use HMAC and constant-time comparison functions where needed.
...
All adhoc MAC applications have been updated to use HMAC, using SHA1 to
generate unique keys for each application based on the SECRET_KEY, which is
common practice for this situation. In all cases, backwards compatibility
with existing hashes has been maintained, aiming to phase this out as per
the normal deprecation process. In this way, under most normal
circumstances the old hashes will have expired (e.g. by session expiration
etc.) before they become invalid.
In the case of the messages framework and the cookie backend, which was
already using HMAC, there is the possibility of a backwards incompatibility
if the SECRET_KEY is shorter than the default 50 bytes, but the low
likelihood and low impact meant compatibility code was not worth it.
All known instances where tokens/hashes were compared using simple string
equality, which could potentially open timing based attacks, have also been
fixed using a constant-time comparison function.
There are no known practical attacks against the existing implementations,
so these security improvements will not be backported.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14218 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-14 20:54:30 +00:00
Jannis Leidel
36f2f7ee7c
Fixed #14301 -- Handle email validation gracefully with email addresses containing non-ASCII characters. Thanks, Andi Albrecht.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14216 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-14 18:37:05 +00:00
Gabriel Hurley
767cf955d2
Fixed #5327 -- Added standardized field information to ModelChoiceField and ModelMultipleChoiceField documentation. Thanks to danielrubio for the report and PhiR for the text.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@14214 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2010-10-14 10:03:08 +00:00