Baptiste Mispelon
d8e2333528
Fixed #31077 -- Made debug decorators raise TypeError if they're not called.
...
Django will raise an error if you forget to call the decorator.
2019-12-10 13:34:28 +01:00
Tim Graham
22a7a406c9
Removed hardcoded pk in view_tests.tests.test_defaults.
2019-11-18 08:46:39 +01:00
Hasan Ramezani
4b78546ef1
Fixed #30405 -- Fixed source code mismatch crash in ExceptionReporter.
2019-11-12 11:31:12 +01:00
Jon Dufresne
607004f81a
Simplified consecutive calls to pathlib.Path.parent.
2019-11-04 09:59:34 +01:00
Nick Pope
7552de7866
Used more specific unittest assertions in tests.
...
* assertIsNone()/assertIsNotNone() instead of comparing to None.
* assertLess() for < comparisons.
* assertIs() for 'is' expressions.
* assertIsInstance() for isinstance() expressions.
* rounding of assertAlmostEqual() for round() expressions.
* assertIs(..., True/False) instead of comparing to True/False.
* assertIs()/assertIsNot() for ==/!= comparisons.
* assertNotEqual() for == comparisons.
* assertTrue()/assertFalse() instead of comparing to True/False.
2019-10-29 12:37:30 +01:00
Ngalim Siregar
503f60ff57
Fixed #29008 -- Fixed crash of 404 debug page when URL path converter raises Http404.
2019-08-09 22:48:08 +02:00
Jerrod Martin
c7bef16a74
Fixed #30411 -- Improved formatting of text tracebacks in technical 500 templates.
...
Co-Authored-By: Daniel Hahler <git@thequod.de>
2019-07-29 11:09:54 +02:00
Jon Dufresne
42b9a23267
Fixed #30400 -- Improved typography of user facing strings.
...
Thanks Claude Paroz for assistance with translations.
2019-06-28 16:46:18 +02:00
Tim Gates
698df6a009
Fixed typos in test comments.
2019-06-25 11:12:45 +02:00
Alexandre Varas
c498f088c5
Fixed #30521 -- Fixed invalid HTML in default error pages.
2019-06-07 07:51:45 +02:00
Mariusz Felisiak
3fb0a1a67f
Refs #30521 -- Added tests for content of default error pages.
2019-06-07 07:49:17 +02:00
Daniel Hahler
08a4ee0651
Fixed typos in test names.
2019-04-27 07:47:42 +02:00
Jon Dufresne
8d76443aba
Fixed #30399 -- Changed django.utils.html.escape()/urlize() to use html.escape()/unescape().
2019-04-25 15:09:07 +02:00
Ran Benita
19fc6376ce
Fixed #30304 -- Added support for the HttpOnly, SameSite, and Secure flags on language cookies.
2019-04-08 11:26:06 +02:00
Nick Pope
6b4e57d79f
Refs #30324 -- Forced utf-8 encoding when loading templates for the technical 404 debug and congrats page.
2019-04-05 16:35:01 +02:00
Nick Pope
efb257a017
Fixed #30324 -- Forced utf-8 encoding when loading the template for the technical 500 debug page.
...
Regression in 50b8493
.
Related to ea542a9
.
2019-04-05 16:35:01 +02:00
Claude Paroz
a8e2a9bac6
Refs #15902 -- Deprecated storing user's language in the session.
2019-02-14 10:23:02 -05:00
Vinay Karanam
3634560fa9
Fixed #29393 -- Prevented infinite loop in ExceptionReporter.get_traceback_frames().
2019-02-02 16:39:36 -05:00
Tim Graham
7e6b214ed3
Fixed #30116 -- Dropped support for Python 3.5.
2019-01-30 10:19:48 -05:00
Claude Paroz
16454ac35f
Fixed #29825 -- Fixed JS ngettext if the string is a non-plural msgid in the catalog.
2019-01-28 21:04:36 +01:00
Tim Graham
8045dff98c
Refs #27829 -- Removed settings.DEFAULT_CONTENT_TYPE per deprecation timeline.
2019-01-17 10:50:25 -05:00
Simon Charette
8c775391b7
Refs #28478 -- Deprecated TestCase's allow_database_queries and multi_db in favor of databases.
2019-01-10 19:11:21 -05:00
Tim Graham
0004daa536
Used 4 space hanging indent for dictionaries.
...
Thanks Mariusz Felisiak for auditing.
2019-01-02 18:18:19 -05:00
Tim Graham
043bd70942
Updated test URL patterns to use path() and re_path().
2018-12-31 10:47:32 -05:00
Simon Charette
0f212db29d
Made reused RequestFactory instances class attributes.
2018-11-27 09:49:02 -05:00
Hasan Ramezani
55b0b766fb
Completed test coverage of views.defaults.bad_request().
2018-10-25 20:03:58 -04:00
Hasan Ramezani
6a8b57df6a
Completed test coverage of views.static.directory_name().
2018-10-23 20:44:27 -04:00
Jon Dufresne
99d4fc18bd
Refs #27829 -- Added warning for settings.DEFAULT_CONTENT_TYPE usage outside of Django.
2018-10-15 16:31:39 -04:00
Claude Paroz
2a74ceb5f3
Fixed #24336 -- Made django.conf.urls.static() ignore all absolute URLs
2018-07-24 09:32:33 +02:00
Tim Graham
7cdeb23ae7
Fixed #29511 -- Added charset to JavaScriptCatalog's Content-Type header.
2018-06-22 09:15:29 +02:00
Claude Paroz
523e04dfeb
Captured logging in tests with self.assertLogs().
2018-05-07 09:34:02 -04:00
Claude Paroz
607970f31c
Replaced django.test.utils.patch_logger() with assertLogs().
...
Thanks Tim Graham for the review.
2018-05-07 09:34:00 -04:00
Tim Graham
fa75b2cb51
Refs #27795 -- Removed force_bytes/text() usage in tests.
2018-02-07 14:20:04 -05:00
Claude Paroz
b3cd9fb18b
Refs #15902 -- Made set_language() view always set the current language in a cookie.
...
The plan is to later deprecate/remove storing the language in the session.
2018-01-03 11:25:40 -05:00
Tim Graham
a862af3839
Fixed #28893 -- Removed unnecessary dict.items() calls.
2017-12-06 17:17:59 -05:00
Tim Graham
941b0a5b33
Fixed #28708 -- Added constants to detect the Python version.
2017-10-13 10:11:15 -04:00
Sjoerd Job Postmus
df41b5a05d
Fixed #28593 -- Added a simplified URL routing syntax per DEP 0201.
...
Thanks Aymeric Augustin for shepherding the DEP and patch review.
Thanks Marten Kenbeek and Tim Graham for contributing to the code.
Thanks Tom Christie, Shai Berger, and Tim Graham for the docs.
2017-09-20 18:04:42 -04:00
Tim Graham
46e2b9e059
Fixed CVE-2017-12794 -- Fixed XSS possibility in traceback section of technical 500 debug page.
...
This is a security fix.
2017-09-05 10:58:38 -04:00
Martin von Gagern
71d39571f4
Fixed #28485 -- Made ExceptionReporter.get_traceback_frames() include frames without source code.
2017-08-12 20:32:39 -04:00
Timothy Allen
5fe9b7b40a
Fixed #28457 -- Updated the design of the 'Congrats' page for new Django projects.
...
Developed by Timothy Allen and Chad Whitman of The Wharton School with
shepherding from Aymeric Augustin and Collin Anderson.
2017-08-07 10:33:55 -04:00
Tim Graham
d70432deae
Refs #7697 -- Tested escaping of safe strings in the technical 500 debug view.
...
Tests were omitted in the original commit: a56a226241
.
2017-08-02 15:56:47 -04:00
Tim Graham
293608a2e0
Refs #7697 -- Removed unnecessary force_escape of technical 500 debug view "unicode hint".
...
The test passes before and after the removal. unicode_hint will never
be SafeText, so normal autoescaping is sufficient.
2017-08-02 15:16:22 -04:00
Tim Graham
74b7a20fe6
Refs #5046 -- Tested the 'unicode hint' in the technical 500 debug view.
2017-08-02 15:07:26 -04:00
Flávio Juvenal
0af14b2eaa
Refs #16870 -- Doc'd that CSRF protection requires the Referer header.
2017-06-22 11:50:00 -04:00
Tim Graham
e1cd5a76d7
Cosmetic edits to tests/view_tests/tests/test_csrf.py.
2017-06-22 09:30:40 -04:00
Claude Paroz
23142eea85
Fixed #18394 -- Added error for invalid JavaScriptCatalog packages
...
Thanks Tim Graham for the review.
2017-06-06 18:02:22 +02:00
partizan
ff099f9db8
Fixed #28271 -- Added charset to technical_500_response() AJAX response.
2017-06-05 14:43:40 -04:00
Jon Dufresne
2c69824e5a
Refs #23968 -- Removed unnecessary lists, generators, and tuple calls.
2017-06-01 19:08:59 -04:00
Claude Paroz
2cbb095bec
Fixed #28221 -- Fixed plural fallback translations in JavaScriptCatalog view
...
Thanks Waldemar Kornewald for the report and initial patch.
2017-05-25 22:47:21 +02:00
Claude Paroz
912ef7f49d
Fixed validity of test django_js.po files
2017-05-18 14:33:18 +02:00
Claude Paroz
d842ada305
Refs #27795 -- Stopped converting integer format settings to str in JS/JSON i18n views
...
Thanks Tim Graham for the review.
2017-05-08 19:32:03 +02:00
Claude Paroz
e3a88c7797
Renamed django.views.i18n test cases
2017-05-08 19:29:27 +02:00
Tim Graham
56970c5b61
Fixed #28122 -- Fixed crash when overriding views.static.directory_index()'s template.
2017-04-25 11:01:21 -04:00
Tim Graham
8c6a3062dd
Fixed #28079 -- Restored "No POST data" (rather than an empty table) in HTML debug page.
...
Regression in 7b6dccc82f
2017-04-15 09:21:35 -04:00
Claude Paroz
ea542a9c72
Fixed #28007 -- Moved debug templates to the filesystem
...
Thanks Tim Graham for the review.
2017-04-12 11:36:47 -04:00
Claude Paroz
2eb1f15f62
Tested template info in debug view's text traceback
2017-04-12 10:38:50 -04:00
Tim Graham
a1f948b468
Fixed CVE-2017-7234 -- Fixed open redirect vulnerability in views.static.serve().
...
This is a security fix.
2017-04-04 10:42:06 -04:00
Claude Paroz
4f99ba84b3
Removed unused code in i18n view_tests
...
Unused since 2b20e4148f
.
2017-04-02 19:58:18 +02:00
Tim Graham
b536dcf656
Fixed #27948 -- Removed incorrect unquote() in static serving views.
2017-03-17 07:55:00 -04:00
Tim Graham
75f0070a54
Fixed #27308 -- Fixed BytesWarnings in the test suite.
2017-02-17 16:04:45 -05:00
Tim Graham
80493b0871
Fixed #27829 -- Deprecated settings.DEFAULT_CONTENT_TYPE.
2017-02-16 07:59:44 -05:00
Tim Graham
500532c95d
Refs #23919 -- Removed default 'utf-8' argument for str.encode()/decode().
2017-02-09 09:03:47 -05:00
Claude Paroz
c651331b34
Converted usage of ugettext* functions to their gettext* aliases
...
Thanks Tim Graham for the review.
2017-02-07 09:04:04 +01:00
Tim Graham
2d899ce16b
Refs #23919 -- Removed a Python 2 code path in force_text().
...
Reverted the obsolete fix and tests for refs #12302 .
2017-02-03 19:38:33 -05:00
Tim Graham
29f607927f
Fixed spelling of "nonexistent".
2017-02-03 08:01:45 -05:00
Anton Samarchyan
56ea394dfd
Improved test coverage for conf.urls.static.
2017-01-27 16:12:09 -05:00
chillaranand
d6eaf7c018
Refs #23919 -- Replaced super(ClassName, self) with super().
2017-01-25 12:23:46 -05:00
Claude Paroz
2366100872
Removed unneeded force_text calls in the test suite
2017-01-24 18:45:54 +01:00
Jon Dufresne
0d74c41981
Replaced dict() usage with dict literals.
...
Literals are faster and more idiomatic.
2017-01-23 19:13:49 -05:00
Tim Graham
4e729feaa6
Refs #23919 -- Removed django.utils._os.upath()/npath()/abspathu() usage.
...
These functions do nothing on Python 3.
2017-01-20 08:01:02 -05:00
Simon Charette
cecc079168
Refs #23919 -- Stopped inheriting from object to define new style classes.
2017-01-19 08:39:46 +01:00
Claude Paroz
2b281cc35e
Refs #23919 -- Removed most of remaining six usage
...
Thanks Tim Graham for the review.
2017-01-18 21:33:28 +01:00
Claude Paroz
c716fe8782
Refs #23919 -- Removed six.PY2/PY3 usage
...
Thanks Tim Graham for the review.
2017-01-18 16:21:28 +01:00
Claude Paroz
f3c43ad1fd
Refs #23919 -- Removed python_2_unicode_compatible decorator usage
2017-01-18 13:44:34 +01:00
Claude Paroz
d7b9aaa366
Refs #23919 -- Removed encoding preambles and future imports
2017-01-18 09:55:19 +01:00
Tim Graham
d334f46b7a
Refs #26601 -- Removed support for old-style middleware using settings.MIDDLEWARE_CLASSES.
2017-01-17 20:52:04 -05:00
Tim Graham
2b20e4148f
Refs #19567 -- Removed deprecated javascript_catalog() and json_catalog() views.
2017-01-17 20:52:03 -05:00
Waldemar Kornewald
b24af2f405
Fixed #27418 -- Fixed occasional missing plural forms in JavaScriptCatalog.
2016-12-14 18:20:30 -05:00
Andreas Pelme
373140b07a
Fixed #27567 -- Fixed crash in the debug view when request.user errors.
2016-12-06 12:28:00 -05:00
Ramin Farajpour Cami
967be82443
Fixed E305 flake8 warnings.
2016-11-14 12:30:46 -05:00
za
321e94fa41
Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings.
2016-11-10 21:30:21 -05:00
Jon Dufresne
611d34b0e4
Captured logging output during NonDjangoTemplatesDebugViewTests.test_400().
2016-10-29 15:39:24 -07:00
Mariusz Felisiak
c7f86d3eec
Fixed #27373 -- Corrected 404 debug page message for an empty request path.
2016-10-27 16:58:41 -04:00
Alvin Lindstam
6b5106b1ce
Fixed #27374 -- Made JavaScriptCatalog respect the packages argument.
2016-10-22 19:26:08 -04:00
Tim Graham
16202863fa
Refs #27025 -- Fixed tests for the new ModuleNotFoundError in Python 3.6.
...
http://bugs.python.org/issue15767
2016-09-16 10:24:47 -04:00
Anatoly Burov
7b6dccc82f
Fixed #27191 -- Fixed debug view crash for requests with 'items' in GET/POST/COOKIES/FILES.
2016-09-07 13:47:09 -04:00
Przemysław Suliga
1f68bb5683
Refs #26902 -- Protected against insecure redirects in set_language().
2016-08-19 19:16:00 -04:00
Tim Graham
1e32e1cc95
Fixed #26973 -- Fixed views.static.serve() crash with show_indexes enabled.
2016-08-10 11:27:03 -04:00
Jon Dufresne
348cfccd90
Fixed #26938 -- Fixed invalid HTML in template postmortem on the debug page.
2016-07-24 18:18:57 +02:00
Tim Graham
c9ae09addf
Replaced use of TestCase.fail() with assertRaises().
...
Also removed try/except/fail antipattern that hides exceptions.
2016-06-28 11:21:26 -04:00
Claude Paroz
78963495d0
Refs #17209 -- Added LoginView and LogoutView class-based views
...
Thanks Tim Graham for the review.
2016-06-24 10:45:13 +02:00
Tim Graham
ece4d24f8e
Refs #26601 -- Deprecated old-style middleware.
2016-05-17 07:22:26 -04:00
Florian Apolloner
9baf692a58
Fixed #26601 -- Improved middleware per DEP 0005.
...
Thanks Tim Graham for polishing the patch, updating the tests, and
writing documentation. Thanks Carl Meyer for shepherding the DEP.
2016-05-17 07:22:22 -04:00
Claude Paroz
de40cfbe74
Fixed #19567 -- Added JavaScriptCatalog and JSONCatalog class-based views
...
Thanks Cristiano Coelho and Tim Graham for the reviews.
2016-04-15 17:28:54 +02:00
Miikka Salminen
9e3f141701
Fixed #26466 -- Added HTTP_REFERER decoding to i18n set_language() view.
2016-04-09 10:57:43 -04:00
Tim Graham
92053acbb9
Fixed E128 flake8 warnings in tests/.
2016-04-08 10:12:33 -04:00
Krzysztof Jurewicz
940b7fd5cb
Fixed #21446 -- Allowed not performing redirect in set_language view
...
Thanks Claude Paroz and Tim Graham for polishing the patch.
2016-03-29 22:15:14 +02:00
Akshesh
44c0ecdd92
Fixed #25364 -- Added generic way to test on all browsers supported by selenium.
...
Browser names should be passed as a comma separated list to the --selenium flag.
Thanks Tim Graham, Simon Charette and Moritz Sichert for review and discussion.
2016-03-15 13:10:32 -04:00
Claude Paroz
ecbdedfc69
Refs #26319 -- Added test for English variant in javascript_catalog
2016-03-08 21:39:59 +01:00
Claude Paroz
11c60b5298
Reused the DjangoTranslation class for the javascript_catalog view
...
Thanks Tim Graham and Cristiano Coelho for the reviews.
Refs #26328 , #26319 .
2016-03-08 21:39:59 +01:00