mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-01-04 23:46:09 +00:00
Code Issues 30 Releases Wiki Activity
26,256 Commits 28 Branches 426 Tags 637 MiB
95bda03f2d
Commit Graph

9805 Commits

Author SHA1 Message Date
Simon Charette
ad82900ad9 Fixed #26720 -- Prevented invalid CreateModel optimizations of related fields. 2018-07-11 10:49:50 -04:00
Simon Charette
a97845a823 Fixed #27768 -- Allowed migration optimization of CreateModel order. 
Thanks Ed Morley from Mozilla for the tests.
 2018-07-11 10:49:50 -04:00
Simon Charette
d3a935f01f Refs #27768 -- Reversed order of optimized and in-between operations. 
Operations can only be optimized through if they don't reference any of the
state the operation they are compared against defines or alters, so it's
safe to reverse the order.
 2018-07-11 10:49:50 -04:00
Jon Dufresne
e26b780a24 Silenced warnings in deprecation tests. 2018-07-11 09:10:31 -04:00
Simon Charette
e4c0878b30 Refs #22875 -- Fixed an optimizer test to use a valid scenario. 
An explicit intermediary many-to-many relationship must declare forward and
reverse foreign keys. The original issue was in the autodetector as these
operations shouldn't have been generated in this order in the first place
which is tested by AutodetectorTests.test_create_with_through_model.
 2018-07-10 16:47:57 -04:00
Ian Foote
952f05a6db Fixed #11964 -- Added support for database check constraints. 2018-07-10 15:32:33 -04:00
Jon Dufresne
08ebed5e79 Fixed #29556 -- Made 'remove_stale_contenttypes --noinput' delete content types. 2018-07-10 10:14:34 -04:00
Tim Graham
178624855a Simplified a couple test docstrings. 2018-07-10 09:43:12 -04:00
Jon Dufresne
e7d7d47b93 Fixed ResourceWarning from unclosed test files. 
When running Django tests with Python warnings enabled.
 2018-07-10 12:26:19 +02:00
Sergey Fedoseev
338f741c5e Fixed #29546 -- Deprecated django.utils.timezone.FixedOffset. 2018-07-09 16:33:36 -04:00
Tom Forbes
45c035c823 Refs #29548 -- Fixed non-GIS test failures on MariaDB. 2018-07-09 14:59:42 -04:00
Tim Graham
5bea8d256d
Fixed #29553 -- Made test client set Content-Length header to a string rather than integer. 2018-07-09 11:44:49 -04:00
Sergey Fedoseev
c9088cfc7b Fixed some assertTrue() that were intended to be assertEqual(). 2018-07-09 11:13:40 -04:00
Sergey Fedoseev
3411c5551a Refs #27472 -- Fixed crash during pickling of empty GEOS point. 2018-07-09 11:02:12 -04:00
Sergey Fedoseev
bdcde79c5f Made test for memoryview handling in force_bytes() more strict. 2018-07-09 11:01:42 -04:00
Christian Barcenas
c9c6c16650 Fixed #20584 -- Fixed memcached's get_many() with single-use iterators. 
Thanks Guyon Morée for the report.
 2018-07-09 10:24:41 -04:00
Mushtaq Ali
66b6b68923 Fixed #29543 -- Fixed CPointerBase.__del__() ImportError crash. 2018-07-06 11:26:14 -04:00
Tom
f98e1c01ea Refs #29451 -- Fixed test_isvalid_lookup on MySQL 8+. 2018-07-06 08:59:27 -04:00
Junyi Jiao
a0b19a0f5b Refs #28643 -- Added math database functions. 
Thanks Nick Pope for much review.
 2018-07-05 11:02:12 -04:00
Tim Graham
f3fa86a89b Fixed #29449 -- Reverted "Fixed #28757 -- Allowed using contrib.auth forms without installing contrib.auth." 
This reverts commit 3333d935d2 due to
a crash if USERNAME_FIELD isn't a CharField.
 2018-07-02 18:39:26 -04:00
Claude Paroz
eac9ab7ebb Removed parser.add_arguments() arguments that match the defaults. 2018-07-02 17:54:57 -04:00
Mariusz Felisiak
0e64e046a4
Fixed #29530 -- Fixed aliases ordering when chaining annotate() and filter(). 2018-07-02 21:09:29 +02:00
Ian Foote
38cada7c94 Fixed #28077 -- Added support for PostgreSQL opclasses in Index. 
Thanks Vinay Karanam for the initial patch.
 2018-06-29 17:00:28 -04:00
Jon Prindiville
b4cba4ed62 Fixed #28144 -- Added FileSystemStorage.OS_OPEN_FLAGS to allow customization. 2018-06-29 15:51:59 -04:00
Przemysław Suliga
d22b90b4ea Fixed #29525 -- Allowed is_safe_url()'s allowed_hosts arg to be a string. 2018-06-29 10:17:52 -04:00
Floris den Hengst
96199e562d Fixed #26067 -- Added ordering support to ArrayAgg and StringAgg. 2018-06-28 20:29:33 -04:00
Carlton Gibson
f4ef71c689 Refs #29514 -- Added test for get_default_timezone()/timezone.utc equality. 2018-06-28 11:14:26 -04:00
Tim Graham
9294110a57 Fixed #29520 -- Fixed test client crash when posting bytes. 
Regression in b8a41a2872.
 2018-06-27 14:50:03 -04:00
Chris Jerdonek
f434f5b84f Refs #29253 -- Fixed method_decorator() crash if decorator sets a new attribute. 
Regression in fdc936c913.
 2018-06-27 11:46:07 -04:00
Alexandr Tatarinov
7410618528 Fixed #29447 -- Made RelatedManager.set() pass bulk argument to clear(). 2018-06-25 13:04:46 -04:00
oliver
6b3e17bab6 Fixed #29518 -- Added validation for sqlmigrate's app_label argument. 2018-06-25 10:43:12 -04:00
Federico Bond
4c36414323 Fixed #29517 -- Rephrased error message when passing incorrect kwarg to model constructor 2018-06-25 09:30:58 +02:00
Tim Graham
7cdeb23ae7 Fixed #29511 -- Added charset to JavaScriptCatalog's Content-Type header. 2018-06-22 09:15:29 +02:00
Paulo
fa679db1ff Refs #18620 -- Refactored ContentTypes view tests to group related field test cases. 2018-06-21 12:31:04 -04:00
Paulo
d14850e525 Fixed #18620 -- Made ContentTypes shortcut view prefer current site if available. 
Thanks Mike Tigas (mtigas) for the initial patch.
 2018-06-21 12:31:04 -04:00
Paulo
efbcd60a22 Added test for contenttype redirect with m2m objects. 
Thanks carltongibson for the test logic.
 2018-06-21 12:31:00 -04:00
Tim Graham
b49ed4be47 Corrected location of some contenttypes_tests. 2018-06-21 12:26:28 -04:00
Sergey Fedoseev
a799dc51b9 Fixed #29509 -- Added SpatiaLite support for covers and coveredby lookups. 2018-06-21 09:25:31 -04:00
Claude Paroz
fc26615164 Refs #29506 -- Added validation for squashmigrations' app_label option. 2018-06-20 15:46:43 -04:00
Claude Paroz
c723a1ff8e Fixed #29506 -- Added validation for migrate's app_label option. 
Thanks MyungSeKyo for the report and the initial patch.
 2018-06-20 15:42:40 -04:00
Claude Paroz
c3c7d15c34 Refs #29469 -- Reused get_app_config() error message in makemigrations error. 2018-06-20 15:41:51 -04:00
Claude Paroz
abbc9cd71c Moved makemigrations app_label validation tests. 2018-06-20 15:33:23 -04:00
Tim Graham
5d98d53fab Refs #27398 -- Simplified some tests with assertRedirects(). 2018-06-20 14:08:56 -04:00
Jan Pieter Waagmeester
24959e48d9 Fixed #27398 -- Added an assertion to compare URLs, ignoring the order of their query strings. 2018-06-20 13:26:12 -04:00
Nick Pope
b0fbfae093 Fixed #29503 -- Made __in lookup keep order of values in query. 
Regression in 86eccdc8b6.
 2018-06-20 09:29:06 -04:00
Sergey Fedoseev
d8d21d3891 Made test for GIS Envelope function more strict. 2018-06-20 16:48:50 +05:00
Carlton Gibson
5b73317181 Fixed #29502 -- Allowed users with the view permission to use autocomplete_fields. 2018-06-18 15:36:20 -04:00
Carlton Gibson
958c7b301e Fixed #29419 -- Allowed permissioning of admin actions. 2018-06-18 15:07:29 -04:00
Mariusz Felisiak
6dd4edb1b4
Fixed #29496 -- Fixed crash on Oracle when converting a non-unique field to primary key. 
Thanks Tim Graham for the review.
 2018-06-17 08:51:02 +02:00
humbertotm
e95008f241 Fixed #29152 -- Allowed passing kwargs to ArgumentParser initialization in management commands. 2018-06-16 15:54:59 -04:00
oliver
78972af367 Fixed #29469 -- Added a helpful makemigrations error if app_label contains dots. 2018-06-16 15:18:57 -04:00
Paulo
553617e613 Fixed #29487 -- Accounted for object level permissions when calculating change view's read-only fields. 
Thanks Matthew Frazier for the report and fix.
 2018-06-15 21:54:22 -04:00
Tim Graham
63f90f55f3 Fixed #29498 -- Fixed a missing pyc test file in source distribution. 2018-06-15 14:18:08 -04:00
Jeff
fcc4e251db Fixed #29000 -- Fixed RenameModel's renaming of a M2M column when run after RenameField. 
Regression in 45ded053b1.
 2018-06-15 11:51:09 -04:00
Henk Kahlfuß
3eb9127678 Fixed #23869 -- Made ModelAdmin.get_deleted_objects() use has_delete_permission() for permissions checking. 2018-06-15 10:31:08 -04:00
Tim Graham
ec2c9c3531 Refs #29428 -- Fixed admin check crash when using a query expression in ModelAdmin.ordering. 2018-06-14 21:04:43 -04:00
Tim Graham
0d8e3e608e Fixed #29428 -- Fixed admin changelist crash when using a query expression without asc()/desc() in the ordering. 2018-06-14 14:22:04 -04:00
Claude Paroz
a77f21880d Fixed #24384 -- Allowed compilemessages to continue running after nonfatal errors. 
Thanks Aymeric Augustin for the report and Carlton Gibson and Tim Graham for
the reviews.
 2018-06-13 21:09:02 +02:00
Carlton Gibson
b30f9b131c Refs #29419, #8936 -- Removed change permission requirement for admin actions. 
Partially reverted 825f0beda8.
 2018-06-13 14:49:28 -04:00
Mads Jensen
4167959105 Added tests for incorrect content type and size in MultiPartParser. 2018-06-12 14:42:20 -04:00
Tim Graham
9e4f26bb40
Fixed #29483 -- Confirmed support for GDAL 2.3. 2018-06-12 13:34:58 -04:00
Bartosz Grabski
2bc014750a Fixed #29452 -- Fixed makemessages setting charset of .pot files. 2018-06-11 21:34:13 -04:00
Arthur Silva
bc1435551c Fixed #29464 -- Silenced post-process messages in collectstatic's default verbosity. 2018-06-11 20:21:58 -04:00
Tim Graham
860903b261
Dropped support for GDAL 1.9 and 1.10. 2018-06-11 08:33:09 -04:00
Claude Paroz
86988dd890 Refs #29483 -- Relaxed WGS 84 check regex 
With GDAL 2.3, the exact string changed again.
 2018-06-09 09:19:08 +02:00
Hasan Ramezani
6df3d36801 Added a missing test for createsuperuser management command. 2018-06-07 19:49:25 -04:00
Claude Paroz
ce3351b950 Fixed #29301 -- Added custom help formatter to BaseCommand class 
This partially reverts c3055242c8.
Thanks Adam Johnson and Carlton Gibson for the reviews.
 2018-06-06 19:16:10 +02:00
Tim Graham
13fe5a87f9 Fixed MySQL QuerySet.explain() test when running tests in reverse. 2018-06-06 11:31:06 -04:00
Carlton Gibson
c4f099de1d
Refs #29451 -- Used quote_name for column names in tests. 
Regression in a253a580e6
 2018-06-06 16:13:25 +02:00
Tom Forbes
a253a580e6 Refs #29451 -- Quoted MySQL column names in tests. 2018-06-05 12:13:29 +02:00
Claude Paroz
bec651a427 Fixed #10827 -- Ensured ContentTypes are created before permission creation. 2018-06-03 22:19:04 -04:00
humbertotm
747ff7a30b Fixed #29385 -- Made admindocs ModelDetailView show model properties. 
Original patch by bkaluza. Tests and docs by humbertotm.
 2018-06-03 21:00:28 -04:00
Tim Graham
666be7b994 Fixed #29461 -- Fixed ogrinspect test_time_field failure on SpatiaLite. 2018-06-01 22:55:22 -04:00
Tim Graham
55f4eee75d
Fixed #29462 -- Fixed ogrinspect test failures with GDAL 2.2. 2018-06-01 22:31:46 -04:00
Adam Donaghy
b18650a263 Fixed #28462 -- Decreased memory usage with ModelAdmin.list_editable. 
Regression in 917cc288a3.
 2018-06-01 10:41:05 -04:00
Mariusz Felisiak
d0ad03cded Refs #29416 -- Fixed GeoExpressionsTests.test_multiple_annotation() on MySQL 5.7+. 
Failure introduced in b6e48f514e.
 2018-05-31 10:38:42 -04:00
Tim Graham
c03e41712b
Refs #28748 -- Reallowed lazy model field choices. 
Regression in 3aa9ab39cc.
 2018-05-29 21:43:38 -04:00
Tim Graham
3dffcb5579
Relaxed a GDAL raster test. 
The exact metadata depends on the GDAL version.
 2018-05-29 21:39:31 -04:00
Dohyeon Kim
f1f4aeb22e Fixed #28044 -- Unified the logic for createsuperuser's interactive and --noinput modes. 2018-05-29 08:41:32 -04:00
Paulo
6104875a2c Fixed #29230 -- Fixed nested prefetches that clash with descriptors. 2018-05-27 21:45:51 -04:00
Hasan Ramezani
e0ff88be4f Added test for createsuperuser's handling of KeyboardInterrupt. 2018-05-27 19:24:07 -04:00
Mariusz Felisiak
4ab1f559e8 Fixed #29416 -- Removed unnecesary subquery from GROUP BY clause on MySQL when using a RawSQL annotation. 
Regression in 1d070d027c.
 2018-05-27 18:25:19 -04:00
Daniel Hepper
4e016d1372 Removed obsolete BaseHandler attributes. 
Unused since d334f46b7a.
 2018-05-27 11:21:27 -04:00
Tim Graham
5cc81cd9eb Reverted "Fixed #29324 -- Made Settings raise ImproperlyConfigured if SECRET_KEY is accessed and not set." 
This reverts commit b3cffde555 due to
a regression and performance concerns.
 2018-05-26 21:06:58 -04:00
ryabtsev
b4fd9b5ad4 Fixed #29432 -- Allowed passing an integer to the slice template filter. 2018-05-26 20:56:51 -04:00
Xaroth Brook
39283c8edb Fixed #29415 -- Fixed detection of custom URL converters in included patterns. 2018-05-26 20:13:48 -04:00
Ryan Rubin
a8d12bc280 Fixed #29400 -- Fixed crash in custom template filters that use decorated functions. 
Regression in 620e9dd31a.
 2018-05-25 11:11:46 -04:00
Ramiro Morales
f40e71a957 Fixed #29417 -- Corrected two admin page titles for view-only users. 2018-05-23 11:02:37 -04:00
Paulo Alvarado
ffb72a95bc Fixed #29414 -- Restored form inputs on admin inlines when the user doesn't have the change permission. 
Regression in 825f0beda8.
 2018-05-18 19:50:58 -04:00
bakabiko
a7bc1aea03 Fixed #29380 -- Added support for QuerySet.select_for_update()'s nowait and skip_locked options on MySQL 8+. 2018-05-18 19:37:36 -04:00
Tim Graham
9792af3648 Increased the default PBKDF2 iterations for Django 2.2. 2018-05-17 11:05:45 -04:00
Tim Graham
b9dd8512f2 Advanced deprecation warnings for Django 2.2. 2018-05-17 11:05:45 -04:00
olivierdalang
825f0beda8 Fixed #8936 -- Added a view permission and a read-only admin. 
Co-authored-by: Petr Dlouhy <petr.dlouhy@email.cz>
Co-authored-by: Olivier Dalang <olivier.dalang@gmail.com>
 2018-05-16 06:44:55 -04:00
Tim Graham
49a1736c2e Added assertion for admin change form's "save and continue editing" message. 2018-05-15 20:17:02 -04:00
Claude Paroz
a177f854c3
Fixed #16470 -- Allowed FileResponse to auto-set some Content headers. 
Thanks Simon Charette, Jon Dufresne, and Tim Graham for the reviews.
 2018-05-15 18:12:11 +02:00
Ryan P Kilby
2dcc5d629a Fixed #29392 -- Disallowed use of abbreviated forms of --settings and --pythonpath management command options. 2018-05-14 22:18:22 -04:00
Tim Graham
cae0107287 Increased the default PBKDF2 iterations for Django 2.1. 2018-05-13 20:06:20 -04:00
Claude Paroz
d65b0f72de Fixed #17379 -- Removed management commands deactivation of the locale. 2018-05-13 10:21:53 +02:00
Tim Graham
1e0cbc72e5
Moved to_language() to django.utils.translation. 
Follow up to 1b7d524cfa.
 2018-05-12 15:03:38 -04:00
Tim Graham
1b7d524cfa Consolidated duplicate to_locale() implementations. 
Follow up to ac59ec8f1a.
 2018-05-12 12:58:21 -04:00
Hasan Ramezani
305dee7bf9 Increased django.utils.translation.trans_null test coverage. 2018-05-12 11:23:44 -04:00
Hasan Ramezani
ac59ec8f1a Aliased trans_null.to_locale() to trans_real.to_locale(). 
The implementations have unintentionally diverged.
 2018-05-12 10:54:22 -04:00
Stefan R. Filipek
a5a2ceeb45 Fixed #27629 -- Added router.allow_relation() calls for assignments between unsaved model instances. 2018-05-10 20:42:44 -04:00
Claude Paroz
9c4ea63e87
Replaced TOKEN_* constants by TokenType enums. 
Thanks Tim Graham for the review.
 2018-05-10 17:51:51 +02:00
Maximilian Merz
78912ccd0e Fixed #21408 — German Translation for “3 days ago” 
The problem:
“3 days ago” should translate to “vor 3 Tagen” in German, while “3 days” translates to “3 Tage”. #21408 describes that django always translated to “Tage”, even when the dative “Tagen” was correct. The same applies to months (“Monate”/“Monaten”) and years (“Jahre”/“Jahren”).

The solution:
Let `timesince` caller provide the string dict to use for the time-related strings.
 2018-05-10 15:53:33 +02:00
Morgan Aubert
704443acac Fixed #29363 -- Added SimpleTestCase.assertWarnsMessage(). 2018-05-09 11:40:28 -04:00
Hasan Ramezani
7ba040de77 Added tests for trans_null.ngettext(). 2018-05-09 09:54:41 -04:00
Nicolas Noé
c629d4e956 Fixed #29389 -- Made Paginator reject non-integer page numbers of type float. 2018-05-09 09:28:52 -04:00
Nicolas Noé
2134e7d439 Refs #29389 -- Added Paginator test for float page number. 2018-05-09 09:23:05 -04:00
Nicolas Noé
c4158d050f Fixed #29370 -- Added choices to LogEntry.action_flag field. 2018-05-07 10:07:45 -04:00
Claude Paroz
523e04dfeb Captured logging in tests with self.assertLogs(). 2018-05-07 09:34:02 -04:00
Claude Paroz
607970f31c Replaced django.test.utils.patch_logger() with assertLogs(). 
Thanks Tim Graham for the review.
 2018-05-07 09:34:00 -04:00
Sanket Saurav
079f324357 Fixed #28913 -- Fixed error handling when MIGRATIONS_MODULES specifies a nonexistent top-level package. 2018-05-05 18:26:33 -04:00
Samir Shah
10b44e4525 Fixed #26688 -- Fixed HTTP request logging inconsistencies. 
* Added logging of 500 responses for instantiated responses.
* Added logging of all 4xx and 5xx responses.
 2018-05-04 20:55:03 -04:00
Carlton Gibson
21fd8041c1
Refs #29358 -- Corrected wording in primary key check message. 2018-05-03 15:28:37 +02:00
Hasan Ramezani
816b8d9518 Fixed #29358 -- Added a system check to prohibit models with more than one primary_key field. 2018-05-03 09:08:29 +02:00
CHI Cheng
98019df855 Used double quotation marks for csrf form element. 2018-05-03 08:57:18 +02:00
CHI Cheng
4660ce5a69 Fixed #29375 -- Removed empty action attribute on HTML forms. 2018-05-02 09:20:04 -04:00
Zackary Troop
30f8642f2e Fixed #29350 -- Fix get_primary_key_column() method in sqlite3 backend 
Thanks Tim Graham and Mariusz Felisiak for the reviews.
 2018-04-28 12:01:45 +02:00
priyanshsaxena
6b3d292043 Fixed #29015 -- Added an exception if the PostgreSQL database name is too long. 2018-04-27 21:37:42 -04:00
Oscar Esgalha
6d1f576945 Fixed #29367 -- Fixed model state on objects with a primary key created with QuerySet.bulk_create(). 2018-04-27 17:57:38 -04:00
Nicolas Noé
3246ad1065 Fixed #27480 -- Added cache.touch(). 2018-04-27 17:48:35 -04:00
Claude Paroz
8e960c5aba Removed urllib2 reference in file storage tests 2018-04-27 14:02:39 +02:00
Claude Paroz
a9189d27ef Fixed #29353 -- Made StaticFilesHandler return a 404 response when settings.DEBUG is False 2018-04-25 10:38:13 +02:00
Tim Graham
c591bc3cce Fixed "invalid escape sequence" warning in runtests.py. 2018-04-24 12:06:04 -04:00
Claude Paroz
3aae43d800 Fixed #28973 -- Silenced copying/linking messages in collectstatic's default verbosity. 2018-04-23 23:04:02 -04:00
François Freitag
d1413c5d70 Refs #28312 -- Added an optimized __bool__() to ModelChoiceIterator. 
COUNT is more expensive than EXISTS; use the latter when possible.
 2018-04-23 13:03:07 -04:00
François Freitag
3fca95e1ad Fixed #28312 -- Made ModelChoiceIterator.__len__() more memory-efficient. 
Instead of loading all QuerySet results in memory, count the number of
entries. This adds an extra query when list() or tuple() is called on the
choices (because both call __len__() then __iter__()) but uses less
memory since the QuerySet results won't be cached. In most cases, the
choices will only be iterated on, meaning that __len__() won't be called
and only one query will be executed.
 2018-04-23 12:39:43 -04:00
Hasan Ramezani
b33f10d8cc Refs #29131 -- Made ArrayField error messages index from 1 instead of 0. 2018-04-22 22:18:46 -04:00
Hasan Ramezani
dd68b51e1d Fixed #29295 -- Fixed management command crash when using subparsers. 
Thanks Tim Graham for the fix.
 2018-04-21 17:33:17 -04:00
orlnub123
21420096c4 Fixed #29247 -- Allowed blank model field choice to be defined in nested choices. 2018-04-20 11:06:14 -04:00
Tim Graham
e35004966b Moved tests for model Field.get_choices(). 2018-04-20 11:05:25 -04:00
Adnan Umer
534d8d875e Fixed #28600 -- Added prefetch_related() support to RawQuerySet. 2018-04-19 13:48:27 -04:00
Adnan Umer
f2026ca5e2 Fixed #29337 -- Added __len__() & __bool__() to RawQuerySet. 2018-04-19 12:46:31 -04:00
Adnan Umer
ec0319ff82 Fixed #29339 -- Added result caching to RawQuerySet. 2018-04-19 11:35:49 -04:00
Tom
c1c163b427 Fixed #28574 -- Added QuerySet.explain(). 2018-04-19 10:52:19 -04:00
Nick Pope
df90e462d9 Fixed #29212 -- Doc'd redirect loop if @permission_required used with redirect_authenticated_user. 2018-04-19 10:21:24 -04:00
Tim Graham
a917a5601f Refs #23890 -- Removed numpy deprecation warning silencing. 
Obsolete since numpy 1.12.0.
 2018-04-18 22:09:26 -04:00
Tim Graham
7a22d9f751
Fixed a test failure with the latest GeoIP2 database. 2018-04-17 21:30:05 -04:00
Brett Cannon
64b74804c5 Fixed #29334 -- Updated pypi.python.org URLs to pypi.org. 2018-04-17 20:24:27 -04:00
Jon Dufresne
b3cffde555 Fixed #29324 -- Made Settings raise ImproperlyConfigured if SECRET_KEY is accessed and not set. 2018-04-17 13:02:05 -04:00
Tim Graham
fff689ed98 Added a test for a settings error message. 2018-04-17 12:55:26 -04:00
Chris Jerdonek
fdc936c913 Fixed #29253 -- Made method_decorator(list) copy attributes. 2018-04-16 13:38:37 -04:00
Tim Graham
a480ef89ad Fixed inconsistent formatting in tests/modeladmin/test_checks.py. 2018-04-16 13:35:40 -04:00
Chris Jerdonek
09f1f0387b Updated decorators test to use subTest(). 2018-04-16 12:48:01 -04:00
Daniel Miller
60156750f6 Fixed #29330 -- Fixed crash when pickling BaseExpression. 
Regression in cfff2af02b.
 2018-04-16 10:15:13 -04:00
Alex Gaynor
9a56b4b13e Fixed #27863 -- Added support for the SameSite cookie flag. 
Thanks Alex Gaynor for contributing to the patch.
 2018-04-13 20:58:31 -04:00
Matthias Kestenholz
13efbb233a Fixed #29322 -- Made admin check all ModelAdmin fieldsets for duplicates. 2018-04-13 11:08:30 -04:00
Mariusz Felisiak
0b66c3b442
Fixed #29286 -- Fixed column mismatch crash with QuerySet.values() or values_list() after combining an annotated and unannotated queryset with union(), difference(), or intersection(). 
Regression in a0c03c62a8.

Thanks Tim Graham and Carlton Gibson for reviews.
 2018-04-13 12:15:52 +02:00
Flávio Juvenal
e1f13f1551 Fixed #29320 -- Added an exception when an annotation alias matches a ForeignKey attname. 2018-04-12 21:15:40 -04:00
Tim Graham
78f8b80f9b Fixed schema test failure when running tests in reverse. 
Follow up to 003334f8af.
 2018-04-12 13:59:02 -04:00
Paul Donohue
33a0b7ac81 Fixed #29296 -- Fixed crashes in admindocs when a view is a callable object. 2018-04-12 13:11:08 -04:00
Jeremy Bowman
ee17bb8a67 Fixed #29193 -- Prevented unnecessary foreign key drops when altering a unique field. 
Stopped dropping and recreating foreign key constraints on other fields
in the same table as the one which is actually being altered in an
AlterField operation.

Regression in c3e0adcad8.
 2018-04-11 23:17:11 -04:00
Jeremy Bowman
003334f8af Tested altering a unique field when a reverse M2M relation exists. 2018-04-11 23:17:11 -04:00
David Foster
c3055242c8 Fixed #29301 -- Made management command --help display command-specific arguments before common arguments. 2018-04-11 13:52:20 -04:00
Alasdair Nicol
65c44a5c1d Fixed #29307 -- Fixed inspectdb import paths for django.contrib.postgres fields. 
Thanks erindy for the report.
 2018-04-10 09:33:05 -04:00
Vinay Karanam
6a1957bb98 Fixed #28950 -- Fixed ArrayField.has_changed() for empty values. 2018-04-07 17:53:33 -04:00
Vinay Karanam
e67dc0fbb2 Added tests for ArrayField.has_changed(). 2018-04-07 17:48:29 -04:00
Faheel Ahmad
5d4d62bf4f Fixed #29248 -- Renamed admin CSS class field-box to fieldBox. 2018-04-05 10:55:36 -04:00
Jon Dufresne
be6ca89396 Fixed #27991 -- Added obj arg to InlineModelAdmin.has_add_permission(). 
Thanks Vladimir Ivanov for the initial patch.
 2018-04-04 19:21:50 -04:00
Jirka Vejrazka
6148dda72f Fixed #29288 -- Made {% widthratio %} assign to as var if an exception occurs. 2018-04-04 14:03:16 -04:00
safu9
9fd9f8bbb2 Fixed #29284 -- Made ImageField render with accept="image/*"' HTML attribute. 2018-04-04 13:16:03 -04:00
Mads Jensen
9c651641f1 Added additional AdminPasswordChangeForm tests. 2018-04-04 11:25:28 -04:00
Dmitry Dygalo
c979c0a2b8 Fixed #25718 -- Made a JSONField lookup value of None match keys that have a null value. 2018-04-04 10:53:46 -04:00
Mariusz Felisiak
816b386d41
Refs #24791 -- Made PostgreSQL's nodb connection use first PostgresSQL db when 'postgres' db isn't available. 
Thanks Tim Graham and Claude Paroz for reviews.
 2018-04-03 22:21:47 +02:00
Mariusz Felisiak
55cc26941a
Refs #28643 -- Added Repeat database function. 
Thanks Tim Graham and Nick Pope for reviews.
 2018-04-03 19:36:12 +02:00
Mariusz Felisiak
6141c752fe
Fixed #29251 -- Added bytes to str conversion in LPad/RPad database functions on MySQL. 
Thanks Tim Graham for the review.
 2018-04-03 18:24:04 +02:00
Tim Graham
4f7467b690
Refs #28577 -- Added check for HStoreField to prevent mutable default. 2018-04-03 11:12:56 -04:00
Jon Dufresne
167d98528a Refs #27728 -- Fixed BytesWarning in admin_views tests. 2018-04-03 10:11:35 -04:00
Jon Dufresne
f3b1c3bd06 Refs #23406 -- Fixed "invalid escape sequence" warning in migrations test. 2018-04-02 22:54:05 -04:00
Claude Paroz
2a2ed0e70a Fixed #29116 -- Fixed OpenLayersWidget deserialization ignoring the widget map's SRID. 
Regression in 6ecccad711.
 2018-04-02 10:20:00 -04:00
Claude Paroz
f3b69f9757 Fixed #29273 -- Prevented initial selection of empty choice in multiple choice widgets. 
Regression in b52c73008a.
 2018-04-02 08:52:53 -04:00
Dan Watson
e163effecc Fixed #29279 -- Added renderer argument to ModelForm. 2018-03-31 20:45:59 -04:00
Chris Lamb
84ad721bd9 Fixed #29275 -- Made assertFormError() output "(actual errors: none)" instead of "(actual errors: )". 2018-03-31 18:35:45 -04:00
Malte Gerth
874977d388 Fixed #29270 -- Fixed UserChangeForm crash if password field is excluded. 2018-03-29 15:25:54 -04:00
Mads Jensen
c59aa9e6aa Added test for combining Q objects with non-Q objects. 2018-03-29 13:58:55 -04:00
Simon Charette
2156565b5b Fixed #29245 -- Made autodetector treat field renames + db_column addition as RenameField. 2018-03-28 12:43:43 -04:00
Abeer Upadhyay
1bf4646f91 Fixed #29258 -- Added type checking for login()'s backend argument. 2018-03-28 10:10:18 -04:00
Hasan Ramezani
76ae1e9a94 Increased test coverage for {% get_admin_log %} and {% static %}. 2018-03-26 13:34:23 -04:00
Mads Jensen
4554f9a783 Increased test coverage for various template tags. 2018-03-24 19:56:46 -04:00
Dan Watson
29150d5da8 Fixed #23406 -- Allowed migrations to be loaded from .pyc files. 2018-03-23 13:20:38 -04:00
Tim Graham
a4f0e9aec7 Fixed #28718 -- Allowed user to request a password reset if their password doesn't use an enabled hasher. 
Regression in aeb1389442.
Reverted changes to is_password_usable() from
703c266682 and documentation changes from
92f48680db.
 2018-03-22 10:03:43 -04:00
Tim Graham
623139b5d1 Refs #29147 --- Added JSONField serialization tests. 2018-03-21 20:11:06 -04:00
Michael Sinov
9aca67bea8 Fixed #27533 -- Fixed inspectdb crash if a unique constraint uses an unsupported type. 2018-03-21 12:28:16 -04:00
Tim Graham
a170dac887 Fixed too many parentheses in inspectdb Meta.unique_together output. 
Regression in c76d87427d.
 2018-03-21 10:39:36 -04:00
Mads Jensen
bb79e480e1 Increased test coverage for i18n template tags. 2018-03-21 08:38:07 -04:00
Tim Graham
c76d87427d
Refs #23919 -- Removed obsolete comments about u'' prefixes. 2018-03-21 08:15:07 -04:00
Tim Graham
6421bd702f Refs #29227 -- Made inspectdb generate BooleanField(null=True) rather than NullBooleanField. 2018-03-20 12:10:10 -04:00
Tim Graham
5fa4f40f45 Fixed #29227 -- Allowed BooleanField to be null=True. 
Thanks Lynn Cyrin for contributing to the patch, and Nick Pope for review.
 2018-03-20 12:10:10 -04:00
Astral
a0c03c62a8 Fixed #29229 -- Fixed column mismatch crash when combining two annotated values_list() querysets with union(), difference(), or intersection(). 
Regression in 7316720603821ebb64dfe8fa592ba6edcef5f3e.
 2018-03-19 21:05:43 -04:00
Mariusz Felisiak
cede5111bb
Refs #28643 -- Added LPad and RPad database functions. 
Thanks Tim Graham for the review.
 2018-03-19 17:35:16 +01:00
Hasan Ramezani
274e3e27f3 Fixed #29184 -- Made TabularInline respect model form's Meta.labels and help_texts. 2018-03-17 20:51:24 -04:00
Claude Paroz
3c4ff21763 Fixed #29103 -- Removed bad 'b'-prefix added by MySQL's SchemaEditor.quote_value(). 2018-03-17 16:36:54 -04:00
Claude Paroz
aa0ee372cd Added tests for MySQL's SchemaEditor.quote_value(). 2018-03-17 16:36:50 -04:00
Tim Graham
f8b98f0edc Removed DatabaseFeatures.can_introspect_null. 
The only known usage is in the unmaintained django-pymssql project.
 2018-03-16 11:43:41 -04:00
Mariusz Felisiak
362813d628
Fixed hanging indentation in various code. 2018-03-16 10:54:34 +01:00
Mattia Procopio
aeb8c38178 Fixed #29206 -- Fixed PasswordResetConfirmView crash when the URL contains a non-UUID where one is expected. 2018-03-15 21:33:15 -04:00
Josh Schneier
b60e5fdbb7 Fixed #28959 -- Fixed 'No, take me back' button on admin's inline popup. 2018-03-15 20:47:18 -04:00
Mariusz Felisiak
9421aee35e
Refs #28643 -- Added LTrim, RTrim, and Trim database functions. 
Thanks Tim Graham and Mads Jensen for reviews.
 2018-03-15 20:57:23 +01:00
Artem Tabolin
a2f7433adc Fixed #29221 -- Corrected admin's autocomplete widget to add a space after custom classes. 2018-03-15 10:55:34 -04:00
Mariusz Felisiak
ba3078c92d Refs #29155 -- Fixed LookupTests.test_pattern_lookups_with_substr() crash on Oracle. 
Test introduced in feb683c4c2 revealed
unexpected behavior on Oracle that allows concatenating NULL with string.
 2018-03-15 09:54:24 -04:00
Tim Graham
87dc0844a6 Fixed #29200 -- Fixed label rendering when using RadioSelect and CheckboxSelectMultiple with MultiWidget. 2018-03-15 09:10:23 -04:00
Tim Graham
fb8fd535c0 Moved SchemaLoggingTest to tests/schema. 2018-03-14 10:24:34 -04:00
Mariusz Felisiak
feb683c4c2
Fixed #29155 -- Fixed crash when database functions are used with pattern lookups. 
Thanks Tim Graham and Sergey Fedoseev for reviews.
 2018-03-14 10:00:07 +01:00
Mariusz Felisiak
acfc650f2a
Fixed #29199 -- Fixed crash when database user password contains @ sign on Oracle. 
Thanks Shane Allgeier for the report and Tim Graham for the review.
 2018-03-13 19:06:40 +01:00
dzhuang
e17088a108 Fixed #29213 -- Fixed autocomplete widget's translations for zh-hans/zh-hant. 2018-03-13 10:58:34 -04:00
robwa
4ab027b944 Fixed #28988 -- Fixed queries when a GenericRelation is used with multi-table inheritance. 2018-03-12 22:42:48 -04:00
Sergey Fedoseev
d696fccae6 Fixed #29209 -- Fixed Cast() with TextField on MySQL and Oracle. 2018-03-12 21:57:14 -04:00
Mariusz Felisiak
c3a1337dfa Refs #29004 -- Optimized InspectDBTransactionalTests.test_include_views() by limiting introspected tables. 2018-03-12 11:22:57 -04:00
Tim Graham
25b97ee170 Added functions for inspectdb table filtering in tests. 2018-03-12 11:15:13 -04:00
Carlton Gibson
5b083a824e Fixed #29180 -- Fixed a regression where migrations already in the plan were readded. 
Regression in a38ae914d8.
 2018-03-09 08:59:57 +01:00
Alex Stovbur
2d9ec4d735 Fixed #29188 -- Fixed ContentFile.size after a write(). 2018-03-08 14:07:29 -05:00
Simon Charette
277ed07209 Fixed #29195 -- Fixed Exists.output_field resolution on single-valued queries. 
The Subquery class which Exists inherits from defaulted to using single-valued
querie's field if no output_field was explicitly specified on initialization
which was bypassing the Exists.output_field defined at the class level.

Moving Subquery's dynamic output_field resolution to _resolve_output_field
should make sure the fallback logic is only performed if required.

Regression in 08654a99bb.

Thanks Oli Warner for the detailed report.
 2018-03-08 13:30:41 -05:00
Fabrizio Ettore Messina
10c0fe528a Fixed #29178 -- Allowed Index.fields to accept a tuple. 2018-03-08 10:56:55 -05:00
Tim Graham
911af0d24b Added more tests for django.utils.html.urlize(). 2018-03-06 08:30:41 -05:00
Tim Graham
97b7dd59bb Fixed CVE-2018-7537 -- Fixed catastrophic backtracking in django.utils.text.Truncator. 
Thanks James Davis for suggesting the fix.
 2018-03-06 08:30:40 -05:00
Tim Graham
8618271caa Fixed CVE-2018-7536 -- Fixed catastrophic backtracking in urlize and urlizetrunc template filters. 
Thanks Florian Apolloner for assisting with the patch.
 2018-03-06 08:30:40 -05:00
Alex Stovbur
d171843f57 Fixed #28981 -- Added an exception if GeoIP database can't be loaded from the path. 2018-03-05 12:20:30 -05:00
Sergey Fedoseev
4ff29a53e6 Refs #17476 -- Removed obsolete simplification of timezone names in cache key generation. 2018-03-03 14:56:39 -05:00
Almad
3d8fadad0f Added model name to AutoField error message. 2018-03-03 13:22:00 -05:00
Patryk Zawadzki
a20aae414e Fixed #29144 -- Made untranslated strings for territorial language variants use translations from the generic language variant. 2018-03-03 12:08:24 -05:00
Alex Tomic
a1a3e51561 Fixed #29133 -- Fixed call_command() crash if a required option is passed in options. 2018-03-02 12:25:08 -05:00
Christophe Mehay
40bac28faa Fixed #29176 -- Fixed AbstractBaseUser.normalize_username() crash if username isn't a string. 2018-03-02 11:32:53 -05:00
François Freitag
a2e97abd81 Fixed #29159 -- Made ModelChoiceIterator reuse QuerySet result cache. 
When __len__() is called (e.g. when casting to list or tuple), the
QuerySet is evaluated and the result cache populated. iterator()
shouldn't be called on the QuerySet after that, as it would reset the
result cache and trigger a second query.
 2018-03-01 14:17:56 -05:00
François Freitag
40f0aa9885 Fixed #29158 -- Fixed len(choices) crash if ModelChoiceField's queryset is a manager. 
Removing all() in __iter__() prevents a duplicate query when choices are
cast to a list and there's a prefetch_related().
 2018-03-01 14:12:14 -05:00
François Freitag
06172d7bc2 Consolidated ModelChoiceField tests. 2018-03-01 14:05:35 -05:00
Tim Graham
4c02e3cda3 Refs #27728 -- Made cosmetic edits to admin template tag template overriding. 2018-03-01 11:45:08 -05:00
Tomáš Ehrlich
fa352626c2 Fixed #29172 -- Fixed crash with Window expression in a subquery. 2018-03-01 10:24:14 -05:00
Mariusz Felisiak
54f80430be
Fixed #29166 -- Fixed crash in When() expression with a list argument. 
Thanks Matthew Pava for the report and Tim Graham and Carlton Gibson for
reviews.
Regression in 19b2dfd1bf.
 2018-02-28 18:05:23 +01:00
Tim Graham
3fb718f17d Eliminated the need to modify a model forms test when new test files are added. 2018-02-28 10:26:26 -05:00
Raffaele Salmaso
5cc28dc752 Fixed #27728 -- Allowed overriding admin templatetags templates. 2018-02-28 08:49:40 +01:00
Tim Graham
5b589a47b9
Fixed #29161 -- Removed BCryptPasswordHasher from PASSWORD_HASHERS. 2018-02-26 09:05:18 -05:00
Becky Smith
8116e588db Fixed #17962 -- Added ModelAdmin.get_deleted_objects(). 2018-02-24 20:41:43 -05:00
Tim Graham
0fa6ab8c18 Tested the admin's delete_selected action when it receives nonexistent pks. 2018-02-24 09:21:13 -05:00
a8568730
ba37ee9ef8 Fixed #28635 -- Fixed admin's preserved filters if the URL contains non-ASCII characters. 2018-02-23 15:40:11 -05:00
Sebastian Sangervasi
7905815510 Fixed #27449 -- Added django.utils.translation.get_supported_language_variant(). 2018-02-23 14:49:00 -05:00
Hasan Ramezani
5033999153 Fixed #29154 -- Corrected examples in pluralize docstring and added tests. 2018-02-23 14:20:00 -05:00
bobort
f82de6bfb1 Refs #28643 -- Added Ord, Chr, Left, and Right database functions. 2018-02-23 10:23:22 -05:00
Matthew Schinckel
c412926a2e Fixed #29142 -- Fixed crash when OuterRef is used with an operator. 2018-02-23 09:38:16 -05:00
Mikhail Porokhovnichenko
14e34dcf8c Fixed #29132 -- Avoided connecting update_last_login() handler if User.last_login isn't a field. 2018-02-21 10:36:31 -05:00
Sebastian Sangervasi
5c4c87e55c Changed "language-code" to the more commonly used "language code". 2018-02-21 09:31:05 -05:00
Tom Forbes
33ac036a6b Fixed #28398 -- Added suggestions for mistyped management commands. 2018-02-21 09:00:49 -05:00
Sebastian Sangervasi
f7b46f0b58 Removed unneeeded inner import in i18n tests. 2018-02-21 08:59:31 -05:00
Oliver Sauder
6f0b8c1c9e Fixed #28442 -- Fixed crash with nested OuterRefs that reference AutoField. 2018-02-20 21:58:43 -05:00
Chillar Anand
e8e0cfa9e5 Fixed #28755 -- Made check_for_language() include apps' locale directories. 2018-02-20 21:34:40 -05:00
Williams Mendez
2691ed7ba1 Fixed #29140 -- Fixed EmailMessage crash when body is None. 2018-02-20 09:34:01 -05:00
Tim Graham
548f78ba46
Removed redundant lookup name in register_lookup() calls. 2018-02-19 13:12:13 -05:00
dizballanze
eb002e7892 Fixed #29135 -- Prevented get_object/list_or_404() from hiding AttributeError raised by QuerySet filtering. 2018-02-19 10:51:15 -05:00
Dylan Verheul
9b1125bfc7 Fixed #28379 -- Made AccessMixin raise Permissiondenied for authenticated users. 2018-02-16 13:58:55 -05:00
Andreas Pelme
e307ff29d2 Fixed #27810 -- Allowed query expressions in admin_order_field. 2018-02-15 21:00:31 -05:00