mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-26 11:06:07 +00:00
Code Issues 27 Releases Wiki Activity
19,360 Commits 28 Branches 426 Tags 667 MiB
8f97413fae
Commit Graph

6130 Commits

Author SHA1 Message Date
Nicholas Serra
6c79d32977 Fixed #23684 -- Used correct package name for Pillow in Error hint. 2014-10-19 13:46:46 +07:00
Thomas Chaumeny
825ea83858 Fixed #21196 -- Removed index on test field causing MySQL specific warning. 2014-10-19 13:44:39 +07:00
Claude Paroz
8d6e1afe0b Fixed #23650 -- Prevented migrate from calling checks 3 times 
Thanks Ilya Baryshev for the report and Tim Graham for the review.
 2014-10-17 20:20:56 +02:00
Tim Graham
7ae03204ac Fixed #23469 -- Removed test runner compatibility check which often yielded false positives. 2014-10-17 10:31:49 -04:00
Rigel Di Scala
a5c77417a6 Fixed #23615 -- Validate that a Model instance's "check" attribute is a method. 
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.

This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
 2014-10-16 23:49:21 +07:00
Loic Bistuer
157f9cf240 Minor cleanup in the check_framework test package. 2014-10-16 23:49:21 +07:00
Thomas Chaumeny
b962653060 Fixed #23664 -- Provided a consistent definition for OrderedSet.__bool__ 
This also defines QuerySet.__bool__ for consistency though this should not have any consequence as bool(qs) used to fallback on QuerySet.__len__ in Py3.
 2014-10-16 14:16:24 +02:00
Claude Paroz
374c14b7fd Fixed #23659 -- Kept annotate() args ordering 
Thanks Loic Bistuer and Simon Charette for the review.
 2014-10-16 09:27:20 +02:00
Simon Charette
f6c208d95c Fixed a flake8 warning. 2014-10-15 16:36:11 -04:00
Collin Anderson
a6a8268d19 Fixed #23660 -- Moved sort_dependencies to core. 2014-10-16 03:04:13 +07:00
Anubhav Joshi
10b17a22be Fixed #19508 -- Implemented uri_to_iri as per RFC. 
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
 2014-10-16 02:31:17 +07:00
Florian Apolloner
3af5af1a61 Fixed remaining test failure in jslex tests. 2014-10-15 17:36:19 +02:00
Florian Apolloner
2ccbaba1f2 Added unicode_literals to the jslexer. 
This ensure that ''.join(c) in jslex.py always returns text.
 2014-10-15 15:09:35 +02:00
Claude Paroz
7a893ee771 Fixed #23651 -- Isolated non-existent fixture tests 
Previous versions of the tests were buggy, as initial_data.json
did exist and the test wasn't failing. It was finally failing on
Python 3.4.2.
Thanks Raphaël Hertzog for the report (and Debian bug #765117
contributors).
 2014-10-15 09:17:44 +02:00
Claude Paroz
7131efa154 Adapted invalid cookie test to all Python versions 
Refs #23638. Older Python versions are less strict when parsing
invalid cookie content. The test just has to ensure Django doesn't
crash.
 2014-10-14 09:30:26 +02:00
Claude Paroz
59d487e7fc Fixed #23638 -- Prevented crash while parsing invalid cookie content 
Thanks Philip Gatt for the report and Tim Graham for the review.
 2014-10-13 17:37:58 +02:00
Florian Apolloner
8d789449c7 Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC. 2014-10-12 22:01:24 +02:00
Konrad Świat
06b11b617e Fixed #23616 - Fixed generic relations in ModelAdmin.list_filter. 
Thanks ranjur for reporting bug, timgraham for review,
and collinanderson for contributing tips.
 2014-10-10 12:10:32 -04:00
Jaap Roes
115c307184 Fixed #23613 -- Deprecated django.utils.checksums 2014-10-10 09:22:20 -04:00
Collin Anderson
4ef9618e12 Avoided requiring sqlparse for a test. 
Refs #23426. Thanks Markus Holtermann for the suggestion.
 2014-10-09 14:59:33 -04:00
Brandon Taylor
16ed35fafc Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows. 2014-10-09 14:58:20 -04:00
Marc Tamlyn
92a17eaae0 Fixed #23627 -- Allowed register_lookup to work as a decorator. 2014-10-09 18:44:58 +01:00
Collin Anderson
d6a87eefd8 Skip another test if sqlparse is not available 
Refs #23426
 2014-10-09 11:54:42 -04:00
Markus Holtermann
f633ba778d Fixed #23609 -- Fixed IntegrityError that prevented altering a NULL column into a NOT NULL one due to existing rows 
Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.
 2014-10-09 21:32:06 +07:00
Tim Graham
30b44cea38 Fixed flake8 warning. 2014-10-08 18:10:50 -04:00
Duncan Parkes
88b6cf4ae4 Fixed #23600 -- Made default_storage aware of more settings changes. 
Added MEDIA_URL, FILE_UPLOAD_PERMISSIONS, and
FILE_UPLOAD_DIRECTORY_PERMISSIONS to the list of settings.
 2014-10-08 18:10:47 -04:00
Artem Rizhov
ca61195827 Fixed #23555 -- Avoided suppressing IndexError in QuerySet.first() and .last() 2014-10-08 14:28:38 -04:00
Loic Bistuer
0eccf8fbea Fixed misplaced test case. 2014-10-08 05:11:09 +07:00
Loic Bistuer
ed37f7e979 Fixed #23611 -- update_or_create failing from a related manager 
Added update_or_create to RelatedManager, ManyRelatedManager and
GenericRelatedObjectManager.
Added missing get_or_create to GenericRelatedObjectManager.
 2014-10-08 03:27:31 +07:00
Jon Dufresne
c1ef234e31 Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes 2014-10-07 13:06:39 -04:00
Browniebroke
d1e87aebf7 Refactored model lookup tests; refs #18586. 2014-10-07 12:04:56 -04:00
Tim Graham
9dff5ce7c7 Fixed #23593 -- Fixed crash in AdminEmailHandler with non-ASCII characters in request. 
Thanks edevil for the report and Simon Charette for review.
 2014-10-06 17:35:53 -04:00
Carl Meyer
6f6e7d01dc Merge pull request #3308 from aericson/ticket_22064 
Fixed #22064 -- Add check for related_name
 2014-10-06 14:06:33 -06:00
Loic Bistuer
ec2fd02bb3 Fixed #23594 -- Fixed deepcopy on ErrorList. 
Thanks Troy Grosfield for the report and Tim Graham for the tests.
 2014-10-07 00:09:55 +07:00
Markus Holtermann
2f16ff5a6c Fixed #23601 -- Ensured view exists in URLconf before importing it in admindocs. 2014-10-06 09:31:39 -04:00
Emmanuelle Delescolle
a24cf21722 Fixed #23604 -- Allowed related m2m fields to be references in the admin. 
Thanks Simon Charette for review.
 2014-10-06 08:35:16 -04:00
André Ericson
1e5e2a4707 Fixed #22064 -- Add check for related_name 
Validates that related_name is a valid Python id or ends with a '+' and
it's not a keyword. Without a check it passed silently leading to
unpredictable problems.

Thanks Konrad Świat for the initial work.
 2014-10-04 20:47:26 -03:00
Jon Dufresne
8c581ff394 Fixed #23482 -- Added SingleObjectMixin.query_pk_and_slug 
Enabling the attribute causes get_object() to perform its lookup
using both the primary key and the slug.
 2014-10-02 15:42:30 -04:00
Markus Holtermann
85f6d89313 Fixed #23426 -- Allowed parameters in migrations.RunSQL 
Thanks tchaumeny and Loic for reviews.
 2014-10-02 11:52:40 -04:00
Seth Hill
fe2afcd318 Fixed #23569 -- Allowed using configs besides dictConfig in LOGGING_CONFIG. 2014-09-30 17:13:27 -04:00
Tim Graham
c7b5883c78 Fixed flake8 warnings. 2014-09-30 13:24:20 -04:00
Nick Sandford
f5cfd09c25 Fixed #7361 -- Added cancel link to admin delete views. 2014-09-30 08:45:04 -04:00
Rudy Mutter
a407b846b4 Fixed #23365 -- Added support for timezone-aware datetimes to migrations. 2014-09-29 20:45:43 -04:00
Thomas Chaumeny
311b3ad9db Fixed #23567 -- Made assertQuerysetEqual check Counter equality when ordered=False 2014-09-29 12:00:14 -04:00
Tim Graham
4b257cf261 Fixed flake8 warnings. 2014-09-29 08:13:40 -04:00
Thomas Chaumeny
b2aad7b836 Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282. 
Thanks Collin Anderson for the review.
 2014-09-29 00:01:38 +07:00
Shai Berger
c1ae0621ba Fixed #22738 -- made finer distinctions for when Boolean is not detected on Oracle 
Thanks Claude Paroz for partial fix and Simon Charrette for review
 2014-09-27 09:49:50 +03:00
Claude Paroz
dbdae3a755 Fixed #22738 -- Abstracted boolean field type introspection 
Thanks maxi for the report, Shai Berger for his help with the patch
and Tim Graham for the review.
 2014-09-26 20:03:44 +02:00
Loic Bistuer
b23d47412c Fixed #23560 -- Fixed MigrationWrite to handle builtin types without imports. 
Thanks Tim Graham for the review.
 2014-09-27 00:36:28 +07:00
Matt Robenolt
ef5f9b6ae8 Fixed #23460 -- Added literal %s support to extra() QuerySets. 2014-09-26 13:01:27 -04:00
Thomas Chaumeny
17557d068c Fixed #8408 -- Added ModelAdmin.show_full_result_count to avoid COUNT() query. 
Thanks lidaobing for the suggestion.
 2014-09-26 12:12:40 -04:00
Markus Holtermann
45bd7b3bd9 Fixed #23455 -- Forced related_name to be a unicode string during deconstruction. 2014-09-25 17:49:44 -04:00
Davide Ceretti
d8e157d5ab Refactored m2m_through tests. Refs #18586 
Refactored old tests that were rewritten 1:1 from doctests.
 2014-09-26 01:28:32 +07:00
Markus Holtermann
215aa4f53b Fixed #23415 -- Added fields for unmanaged and proxy model migrations. 
Thanks sky-chen for the report.
 2014-09-25 10:25:03 -04:00
Marco Buttu
e077c29155 Fixed #23551 -- Fixed bash autocompletion crash on Python 3. 2014-09-25 07:44:22 -04:00
Tim Graham
d7ab2cefb7 Revert "Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations." 
This reverts commit abcf28a076.
 2014-09-24 15:49:30 -04:00
Tim Graham
a4f23eba2e Fixed #23421 -- Corrected TEST SERIALIZE setting. 
Thanks gkoller for the report.
 2014-09-24 14:46:10 -04:00
Markus Holtermann
b9a670b227 Fixed #23426 -- Don't require double percent sign in RunSQL without parameters 2014-09-24 07:20:57 -04:00
Tim Graham
0aca91cf7f Fixed flake8 warnings. 2014-09-24 06:32:42 -04:00
Justin Caratzas
cf43a1ee90 Fixed #23539 -- Added get_extra(), get_max_num(), and get_min_num() hooks to GenericInlineModelAdmin. 2014-09-24 06:32:42 -04:00
Loic Bistuer
2f3a4cd573 Removed numbering from the models.py header of some test packages. 
This is a reliqua from the early days of the modeltests/regressiontests era.
 2014-09-24 17:28:56 +07:00
Shai Berger
d128eac316 Changed Oracle test-user creation to grant privileges instead of roles 
because the roles (specifically RESOURCE) are deprecated.
Also added optional support for creating views in tests, and made an
introspection test fail (rather than skip)  if a view cannot be created
due to lacking privileges.

Refs #18782

Thanks Tim Graham for review, and Josh Smeaton
 2014-09-24 04:58:33 +03:00
Loic Bistuer
e043aae9bb Fixed #23550 -- Normalized get_queryset() of RelatedObjectDescriptor 
and ReverseSingleRelatedObjectDescriptor so they actually return QuerySet
instances.

Also ensured that SingleRelatedObjectDescriptor.get_queryset() accounts
for use_for_related_fields=True.

This cleanup lays the groundwork for #23533.

Thanks Anssi Kääriäinen for the review.
 2014-09-24 02:03:12 +07:00
Loic Bistuer
1fd6e13bf2 Consolidated some many_to_one tests. 2014-09-24 02:03:12 +07:00
Claude Paroz
2a1bdf5ced Called table_names instead of get_table_list in migrations 2014-09-23 20:13:31 +02:00
Claude Paroz
ed297061a6 Fixed #18782 -- Prevented sql_flush to flush views 
Thanks rodolfo_3 for the report and the initial patch, and
Josh Smeaton, Shai Berger and Tim Graham for the reviews.
 2014-09-23 20:13:31 +02:00
Sergey Fedoseev
463952d940 Fixed #23503 -- Fixed renaming of model with self-referential m2m field. 2014-09-23 10:03:37 -04:00
Sergey Fedoseev
83cd18633f Fixed #23065 -- Quoted constraint names in SQL generated by migrations. 2014-09-23 09:25:31 -04:00
Loic Bistuer
3c6ac0bab8 Consolidated some text utils into the utils_tests test package. 2014-09-23 19:45:59 +07:00
Loic Bistuer
0dab07e5da Merged custom_managers_regress into the custom_managers test package. 2014-09-23 03:56:19 +07:00
Loic Bistuer
d42a45de40 Merged custom_columns_regress into the custom_columns test package. 2014-09-23 03:56:19 +07:00
Loic Bistuer
7fe554b2a3 Merged one_to_one_regress into the one_to_one test package. 2014-09-23 03:56:19 +07:00
Claude Paroz
aeb48b9bc5 Fixed an i18n test with native string 
Refs commit 11f307a5a8.
 2014-09-21 17:28:37 +02:00
Yuri Kriachko
11f307a5a8 Fixed #23196 -- Short-circuited empty string translation 
Translating an empty string used to return the gettext catalog
metadata instead of the empty string.
Thanks Ned Batchelder for the suggestion, Tim Graham for the review
and Anton Berezin and Claude Paroz for contributions to the patch.
 2014-09-21 17:08:17 +02:00
Tim Graham
9d30412a5a Fixed some flake8 errors. 
Originally I added migrations to flake8 exclude because of long lines
in migration files, but there are other directories named migrations we
do want to check. We are not warning on line lengths yet anyway.
 2014-09-19 12:31:15 -04:00
Thomas Chaumeny
e008a10c2f Fixed #23443 -- Corrected erroneous FieldError message. 
Thanks Tim Graham for the review.
 2014-09-19 01:01:31 +07:00
Claude Paroz
abc11b0a33 Fixed #23514 -- Prevented queries in PostGISOperations init 
Thanks Mattia Procopio for the report.
 2014-09-18 20:00:35 +02:00
Claude Paroz
fc2b8ddcc8 Fixed #23495 -- Stopped swallowing real settings import error 
Thanks papaloizouc for the report.
 2014-09-17 17:15:44 +02:00
Baptiste Mispelon
d63ac5b595 Fixed #23492 -- Restored F.__deepcopy__. 
This reverts commit 3a66035107.
A regression test was also added.
 2014-09-16 12:19:00 +02:00
Marc Tamlyn
ed7821231b Fixed #19463 -- Added UUIDField 
Uses native support in postgres, and char(32) on other backends.
 2014-09-16 10:08:09 +01:00
valtron
abcf28a076 Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations. 2014-09-15 14:56:59 -04:00
Tim Graham
8ed7834fb2 Fixed occasional selenium test failure on Jenkins with Chrome 36+. 
Previously find_element_by_id('id_password') on the next line failed with
NoSuchElementException and selenium.page_source was
<html xmlns="http://www.w3.org/1999/xhtml"><head></head><body></body></html>.

Possibly related: https://code.google.com/p/selenium/issues/detail?id=1969.
 2014-09-14 20:31:10 -04:00
Jason Hobbs
e1424b2370 Fixed #23397 -- Stripped whitespace from base64 during chunking 
This insures the actual base64 content has a length a multiple of 4.
Also added a test case for the failure.
 2014-09-13 19:06:21 +02:00
Malte Beckmann
22bfc45146 Fixed #23466 -- Removed seconds from all locale time output formats. 2014-09-13 13:00:42 -04:00
José Padilla
5472d18e31 Fixed #23461 -- Added EMAIL_TIMEOUT setting 2014-09-13 09:33:21 -04:00
Szilveszter Farkas
5e32605ce9 Fixed #23483 -- Prevented ImproperlyConfigured with dotted app names 
Made sure the app labels stay unique for the AppConfigStubs, so
migrations wouldn't fail if two dotted app names has the same last part
(e.g. django.contrib.auth and vendor.auth)
 2014-09-12 14:58:54 -06:00
Tim Graham
52ef6a4726 Fixed #17101 -- Integrated django-secure and added check --deploy option 
Thanks Carl Meyer for django-secure and for reviewing.

Thanks also to Zach Borboa, Erik Romijn, Collin Anderson, and
Jorge Carleitao for reviews.
 2014-09-12 15:05:23 -04:00
Andi Albrecht
00535e8e6b Fixed #20743 -- Added support for keyfile/certfile in SMTP connections. 
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
 2014-09-10 11:14:20 -04:00
Markus Bertheau
61f56e239f Corrected grammar in migrations error message. 2014-09-10 10:32:33 -04:00
Markus Holtermann
6d5958c7a3 Fixed #23452 -- Prevented infinite migrations for empty unique/index_together. 
Thanks fwkroon for the report.
 2014-09-10 07:54:16 -04:00
Claude Paroz
b9d9287f59 Fixed urlize after smart_urlquote rewrite 
Refs #22267.
 2014-09-09 21:59:35 +02:00
Claude Paroz
4b8a1d2c0d Fixed #22267 -- Fixed unquote/quote in smart_urlquote 
Thanks Md. Enzam Hossain for the report and initial patch, and
Tim Graham for the review.
 2014-09-09 21:58:07 +02:00
Aymeric Augustin
9562ffea97 Avoid the word "stupid". 
There's always a better word.
 2014-09-09 20:55:57 +02:00
Flavio Curella
c53f2451a8 Fixed #23398 -- Added helpful error message when runserver is accessed via HTTPS 2014-09-09 12:29:30 -04:00
Tim Graham
c32bc1a7a7 Fixed #11775 -- Made ABSOLUTE_URL_OVERRIDES work with models that don't define get_absolute_url(). 
Thanks jukvalim for the report and initial patch,
and Preston Timmons for review.
 2014-09-09 11:05:31 -04:00
Petras Zdanavičius
f7eee04ebe Fixed #23451 -- Fixed typo in inlineformset_factory() error message. 2014-09-08 17:22:23 -04:00
Aymeric Augustin
b161c01c48 Fixed #22920 -- Avoid masking some exceptions. 
If loading an application trigger an ImportError, the details of that
error were lost in some cases. Thanks Ben Davis for the report.
 2014-09-08 23:16:50 +02:00
Tim Graham
d3543af750 Added sorting to some admin_view tests to prevent transient failures; refs #23380. 2014-09-08 17:10:58 -04:00
Markus Holtermann
16548cfc7c Fixed broken test from da160d440f; refs #23418. 2014-09-08 16:49:06 -04:00
Markus Holtermann
d28b5f13b3 Fixed #23418 -- Fail when migration deconstruct produces invalid import 2014-09-08 21:27:34 +02:00
Simon Charette
342ccbddc1 Fixed #23431 -- Allowed inline and hidden references to admin fields. 
This fixes a regression introduced by the 53ff096982 security fix.

Thanks to @a1tus for the report and Tim for the review.

refs #23329.
 2014-09-08 13:49:07 -04:00
Andrew Pinkham
4680d25df2 Fixed #22951 -- Checked for types during deep_deconstruct migration serialization process. 
Thanks Sam Hartsfield for the report.
 2014-09-08 07:39:09 -04:00
Marc Tamlyn
14c8456ffe Fixed #23416 -- Make sure DatabaseCreation respects checks. 
Migrations respected Field.db_parameters()['check'], but
DatabaseCreation was still using just Field.db_type().
 2014-09-06 19:01:06 +01:00
Baylee Feore
f7d3a6255c Fixed #23380 -- Fixed flaky test: admin_filters.tests.ListFiltersTests.test_relatedfield 2014-09-05 20:05:51 -04:00
Andrew Godwin
3ab36d0046 Fix Python 3 incompatability 2014-09-05 15:47:20 -07:00
Ben Reilly
b878c73fc3 switch out recursive dfs for stack based approach, to avoid possibly hitting the recursion limit 2014-09-05 15:26:05 -07:00
Claude Paroz
885ff6845e Revert "Fixed #23384 -- Allowed overriding part of a dictionary-type setting" 
This reverts commit 66757fee7e.
Discussions have led to think that this functionality does not
bring significant benefits to justify the added complexity.
Read also discussions on ticket #22734.
 2014-09-05 20:06:02 +02:00
Tim Graham
f8bb8436e5 Corrected deprecation warning silencing of SubfieldBase. 2014-09-05 09:12:14 -04:00
Marc Tamlyn
e9103402c0 Fixed #18757, #14462, #21565 -- Reworked database-python type conversions 
Complete rework of translating data values from database

Deprecation of SubfieldBase, removal of resolve_columns and
convert_values in favour of a more general converter based approach and
public API Field.from_db_value(). Now works seamlessly with aggregation,
.values() and raw queries.

Thanks to akaariai in particular for extensive advice and inspiration,
also to shaib, manfre and timograham for their reviews.
 2014-09-03 20:36:03 +01:00
Raffaele Salmaso
1435cfbe8d Fixed #23302 -- Added --name/-n option to makemigrations command 2014-09-02 21:09:18 -04:00
Dave Hall
e03b7940e5 Fixed #22918 -- Fixed SeparateDatabaseAndState crash 2014-09-02 08:06:44 -04:00
Thomas Chaumeny
032c091659 Fixed #23388 -- Made django.utils.timezone.override usable as a decorator 2014-08-31 09:03:53 +02:00
Alex Gaynor
8b6cb9d0dd Added a missing word in a skip message 2014-08-30 15:18:58 -07:00
Claude Paroz
5021421799 Fixed #22820 -- Treated int and long types alike in lazy_number 
Thanks kwist for the report and the initial patch.
 2014-08-30 18:51:12 +02:00
Ramiro Morales
3a297d7816 Fixed #23055 -- Made generic admin filter obey ModelAdmin queryset. 
Thanks to Trac user synasius and to Ola Sitarska for helping in
identifying the issue and helping with the test case.
 2014-08-30 10:07:00 -03:00
Aymeric Augustin
df251e033c Fixed a PEP 8 error. 2014-08-30 13:27:56 +02:00
Bas Peschier
eacf244506 Converted sql_queries into a lazily evaluated list. 
Fixed #23364. Thanks Markush2010 for the report.
 2014-08-30 13:27:56 +02:00
Akis Kesoglou
6613ea6e3f Fixed #23370 -- defer() + select_related() crashed with inherited models. 2014-08-30 07:14:44 -04:00
Claude Paroz
66757fee7e Fixed #23384 -- Allowed overriding part of a dictionary-type setting 
This change is needed for upcoming changes where settings might be
grouped in a parent dictionary.
Thanks Tim Graham for the review.
 2014-08-30 12:37:10 +02:00
Joshua "jag" Ginsberg
eb2af16c59 Fixed #21483 -- Added WSGI environ to kwargs sent to request_started signal. 2014-08-29 10:12:03 -04:00
Tim Graham
149605dfb4 Fixed flake8 warning. 2014-08-29 09:42:22 -04:00
Vlastimil Zíma
e622caaa85 Fixed #21201 -- Improved customization of ClearableFileInput. 2014-08-29 09:40:08 -04:00
Andrew Torpedov
bc06d2c11c Fixed #23313 -- Corrected repr(RawQuery) with dict parameters. 2014-08-29 07:22:08 -04:00
Simon Charette
e98c5513cb Fixed an Oracle test failure introduced by 1e404180c1. 2014-08-28 19:33:36 -04:00
Thomas Chaumeny
efcbf3e095 Fixed #23381 -- Context manager restored state should be determined in __enter__ 2014-08-28 19:18:34 -04:00
Simon Charette
1e404180c1 Fixed #23379 -- Corrected a referencing issue in sql_create. 
Thanks to Trac alias flakfizer for the report.
 2014-08-28 15:17:50 -04:00
Thomas Chaumeny
2db1ed1033 Fixed #23323 -- Made django.utils.translation.override usable as a decorator. 2014-08-28 11:58:21 -04:00
Claude Paroz
3a44e20005 Fixed #23374 -- Renamed StaticLiveServerCase to StaticLiveServerTestCase 
Refs #20739. Thanks Raphaël Hertzog for the report and the initial
patch.
 2014-08-28 08:44:26 +02:00
Simon Charette
3cbb7590cb Fixed #23329 -- Allowed inherited and m2m fields to be referenced in the admin. 
Thanks to Trac alias Markush2010 and ross for the detailed reports.
 2014-08-27 21:26:53 -04:00
Jon Dufresne
f0d3dd4f04 Fixed #23357 -- Added small int introspection support to MySQL backend. 
In the MySQL backend, updated the can_introspect_small_integer feature
flag to True. In data_types_reverse, map FIELD_TYPE.SHORT to a
SmallIntegerField. Added test to verify introspecting SmallIntegerFields
and fixed existing tests influenced by this change.
 2014-08-27 10:58:44 -04:00
areski
a81af7f49d Fixed #13749 -- Added link from admin site to front-end site. 
Thanks romankrv for the suggestion.
 2014-08-27 08:34:53 -04:00
Claude Paroz
00f8b4dfae Lowered memory consumption in debug ouput test 2014-08-26 22:42:41 +02:00
Claude Paroz
5675eb371f Allowed skipIf/UnlessDBFeature to accept several feature strings 2014-08-26 20:03:37 +02:00
Tim Graham
e0cf030194 Removed unnecessary absolute_imports. 2014-08-25 10:07:14 -04:00
Raffaele Salmaso
abd640fbdf Fixed #23341 -- Added migration name to nonexistent migration error in makemigrations. 2014-08-23 19:18:03 -04:00
Raffaele Salmaso
be4baaefe2 Fixed #23352 -- Added tests for MigrationGraph.{forwards,backwards}_plan 2014-08-23 21:35:13 +00:00
Ian Foote
03d89168a2 Fixed #23333 -- Made urlsafe_base64_decode() return proper type on Python 3. 2014-08-22 20:07:12 -04:00
Tim Graham
f9c7732e96 Tweaked docstrings from previous commit. 2014-08-22 15:57:15 -04:00
areski
a6691e5dcf Fixed #23167 -- Added BaseForm.__repr__() 
Thanks Keryn Knight for the idea.
 2014-08-22 15:55:56 -04:00
Shai Berger
56252e7f46 Fixed schema test for Oracle 11.2.0.1 which is used in Django Project's CI. 
Refs #23073 Workaround.

Refs #22738 Repeats the mysql "offense". When the issue is solved, the
Oracle special case should be made to play with the solution (that is,
Oracle should be fixed the same way that mysql and the 3rd-party backneds
are).
 2014-08-22 05:08:53 +03:00
Markus Holtermann
144cff3f51 Fixed #23322 -- Use resolved swappable model for dependency resolution during makemigrations 2014-08-20 16:04:21 -04:00
Simon Charette
53ff096982 Prevented data leakage in contrib.admin via query string manipulation. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Tim Graham
0d8d30b7dd Fixed #23157 -- Removed O(n) algorithm when uploading duplicate file names. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Florian Apolloner
28e765810d Prevented reverse() from generating URLs pointing to other hosts. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Tim Graham
6f59d29158 Fixed flake8 warnings. 2014-08-20 14:37:33 -04:00
Tim Graham
d1299fce0e Fixed migrations tests added in refs #23315. 2014-08-20 14:00:59 -04:00
Andrew Godwin
9247da1032 Fixed #23315: Operational dependency fail with mixed create/add 2014-08-19 19:51:12 -07:00
Unai Zalakain
5f2542f12a Fixed #10190 -- Made HttpResponse charset customizable. 
Thanks to Simon Charette, Aymeric Augustin, and Tim Graham
for reviews and contributions.
 2014-08-19 17:34:38 -04:00
Claude Paroz
fa02120d36 Fixed #22996 -- Prevented crash with unencoded query string 
Thanks Jorge Carleitao for the report and Aymeric Augustin, Tim Graham
for the reviews.
 2014-08-19 22:29:31 +02:00
Lee Sanghyuck
11d9cbe2f4 Fixed #23316 -- Added datetime.time serialization in migrations. 2014-08-19 13:31:46 -04:00
Baptiste Mispelon
54164b814c Fixed broken tests on Oracle after 5853c87a45. 
Oracle doesn't have a `BEGIN` statement so the test would
fail.

Refs #23303
 2014-08-19 17:58:30 +02:00
Claude Paroz
6295ea0027 Replaced HAS_SPATIAL_DB by testing database feature 
Refs #22632. This should be the base for using more database
features to exclude specific backends in GIS tests.
Thanks Tim Graham for the review.
 2014-08-19 17:57:01 +02:00
Claude Paroz
132d0e516e Fixed #22171 -- Improved sanitize_separators cleverness 
Thanks Klaas van Schelven for the report and Tim Graham for the
review.
 2014-08-18 19:57:50 +02:00
Claude Paroz
a3d7f58151 Removed test, duplicate of admin_scripts.CommandTypes tests 2014-08-18 19:55:05 +02:00
Tim Graham
f76222e1d3 Fixed flake8 warning. 2014-08-18 13:44:10 -04:00
Gabriel Muñumel
3e241313a4 Fixed #23136 -- Added a message when sqlclear does nothing 2014-08-18 13:20:29 -04:00
Baptiste Mispelon
5853c87a45 Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate. 2014-08-18 18:55:12 +02:00
Raffaele Salmaso
e0a98e2374 Fixed #23309 -- Fixed call_command to parse args correctly 2014-08-18 17:54:24 +02:00
Collin Anderson
230393e5e8 Fixed #23295 -- Removed unnecessary fix_location_header request.get_host() check. 2014-08-15 14:59:36 -04:00
Peter Harley
2724cdbff6 Fixed #18355 -- Added ordering options to list based generic views. 
Added MultipleObjectMixin.ordering and get_ordering().

Refs #21450.
 2014-08-15 11:09:47 -04:00
Tim Graham
0ad4672c0f Fixed typo in tests/migrations/test_operations.py 2014-08-15 11:01:49 -04:00
Tim Graham
e122facbd8 Fixed #23269 -- Deprecated django.utils.remove_tags() and removetags filter. 
Also the unused, undocumented django.utils.html.strip_entities() function.
 2014-08-15 08:20:02 -04:00
Gabriel Muñumel
deed00c0d8 Fixed #23162 -- Renamed forms.Field._has_changed() to has_changed(). 2014-08-15 08:14:45 -04:00
Andrew Godwin
4d2f9c38e8 Fixed #23288: deconstruct() ignoring related_name 2014-08-14 19:47:22 -07:00
areski
3021453285 Fixed #20133 -- Added summary to admin deletion confirmation pages. 
Thanks jonash for the suggestion and initial patch.
 2014-08-14 13:56:23 -04:00
Jaap Roes
b3660d28f3 Fixed #23260: Added generator support to defaultfilters.unordered_list. 2014-08-14 10:43:44 -04:00
Tim Graham
fe38be96c1 Fixed #21579 -- Made LocaleMiddleware respect script prefix. 
Thanks buettgenbach at datacollect.com for the report and patch.
 2014-08-14 09:36:41 -04:00
Claude Paroz
b42e5ca058 Fixed #22971 -- Properly parsed RFC 2388 encoded headers 
Thanks homm for the report, Cea Stapleton for patch improvements
and Ian Cordasco, Christian Schmitt and Tim Graham for the review.
 2014-08-14 11:45:43 +02:00
Florian Apolloner
7244a8d0ae Fixed test failure on python 3.x. 2014-08-14 09:58:15 +02:00
Maxime Turcotte
25e06bca57 Fixed #18767 -- Fixed admin calendar for other locales than English. 
Refactored openCalendar function from DateTimeShortcuts.js. Now, when
entered manually in the input field, the date will show up correctly on
the calendar for locales that don't use "-" for separator.

Thanks charettes for revivew and Alexey Boriskin for some of the patch.
 2014-08-13 20:36:26 -04:00
Shai Berger
2a9f44dfbe Fixed #21603 (again) -- Made a raw query in a test Oracle-compliant 2014-08-14 03:19:22 +03:00
zsoldosp
01801edd37 Fixed #22646: Added support for the MySQL ssl-ca option to dbshell. 2014-08-13 18:29:42 -04:00
Walter Doekes
e0e28bfe71 Fixed #20368 -- Made TECHNICAL_500 more robust against bad input. 
This limits large variables and avoids non-utf-8 in the TECHNICAL_500 output.
 2014-08-13 12:56:26 -04:00
Tim Graham
d38a00332e Updated tests for added newlines in 6868643063. 2014-08-12 20:16:04 -04:00
Trey Hunner
6868643063 Added newlines to the ends of CSS, HTML, and JavaScript files missing them. 2014-08-12 19:22:09 -04:00
Collin Anderson
85c22dd4c4 Fixed #23262 -- Made SelectFilter2.js move items on enter Key press. 2014-08-12 16:17:00 -04:00
Claude Paroz
2cc8ffe258 Fixed #22985 -- Made call_command accept option name parameter 
Thanks giulettamasina for the report and Tim Graham for the review.
 2014-08-12 21:53:29 +02:00
Andrew Godwin
8f9862cd4d Fixed #23275: Unmanaged models kept by autodetector, ignored by ops 2014-08-12 12:49:20 -07:00
Tim Graham
a9fd740d22 Fixed #23276 -- Deprecated passing views as strings to url(). 2014-08-12 13:15:40 -04:00
Anssi Kääriäinen
f7dba61881 Avoided creation of deferred model from another deferred model 
Also never create deferred model when no attrs are deferred.
 2014-08-12 14:58:10 +03:00
Josh Smeaton
5b0375ec3e Fixed #23001 -- Fixed mixing defer and annotations 2014-08-12 14:58:10 +03:00
Jaap Roes
e92b057e06 Fixed #23261 -- Deprecated old style list support for unordered_list filter. 2014-08-11 07:04:33 -04:00
Anssi Kääriäinen
dfadbdac6a Fixed #16426 -- deletion of 1000+ objects with relations on SQLite 
SQLite doesn't work with more than 1000 parameters in a single query.
The deletion code could generate queries that try to get related
objects for more than 1000 objects thus breaking the limit. Django now
splits the related object fetching into batches with at most 1000
parameters.

The tests and patch include some work done by Trac alias NiGhTTraX in
ticket #21205.
 2014-08-11 12:47:37 +03:00
Anubhav Joshi
cdfdcf4b70 Fixed #23266 -- Prevented queries caused by type checking lookup values 
Small modifications done by committer.
 2014-08-11 09:51:57 +03:00
Rajiv Makhijani
f0b358880a Fixed #23259 -- Corrected insertion order of extra() select_params 
A regression caused queries to produce incorrect results for cases where
extra(select) is excluded by values() but included by extra(order_by)

The regression was caused by 2f35c6f10f.
 2014-08-11 09:33:18 +03:00
Andrew Godwin
27b6f28435 Fixed #23264: Schema backends honour db_constraint 2014-08-09 17:50:00 +10:00
Justin Hamade
8fe406864c Fixed #22336 -- Added path matching for makemessages ignore option 
This fixes a regression introduced by 9012a9e200.
 2014-08-08 22:54:30 +02:00
Tim Graham
f53b1c779b Fixed #23099 -- Removed usage of deprecated initial data in Django's test suite. 
Thanks Claude Paroz for assistance with debugging the tests.
 2014-08-08 14:01:59 -04:00
Jacob Haslehurst
f676305ece Fixed #22982 -- Added GenericRelatedObjectManager.__str__. to prevent crash. 
Thanks bendavis78 for the report.

Forwardport of 29585e9b6a from stable/1.7.x
 2014-08-07 14:44:20 -04:00
Tim Graham
57b60f9f93 Added a missing unicode_literals that caused a test failure after refs #23226. 2014-08-07 08:30:50 -04:00
Andrew Godwin
dfe86449c9 Fixed #23244: Error altering FK to non-FK in migrations 2014-08-07 11:52:31 +10:00
Alex Hill
938da36cb1 Fixed #21603 -- Fixed complex RawQuerySets queries on some versions of SQLite. 2014-08-06 08:41:34 -04:00
Tim Graham
fcd42a4819 Removed code that assumed BooleanField could be null. 
Such a field will no longer pass model validation.
 2014-08-05 07:49:53 -04:00
Shai Berger
746f2a4bed Fixed #23061: Avoided setting a limit on a query for get with select_for_update on Oracle 
Thanks Michael Miller for reporting the issue.
 2014-08-05 03:12:08 +03:00
Florian Apolloner
6d256ae248 Fixed test failures from 98e8da3709. 2014-08-04 16:54:43 +02:00
Tim Graham
b50ea73e1e Fixed two tests in previous commit; refs #16311. 2014-08-04 10:21:13 -04:00
Stanislas Guerra
98e8da3709 Fixed #16311 -- Added a RelatedOnlyFieldListFilter class in admin.filters. 2014-08-04 09:39:02 -04:00
Vincent-Vega
5e06fa1469 Fixed #22745 -- Prevented reevaluation of ModelChoiceField's queryset when accesssing BoundField's attrs. 
Thanks Christian Schmitt for review.
 2014-08-04 07:47:37 -04:00
Andrew Godwin
c06e124b5e Fixed #23091: CreateModel and AddField were clashing with deferred SQL 2014-08-04 11:59:29 +10:00
Simon Charette
1b00738f73 Fixed a MySQL test failure introduced by cbb29af1aa. 
Seems like unlike other backends MySQL get_constraints fails when dealing
with a non-existing table. refs #23160.
 2014-08-03 16:32:36 -04:00
Simon Charette
cbb29af1aa Fixed #23160 -- Correctly rename models with self referential fields. 
Thanks to whitews AT gmail for the report.
 2014-08-03 15:27:01 -04:00
Florian Apolloner
40fb6a5601 Revert "Fixed #23088 -- Used six range type in Paginator.page_range." 
This reverts commit 6508db2ff9.

Refs #23088.
 2014-08-03 21:08:24 +02:00
Tim Graham
6e77acc589 Fixed flake8 warning. 2014-08-03 14:21:45 -04:00
qingfeng
0d23450e81 Fixed #19802 -- Fixed HttpResponse.set_cookie() with unicode data on Python 2. 
Thanks django at patrickbregman.eu for the report.
 2014-08-03 12:50:25 -04:00
Tim Graham
0f2ceee025 Fixed #23151 -- Deprecated RegexField.error_message. 
Thanks Baptiste Mispelon for the suggestion.
 2014-08-03 11:21:01 -04:00
Baptiste Mispelon
7432533932 Added missing logic to TimeField.deconstruct(). 
If auto_now or auto_now_add was used then the serialized
field in the migration contained unnecessary `editable` and
`blank` arguments.
 2014-08-03 14:02:21 +02:00
Baptiste Mispelon
72f1eb48df Fixed #23156 -- Added missing BinaryField.deconstruct() method. 2014-08-03 13:02:31 +02:00
Tim Graham
d28396f526 Fixed #23144 -- Dropped support for MySQL 5.0, 5.1. 2014-08-02 10:28:40 -04:00
Tim Graham
a9bdce7e55 Fixed #23108 -- Dropped support for PostgreSQL 8.4 & PostGIS 1.3, 1.4. 
Thanks Claude Paroz for the review.
 2014-08-01 10:26:00 -04:00
Petras Zdanavičius
8b7347220f Fixed #23103 -- Annotated ImageField file with image and content_type attributes. 
Thanks Jeremy Dunck for the suggestion and Nick Sanford for review.
 2014-08-01 09:30:58 -04:00
Niclas Olofsson
cdc25ac474 Fixed #22808 -- Made ModelMultipleChoiceField validation more robust to invalid data types.. 
Thanks Mattias Lindvall for the report and inital patch.
 2014-07-31 15:29:46 -04:00
Anubhav Joshi
0dd05c9e66 Fixed #16383 -- Raised the AttributeError raised in property of an object when used in a template. 
Thanks maraujop for the report and Hiroki and Tim Graham for review.
 2014-07-31 09:13:55 -04:00
Nick Sandford
9d9f0acd7e Fixed #13163 -- Added ability to show change links on inline objects in admin. 
Thanks DrMeers for the suggestion.
 2014-07-31 08:07:28 -04:00
Tim Graham
9a922dcad1 Fixed flake8 warnings. 2014-07-31 08:06:46 -04:00
Florian Apolloner
4453c80634 Fixed the previous commit for Python3. 2014-07-30 22:22:04 +02:00
areski
97a38de230 Fixed #23112 -- Field.get_choices tries to index an iterable 2014-07-30 21:35:02 +02:00
Tim Graham
c2ab501bab Fixed test failure on Windows. 
os.close(fd) is needed to avoid "The process cannot access the file
because it is being used by another process"
 2014-07-30 14:31:59 -04:00
Christoph Heer
d47409831f Fixed #23067 -- Updated docs to use django-admin 2014-07-30 14:14:03 -04:00
Tim Graham
34c60c42b6 Fixed flake8 errors. 2014-07-30 12:58:53 -04:00
areski
67d7da5fb9 Fixed #23107 -- Made runserver output respect --no-color. 2014-07-30 12:58:53 -04:00
Kit La Touche
17e75d03f9 Fixed #23129 -- Added 'true' and 'false' to NullBooleanField. 
JavaScript serializations of forms will sometimes render the boolean
values as the strings 'true' and 'false', in lower case. Rather than
repeat boilerplate in the JavaScript to circumvent this, it seems
reasonable to allow Django to understand the lower-case versions of the
booleans.
 2014-07-29 19:55:55 -04:00
Andrew Godwin
a338e07735 Fixed #23101: Prefer doing deletes before creates in autodetector. 
Makes declined or missed renames still work (but drop data).
 2014-07-29 09:38:51 -07:00
Marc Tamlyn
ef9f109013 Fixed #22962 -- Default values for ArrayField with migrations. 
Fields normally try to force the default value to a string. As
translatable strings are not valid default values for ArrayField, we can
remove this behaviour which was causing issues with some migrations.

Thanks to @schinckel for the report.
 2014-07-29 10:37:11 +01:00
Andrew Godwin
d6e73a876d Fixed #23121: AlterModelOptions operation not changing state right 2014-07-28 10:47:28 -07:00
Andrew Godwin
cb60d22bd9 Fixed #23100: Individual FK creation missing dependencies 2014-07-28 10:32:43 -07:00
Simon Charette
80708ac772 Fixed #23113 -- ChoiceInput.render should take specified attrs into account. 
Thanks to Tim Graham for the review.
 2014-07-28 10:01:07 -04:00
Aymeric Augustin
729e4ae4f0 Fixed #23074 -- Avoided leaking savepoints in atomic. 
Thanks Chow Loong Jin for the report and the initial patch.
 2014-07-28 14:30:41 +02:00
Florian Apolloner
2f73b527dd Fixed #23098 -- Checked that lazy choices are not evaluated too soon 
Thanks Matthieu Agopian for the report.
 2014-07-27 13:31:25 +02:00
Tushar Bhatia
11181a64f9 Fixed #22979 -- Moved bug* tests 2014-07-26 21:05:49 -04:00
Abraham Martin
e1347e9253 Fixed #23101 db_table wasn't copied in deconstruct 
Forward port of 999758fc7a from
stable/1.7.x
 2014-07-26 10:00:02 -07:00
Andrew Godwin
805774df1f Fixed #22944: Bad dependency on FK alteration in autodetector 2014-07-26 09:22:19 -07:00
qingfeng
08451f17d0 Fixed #23060 -- Prevented UnicodeDecodeError in debug templatetag 2014-07-26 18:03:19 +02:00
Anubhav Joshi
5cdb8f8c1e Fixed #16617 -- Added 'value' to BaseValidator params. 
Also allowed overriding the default messages in subclasses of BaseValidator.

Thanks sperrygrove for initial patch.
 2014-07-26 10:03:00 -04:00
Hiroki KIYOHARA
d0889863de Fixed code to solve #23070 problem 
Added a class to wrap callable in settings:
* Not to call in the debug page (#21345).
* Not to break the debug page if the callable forbidding to set attributes (#23070).

Thanks @bmispelon for giving me some advice.
 2014-07-26 12:35:51 +02:00
Hiroki KIYOHARA
e569144910 Added test for the #23070 problem 2014-07-26 12:01:44 +02:00
Tim Graham
57d2b3f2a7 Fixed bad usage of rstrip() that caused test failure. 
If the temporary file name contained a p or y as its last
characters, it would be stripped. refs #23083.
 2014-07-25 15:16:47 -04:00
Tim Graham
b8cb5ba708 Fixed #23083 -- Fixed runserver reloading when deleting a file. 
Thanks Collin Anderson for the report and hirokiky for the fix.
 2014-07-25 13:23:52 -04:00
Andrew Godwin
a64bc3df77 Fixed #23093: soft application detection for swapped models 2014-07-25 09:35:38 -07:00
Andrew Godwin
ed4812692e Merge pull request #2938 from dekkers/ticket_23071 
Fixed #23071 -- Use last migration's name in dependency to other app
 2014-07-25 08:53:57 -07:00
Moayad Mardini
6508db2ff9 Fixed #23088 -- Used six range type in Paginator.page_range. 2014-07-25 11:04:58 +03:00
Tim Graham
64e75c47ef Fixed #23014 -- Infinite migration regression with unique/index_together. 2014-07-24 14:27:10 -04:00
Anubhav Joshi
b1abfb3c59 Fixed #21707 -- Added helpful error message when using {{ block.super }} in base template. 
Thanks mitar for the suggestion.
 2014-07-24 14:22:19 -04:00
Tim Graham
99cd80dc74 Silenced test warning for deprecated IPAddressField. 2014-07-24 11:27:26 -04:00
Tim Graham
66211b4b75 Silenced a Python 2 ImportWarning in a migrations test. 2014-07-24 09:24:52 -04:00
Tim Graham
577ced2aae Silenced OptionParser deprecation warning in a test. 2014-07-24 08:51:47 -04:00
Tim Graham
936fba5878 Improved patching of sys.stdout in refs #23078. 2014-07-24 08:46:29 -04:00
Tim Graham
9b1515906e Removed usage of deprecated switch_to_*() selenium methods. 2014-07-24 08:25:15 -04:00
Nick Sandford
fa3cf006b2 Fixed #23078 -- Regression in update_contenttypes() interactivity. 
Thanks raymond at adaptiv.nl for the report.
 2014-07-23 08:45:09 -04:00
Jeroen Dekkers
3582698c13 Fixed #23071 -- Use last migration's name in dependency to other app 
Changed the autodetector to lookup the name of the other app's last
migration in the graph and use that as dependency instead of using
__latest__.
 2014-07-22 01:03:02 +02:00
Andrew Godwin
e24e9e0438 Fixed #23014: Renaming not atomic with unique together 2014-07-21 11:36:34 +01:00