mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 01:25:32 +00:00
Code Issues 32 Releases Wiki Activity
24,689 Commits 30 Branches 460 Tags
8df7681d0e3b39cda9393c8e59f13b5681cc2f2f
Commit Graph

55 Commits

Author SHA1 Message Date
Mads Jensen
a51c4de194 Used assertRaisesMessage() to test Django's error messages. 2017-07-29 19:07:23 -04:00
Jon Dufresne
2c69824e5a Refs #23968 -- Removed unnecessary lists, generators, and tuple calls. 2017-06-01 19:08:59 -04:00
François Freitag
ec05ff086c Refs #25546 -- Added detailed comments for prefetch_related test. 2017-05-04 09:19:54 -04:00
François Freitag
c0a2b9508a Fixed #27554 -- Fixed prefetch_related() crash when fetching relations in nested Prefetches. 2017-05-04 09:17:29 -04:00
Claude Paroz
43b4a1618e Fixed #28096 -- Allowed prefetch calls with ModelIterable subclasses 
Regression in 7ec330eeb9.
Thanks Tim Graham for the review.
 2017-04-19 19:32:46 +02:00
Tim Graham
6b4f018b2b Replaced type-specific assertions with assertEqual(). 
Python docs say, "it's usually not necessary to invoke these methods directly."
 2017-03-17 07:51:48 -04:00
Claude Paroz
2366100872 Removed unneeded force_text calls in the test suite 2017-01-24 18:45:54 +01:00
Claude Paroz
7b2f2e74ad Refs #23919 -- Removed six.<various>_types usage 
Thanks Tim Graham and Simon Charette for the reviews.
 2017-01-18 20:18:46 +01:00
Claude Paroz
d7b9aaa366 Refs #23919 -- Removed encoding preambles and future imports 2017-01-18 09:55:19 +01:00
Tim Graham
b70094f040 Refs #26226 -- Removed support for related manager classes without a _apply_rel_filters() method. 
Per deprecation timeline.
 2017-01-17 20:52:03 -05:00
François Freitag
ee1c1c696b Made prefetch_related SQL inspection tests less brittle. 
After refs #16614, integers might appear outside the WHERE clause.
 2017-01-09 11:18:32 -05:00
Ramin Farajpour Cami
0a63ef3f61 Fixed #27463 -- Fixed E741 flake8 warnings. 2016-11-14 17:40:28 -05:00
za
321e94fa41 Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings. 2016-11-10 21:30:21 -05:00
Simon Charette
271bfe65d9 Fixed #26916 -- Fixed prefetch_related when using a cached_property as to_attr. 
Thanks Trac alias karyon for the report and Tim for the review.
 2016-07-19 16:05:07 -04:00
Simon Charette
53a5fb3cc0 Fixed #26676 -- Prevented prefetching to_attr from caching its result in through attr. 
Thanks Ursidours for the report.
 2016-05-31 14:32:58 -04:00
Simon Charette
7ec330eeb9 Refs #26565 -- Errored nicely when using Prefetch with a values() queryset. 
Thanks Maxime Lorant for the report and Anssi for the suggestion.
 2016-05-03 09:28:31 -04:00
Tim Graham
92053acbb9 Fixed E128 flake8 warnings in tests/. 2016-04-08 10:12:33 -04:00
Simon Charette
c92123cc1d Fixed #26226 -- Made related managers honor the queryset used for prefetching their results. 
Thanks Loïc for the suggested improvements and Tim for the review.
 2016-03-02 16:10:18 -05:00
Simon Charette
5d240b070d Refs #17001 -- Added a test for custom prefetch related queryset on generic relations. 2016-03-02 16:08:37 -05:00
Simon Charette
c30086159d Used setupTestData in prefetch_related tests. 2016-02-23 13:53:58 -05:00
François Freitag
bdbe50a491 Fixed #25546 -- Prevented duplicate queries with nested prefetch_related(). 2016-01-26 07:20:13 -05:00
Ian Foote
86eccdc8b6 Fixed #25544 -- Removed duplicate ids in prefetch_related() queries. 2015-12-17 19:08:30 -05:00
Simon Charette
cc8c02fa0f Refs #25693 -- Added a regression test for to_attr validation on forward m2m. 2015-11-11 12:25:10 -05:00
Ian Foote
4608573788 Fixed #25693 -- Prevented data loss with Prefetch and ManyToManyField. 
Thanks to Jamie Matthews for finding and explaining the bug.
 2015-11-10 12:12:07 -05:00
Aymeric Augustin
e542e81b39 Renamed descriptor classes for related objects. 
The old names were downright confusing. Some seemed to mean the opposite
of what the class actually did.

The new names follow a consistent nomenclature:

    (Forward|Reverse)(ManyToOne|OneToOne|ManyToMany)Descriptor.

I mentioned combinations that do not exist in the docstring in order to
help people who would search for them in the code base.
 2015-09-21 22:20:42 +02:00
Dražen Odobašić
b1e33ceced Fixed #23395 -- Limited line lengths to 119 characters. 2015-09-12 11:40:50 -04:00
Gagaro
74261bc593 Fixed #24873 -- Prevented nested Prefetch objects from being overwritten. 2015-06-18 15:42:47 -04:00
Tim Graham
0ed7d15563 Sorted imports with isort; refs #23860. 2015-02-06 08:16:28 -05:00
Jon Dufresne
4468c08d70 Fixed #23968 -- Replaced list comprehension with generators and dict comprehension 2014-12-08 07:58:23 -05:00
Berker Peksag
f7969b0920 Fixed #23620 -- Used more specific assertions in the Django test suite. 2014-11-03 11:56:37 -05:00
Tim Graham
4b257cf261 Fixed flake8 warnings. 2014-09-29 08:13:40 -04:00
Thomas Chaumeny
b2aad7b836 Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282. 
Thanks Collin Anderson for the review.
 2014-09-29 00:01:38 +07:00
Aymeric Augustin
9562ffea97 Avoid the word "stupid". 
There's always a better word.
 2014-09-09 20:55:57 +02:00
Aymeric Augustin
ae3fe6ccbb Reordered setUp code in prefetch_related tests. 
This allows these tests to run on databases that reject duplicate NULL
values in unique fields e.g. SQL Server.

Forward port of 4fb50a9a from stable/1.7.x.
 2014-06-05 16:33:02 +02:00
Loic Bistuer
870b0a1f86 Fixed the ordering of prefetch lookups so that latter lookups can refer to former lookups. 
Thanks Anssi Kääriäinen and Tim Graham for the reviews. Refs #17001 and #22650.
 2014-05-21 10:30:48 +07:00
Loic Bistuer
bdf3473e64 Fixed #22650 -- Fixed regression on prefetch_related. 
Regression from f51c1f59 when using select_related then prefetch_related
on the reverse side of an O2O:

Author.objects.select_related('bio').prefetch_related('bio__books')

Thanks Aymeric Augustin for the report and tests. Refs #17001.
 2014-05-21 10:26:04 +07:00
Simon Charette
79f05616fb Fixed flake8 warnings introduced in recent commits. 2014-04-16 16:49:37 -04:00
Loic Bistuer
b82f30785f Fixed stray comment introduced by d3b71b9. 
Thanks Claude Paroz for the report.
 2014-04-13 08:26:25 +07:00
valtron
d3b71b976d Fixed #21760 -- prefetch_related used an inefficient query for reverse FK. 
Regression introduced by commit 9777442. Refs #21410.
 2014-04-13 00:34:16 +07:00
Loic Bistuer
7bbb6958dc Allowed custom querysets when prefetching single valued relations 
The original patch for custom prefetches didn't allow usage of custom
queryset for single valued relations (along ForeignKey or OneToOneKey).
Allowing these enables calling performance oriented queryset methods like
select_related or defer/only.

Thanks @akaariai and @timgraham for the reviews. Refs #17001.
 2014-03-03 21:35:19 +02:00
Aymeric Augustin
e32095616c Imported override_settings from its new location. 2013-12-23 21:37:56 +01:00
Loic Bistuer
6685713869 Fixed E127 pep8 warnings. 2013-12-14 11:59:15 -05:00
Loic Bistuer
cb83448891 Fixed #21410 -- prefetch_related() for ForeignKeys with related_name='+' 
Regression introduced by commit 9777442.

Thanks to trac username troygrosfield for the report and test case.
 2013-11-13 07:35:34 +02:00
Tim Graham
536c447820 Fixed a couple flake8 warnings. 2013-11-07 20:10:25 -05:00
Loic Bistuer
f51c1f5900 Fixed #17001 -- Custom querysets for prefetch_related. 
This patch introduces the Prefetch object which allows customizing prefetch
operations.

This enables things like filtering prefetched relations, calling select_related
from a prefetched relation, or prefetching the same relation multiple times
with different querysets.

When a Prefetch instance specifies a to_attr argument, the result is stored
in a list rather than a QuerySet. This has the fortunate consequence of being
significantly faster. The preformance improvement is due to the fact that we
save the costly creation of a QuerySet instance.

Thanks @akaariai for the original patch and @bmispelon and @timgraham
for the reviews.
 2013-11-07 14:49:49 +02:00
Alex Gaynor
9d740eb8b1 Fix all violators of E231 2013-10-26 12:15:03 -07:00
Tim Graham
96d1d4e292 Removed unused local variables in tests. 2013-10-19 08:31:38 -04:00
Alasdair Nicol
a800036981 Fixed #21287 -- Fixed E123 pep8 warnings 2013-10-18 10:07:39 +01:00
Alasdair Nicol
bab9123daa Fixed #21268 -- Fixed E303 pep8 warnings 2013-10-18 01:46:24 +01:00
Alasdair Nicol
dfb4cb9970 Fixed #21285 -- Fixed E121,E122 pep8 warnings 2013-10-17 20:20:11 -04:00