mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-27 03:25:58 +00:00
Code Issues 30 Releases Wiki Activity
26,981 Commits 28 Branches 426 Tags 668 MiB
8bdc7a6778
Commit Graph

163 Commits

Author SHA1 Message Date
Ed Morley
674e3fe13e Fixed #19914 -- Fixed test failures with pylibmc. 2016-08-29 11:03:59 -04:00
Ed Morley
047c1d48a6 Fixed #27132 -- Allowed testing MemcachedCache and PyLibMCCache during the same test run. 2016-08-29 10:57:52 -04:00
Ed Morley
cfd1f93d55 Refs #19914 -- Split the test_invalid_keys cache test into two. 
The first half of the test fails when using pylibmc (so will need
to be skipped).
 2016-08-29 10:21:20 -04:00
Ed Morley
606a303856 Fixed #27124 -- Excluded cull-related cache configs from memcached tests. 
Since the `cull` and `zero_cull` test cache configs set `MAX_ENTRIES`
and `CULL_FREQUENCY` in `OPTIONS`, which are only intended for use with
the locmem, filesystem, and database backends. This prevents test
failures once refs #20892 is fixed.
 2016-08-26 14:29:22 -04:00
Dmitry Dygalo
ca32979cdc
Made miscellaneous code cleanups 2016-07-21 10:08:19 -04:00
Dmitry S..ky / skype: dvska-at-skype
82be474efa Fixed #26792 -- Allowed None for the value of cache.get_or_set(). 2016-07-11 20:49:27 -04:00
Tobias McNulty
17e661641d Refs #26666 -- Added ALLOWED_HOSTS validation when running tests. 
Also used ALLOWED_HOSTS to check for external hosts in assertRedirects().
 2016-06-20 11:07:46 -04:00
Jon Dufresne
4f336f6652 Fixed #26747 -- Used more specific assertions in the Django test suite. 2016-06-16 14:19:18 -04:00
Jon Dufresne
779829662d Fixed #26694 -- Made FileBasedCache.get() reraise non-ENOENT IOErrors. 2016-06-01 15:29:24 -04:00
Tim Graham
92053acbb9 Fixed E128 flake8 warnings in tests/. 2016-04-08 10:12:33 -04:00
Przemysław Suliga
90ce5d46bf Fixed #26462 -- Fixed Python 2 UnicodeEncodeError when warning about long cache keys. 2016-04-05 11:16:04 -04:00
Przemysław Suliga
d356bb653f Fixed #26460 -- Issued a single warning for invalid cache key 2016-04-04 15:20:55 -04:00
Przemysław Suliga
96ec67a7cf Fixed #26332 -- Fixed a race condition in BaseCache.get_or_set(). 2016-03-08 11:44:37 -05:00
George Marshall
75614f6d4c Fixed #26331 -- Fixed test function names with typos 2016-03-07 11:58:21 +01:00
Hasan
3d0dcd7f5a Refs #26022 -- Used context manager version of assertRaises in tests. 2016-01-29 12:32:18 -05:00
Emre Yilmaz
8e838d9c86 Fixed #25840 -- Fixed BaseCache.get_or_set() on the DummyCache backend. 
This also fixes a possible data eviction race condition between
setting and getting a key. Another thread could remove the key
before get_and_set() accesses it again. In this case, now the
default value will be returned instead of None.
 2015-12-04 12:22:17 -05:00
Dwight Gunning
1f29164ced Fixed #6727 -- Made patch_cache_control() patch an empty Cache-Control header. 2015-11-09 14:26:29 -05:00
Tim Graham
bab9c09342 Fixed spelling of "unpicklable" in cache tests. 2015-10-21 11:56:30 -04:00
Andrew Artajos
48888a1a67 Fixed #25501 -- Made the file-based cache backend use the highest pickling protocol. 2015-10-20 13:05:33 -04:00
Dražen Odobašić
b1e33ceced Fixed #23395 -- Limited line lengths to 119 characters. 2015-09-12 11:40:50 -04:00
Maxime Lorant
5153a3bfdc Fixed #25331 -- Removed trailing blank lines in docstrings. 2015-08-31 17:37:21 -04:00
Adam Chainz
05239180c0 Removed unnecessary DBCacheTests.test_clear_commits_transaction test. 
Was added in 44164c5c30 but the
transaction.commit_unless_managed() line was removed in
ba5138b1c0253fcf390b7509ad7b954117b3be88; thus the test does nothing
but check that clear() runs.
 2015-08-31 09:14:06 -04:00
Simon Charette
be67400b47 Refs #24652 -- Used SimpleTestCase where appropriate. 2015-05-20 13:46:13 -04:00
Adam Chainz
5564d0f2ee Fixed #24560 -- Added a --dry-run mode to the createcachetable command. 2015-04-09 12:15:50 -04:00
Berker Peksag
34fb909180 Fixed #12982 -- Added a get_or_set() method to the BaseCache backend. 2015-03-14 20:07:16 +02:00
Loic Bistuer
bed504d70b Fixed #24351, #24346 -- Changed the signature of allow_migrate(). 
The new signature enables better support for routing RunPython and
RunSQL operations, especially w.r.t. reusable and third-party apps.

This commit also takes advantage of the deprecation cycle for the old
signature to remove the backward incompatibility introduced in #22583;
RunPython and RunSQL won't call allow_migrate() when when the router
has the old signature.

Thanks Aymeric Augustin and Tim Graham for helping shape up the patch.

Refs 22583.
 2015-02-20 21:34:09 +07:00
Tim Graham
0ed7d15563 Sorted imports with isort; refs #23860. 2015-02-06 08:16:28 -05:00
darkryder
9ec8aa5e5d Fixed #24149 -- Normalized tuple settings to lists. 2015-02-03 14:59:45 -05:00
Tim Graham
d038c547b5 Removed django.core.cache.get_cache() per deprecation timeline; refs #21012. 2015-01-17 09:55:18 -05:00
Aymeric Augustin
79deb6a071 Accounted for multiple template engines in template responses. 2015-01-12 21:01:34 +01:00
Tim Graham
5c43fd4825 Isolated some cache tests; refs #23947. 
This reverts a change made in 40c60efecc
which was incorrect and caused CacheKeyWarnings.
 2015-01-08 13:14:45 -05:00
Claude Paroz
51890ce889 Applied ignore_warnings to Django tests 2014-12-30 18:16:25 +01:00
Aymeric Augustin
92e8f1f302 Moved context_processors from django.core to django.template. 2014-12-28 17:00:07 +01:00
Jon Dufresne
4468c08d70 Fixed #23968 -- Replaced list comprehension with generators and dict comprehension 2014-12-08 07:58:23 -05:00
Tim Graham
40c60efecc Refs #23947 -- Isolated some cache tests. 
Thanks Diego Guimarãesi and Florian Apolloner.
 2014-12-06 13:59:49 -05:00
wrwrwr
9136ceb6fb Replaced router.routers usage with override_settings(DATABASE_ROUTERS); refs #23933. 2014-12-01 11:34:15 -05:00
Michael Manfre
bc8abe36ba Fixed #16358 - Made memcache backend delete old value on a failure to set. 
Default Memcached configuration allows for a maximum object of 1MB and
will fail to set the key if it is too large. The key will be deleted from
memcached if it fails to be set. This is needed to avoid an issue with
cache_db session backend using the old value stored in memcached, instead
of the newer value stored in the database.
 2014-11-13 00:46:03 -05:00
Thomas Chaumeny
d89f56dc4d Fixed #21281 -- Made override_settings act at class level when used as a TestCase decorator. 2014-11-03 14:14:39 -05:00
Berker Peksag
f7969b0920 Fixed #23620 -- Used more specific assertions in the Django test suite. 2014-11-03 11:56:37 -05:00
Loic Bistuer
494ba051bb Made testing of stdout and stderr more consistent. 
Refs #23663.
 2014-10-22 09:25:50 +07:00
Loic Bistuer
968510e5d7 Moved a test case that caused deprecation warnings. 
`cache.tests.TestEtagWithAdmin` loaded views from the `admin_views` test
package. This is problematic because when the `cache` test package is
run in isolation, `admin_views` isn't in INSTALLED_APPS, and therefore
loading its models isn't allowed since the app loading refactor.
 2014-10-20 00:22:48 +07:00
Thomas Chaumeny
b2aad7b836 Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282. 
Thanks Collin Anderson for the review.
 2014-09-29 00:01:38 +07:00
Claude Paroz
885ff6845e Revert "Fixed #23384 -- Allowed overriding part of a dictionary-type setting" 
This reverts commit 66757fee7e.
Discussions have led to think that this functionality does not
bring significant benefits to justify the added complexity.
Read also discussions on ticket #22734.
 2014-09-05 20:06:02 +02:00
Aymeric Augustin
df251e033c Fixed a PEP 8 error. 2014-08-30 13:27:56 +02:00
Claude Paroz
66757fee7e Fixed #23384 -- Allowed overriding part of a dictionary-type setting 
This change is needed for upcoming changes where settings might be
grouped in a parent dictionary.
Thanks Tim Graham for the review.
 2014-08-30 12:37:10 +02:00
Claude Paroz
1d9596025e Ensured cache tests do not leak temp dirs 
Refs #17215.
 2014-06-23 14:06:04 +02:00
Vincent-Vega
4529af9ecf Fixed #22845 -- Correctly handled memcached default timeout value. 2014-06-16 16:34:00 -04:00
Claude Paroz
35e1b1efab Used more precise assertions in cache tests 2014-05-09 19:34:53 +02:00
Malcolm Box
66880e4cd1 Fixed #22606 -- Locmemcache has_key() failed for infinite cache expiry 
Refactored cache expiry logic for Locmemcache to make consistent across
all places where accessed, and correctly handle None as expiry time.
 2014-05-09 18:35:07 +02:00
Malcolm Box
af5f688392 Fixed #22495 -- Locmem cache.add() failed with infinite timeouts 
cache.add() incorrectly succeeded when there was an existing key
with an infinite (None) timeout.
 2014-04-23 14:49:46 +02:00
Aymeric Augustin
c083e3815a Prevented leaking the CSRF token through caching. 
This is a security fix. Disclosure will follow shortly.
 2014-04-21 18:11:26 -04:00
Aymeric Augustin
428c0bbe1b Appeased flake8 2.1.0. 2014-04-21 12:27:34 +02:00
Anubhav Joshi
cd914e31c9 Fixed #21977 -- Deprecated SimpleTestCase.urls 2014-04-06 17:33:43 -04:00
Aymeric Augustin
232181d1c5 Advanced deprecation warnings for 1.8. 2014-03-22 21:12:58 +01:00
Aymeric Augustin
0757e0f30d Avoided transactional DDL on castrated databases. 
Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308.
 2014-03-22 11:05:14 +01:00
Aymeric Augustin
753a22a635 Fixed transaction handling in two management commands. 
Previously, when createcachetable and flush operated on non-default
databases, they weren't atomic.
 2014-03-21 21:29:51 +01:00
Tim Graham
f567d04b24 Removed settings.CACHE_MIDDLEWARE_ANONYMOUS_ONLY per deprecation timeline. 
refs #15201.
 2014-03-21 09:46:17 -04:00
Claude Paroz
c564277937 Fixed #22237 -- Removed some warnings in the test suite 
Thanks Aymeric Augustin for the report.
 2014-03-09 22:10:49 +01:00
Baptiste Mispelon
5a5815d373 Fixed incorrect docstring in cache tests (take two) 
3e25c8ac69 was an incomplete
merge of the pull request.

Thanks to @ramast for catching this.
 2014-03-05 07:35:07 +01:00
ramast
3e25c8ac69 Fixed incorrect docstring in cache tests 2014-03-04 21:50:21 +01:00
zedr
6fe22b30e0 Fixed #22085 -- Added a feature for setting non-expiring keys as the default. 
This feature allows the default `TIMEOUT` Cache argument to be set to `None`,
so that cache instances can set a non-expiring key as the default,
instead of using the default value of 5 minutes.

Previously, this was possible only by passing `None` as an argument to
the set() method of objects of type `BaseCache` (and subtypes).
 2014-03-04 21:16:35 +01:00
Rodolfo Carvalho
0d91225892 Fixed many typos in comments and docstrings. 
Thanks Piotr Kasprzyk for help with the patch.
 2014-03-03 07:38:09 -05:00
Tim Graham
6c5a30b4e7 Added tests for LocalMemCache deadlocks. refs #20613 and refs #18541. 
Thanks Zach Smith for the patch.
 2014-02-08 05:49:27 -05:00
Claude Paroz
be0ad62994 Fixed #21911 -- Made admin views redirect to login when needed 
Historically, the Django admin used to pass through the request
from an unauthorized access to the login view directly. Now we
are using a proper redirection, which is also preventing
inadvertantly changing data when POSTing login data to an admin
view when user is already authorized.
Thanks Marc Tamlyn and Tim Graham for the reviews.
 2014-02-04 20:02:28 +01:00
Michael Manfre
3ffeb93186 Ensure cursors are closed when no longer needed. 
This commit touchs various parts of the code base and test framework. Any
found usage of opening a cursor for the sake of initializing a connection
has been replaced with 'ensure_connection()'.
 2014-02-02 12:47:21 -05:00
ijl
71a03e01aa Fixed #20346 -- Made cache middleware vary on the full URL. 
Previously, only the URL path was included in the cache key.

Thanks jamey for the suggestion.
 2013-12-28 11:20:18 -05:00
Aymeric Augustin
e32095616c Imported override_settings from its new location. 2013-12-23 21:37:56 +01:00
Alex Gaynor
83ab04c6d6 flake8 fixes 2013-11-24 21:07:21 -06:00
Florian Apolloner
d47f794f8f Properly closed cache connections at the end of the request. 
This only affects the new cache api and not the deprecated get_cache.

Refs #21012
 2013-11-24 16:23:28 +01:00
Alex Gaynor
8adbfdfcc4 Fixed flake8 error (5 space identation!!!) 2013-11-24 08:33:22 -06:00
Florian Apolloner
87ea38cc9e Don't fail if there is no memcached backend active. 2013-11-24 12:08:41 +01:00
Florian Apolloner
3ea65d1f68 Fixed regression from ffc37e2343. 
This (hopefully) ensures that the cache are created the same way as before
the offending commit.
 2013-11-24 11:51:37 +01:00
Florian Apolloner
101da92ebd Randomized KEY_PREFIX in caches test to prevent failures during parallel testruns. 2013-11-24 10:15:43 +01:00
Florian Apolloner
9e87444552 Don't fail if cPickle doesn't exist. 
Today is not my day :(
 2013-11-23 19:05:13 +01:00
Florian Apolloner
cf7ddc5765 Follow up to e112654fc8 
Actually comitted the code now :þ
 2013-11-23 18:55:28 +01:00
Florian Apolloner
e112654fc8 Fixed #21200 -- Consistantly raise errors across all cache backends. 
Thanks to tchaumeny for the patch.
 2013-11-23 17:50:28 +01:00
Alex Gaynor
0ec712dd11 A handful of flake8 fixes 2013-11-23 08:26:11 -08:00
Aymeric Augustin
1124e16340 Allowed running the test suite without memcached (!) 2013-11-23 16:49:14 +01:00
Curtis Maloney
ffc37e2343 Fixed #21012 -- New API to access cache backends. 
Thanks Curtis Malony and Florian Apolloner.

Squashed commit of the following:

commit 3380495e93
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 14:18:07 2013 +0100

    Looked up the template_fragments cache at runtime.

commit 905a74f52b
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 14:19:48 2013 +0100

    Removed all uses of create_cache.

    Refactored the cache tests significantly.

    Made it safe to override the CACHES setting.

commit 35e289fe92
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 12:23:57 2013 +0100

    Removed create_cache function.

commit 8e274f747a
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 12:04:52 2013 +0100

    Updated docs to describe a simplified cache backend API.

commit ee7eb0f73e
Author: Curtis Maloney <curtis@tinbrain.net>
Date:   Sat Oct 19 09:49:24 2013 +1100

    Fixed #21012 -- Thread-local caches, like databases.
 2013-11-23 15:06:59 +01:00
Alex Gaynor
b9d908da54 Fixed some flake8 issues 2013-11-22 09:10:18 -08:00
Unai Zalakain
2b4bed6dbd Fixed #21476 -- Cache tests make an incorrect use of HttpRequest 
Using `django.test.client.RequestFactory` solves the problem and cleans up all
the `get_request` mess.
 2013-11-21 18:51:08 +01:00
Tim Graham
536c447820 Fixed a couple flake8 warnings. 2013-11-07 20:10:25 -05:00
Jaap Roes
7be638390e Fixed #20536 -- rewrite of the file based cache backend 
* Safer for use in multiprocess environments
 * Better random culling
 * Cache files use less disk space
 * Safer delete behavior

Also fixed #15806, fixed #15825.
 2013-11-07 16:12:15 +02:00
Alex Gaynor
c347f78cc1 Fixed all E226 violations 2013-11-03 10:08:55 -08:00
Jason Myers
7a61c68c50 PEP8 cleanup 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:50:49 -05:00
coagulant
8eec2d93b6 Fixed all E261 warnings 2013-11-02 23:50:33 -05:00
Alex Gaynor
b35ff0d920 Fixed all the E203 violations 2013-10-26 18:27:42 -07:00
Alex Gaynor
9d740eb8b1 Fix all violators of E231 2013-10-26 12:15:03 -07:00
Alasdair Nicol
c3aa2948c6 Fixed #21298 -- Fixed E301 pep8 warnings 2013-10-23 13:45:03 +01:00
Tim Graham
ae48d77ef8 Fixed E225 pep8 warnings. 2013-10-23 06:09:29 -04:00
Alasdair Nicol
b289fcf1bf Fixed #21288 -- Fixed E126 pep8 warnings 2013-10-21 08:31:30 -04:00
Alasdair Nicol
a800036981 Fixed #21287 -- Fixed E123 pep8 warnings 2013-10-18 10:07:39 +01:00
Alasdair Nicol
bab9123daa Fixed #21268 -- Fixed E303 pep8 warnings 2013-10-18 01:46:24 +01:00
Alasdair Nicol
dfb4cb9970 Fixed #21285 -- Fixed E121,E122 pep8 warnings 2013-10-17 20:20:11 -04:00
Larry O'Neill
83b9bfea44 Fixed #21266 -- Fixed E201,E202 pep8 warnings. 2013-10-14 18:12:00 -04:00
Claude Paroz
1e8eadc94e Fixed #15888 -- Made tablename argument of createcachetable optional 
Thanks Aymeric Augustin for the report and the documentation and
Tim Graham for the review.
 2013-10-14 13:24:40 +02:00
Tim Graham
b67ab75e82 Fixed assorted flake8 errors. 2013-10-11 07:25:14 -04:00
Tim Graham
1dae4ac177 Whitespace cleanup. 
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
 2013-10-10 16:49:20 -04:00
Curtis Maloney
4e9f800742 Fixed #21125 -- Removed support for cache URI syntax 2013-09-19 10:01:39 -04:00
Alex Gaynor
9d11522599 Removed some more unused local vars 2013-09-08 12:20:01 -07:00