Andrew Gorcester
f9ab543720
Fixed #20084 -- Provided option to validate formset max_num on server.
...
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.
This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.
Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.
Thanks to Preston for discussion of the design choices.
2013-03-21 01:27:24 -07:00
Claude Paroz
7ec2a21be1
Fixed #19686 -- Added HTML5 number input type
...
Thanks Simon Charette for his help on the patch. Refs #16630 .
2013-02-23 10:18:08 +01:00
Aymeric Augustin
35c991aa06
Added a default limit to the maximum number of forms in a formset.
...
This is a security fix. Disclosure and advisory coming shortly.
2013-02-19 11:23:30 -07:00
Alex Hunley
976dc07baf
Removed a misleading examples from documentations ala ticket #19719
2013-02-16 14:30:55 -05:00
JonLoy
74003ca36b
Fixed #19808 Capitalization error in example text
2013-02-12 09:14:19 -05:00
Tim Graham
fdaaa24171
Fixed #19700 - Added documentation for BoundField.field.
...
Thanks Tiberiu Ana for the report and patch.
2013-02-02 08:34:42 -05:00
Claude Paroz
4f16376274
Added HTML5 email input type
...
Refs #16630 .
2013-01-28 22:10:50 +01:00
Nick Sandford
93e79b45bc
Fixed #17416 -- Added widgets argument to inlineformset_factory and modelformset_factory
2013-01-24 08:58:17 +01:00
Tim Graham
0de2645c00
Fixed #19610 - Added enctype note to forms topics doc.
...
Thanks will@ for the suggestion.
2013-01-23 04:49:48 -05:00
Tim Graham
5b2d9bacd2
Fixed #19640 - Added inlineformset_factory to reference docs.
...
Thanks wim@ for the suggestion.
2013-01-22 07:55:34 -05:00
Tim Graham
71d76ec011
Fixed #10239 - Added docs for modelform_factory
...
Thanks ingenieroariel for the suggestion and slurms for the review.
2013-01-11 06:00:19 -05:00
Tim Graham
9b5f64cc6e
Fixed #19516 - Fixed remaining broken links.
...
Added -n to sphinx builds to catch issues going forward.
2013-01-02 18:32:57 -05:00
Aymeric Augustin
7ee7599ab3
Removed versionadded/changed annotations dating back to 1.4.
2012-12-29 21:59:08 +01:00
Tim Graham
067505ad19
Fixed broken links, round 4. refs #19516
2012-12-29 15:54:33 -05:00
Claude Paroz
8248d14029
Removed US localflavor-specific tests from core
...
Also fixes #9045 .
2012-12-08 21:07:59 +01:00
Tim Graham
d3fd8a1512
Fixed #15591 - Clarified interaction between ModelForm and model validation.
2012-11-05 18:24:28 -05:00
Tim Graham
fd02bcff4a
Fixed #18548 - Clarified note regarding reusing model instances when form validation fails.
2012-10-16 20:39:13 -04:00
Tim Graham
837425b425
Fixed #18934 - Removed versionadded/changed annotations for Django 1.3
2012-09-20 19:06:55 -04:00
Tim Graham
a73838fde3
Fixed #11185 - Expanded docs on customizing widgets; thanks fadeev for the draft patch.
2012-09-15 06:22:00 -04:00
Nick Martini
571698997f
fixing modelforms example code, ticket #18832
2012-09-08 12:30:41 -04:00
Tim Graham
e57338f2b9
Fixed #18847 - Updated for media examples to use static.example.com. Thanks Jamie Curle.
2012-08-24 08:23:50 -04:00
Tim Graham
3fd89d9903
Fixed #14885 - Clarified that ModelForm cleaning may not fully complete if the form is invalid.
...
Thanks Ben Sturmfels for the patch.
2012-08-21 17:32:53 -04:00
Tim Graham
ebbc414d17
Fixed #16168 - Added note regarding type requirements when overridng ModelForm fields.
...
Thanks Pieter Swinkels for the patch.
2012-08-01 07:59:28 -04:00
Florian Apolloner
7d06f975fe
Fixed #18614 -- Added missing imports in code samples.
2012-07-25 22:32:53 +02:00
Claude Paroz
19a810b18c
Fixed #14917 -- Hinted that view should redirect after form post success
2012-06-23 18:47:52 +02:00
Jannis Leidel
c4c7fbcc0d
Fixed #18451 -- Vastly improved class based view documentation.
...
Many thanks to Daniel Greenfeld, James Aylett, Marc Tamlyn, Simon Williams, Danilo Bargen and Luke Plant for their work on this.
2012-06-11 10:40:23 +02:00
Audrey Roy
7ab6e32843
Revised the text in the 'Processing the data from a form' section.
2012-06-08 12:13:52 +02:00
Audrey Roy
3c05b500a5
Revised the text in the 'Using a form in a view' section.
2012-06-08 12:03:52 +02:00
Aymeric Augustin
33999d9871
Fixed #18445 -- Added a links in the docs.
...
Thanks Audrey Roy for the patch.
2012-06-07 22:11:24 +02:00
Aymeric Augustin
c28e700c7e
Removed references to changes made in 1.2.
...
Thanks Florian Apolloner for the patch.
2012-06-07 15:02:35 +02:00
Adrian Holovaty
6799ffad9a
Merge pull request #99 from danielroseman/master
...
Docs: "Form in a view" example doesn't use RequestContext
2012-06-04 13:13:14 -07:00
Daniel Roseman
5c59e43aef
Use render shortcut in form example.
2012-05-31 15:33:45 +01:00
Claude Paroz
6219591f2e
Fixed #18244 -- Documented that formset.has_changed is a 1.4 addition.
2012-05-22 13:56:03 +02:00
Claude Paroz
596cb9c7e2
Replaced print statement by print function (forward compatibility syntax).
2012-04-30 20:45:03 +02:00
Aymeric Augustin
9ed6e08ff9
Removed deprecated URLField.verify_exists.
...
The deprecation schedule was slightly accelerated because of possible security ramifications.
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17847 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-03-31 13:55:03 +00:00
Adrian Holovaty
6ecadcbdd2
Made a bunch more edits up until [17418]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17428 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-02-03 20:45:45 +00:00
Ramiro Morales
e308cfc0e1
Added support for specifying initial values to model formsets and inline formsets.
...
This make them consistent with the similar capability of regular
formsets. Thanks to simon29 form the report and to Claude Paroz for the
patch.
Fixes #14574 .
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17373 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2012-01-15 01:36:14 +00:00
Timo Graham
f2d02647fa
Fixed #16851 - Added how-to access form field value in template; thanks yasar11732 for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17138 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-11-21 23:33:39 +00:00
Luke Plant
d1e5c55258
Fixed many more ReST indentation errors, somehow accidentally missed from [16955]
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16983 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-14 00:12:01 +00:00
Alex Gaynor
749f0721c4
Fixed #16985 -- corrected a few grammar errors in the docs.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16925 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-10-04 23:54:12 +00:00
Paul McMillan
4f109fcbff
Fixed 11674 -- Clarified docs on excluded fields of ModelForms.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16875 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-22 04:52:43 +00:00
Julien Phalip
3513234cf8
Fixed #16815 -- Rectified the code example for hidden_fields and visible_fields in the forms documentation. Thanks, joonas.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16823 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-13 08:22:53 +00:00
Alex Gaynor
d14bf8c62b
Fixed #11404 . Added `FormSet.has_changed
, for consistancy with
Form.has_changed
`. Thanks to michelts for the patch.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16773 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10 02:42:05 +00:00
Alex Gaynor
01b0eb50fd
Make `Formset.__getitem__
O(1), rather than O(n). If you override
__iter__
you now need to also override
__getitem__
` for consistant behavior. Thanks to Carl and Russ for the review.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16770 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-09-10 01:53:56 +00:00
Gabriel Hurley
bdd1409eea
Fixed #16467 -- Restored a previously correct example which was broken in [16564]. Thanks to dmclain for pointing out that the original example was correct.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16623 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-18 21:47:04 +00:00
Jannis Leidel
566b3295fa
Fixed #16621 -- Fixed lots of typos in the docs. Thanks, Bernhard Essl.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16615 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-13 11:58:19 +00:00
Timo Graham
0350d65fa4
Fixed #16513 - Add forms import to example; thanks teraom.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16586 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-08-06 19:02:20 +00:00
Jannis Leidel
8ac23178ad
Fixed #16467 -- Corrected formset code example. Thanks, teraom.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16564 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-07-29 09:40:22 +00:00
Jannis Leidel
1dfa567a23
Fixed typos introduced in r16430 and r16431. Thanks, magopian.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16433 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-18 08:48:25 +00:00
Jannis Leidel
2a122be0fc
Fixed #16126 -- Added documentation about DELETE and ORDER fields in formsets. Many thanks to Aleksandra Sendecka.
...
git-svn-id: http://code.djangoproject.com/svn/django/trunk@16430 bcc190cf-cafb-0310-a4f2-bffc1f526a37
2011-06-17 15:39:28 +00:00