mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity
30,017 Commits 30 Branches 460 Tags
668b990bf6da5232b16f979f59bb5d9b3af19e45
Commit Graph

101 Commits

Author SHA1 Message Date
Mariusz Felisiak
fa1d7ba5b9 Refs #29898 -- Changed fields in ProjectState's relation registry to dict. 2021-08-26 07:49:37 +02:00
Manav Agarwal
196a99da5d Refs #29898 -- Made ProjectState encapsulate alterations in relations registry. 
Thanks Simon Charette and Chris Jerdonek for reviews.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2021-08-25 09:12:01 +02:00
Chris Jerdonek
7800596924 Fixed #33014 -- Made ProjectState raise exception when real_apps argument is not a set. 2021-08-19 10:18:51 +02:00
Mariusz Felisiak
54a30a7a00 Refs #29898 -- Changed ProjectState.real_apps to set. 2021-08-11 09:01:14 +02:00
David Smith
1cba320786 Refs #32956 -- Changed "afterwards" to "afterward" in docs and comments. 
This also removes unnecessary comments with the previous spelling.

AP Stylebook has a short entry to advise the preferred spelling for
"en-us". "Afterwards" is preferred in British English.
 2021-07-27 10:41:51 +02:00
luzpaz
bbf09254a3 Fixed typos in test comments. 2021-06-07 20:54:28 +02:00
Hannes Ljungberg
87acbf0631 Fixed #32458 -- Made __repr__() for Index and BaseConstraint subclasses more consistent. 2021-02-19 20:25:11 +01:00
Mariusz Felisiak
62d85a2835 Fixed #31742 -- Fixed makemigrations crash on ForeignKey to an app with mixed case label. 
Regression in 9e1b6b8a66.

Thanks Ignacio Santolin for the report.
 2020-06-26 23:18:59 +02:00
Simon Charette
06889d6206 Fixed #31499 -- Stored ModelState.fields into a dict. 
This allows the removal of its O(n) .get_field_by_name method and many
other awkward access patterns.

While fields were initially stored in a list to preserve the initial
model definiton field ordering the auto-detector doesn't take field
ordering into account and no operations exists to reorder fields of a
model.

This makes the preservation of the field ordering completely superflous
because field reorganization after the creation of the model state
wouldn't be taken into account.
 2020-04-22 07:10:00 +02:00
Simon Charette
696024fb73 Refs #31499 -- Ignored field ordering to determine ModelState equality. 2020-04-22 06:20:54 +02:00
Mariusz Felisiak
db6933a032 Refs #30966 -- Added test for reloading related model state on non-relational changes. 
Thanks Markus Holtermann for initial test.

Fixed in 1d16c5d562.
 2020-04-08 10:43:38 +02:00
Simon Charette
1d16c5d562 Refs #27666 -- Ensured relationship consistency on delayed reloads. 
Delayed reloads of state models broke identity based relationships
between direct and non-direct ancestors.

Basing models.Options related objects map of model labels instead of
their identity ensured relationship consistency is maintained.

Refs #30966.

Co-authored-by: Hasan Ramezani <hasan.r67@gmail.com>
 2020-04-07 09:20:46 +02:00
Mariusz Felisiak
bf77669453 Fixed #29998 -- Allowed multiple OneToOneFields to the parent model. 
We assumed that any OneToOneField's in a child model must be the
parent link and raised an error when parent_link=True was not
specified. This patch allows to specify multiple OneToOneField's to
the parent model.

OneToOneField's without a custom related_name will raise fields.E304
and fields.E305 so this should warn users when they try to override
the auto-created OneToOneField.
 2020-01-16 08:06:16 +01:00
Jon Dufresne
e649d691f8 Removed unnecessary parentheses in various code. 2019-11-18 15:25:59 +01:00
Nick Pope
7552de7866 Used more specific unittest assertions in tests. 
* assertIsNone()/assertIsNotNone() instead of comparing to None.
* assertLess() for < comparisons.
* assertIs() for 'is' expressions.
* assertIsInstance() for isinstance() expressions.
* rounding of assertAlmostEqual() for round() expressions.
* assertIs(..., True/False) instead of comparing to True/False.
* assertIs()/assertIsNot() for ==/!= comparisons.
* assertNotEqual() for == comparisons.
* assertTrue()/assertFalse() instead of comparing to True/False.
 2019-10-29 12:37:30 +01:00
Mariusz Felisiak
8233144ca0 Changed django.db.models.indexes.Index imports to django.db.models.Index. 2019-07-08 14:19:46 +02:00
Simon Charette
9142bebff2 Refs #11964 -- Changed CheckConstraint() signature to use keyword-only arguments. 
Also renamed the `constraint` argument to `check` to better represent which
part of the constraint the provided `Q` object represents.
 2018-10-02 10:53:04 -04:00
Ian Foote
952f05a6db Fixed #11964 -- Added support for database check constraints. 2018-07-10 15:32:33 -04:00
Mariusz Felisiak
83a36ac49a Removed unnecessary trailing commas and spaces in various code. 2017-12-28 21:07:29 +01:00
Jon Dufresne
2c69824e5a Refs #23968 -- Removed unnecessary lists, generators, and tuple calls. 2017-06-01 19:08:59 -04:00
Tim Graham
eb9a3bd63a Refs #26605 -- Isolated a migrations state test. 2017-04-10 08:13:45 -04:00
Ingo Klöcker
67b2b1f116 Refs #26605 -- Added migrations state test for a swappable model inheriting an abstract model inheriting concrete model. 
Thanks Sébastien Diemer for the report and test.
 2017-04-07 13:41:07 -04:00
Markus Holtermann
d3cf75ec6f Fixed #28051 -- Made migrations respect Index's name argument. 
Thanks Marc Tamlyn for the report and Tim Graham for the review.
 2017-04-07 11:47:53 -04:00
Tim Graham
3d19d1428a Fixed #27915 -- Allowed Meta.indexes to be defined in abstract models. 
Thanks Markus Holtermann for review.
 2017-03-21 10:53:21 -04:00
Claude Paroz
8346680e1c Refs #27795 -- Removed unneeded force_text calls 
Thanks Tim Graham for the review.
 2017-03-04 18:18:21 +01:00
Simon Charette
9695b14982 Refs #23919 -- Removed str() conversion of type and method __name__. 2017-01-19 11:31:07 -05:00
Claude Paroz
7b2f2e74ad Refs #23919 -- Removed six.<various>_types usage 
Thanks Tim Graham and Simon Charette for the reviews.
 2017-01-18 20:18:46 +01:00
za
321e94fa41 Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings. 2016-11-10 21:30:21 -05:00
Akshesh
6a8372e6ec Fixed #26808 -- Added Meta.indexes for class-based indexes. 
* Added the index name to its deconstruction.
* Added indexes to sqlite3.schema._remake_table() so that indexes
  aren't dropped when _remake_table() is called.

Thanks timgraham & MarkusH for review and advice.
 2016-08-05 18:12:51 -04:00
Loïc Bistuer
dab83e5ba1 Fixed #26881 -- Fixed duplicate managers in migrations. 
When both parent and child models had managers with the same name and
a migrations opt-in both were added to the migration state.
 2016-07-09 17:52:52 +07:00
Akshesh
156e2d59cf Fixed #26709 -- Added class-based indexes. 
Added the AddIndex and RemoveIndex operations to use them in migrations.

Thanks markush, mjtamlyn, timgraham, and charettes for review and advice.
 2016-06-27 10:41:01 -04:00
Loïc Bistuer
2eb7cb2fff Fixed #26643 -- Prevented unnecessary AlterModelManagers operations caused by the manager inheritance refactor. 
This also makes migrations respect the base_manager_name and
default_manager_name model options.

Thanks Anthony King and Matthew Schinckel for the initial patches.
 2016-06-20 12:55:57 -04:00
Jon Dufresne
4f336f6652 Fixed #26747 -- Used more specific assertions in the Django test suite. 2016-06-16 14:19:18 -04:00
Alex Hill
2ff7ef15b0 Refs #26421 -- Refactored Apps.lazy_model_operation() for better checks and tests 2016-05-19 21:33:36 -04:00
Loïc Bistuer
3a47d42fa3 Fixed #20932, #25897 -- Streamlined manager inheritance. 2016-05-17 02:29:22 +07:00
Simon Charette
c0118ff80b Refs #24201 -- Ignored order_with_respect_to private fields in migrations. 
Thanks Tim for the review.
 2016-05-13 15:43:23 -04:00
Tim Graham
92053acbb9 Fixed E128 flake8 warnings in tests/. 2016-04-08 10:12:33 -04:00
Simon Charette
63f0e2df2a Refs #18012 -- Accounted for reverse proxy relations in migrations. 
Thanks to Markus for the suggestion and Tim for the review.
 2015-10-19 20:15:13 -04:00
Dražen Odobašić
b1e33ceced Fixed #23395 -- Limited line lengths to 119 characters. 2015-09-12 11:40:50 -04:00
Alex Hill
25c157e4cc Refs #24215 -- Improved error message for unhandled lazy model operations. 2015-09-07 20:31:58 -04:00
Flavio Curella
c2e70f0265 Fixed #21127 -- Started deprecation toward requiring on_delete for ForeignKey/OneToOneField 2015-07-27 18:28:13 -04:00
Kai Richard Koenig
60f795c060 Fixed #25040 -- Fixed migrations state crash with GenericForeignKey 2015-07-02 12:48:29 -04:00
Andriy Sokolovskiy
c0cf73a57d Refs #20203 -- Allowed adding custom default manager to the model state 
If the only manager on the model is the default manager defined
by Django (`objects = models.Manager()`), this manager will not
be added to the model state. If it is custom, it needs to be
passed to the model state.
 2015-06-29 21:15:37 -04:00
Simon Charette
be67400b47 Refs #24652 -- Used SimpleTestCase where appropriate. 2015-05-20 13:46:13 -04:00
Tim Graham
f5da438072 Fixed #24812 -- Fixed app registry RuntimeWarnings in schema and migrations tests. 2015-05-18 09:48:25 -04:00
Markus Holtermann
811d7870a5 Moved migration exception classes to shared module 
Thanks Aymeric Augustin for the review.
 2015-05-02 12:54:44 +02:00
Markus Holtermann
faad6070ee Fixed #24701 -- Converted model manager names to unicode in migrations 
Thanks to Reto Aebersold for reporting the issue and Tim Graham and
Claude Paroz for the review.
 2015-04-25 18:17:06 +02:00
Markus Holtermann
b93690c465 Fixed #24573 -- Considered new related models for reloading 
Thanks tttomekkk for the report.
 2015-04-21 11:35:45 +02:00
Marten Kenbeek
1a1f16d67d Fixed #24591 -- Optimized cloning of ModelState objects. 
Changed ModelState.clone() to create a shallow copy of self.fields
and self.managers.
 2015-04-20 19:53:21 -04:00
Marten Kenbeek
039d7881b4 Refs #24397 -- Sped up model reloading in ProjectState. 
Created bulk_update() context manager on StateApps. Sped up unregistering
models in reload_models() by using this context mananger.
 2015-04-20 14:42:23 -04:00