mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-03-06 15:32:33 +00:00
Code Issues 32 Releases Wiki Activity
31,177 Commits 29 Branches 437 Tags
Commit Graph

12593 Commits

Author SHA1 Message Date
Mariusz Felisiak
57c2e5da71
Refs #33984 -- Added test for creating copies of model instances with inherited m2m fields. 2022-11-02 12:30:16 +01:00
DevilsAutumn
d5bcdf858d Fixed #34112 -- Added async-compatible interface to Model methods. 
Thanks Adam Johnson for the review.
 2022-11-02 09:14:17 +01:00
Nick Pope
2bc47d7fe9 Avoided assignment followed by immediate return. 
Identified using the following command:

$ pcre2grep --line-number --multiline --recursive \
    "(?s)(\n +)(\w+) = [^\n]+\1return \2;?$" \
    django docs extras js_tests scripts tests
 2022-10-31 12:31:13 +01:00
Nick Pope
d3cb91db87 Used more augmented assignment statements. 
Identified using the following command:

$ git grep -I '\(\<[_a-zA-Z0-9]\+\>\) *= *\1 *[-+/*^%&|<>@]'
 2022-10-31 12:30:13 +01:00
David Wobrock
a320aab512 Fixed #16211 -- Added logical NOT support to F expressions. 2022-10-31 09:55:51 +01:00
Msvstl
67bc2f1b99
Corrected test_update_or_create_with_model_property_defaults test. 2022-10-29 13:27:10 +02:00
Simon Charette
c2cc80756b
Fixed #34125 -- Fixed sliced QuerySet.union() crash on a single non-empty queryset. 
The bug existed since sliced query union was added but was elevated to
query union slices by moving the .exists() optimization to the compiler
in 3d734c09ff0138441dfe0a59010435871d17950f.

Thanks Stefan Hammer for the report.
 2022-10-29 09:21:25 +02:00
Simon Kern
de2c2127b6 Fixed #34066 -- Fixed link to password reset view in UserChangeForm.password's help text when using to_field. 
Co-Authored-By: David Sanders <shang.xiao.sanders@gmail.com>
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2022-10-27 09:23:34 +02:00
Mariusz Felisiak
d559cb02da
Refs #19215 -- Fixed admin_widgets tests if Pillow isn't installed. 
Follow up to c0fc1b5302f5d9d82e2255fb5758321fbac34949.
 2022-10-27 08:41:03 +02:00
Tobias Bengfort
350455b666 Fixed #33606 -- Cleansed sessionid cookie in error reports. 
Co-authored-by: Simon Charette <charette.s@gmail.com>
 2022-10-26 14:39:58 +02:00
Marcelo Galigniana
b440493eaa Completed test coverage for contrib.auth.forms. 2022-10-26 12:52:18 +02:00
Marcelo Galigniana
c0fc1b5302 Fixed #19215 -- Fixed rendering ClearableFileInput when editing with invalid files. 
Thanks Michael Cardillo for the initial patch.
 2022-10-25 16:53:52 +02:00
Yuri Konotopov
64e5ef1f17 Fixed #29027 -- Fixed file_move_safe() crash when moving files with SELinux. 
Thanks Florian Apolloner for the review.
 2022-10-24 13:54:51 +02:00
Vlastimil Zíma
08c5a78726
Fixed #34098 -- Fixed loss of precision for Decimal values in floatformat filter. 
Regression in 12f7928f5a455e330c0a7f19bc86b37baca12811.
 2022-10-24 12:59:34 +02:00
Marcelo Galigniana
1d6948096f Fixed flaky test_ForeignKey_using_to_field test. 2022-10-24 11:54:00 +02:00
Giebisch
3283120cca Fixed #34111 -- Made test runner with --debug-sql format SQL queries. 2022-10-24 08:11:30 +02:00
HieuPham9720
3e928de8ad
Skipped scrypt tests when OpenSSL 1.1+ is not installed. 2022-10-20 18:50:48 -07:00
Carlton Gibson
5c2c7277d4 Fixed #34085 -- Made management commands don't use black for non-Python files. 
Bug in d113b5a837f726d1c638d76c4e88445e6cd59fd5.

Co-authored-by: programmylife <acmshar@gmail.com>
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
 2022-10-20 13:38:31 -07:00
Simon Charette
d62563cbb1
Fixed #34105 -- Fixed crash of ordering by nested selected expression. 
This stops ordering by nested selected references. It's not supported on
PostgreSQL and not required to support psycopg3.

Regression in 04518e310d4552ff7595a34f5a7f93487d78a406.

Thanks Matt Westcott for the report.
 2022-10-18 17:31:45 -07:00
Marcelo Galigniana
2a2503c2c1 Completed test coverage for django.core.paginator. 2022-10-13 12:27:41 +02:00
Sergio
94e7f471c4 Fixed #34069 -- Made LocaleMiddleware respect language from requests when i18n patterns are used. 2022-10-13 10:38:26 +02:00
Rasmus Magnell
c4aac2ac1e Fixed #34042 -- Improved accessibility of admin's navigation sidebar. 2022-10-12 10:21:17 +02:00
Marcelo Galigniana
f30c7e381c
Completed test coverage for contenttypes models. 2022-10-11 05:38:39 +02:00
Adam Johnson
6402b064a9 Used test client headers in i18n tests. 2022-10-10 11:46:31 +02:00
Sarah Boyce
84206607d6
Fixed #32833 -- Fixed ContentTypeManager.get_for_models() crash when using in migrations. 
Co-authored-by: Heraldo Lucena <23155511+HMaker@users.noreply.github.com>
 2022-10-10 08:57:52 +02:00
Gregor Gärtner
f0c06f8ab7 Refs #33990 -- Renamed TransactionTestCase.assertQuerysetEqual() to assertQuerySetEqual(). 
Co-Authored-By: Michael Howitz <mh@gocept.com>
 2022-10-08 08:07:38 +02:00
Mariusz Felisiak
d795259ea9
Replaced assertQuerysetEqual() to assertSequenceEqual()/assertCountEqual() where appropriate. 
Follow up to 3f7b3275627385f8f7531fca01cdda50d4ec6b6e.
 2022-10-07 13:05:35 +02:00
Gregor Gärtner
564b317fb5 Refs #33990 -- Renamed SimpleTestCase.assertFormsetError() to assertFormSetError(). 
Co-Authored-By: Michael Howitz <mh@gocept.com>
 2022-10-07 11:22:16 +02:00
Mariusz Felisiak
749cd83e13
Removed hardcoded pks in TestQuerying.test_group_by_order_by_aliases test. 2022-10-07 08:26:41 +02:00
Shubh1815
7a39a691e1 Fixed #32603 -- Made ModelAdmin.list_editable use transactions. 2022-10-06 20:44:07 +02:00
Simon Charette
c6350d594c Refs #30158 -- Removed alias argument for Expression.get_group_by_cols(). 
Recent refactors allowed GROUP BY aliasing allowed for aliasing to be
entirely handled by the sql.Query.set_group_by and compiler layers.
 2022-10-06 12:04:00 +02:00
Simon Charette
b7b28c7c18 Refs #31150 -- Enabled implicit GROUP BY aliases. 
This ensures implicit grouping from aggregate function annotations
groups by uncollapsed selected aliases if supported.

The feature is disabled on Oracle because it doesn't support it.
 2022-10-06 11:51:32 +02:00
Simon Charette
3d734c09ff Refs #33992 -- Refactored subquery grouping logic. 
This required moving the combined queries slicing logic to the compiler
in order to allow Query.exists() to be called at expression resolving
time.

It allowed for Query.exists() to be called at Exists() initialization
time and thus ensured that get_group_by_cols() was operating on the
terminal representation of the query that only has a single column
selected.
 2022-10-06 11:38:03 +02:00
Simon Charette
04518e310d Refs #33308 -- Enabled explicit GROUP BY and ORDER BY aliases. 
This ensures explicit grouping from using values() before annotating an
aggregate function groups by selected aliases if supported.

The GROUP BY feature is disabled on Oracle because it doesn't support it.
 2022-10-06 09:34:31 +02:00
Simon Charette
c58a8acd41 Fixed #33768 -- Fixed ordering compound queries by nulls_first/nulls_last on MySQL. 
Columns of the left outer most select statement in a combined query
can be referenced by alias just like by index.

This removes combined query ordering by column index and avoids an
unnecessary usage of RawSQL which causes issues for backends that
specialize the treatment of null ordering.
 2022-10-05 14:04:49 +02:00
Jack Linke
344d31c7e9 Fixed #34071 -- Improved error message for Range(Min/Max)ValueValidator. 2022-10-05 09:41:01 +02:00
Dhanush
9fbb5b5e16 Fixed #34068 -- Corrected output of runserver command for "0" IP address. 
Thanks David Sanders for the review.
 2022-10-04 10:13:32 +02:00
Adam Johnson
e5ea284294 Fixed CVE-2022-41323 -- Prevented locales being interpreted as regular expressions. 
Thanks to Benjamin Balder Bach for the report.
 2022-10-04 09:10:04 +02:00
David Sanders
4771a1694b Fixed #34012 -- Made QuerySet.order_by() apply transforms on related fields for models with Meta.ordering. 
This makes QuerySet.order_by() no longer ignore trailing transforms for
models with Meta.ordering. As a consequence, FieldError is raised in
such cases for non-existent fields.

Thanks to Klaas van Schelven for the report and Mariusz Felisiak for the
review and advice.
 2022-10-04 08:19:34 +02:00
Lily Foote
649b28eab6 Fixed #34070 -- Added subsecond support to Now() on SQLite and MySQL. 2022-10-03 12:13:27 +02:00
Mariusz Felisiak
f71b0cf769
Refs #32987 -- Relaxed system check for template tag modules with the same name by turning into a warning. 
Thanks Claude Paroz for the report.

Regression in 004b4620f6f4ad87261e149898940f2dcd5757ef.
 2022-10-03 10:52:21 +02:00
David Wobrock
3b4a5b9f97 Fixed #23353 -- Used "raise from" when raising TransactionManagementError. 
This change sets the __cause__ attribute to raised exceptions.
 2022-10-03 06:08:54 +02:00
Mariusz Felisiak
bc3b8f1524
Refs #34058 -- Fixed changing/deleting sequences when altering pre-Django 4.1 auto fields on PostgreSQL. 
Thanks Anders Kaseorg for the report.

Follow up to 19e6efa50b603af325e7f62058364f278596758f.
Regression in 2eea361eff58dd98c409c5227064b901f41bd0d6.
 2022-10-01 07:53:32 +02:00
Mariusz Felisiak
5e0aa362d9
Fixed #33984 -- Reverted "Fixed #32980 -- Made models cache related managers." 
This reverts 4f8c7fd9d91b35e2c2922de4bb50c8c8066cbbc6 and adds
two regression tests:
- test_related_manager_refresh(), and
- test_create_copy_with_m2m().

Thanks joeli for the report.
 2022-09-30 18:18:33 +02:00
sarahboyce
6cc0f22a73 Fixed #32095 -- Made QuerySet.update_or_create() save only fields passed in defaults or with custom pre_save(). 
Thanks Florian Apolloner for the initial patch.
 2022-09-30 06:26:19 +02:00
Antoine Lorence
9b0c9821ed Fixed #34062 -- Updated View.http_method_not_allowed() to support async. 
As with the options() methods, wrap the response in a coroutine if
the view is async.

Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
 2022-09-29 16:28:44 +02:00
Mariusz Felisiak
19e6efa50b
Fixed #34058 -- Changed sequence types when altering pre-Django 4.1 auto fields on PostgreSQL. 
Thanks Anders Kaseorg for the report.

Thanks Florian Apolloner for pair programming.

Regression in 2eea361eff58dd98c409c5227064b901f41bd0d6.
 2022-09-29 13:20:14 +02:00
Adam Johnson
0f5b11eca0 Refs #34010 -- Made --debug-mode work for parallel tests using spawn. 
Bug in 3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc.

Thanks Kevin Renskers for the report.
 2022-09-28 19:39:25 +02:00
David Sanders
9976f3d4b8 Fixed #34025 -- Fixed selecting ModelAdmin.autocomplete_fields after adding/changing related instances via popups. 
Regression in c72f6f36c13a21f6db3d4f85d2d3cec87bad45e6.

Thanks Alexandre da Silva for the report.
 2022-09-28 11:28:01 +02:00
Mariusz Felisiak
6e891a1722
Removed obsolete test_skip_link_is_skipped_when_there_is_searchbar test. 
searchbar doesn't have autofocus since
d938b3b2577807ffd585f654caa0f37d9574e565.
 2022-09-28 11:27:11 +02:00