mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-23 09:36:06 +00:00
Code Issues 25 Releases Wiki Activity
27,925 Commits 28 Branches 426 Tags 666 MiB
4ef107e34f
Commit Graph

10731 Commits

Author SHA1 Message Date
Mariusz Felisiak
e2fab0b679 Refs #22261 -- Added missing trailing slash to the flatpages_tests urls. 2020-01-28 13:01:08 +01:00
Hannes Ljungberg
7edd06a9cf Improved SearchVectorCombinable and SearchQueryCombinable error messages. 2020-01-27 15:09:47 +01:00
Claude Paroz
50cf183d21 Refs #27468 -- Added algorithm parameter to django.utils.crypto.salted_hmac(). 2020-01-27 12:42:21 +01:00
Mariusz Felisiak
c00b863ac6 Made OnDeleteTests.test_protect() assert more specific ProtectedError. 2020-01-27 12:21:02 +01:00
Hasan Ramezani
ab3cbd8b9a Refs #27852 -- Fixed object deletion to show all protected related objects rather than just the first one. 
Thanks Anton Samarchyan for the initial patch.
 2020-01-27 12:21:02 +01:00
Claude Paroz
e348ab0d43 Fixed #30997 -- Deprecated HttpRequest.is_ajax(). 2020-01-27 08:54:32 +01:00
Claude Paroz
7fa0fa45c5 Refs #30997 -- Removed HttpRequest.is_ajax() usage. 2020-01-27 08:52:40 +01:00
Claude Paroz
d66d72f956 Refs #30997 -- Added HttpRequest.accepts(). 2020-01-24 14:24:59 +01:00
Hasan Ramezani
b94764e178 Fixed #27888 -- Added link to clear all filters in the admin changelist view. 2020-01-23 14:14:54 +01:00
Michael Mulholland
5a68a223c7 Fixed #31200 -- Added system checks for permissions codenames max length. 2020-01-23 12:22:59 +01:00
Mariusz Felisiak
b423873cb7
Refs #31197 -- Added tests for combined expressions in CheckConstraint.check. 
Thanks Adam Johnson for the report.

Fixed in 306b687520.
 2020-01-23 10:28:36 +01:00
Eugene Hatsko
0b013564ef Fixed #31190 -- Fixed prefetch_related() crash for GenericForeignKey with custom ContentType foreign key. 
Regression in dffa3e1992.
 2020-01-22 07:54:16 +01:00
Sergey Fedoseev
31e2ab345b Fixed #31195 -- Relaxed GeometryDistance test for PROJ 5.2+. 2020-01-21 22:16:23 +01:00
Sergey Fedoseev
f2a725fba3 Fixed #30274 -- Prevented segmentation fault on LineString iteration. 
This reverts commit 138a78ec8c and adds
a test for the regression.
 2020-01-21 21:46:47 +01:00
Christopher G Johnson
33ec01caaf Refs #29095 -- Added test for using QuerySet.count() with window expressions ordered by related fields. 
Fixed in 3f32154f40.
 2020-01-21 10:43:21 +01:00
Tim Graham
227d0c7365 Fixed #31183 -- Added a feature flag for "<db> only supports UNBOUNDED together with PRECEDING and FOLLOWING". 2020-01-20 20:03:35 +01:00
Matthijs Kooijman
2a2ea4ee18 Refs #31117 -- Made various tests properly handle unexpected databases aliases. 
- Used selected "databases" instead of django.db.connections.
- Made routers in tests.migrations skip migrations on unexpected
  databases.
- Added DiscoverRunnerGetDatabasesTests.assertSkippedDatabases() hook
  which properly asserts messages about skipped databases.
 2020-01-20 14:39:02 +01:00
Matthijs Kooijman
b64b1b2e1a Fixed #31117 -- Isolated backends.base.test_creation.TestDbCreationTests. 
Previously, this test could modify global state by changing
connection.settings_dict. This dict is a reference to the same dict as
django.db.connections.databases['default'], which is thus also changed.
The cleanup of this test would replace connection.settings_dic` with a
saved copy, which would leave the dict itself modified.

Additionally, create_test_db() would also modify these same dicts, as
well as settings.databases['default']['NAME'] by adding a "test_"
prefix, which is what can cause problems later.

This patch:
 - makes a complete copy of the connection and work on that, to improve
   isolation.
 - calls destroy_test_db() to let that code clean up anything done by
   create_test_db().
 2020-01-20 11:00:17 +01:00
Mariusz Felisiak
f34be5294d Refs #31117 -- Moved get_connection_copy() test hook to a module level. 2020-01-20 11:00:05 +01:00
Sergey Fedoseev
a920c0b852 Fixed #31142 -- Fixed MakeValid.output_field when geometry type is changed. 
Regression in 2ef4b4795e.
 2020-01-20 08:59:45 +01:00
Mariusz Felisiak
7d8df4ad03
Fixed field default in dates tests. 2020-01-18 20:07:25 +01:00
Pavel Lysak
13e4abf83e Fixed #30752 -- Allowed using ExceptionReporter subclasses in error reports. 2020-01-16 15:25:49 +01:00
Mariusz Felisiak
266c853e10
Fixed #31162 -- Prevented error logs when using WKT strings in lookups. 
Thanks dbxnr for the initial patch.

Regression in 6f44f714c9.
 2020-01-16 14:34:54 +01:00
Flavio Curella
d08d4f464a Fixed #30765 -- Made cache_page decorator take precedence over max-age Cache-Control directive. 2020-01-16 13:39:16 +01:00
Mariusz Felisiak
bf77669453
Fixed #29998 -- Allowed multiple OneToOneFields to the parent model. 
We assumed that any OneToOneField's in a child model must be the
parent link and raised an error when parent_link=True was not
specified. This patch allows to specify multiple OneToOneField's to
the parent model.

OneToOneField's without a custom related_name will raise fields.E304
and fields.E305 so this should warn users when they try to override
the auto-created OneToOneField.
 2020-01-16 08:06:16 +01:00
Carlton Gibson
29c126bb34 Fixed #31124 -- Fixed setting of get_FOO_display() when overriding inherited choices. 
Regression in 2d38eb0ab9
 2020-01-15 15:35:22 +01:00
Claude Paroz
b5a62bd17d Refs #27468 -- Added explicit tests for django.utils.crypto.salted_hmac() 2020-01-15 12:53:21 +01:00
Mariusz Felisiak
59b4e99dd0
Refs #31136 -- Made QuerySet.values()/values_list() group only by selected annotation. 
Regression in 0f843fdd5b.
 2020-01-15 09:32:42 +01:00
chetan22
63e6ee1f99 Fixed #29871 -- Allowed setting pk=None on a child model to create a copy. 
Thanks Simon Charette and Tim Graham for the initial patch.
 2020-01-15 08:28:30 +01:00
Mariusz Felisiak
6f7998adc7
Fixed #31155 -- Fixed a system check for the longest choice when a named group contains only non-string values. 
Regression in b6251956b6.

Thanks Murat Guchetl for the report.
 2020-01-11 19:47:36 +01:00
Adam Donaghy
8b3e714ecf Fixed #30980 -- Improved error message when checking uniqueness of admin actions' __name__. 
Thanks Keshav Kumar for the initial patch.
 2020-01-10 14:00:28 +01:00
Carlton Gibson
e2d9d66a22 Fixed #23004 -- Added request.META filtering to SafeExceptionReporterFilter. 
Co-authored-by: Ryan Castner <castner.rr@gmail.com>
 2020-01-10 11:35:41 +01:00
Carlton Gibson
581ba5a948 Refs #23004 -- Allowed exception reporter filters to customize settings filtering. 
Thanks to Tim Graham for the original implementation idea.

Co-authored-by: Daniel Maxson <dmaxson@ccpgames.com>
 2020-01-10 11:21:23 +01:00
Adam Johnson
5166097d7c Fixed #31154 -- Added support for using enumeration types in templates. 
Enumeration helpers are callables, so the template system tried to call
them with no arguments.

Thanks Rupert Baker for helping discover this.
 2020-01-10 07:52:06 +01:00
Carlton Gibson
4c1b401e82 Added file cleanup in FileFieldTests.test_pickle(). 2020-01-09 20:47:45 +01:00
Jack Cushman
eb629f4c02 Fixed #30995 -- Allowed converter.to_url() to raise ValueError to indicate no match. 2020-01-09 14:41:41 +01:00
Hasan Ramezani
eef3ea847e Fixed #31148 -- Added error messages on update()/delete() operations following union(), intersection(), and difference(). 2020-01-09 12:20:54 +01:00
Hasan Ramezani
f600e3fad6 Fixed #21238 -- Fixed restoring attributes when pickling FileField and ImageField. 2020-01-09 09:37:59 +01:00
Hasan Ramezani
aaea9deac4 Refs #21238 -- Added more tests for pickling FileField and ImageField. 2020-01-09 09:18:53 +01:00
Hasan Ramezani
66e16dcc99 Removed unused lines in ImageFieldTests.test_pickle(). 2020-01-09 08:44:39 +01:00
Jack Cushman
07f6ff09e4 Added tests for using the same name for multiple URL patterns. 2020-01-08 10:55:53 +01:00
Shubham singh
ffcf1a8ebf Fixed #31118 -- Made FileInput to avoid the required attribute when initial data exists. 2020-01-08 09:15:31 +01:00
Mariusz Felisiak
53d8646f79
Fixed #31141 -- Relaxed system check of translation settings for sublanguages. 
Regression in 4400d8296d.

Thanks Enrique Matías Sánchez for the report.
 2020-01-08 08:05:43 +01:00
Mariusz Felisiak
8be477be5c
Fixed timezones tests for PyYAML 5.3+. 2020-01-07 09:54:22 +01:00
Adam Johnson
2ea3fb3e63 Removed "Don't do that" from docs and error messages. 
It's slightly aggressive and doesn't explain itself.
 2020-01-06 13:50:43 +01:00
Claude Paroz
1487f16f2d Fixed #11385 -- Made forms.DateTimeField accept ISO 8601 date inputs. 
Thanks José Padilla for the initial patch, and Carlton Gibson for the
review.
 2020-01-06 10:52:09 +01:00
Mariusz Felisiak
0f843fdd5b
Fixed #31136 -- Disabled grouping by aliases on QuerySet.values()/values_list(). 
Regression in fb3f034f1c.

Thanks Sigurd Ljødal for the report.
 2020-01-04 20:49:11 +01:00
Claude Paroz
495d7a1ddf Reorganized forms.DateTimeField tests. 2020-01-03 10:36:58 +01:00
Simon Charette
9bcbcd599a Fixed #31133 -- Fixed crash when subtracting against a subquery annotation. 
The subtract_temporals() database operation was not handling expressions
returning SQL params in mixed database types.

Regression in 3543129822.

Thanks Reupen Shah for the report.
 2020-01-03 10:35:08 +01:00
Federico Jaramillo Martínez
372eaa395f Fixed #28991 -- Added EmptyFieldListFilter class in admin.filters. 
Thanks Simon Charette and Carlton Gibson for reviews.

Co-Authored-By: Jonas Haag <jonas@lophus.org>
Co-Authored-By: Christophe Baldy <christophe.baldy@polyconseil.fr>
 2020-01-03 07:58:04 +01:00
Mariusz Felisiak
1960d55f8b
Refs #31040 -- Fixed crypt.crypt() call in test_hashers.py. 
An empty string is invalid salt in Python 3 and raises exception since
Python 3.9, see https://bugs.python.org/issue38402.
 2020-01-03 07:47:04 +01:00
Patrick Seebauer
e3d546a1d9 Fixed #31128 -- Fixed TemplateSyntaxError in simple_tag() and inclusion_tag() for kwargs. 2020-01-02 10:44:07 +01:00
Jon Dufresne
9762617a03 Improved tests assertions in cache tests. 
Added assertions to compare results of .add(), .delete(), .touch(),
.incr(), .decr(), and .get_or_set() methods.

Made tests use assertIs() rather than assertTrue/False().
 2019-12-31 12:49:36 +01:00
Mariusz Felisiak
c159baceba
Refs #31117 -- Isolated backends.sqlite.test_creation.TestDbSignatureTests. 2019-12-31 12:09:50 +01:00
David Wobrock
2f565f84ac Fixed #31097 -- Fixed crash of ArrayAgg and StringAgg with filter when used in Subquery. 2019-12-31 10:35:43 +01:00
David Wobrock
7d44aeb388 Refs #31097 -- Added tests for filter in ArrayAgg and StringAgg. 2019-12-31 10:35:39 +01:00
Sjbrgsn
b2bd08bb7a Fixed #30892 -- Fixed slugify() and admin's URLify.js for "İ". 
Thanks Luis Nell for the implementation idea and very detailed report.

Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2019-12-30 20:47:22 +01:00
Simon Charette
5779cc938a Fixed #31071 -- Disabled insert optimization for primary keys with defaults when loading fixtures. 
Model.save_base() is called directly when loading fixtures and assumes
existing rows will be updated. Branching of "raw" allows to maintain
the optimization introduced in #29260 while supporting this edge case.

Regression in 85458e94e3.

Thanks Reupen Shah for the report.
 2019-12-30 07:49:10 +01:00
Mariusz Felisiak
5a68f02498
Fixed random models_fields.test_uuid.TestQuerying failures. 
Random failures depended on a generated UUID.
 2019-12-27 15:25:50 +01:00
Mads Jensen
62727e65fb Increased test coverage of django.utils.inspect. 2019-12-27 10:08:24 +01:00
Jon Dufresne
e42b68debf Fixed #31114 -- Fixed HttpRequest.build_absolute_uri() crash with reverse_lazy() locations. 2019-12-27 09:19:56 +01:00
Claude Paroz
5660267e5b Fixed #31121 -- Cleared Site cache in SitesFrameworkTests. 
Thanks Matthijs Kooijman for the report and analysis.
 2019-12-27 08:57:34 +01:00
Mariusz Felisiak
22ce5d0031
Fixed #31106 -- Fixed migrations crash on PostgreSQL 10+ when adding FK constraints inline and changing data. 
This allows adding foreign key constraints inline and changing data in
the same migration on PostgreSQL 10+.

Regression in 738faf9da2.

Thanks Janne Rönkkö for the report and Simon Charette for the
implementation idea and review.
 2019-12-23 23:28:59 +01:00
Mariusz Felisiak
45bcc6feac
Refs #31115 -- Added test for nested subquery that references related fields. 
Thanks Dmitriy Gunchenko for the report and Simon Charette for the
analysis and tests.

Regression in 5a4d7285bd.

Fixed in 5a4d7285bd.
 2019-12-23 12:17:56 +01:00
Jon Dufresne
67ea35df52 Fixed #30998 -- Added ModelChoiceIteratorValue to pass the model instance to ChoiceWidget.create_option(). 2019-12-23 10:34:50 +01:00
Simon Charette
720de4d044 Fixed #31109 -- Disabled grouping by aliases on QuerySet.exists(). 
Clearing the SELECT clause in Query.has_results was orphaning GROUP BY
references to it.

Thanks Thierry Bastian for the report and Baptiste Mispelon for the
bisect.

Regression in fb3f034f1c.
 2019-12-23 09:24:03 +01:00
Nick Pope
a2d894b2e4 Refs #28954 -- Removed remaining Jython-specific code from dispatch tests. 
Missed in 23b21db31b.
 2019-12-19 16:42:12 +01:00
Hasan Ramezani
a3fc24f014 Fixed #31095 -- Made RelatedManager.set() preserve existing m2m relations with an invalid type. 2019-12-19 13:33:05 +01:00
Simon Charette
5a4d7285bd Fixed #31094 -- Included columns referenced by subqueries in GROUP BY on aggregations. 
Thanks Johannes Hoppe for the report.

Regression in fb3f034f1c.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
 2019-12-19 10:04:56 +01:00
Simon Charette
a0f34d8fef Refs #31094 -- Added test for not using aliases in GROUP BY clauses. 2019-12-19 09:12:29 +01:00
Mike Hansen
35d36d9462 Refs #30585 -- Updated project templates and tests to use (block)translate tags. 2019-12-18 13:15:38 +01:00
Mike Hansen
d291c72bf2 Fixed #30585 -- Added {% translate %} and {% blocktranslate %} template tags. 2019-12-18 13:15:38 +01:00
Simon Charette
5b1fbcef7a Fixed CVE-2019-19844 -- Used verified user email for password reset requests. 
Co-Authored-By: Florian Apolloner <florian@apolloner.eu>
 2019-12-18 09:11:39 +01:00
Shubham singh
f4647179cc Fixed #31086 -- Improved error message for admin model inlines with more than one foreign key to the same parent. 2019-12-17 09:15:01 +01:00
James Turk
ff00a05347 Fixed #31088 -- Added support for websearch searching in SearchQuery. 2019-12-16 14:59:59 +01:00
Zeynel Özdemir
9d40b6bbf4 Fixed #31076 -- Fixed dbshell crash on Windows with Python < 3.8. 
subprocess.run()'s args parameter accepts path-like objects on Windows
since Python 3.8.
 2019-12-16 11:20:41 +01:00
Baptiste Mispelon
4161e35048 Refs #12679 -- Added test for using property as ModelAdmin.inlines. 
Fixed in 1d8eb0cae5.
 2019-12-14 21:15:44 +01:00
Baptiste Mispelon
738e9e615d Fixed #26743 -- Fixed UnboundLocalError crash when deserializing m2m fields and value isn't iterable. 2019-12-13 11:38:09 +01:00
Osaetin Daniel
b33bfc3839 Fixed #30862 -- Allowed setting SameSite cookies flags to 'none'. 
Thanks Florian Apolloner and Carlton Gibson for reviews.
 2019-12-12 10:52:31 +01:00
Baptiste Mispelon
200cd8803d Refs #25361 -- Added test for pickling queryset of abstract-inherited models with Meta.ordering. 
Fixed in 67cf5efa31.
 2019-12-12 09:01:47 +01:00
Jon Dufresne
8ea3ff155e Fixed typo in tests/cache/tests.py docstring. 2019-12-11 17:39:21 +01:00
Jon Dufresne
8d087f9a17 Fixed typo in ModelChoiceFieldTests. 
The subindex and attrs arguments should be passed through to the parent,
not overridden as None.
 2019-12-11 15:15:12 +01:00
Jon Dufresne
e703b93a65 Fixed #31080 -- Removed redundant type="text/javascript" attribute from <script> tags. 2019-12-11 09:49:54 +01:00
Baptiste Mispelon
d8e2333528 Fixed #31077 -- Made debug decorators raise TypeError if they're not called. 
Django will raise an error if you forget to call the decorator.
 2019-12-10 13:34:28 +01:00
Peter Andersen
02eff7ef60 Fixed #31073 -- Prevented CheckboxInput.get_context() from mutating attrs. 2019-12-10 12:27:50 +01:00
Mariusz Felisiak
3fb7c12158
Refs #23433 -- Fixed test_django_admin_py.DeprecationTest tests failures on Windows and Python < 3.8. 
subprocess.run()'s args parameter accepts a path-like object on Windows
since Python 3.8.
 2019-12-10 11:17:50 +01:00
Baptiste Mispelon
3df3c5e670 Fixed #26480 -- Fixed crash of contrib.auth.authenticate() on decorated authenticate() methods of authentication backends. 
The Signature API (PEP 362) has better support for decorated functions
(by default, it follows the __wrapped__ attribute set by
functools.wraps for example).
 2019-12-10 09:36:30 +01:00
Mariusz Felisiak
d6505273cd Refs #31044 -- Fixed error message when using Prefetch with a values_list() queryset. 2019-12-09 15:45:53 +01:00
Hasan Ramezani
4540842bc3 Fixed #31044 -- Errored nicely when using Prefetch with a raw() queryset. 2019-12-09 15:45:18 +01:00
Baptiste Mispelon
9e565386d3 Fixed #27430 -- Added -b/--buffer option to DiscoverRunner. 2019-12-09 13:47:12 +01:00
Mariusz Felisiak
f464526388
Refs #30676 -- Added test for invalid --pdb and --parallel usage in DiscoverRunner. 2019-12-09 11:12:06 +01:00
Alex Aktsipetrov
bf12273db4 Fixed #31060 -- Reallowed window expressions to be used in conditions outside of queryset filters. 
Regression in 4edad1ddf6.

Thanks utapyngo for the report.
 2019-12-06 13:52:16 +01:00
Jon Dufresne
5708327c37 Fixed #23433 -- Deprecated django-admin.py entry point in favor of django-admin. 
Unify on the entry point created by setuptools entry_points feature.
 2019-12-06 12:11:44 +01:00
Jon Dufresne
8eb0f73eed Refs #23433 -- Removed script argument from AdminScriptTestCase.run_test(). 2019-12-06 10:33:54 +01:00
Jon Dufresne
8aefe11137 Removed unnecessary __init__.py creation in admin_scripts.tests. 2019-12-06 09:57:09 +01:00
Mariusz Felisiak
82a88d2f48
Fixed #31061 -- Ignored positional args in django.urls.resolve() when all optional named parameters are missing. 
Regression in 76b993a117.

Thanks Claude Paroz for the report and Carlton Gibson for reviews.
 2019-12-06 09:32:51 +01:00
Hasan Ramezani
5d674eac87 Fixed #31039 -- Added support for contained_by lookup with AutoFields, SmallIntegerField, and DecimalField. 2019-12-05 15:50:39 +01:00
Carlton Gibson
6410d38ca7
Moved selenium import to nested scope. 2019-12-05 12:47:31 +01:00
Gordon Pendleton
adb9661789 Fixed #31010 -- Allowed subdomains of localhost in the Host header by default when DEBUG=True. 2019-12-05 09:44:45 +01:00
Aymeric Augustin
c06492dd87 Fixed #23524 -- Allowed DATABASES['TIME_ZONE'] option on PostgreSQL. 2019-12-04 18:22:08 +01:00