mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-28 12:06:22 +00:00
Code Issues 30 Releases Wiki Activity
19,923 Commits 28 Branches 426 Tags 680 MiB
4abadc4872
Commit Graph

355 Commits

Author SHA1 Message Date
Luke Plant
ff3d746e8d Fixed bug in circular dependency algo for migration dependencies. 
Previous algo only worked if the first item was a part of the loop,
and you would get an infinite loop otherwise (see test).

To fix this, it was much easier to do a pre-pass.

A bonus is that you now get an error message that actually helps you debug
the dependency problem.
 2014-11-25 15:37:34 +00:00
Andrzej Pragacz
72729f844e Fixed #23794 -- Fixed migrations crash when removing a field that's part of index/unique_together. 2014-11-21 10:55:19 -05:00
Markus Holtermann
4c709cc0ef Fixed duplicate index error on Oracle; refs #23859. 
Refers to regression introduced in 7b4a994599
 2014-11-20 14:42:39 -05:00
Patryk Zawadzki
21e21c7bc2 Fixed #23844 -- Used topological sort for migration operation dependency resolution. 
This removes the concept of equality between operations to guarantee
compatilibity with Python 3.

Python 3 requires equality to result in identical object hashes. It's
impossible to implement a unique hash that preserves equality as
operations such as field creation depend on being able to accept
arbitrary dicts that cannot be hashed reliably.

Thanks Klaas van Schelven for the original patch in
13d613f800.
 2014-11-20 12:49:49 -05:00
Carl Meyer
51f2de1530 Added another migration-executor test to avoid regressions. 2014-11-19 19:43:12 -07:00
Carl Meyer
ab2819aa7b Fixed #23410 -- Avoided unnecessary rollbacks in related apps when migrating backwards. 2014-11-19 16:11:44 -07:00
Carl Meyer
47b7f601ee Fixed #23872 -- Removed sensitivity of migrations tests to CWD. 2014-11-19 15:03:47 -07:00
Markus Holtermann
2331650835 Cleaned up and reformatted autodetector tests 2014-11-19 11:09:38 -05:00
Markus Holtermann
f17acd5930 Formatted model states in autodetector tests 2014-11-19 11:09:38 -05:00
Stratos Moros
cf7a2a000e Fixed #22248 -- Made RenameModel reversible 2014-11-19 14:11:35 +02:00
Tillmann Karras
d188101319 Fixed #23799 -- Made makemigrations respect --no-optimize. 
Thanks to yamila-moreno for the idea of a skip message.
 2014-11-18 07:37:06 +01:00
Markus Holtermann
7b4a994599 Fixed #23859 -- Fixed a migration crash when a field is renamed that is part of an index_together 2014-11-17 19:15:07 +01:00
Simon Charette
68ef44c565 Removed references to the deprecated assertRaisesRegexp method. 2014-11-16 02:12:36 +01:00
Andrew Godwin
c5def493d0 Fixed #23835: Changed circular dependency in DFS to be less infinite 2014-11-15 17:39:02 +01:00
Tim Graham
83d104d61a Revert "Use topological sort for migration operation dependency resolution" 
This commit broke the tests on Python 3.

This reverts commit 13d613f800.
 2014-11-15 15:28:04 +01:00
Klaas van Schelven
13d613f800 Use topological sort for migration operation dependency resolution 
rather than an ad-hoc algorithm
 2014-11-15 14:45:42 +01:00
Markus Holtermann
c7c098cf97 Fixed #23770 -- Changed serialization strategy for floats with respect to NaN and Inf 
Thanks to w0rp for the report
 2014-11-06 15:30:30 +01:00
Berker Peksag
f7969b0920 Fixed #23620 -- Used more specific assertions in the Django test suite. 2014-11-03 11:56:37 -05:00
twidi
fd061b6591 Fixed #23733 -- Fixed squashing migrations that depend on multiple apps. 2014-10-30 14:39:11 -04:00
Markus Holtermann
85086c8158 Fixed #23556 -- Raised a more meaningful error message when migrations refer to an unavailable node 2014-10-30 00:17:29 +01:00
Markus Holtermann
5c9c1e029d Fixed #23614 -- Changed the way the migration autodetector orders unique/index_together 
Thanks to Naddiseo for the report and Tim Graham for the review
 2014-10-29 13:05:42 -04:00
Claude Paroz
70428902c0 Added missing available app in migrations test case 
In some test combinations, having contrib.auth available but not
contrib.contenttypes can produce failures while creating permissions.
 2014-10-23 15:39:26 +02:00
Tim Graham
41b337efa0 Fixed #23630 -- Made AlterModelTable rename auto-created M2M tables. 
Thanks Naddiseo for the report, Andrew Godwin for guidance,
and Shai Berger for review.
 2014-10-23 08:05:39 -04:00
Loic Bistuer
494ba051bb Made testing of stdout and stderr more consistent. 
Refs #23663.
 2014-10-22 09:25:50 +07:00
Claude Paroz
bbc3505ef8 Removed unneeded override_system_checks 
Refs #23685.
 2014-10-21 20:54:32 +02:00
Tianyi Wang
5732424bee Fixed #23629 -- Allowed autodetector to detect changes in Meta.db_table. 
Thanks Naddiseo for reporting.
 2014-10-20 13:14:44 -04:00
Claude Paroz
6d11bb102d Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times" 
This reverts commit 8d6e1afe0b.
call_command now always set skip_checks to True (tested in
user_commands).
 2014-10-20 17:26:00 +02:00
Claude Paroz
8d6e1afe0b Fixed #23650 -- Prevented migrate from calling checks 3 times 
Thanks Ilya Baryshev for the report and Tim Graham for the review.
 2014-10-17 20:20:56 +02:00
Collin Anderson
4ef9618e12 Avoided requiring sqlparse for a test. 
Refs #23426. Thanks Markus Holtermann for the suggestion.
 2014-10-09 14:59:33 -04:00
Collin Anderson
d6a87eefd8 Skip another test if sqlparse is not available 
Refs #23426
 2014-10-09 11:54:42 -04:00
Markus Holtermann
f633ba778d Fixed #23609 -- Fixed IntegrityError that prevented altering a NULL column into a NOT NULL one due to existing rows 
Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.
 2014-10-09 21:32:06 +07:00
Markus Holtermann
85f6d89313 Fixed #23426 -- Allowed parameters in migrations.RunSQL 
Thanks tchaumeny and Loic for reviews.
 2014-10-02 11:52:40 -04:00
Rudy Mutter
a407b846b4 Fixed #23365 -- Added support for timezone-aware datetimes to migrations. 2014-09-29 20:45:43 -04:00
Thomas Chaumeny
b2aad7b836 Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282. 
Thanks Collin Anderson for the review.
 2014-09-29 00:01:38 +07:00
Loic Bistuer
b23d47412c Fixed #23560 -- Fixed MigrationWrite to handle builtin types without imports. 
Thanks Tim Graham for the review.
 2014-09-27 00:36:28 +07:00
Markus Holtermann
215aa4f53b Fixed #23415 -- Added fields for unmanaged and proxy model migrations. 
Thanks sky-chen for the report.
 2014-09-25 10:25:03 -04:00
Tim Graham
d7ab2cefb7 Revert "Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations." 
This reverts commit abcf28a076.
 2014-09-24 15:49:30 -04:00
Markus Holtermann
b9a670b227 Fixed #23426 -- Don't require double percent sign in RunSQL without parameters 2014-09-24 07:20:57 -04:00
Claude Paroz
2a1bdf5ced Called table_names instead of get_table_list in migrations 2014-09-23 20:13:31 +02:00
Sergey Fedoseev
463952d940 Fixed #23503 -- Fixed renaming of model with self-referential m2m field. 2014-09-23 10:03:37 -04:00
Tim Graham
9d30412a5a Fixed some flake8 errors. 
Originally I added migrations to flake8 exclude because of long lines
in migration files, but there are other directories named migrations we
do want to check. We are not warning on line lengths yet anyway.
 2014-09-19 12:31:15 -04:00
valtron
abcf28a076 Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations. 2014-09-15 14:56:59 -04:00
Szilveszter Farkas
5e32605ce9 Fixed #23483 -- Prevented ImproperlyConfigured with dotted app names 
Made sure the app labels stay unique for the AppConfigStubs, so
migrations wouldn't fail if two dotted app names has the same last part
(e.g. django.contrib.auth and vendor.auth)
 2014-09-12 14:58:54 -06:00
Markus Bertheau
61f56e239f Corrected grammar in migrations error message. 2014-09-10 10:32:33 -04:00
Markus Holtermann
6d5958c7a3 Fixed #23452 -- Prevented infinite migrations for empty unique/index_together. 
Thanks fwkroon for the report.
 2014-09-10 07:54:16 -04:00
Markus Holtermann
16548cfc7c Fixed broken test from da160d440f; refs #23418. 2014-09-08 16:49:06 -04:00
Markus Holtermann
d28b5f13b3 Fixed #23418 -- Fail when migration deconstruct produces invalid import 2014-09-08 21:27:34 +02:00
Andrew Pinkham
4680d25df2 Fixed #22951 -- Checked for types during deep_deconstruct migration serialization process. 
Thanks Sam Hartsfield for the report.
 2014-09-08 07:39:09 -04:00
Andrew Godwin
3ab36d0046 Fix Python 3 incompatability 2014-09-05 15:47:20 -07:00
Ben Reilly
b878c73fc3 switch out recursive dfs for stack based approach, to avoid possibly hitting the recursion limit 2014-09-05 15:26:05 -07:00
Claude Paroz
885ff6845e Revert "Fixed #23384 -- Allowed overriding part of a dictionary-type setting" 
This reverts commit 66757fee7e.
Discussions have led to think that this functionality does not
bring significant benefits to justify the added complexity.
Read also discussions on ticket #22734.
 2014-09-05 20:06:02 +02:00
Raffaele Salmaso
1435cfbe8d Fixed #23302 -- Added --name/-n option to makemigrations command 2014-09-02 21:09:18 -04:00
Dave Hall
e03b7940e5 Fixed #22918 -- Fixed SeparateDatabaseAndState crash 2014-09-02 08:06:44 -04:00
Claude Paroz
66757fee7e Fixed #23384 -- Allowed overriding part of a dictionary-type setting 
This change is needed for upcoming changes where settings might be
grouped in a parent dictionary.
Thanks Tim Graham for the review.
 2014-08-30 12:37:10 +02:00
Raffaele Salmaso
abd640fbdf Fixed #23341 -- Added migration name to nonexistent migration error in makemigrations. 2014-08-23 19:18:03 -04:00
Raffaele Salmaso
be4baaefe2 Fixed #23352 -- Added tests for MigrationGraph.{forwards,backwards}_plan 2014-08-23 21:35:13 +00:00
Markus Holtermann
144cff3f51 Fixed #23322 -- Use resolved swappable model for dependency resolution during makemigrations 2014-08-20 16:04:21 -04:00
Tim Graham
d1299fce0e Fixed migrations tests added in refs #23315. 2014-08-20 14:00:59 -04:00
Andrew Godwin
9247da1032 Fixed #23315: Operational dependency fail with mixed create/add 2014-08-19 19:51:12 -07:00
Lee Sanghyuck
11d9cbe2f4 Fixed #23316 -- Added datetime.time serialization in migrations. 2014-08-19 13:31:46 -04:00
Baptiste Mispelon
54164b814c Fixed broken tests on Oracle after 5853c87a45. 
Oracle doesn't have a `BEGIN` statement so the test would
fail.

Refs #23303
 2014-08-19 17:58:30 +02:00
Baptiste Mispelon
5853c87a45 Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate. 2014-08-18 18:55:12 +02:00
Tim Graham
0ad4672c0f Fixed typo in tests/migrations/test_operations.py 2014-08-15 11:01:49 -04:00
Andrew Godwin
8f9862cd4d Fixed #23275: Unmanaged models kept by autodetector, ignored by ops 2014-08-12 12:49:20 -07:00
Andrew Godwin
dfe86449c9 Fixed #23244: Error altering FK to non-FK in migrations 2014-08-07 11:52:31 +10:00
Andrew Godwin
c06e124b5e Fixed #23091: CreateModel and AddField were clashing with deferred SQL 2014-08-04 11:59:29 +10:00
Simon Charette
1b00738f73 Fixed a MySQL test failure introduced by cbb29af1aa. 
Seems like unlike other backends MySQL get_constraints fails when dealing
with a non-existing table. refs #23160.
 2014-08-03 16:32:36 -04:00
Simon Charette
cbb29af1aa Fixed #23160 -- Correctly rename models with self referential fields. 
Thanks to whitews AT gmail for the report.
 2014-08-03 15:27:01 -04:00
Andrew Godwin
a338e07735 Fixed #23101: Prefer doing deletes before creates in autodetector. 
Makes declined or missed renames still work (but drop data).
 2014-07-29 09:38:51 -07:00
Andrew Godwin
d6e73a876d Fixed #23121: AlterModelOptions operation not changing state right 2014-07-28 10:47:28 -07:00
Andrew Godwin
cb60d22bd9 Fixed #23100: Individual FK creation missing dependencies 2014-07-28 10:32:43 -07:00
Andrew Godwin
805774df1f Fixed #22944: Bad dependency on FK alteration in autodetector 2014-07-26 09:22:19 -07:00
Andrew Godwin
a64bc3df77 Fixed #23093: soft application detection for swapped models 2014-07-25 09:35:38 -07:00
Andrew Godwin
ed4812692e Merge pull request #2938 from dekkers/ticket_23071 
Fixed #23071 -- Use last migration's name in dependency to other app
 2014-07-25 08:53:57 -07:00
Tim Graham
64e75c47ef Fixed #23014 -- Infinite migration regression with unique/index_together. 2014-07-24 14:27:10 -04:00
Tim Graham
66211b4b75 Silenced a Python 2 ImportWarning in a migrations test. 2014-07-24 09:24:52 -04:00
Jeroen Dekkers
3582698c13 Fixed #23071 -- Use last migration's name in dependency to other app 
Changed the autodetector to lookup the name of the other app's last
migration in the graph and use that as dependency instead of using
__latest__.
 2014-07-22 01:03:02 +02:00
Andrew Godwin
e24e9e0438 Fixed #23014: Renaming not atomic with unique together 2014-07-21 11:36:34 +01:00
Andrew Godwin
dcb4ed5170 Fixed #22975: Don't call rename SQL if not needed 2014-07-21 10:14:00 +01:00
Andrew Godwin
145d231782 Fixed #23041: Bad base dependencies for proxy models 2014-07-16 09:59:08 -07:00
Tim Graham
0154965392 Fixed #23013 -- Fixed removing unique_together/index_together constraints in migrations. 
Thanks melinath for the report.
 2014-07-15 15:20:59 -04:00
Tim Graham
9a2ab62977 Fixed #23008 -- Fixed typo causing bad migration dependencies. 
Thanks semenov for the report and Florian for investigation.
 2014-07-15 08:48:29 -04:00
Huu Nguyen
f7a78f9bba Fixed #22791 -- Invoke interactive questioner only for conflicts in specified apps. 
Thanks bendavis78 for the report and Tim Graham for the review.
 2014-07-14 11:00:49 -04:00
Andrew Godwin
9e5a37c82d Fix comment 2014-07-10 10:00:31 -07:00
Andrew Godwin
008bff92b7 Fixed #22970: Incorrect dependencies for existing migrated apps 2014-07-09 23:53:43 -07:00
Loic Bistuer
2572c07cc6 Fixed #22906 -- Added a more helpful repr to migrations' ModelState. 
Thanks Collin Anderson for the report and original patch.
 2014-07-06 14:56:18 +07:00
Andrew Godwin
f751109cb2 Merge pull request #2881 from charettes/ticket-22943-compiled-regex-deconstruction 
Fixed #22943 -- Correctly serialize compiled regexes.
 2014-07-05 16:37:10 -07:00
Andrew Godwin
80a12f21e3 Fixed #22960: Bad handling of relations as PKs in autodetector 2014-07-05 16:33:03 -07:00
Simon Charette
35c2c37041 Fixed #22943 -- Correctly serialize compiled regexes. 
Thanks to antialiasis at gmail dot com for the patch.
 2014-07-04 13:34:20 -04:00
Colin Wood
27ee608b55 Fixed #22940 -- Added missing string iterpolation parameters in migrations.writer error. 
Forwardport of f5740af868 from stable/1.7.x
 2014-07-02 12:45:02 -04:00
Tim Graham
70576740b0 Fixed #22917 -- Fixed typo in AlterIndexTogether.describe(). 2014-06-27 10:34:48 -04:00
Tim Graham
e0cd07ec2f Fixed #22903 -- Fixed migration generation if index_together or unique_together is removed from a model. 2014-06-25 10:02:12 -04:00
Andrew Godwin
fe262c0b84 Fixed #22708: Typo in autodetector base dependency gen 2014-06-23 20:48:33 -07:00
Tim Graham
908160f692 Fixed test failures introduced by refs #22881. 2014-06-23 09:59:36 -04:00
Chris Beaven
21c496ea52 Fixed #22881 -- Better soft_applied migration detection 2014-06-23 13:36:22 +12:00
Andrew Godwin
b30d32ff24 Fixed #22875: Optimizer did not take through= into account. 2014-06-22 11:23:45 -07:00
Tim Graham
9a46836a0c Moved a line outside of try/except to prevent an error in finally. 
Thanks Ian Foote.
 2014-06-20 09:13:34 -04:00
Huu Nguyen
fbb684d95e Fixed #22862 -- Added --noinput option to makemigrations. 
Thanks artortenburger for the report.
 2014-06-20 08:55:02 -04:00
Alex Gaynor
d015c9d11c Fixed several flake8 errors 2014-06-18 07:47:13 -07:00
Andrew Godwin
2cee1d4642 Fixed #22861: Internal migrations done first so __first__ works 
Thanks to Chris Beaven.
 2014-06-17 23:28:35 -07:00