1
0
mirror of https://github.com/django/django.git synced 2025-01-01 05:56:09 +00:00
Commit Graph

4680 Commits

Author SHA1 Message Date
Adam Johnson
16a8fe18a3 [5.0.x] Fixed CVE-2024-24680 -- Mitigated potential DoS in intcomma template filter.
Thanks Seokchan Yoon for the report.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Co-authored-by: Shai Berger <shai@platonix.com>
2024-02-06 09:13:21 -03:00
Simon Charette
761946f8e1 [5.0.x] Fixed #35149 -- Fixed crashes of db_default with unresolvable output field.
Field.db_default accepts either literal Python values or compilables
(as_sql) and wrap the former ones in Value internally.

While 1e38f11 added support for automatic resolving of output fields for
types such as str, int, float, and other unambigous ones it's cannot do
so for all types such as dict or even contrib.postgres and contrib.gis
primitives.

When a literal, non-compilable, value is provided it likely make the
most sense to bind its output field to the field its attached to avoid
forcing the user to provide an explicit `Value(output_field)`.

Thanks David Sanders for the report.

Backport of e67d7d70fa from main
2024-02-04 14:48:44 +01:00
Simon Charette
3e7a30fb3a [5.0.x] Fixed #35162 -- Fixed crash when adding fields with db_default on MySQL.
MySQL doesn't allow literal DEFAULT values to be used for BLOB, TEXT,
GEOMETRY or JSON columns and requires expression to be used instead.

Regression in 7414704e88.

Backport of dfc77637ea from main
2024-02-04 09:24:38 +01:00
Petar Netev
741f080ab5 [5.0.x] Fixed #35147 -- Added backward incompatibility note about filtering against overflowing integers.
Backport of 0630ca5725 from main
2024-02-01 20:36:50 +01:00
James Thorniley
f1fbd061ac [5.0.x] Fixed #35059 -- Ensured that ASGIHandler always sends the request_finished signal.
Prior to this work, when async tasks that process the request are cancelled due
to receiving an early "http.disconnect" ASGI message, the request_finished
signal was not being sent, potentially leading to resource leaks (such as
database connections).

This branch ensures that the request_finished signal is sent even in the case
of early termination of the response.

Regression in 64cea1e48f.

Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>

Backport of 11393ab131 from main
2024-01-31 14:45:44 -03:00
Mariusz Felisiak
7453d6a807 [5.0.x] Fixed #35159 -- Fixed dumpdata crash when base querysets use prefetch_related().
Regression in 1391356276
following deprecation in edbf930287.

Thanks Andrea F for the report.
Backport of 38eaf2f21a from main
2024-01-31 16:10:50 +01:00
Nicolas Delaby
a5440054d2 [5.0.x] Fixed #35135 -- Made FilteredRelation raise ValueError on querysets as rhs.
Regression in 59f4754704.

Backport of 820c5f1bac from main
2024-01-30 05:54:39 +01:00
Natalia
f588c444fd [5.0.x] Added stub release notes and release date for 5.0.2, 4.2.10, and 3.2.24.
Backport of 06d0a1bd56 from main
2024-01-29 11:47:13 -03:00
Claude Paroz
3cc35aafab [5.0.x] Updated translations from Transifex. 2024-01-29 05:22:31 +01:00
Mariusz Felisiak
0379e7532f [5.0.x] Applied Black's 2024 stable style.
https://github.com/psf/black/releases/tag/24.1.0

Backport of 305757aec1 from main
2024-01-26 12:55:56 +01:00
Mariusz Felisiak
ee78fe390d [5.0.x] Fixed #35127 -- Made Model.full_clean() ignore GeneratedFields.
Thanks Claude Paroz for the report.

Regression in f333e3513e.
Backport of 4879907223 from main
2024-01-19 08:56:14 +01:00
Salvo Polizzi
4ed1423de4 [5.0.x] Fixed #35121 -- Corrected color for links in the admin.
Thanks Collin Anderson for the report.

Regression in 6ad2738a8f.

Backport of 10c7c7320b from main
2024-01-18 14:07:23 +01:00
Sarah Boyce
4cba6748a6 [5.0.x] Fixed #35087 -- Reallowed filtering against foreign keys not listed in ModelAdmin.list_filters.
Regression in f80669d2f5.

Backport of a9094ec1f4 from main
2024-01-08 14:25:32 +01:00
Mariusz Felisiak
abb2448f17 [5.0.x] Added stub release notes for 5.0.2.
Backport of f412add786 from main
2024-01-02 10:35:04 +01:00
Mariusz Felisiak
01d2f94cfd [5.0.x] Added release date for 5.0.1 and 4.2.9.
Backport of f82a2c3b3d from main
2024-01-02 09:58:37 +01:00
Mariusz Felisiak
9a182f3d95 [5.0.x] Fixed #35056 -- Fixed system check crash on reverse m2m relations with related_name in ModelAdmin.filter_horizontal/vertical.
Thanks Thomas Feldmann for the report.

Regression in 107865780a.
Backport of 751d732a38 from main
2023-12-27 20:37:23 +01:00
David Wobrock
9aad44150f [5.0.x] Fixed #35050 -- Fixed prefixing field names in FilteredRelation().
Thanks Mark Zorn for the report.

Regression in 59f4754704.

Backport of 14917c9ae2 from main
2023-12-23 18:33:07 +01:00
Mariusz Felisiak
42c31f867f [5.0.x] Fixed #35054 -- Fixed crash on Oracle when fetching JSONFields with oracledb 2.0.0.
Backport of 6c08dba517 from main
2023-12-22 09:44:34 +01:00
Emanuel Andrecut
636d701ded [5.0.x] Fixed #35032 -- Corrected Char32UUIDField implementation in 5.0 release notes.
This fixes Char32UUIDField implementation in 5.0 release notes causing
records with UUIDFields created using pre-Django 5.0 and CHAR(32) not
being able to be saved anymore after upgrading and keeping the CHAR(32)
columns.

Regression in 7cd187a5ba.

Backport of e72b2826ff from main
2023-12-14 10:31:36 +01:00
Tom Carrick
8b0710cfc9 [5.0.x] Fixed #35012 -- Restored wrapping admin fieldsets with multiple fields per line.
Thanks James Gillard for the report.

Regression in 729266c6f2.

Backport of 4aae864463 from main
2023-12-13 12:34:19 +01:00
Mariusz Felisiak
5f89da0837 [5.0.x] Fixed #35018 -- Fixed migrations crash on GeneratedField with BooleanField as output_field on Oracle < 23c.
Thanks Václav Řehák for the report.

Regression in f333e3513e.

Backport of fcf95e5927 from main.
2023-12-12 05:41:38 +01:00
Sarah Boyce
03af8fbd0f [5.0.x] Fixed #35019 -- Fixed save() on models with both GeneratedFields and ForeignKeys.
Thanks Deb Kumar Das for the report.

Regression in f333e3513e.

Backport of b287af5dc9 from main
2023-12-08 12:09:56 +01:00
Mariusz Felisiak
415a08a528 [5.0.x] Fixed #35024 -- Fixed model instance creation crash on GeneratedField.output_field with backend converters.
Regression in d9de74141e.

This is a long standing issue, however it caused a crash of
GeneratedFields for all output fields that have backend-specific
converters when the RETURNING clause is not supported
(MySQL and SQLite < 3.35).
That's why severity was exacerbated.
Backport of 5b3b791e90 from main
2023-12-07 20:50:48 +01:00
Sarah Boyce
454fd50efb [5.0.x] Fixed #35020 -- Fixed ModelAdmin.lookup_allowed() for non-autofield primary keys.
Thanks Joshua Goodwin for the report.

Regression in 45ecd9acca.

Backport of f80669d2f5 from main
2023-12-07 08:44:59 +01:00
Mariusz Felisiak
da2475a217 [5.0.x] Added stub release notes for 4.2.9.
Backport of 464af0975c from main
2023-12-05 06:11:44 +01:00
Mariusz Felisiak
a1ddda7ac2 [5.0.x] Updated expected release date for 5.0.1.
Backport of 689306c745 from main
2023-12-05 06:03:44 +01:00
Natalia
cd4beb995c [5.0.x] Added stub release notes for 5.0.1.
Backport of 14884b6be8 from main
2023-12-04 10:23:51 -03:00
Natalia
94914b550d [5.0.x] Finalized release notes for Django 5.0.
Backport of 1994a26438 from main
2023-12-04 09:55:28 -03:00
Mariusz Felisiak
e4d7cc3eae [5.0.x] Added release date for 4.2.8.
Backport of 8fcb9f1f10 from main
2023-12-04 09:25:37 +01:00
Mariusz Felisiak
7f1dc67f53 [5.0.x] Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_comment on SQLite.
Thanks Юрий for the report.

Regression in 78f163a4fb.
Backport of 37fc832a54 from main
2023-11-30 10:11:02 +01:00
Mariusz Felisiak
92af3d4d23 [5.0.x] Refs #34380 -- Added FORMS_URLFIELD_ASSUME_HTTPS transitional setting.
This allows early adoption of the new default "https".

Backport of a4931cd75a from main.
2023-11-28 20:08:10 +01:00
Tom Carrick
432bfa2615 [5.0.x] Fixed #34982 -- Fixed admin's read-only password widget and help texts alignment for tablet screen size.
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>

Backport of 729266c6f2 from main
2023-11-27 15:20:22 -03:00
Mariusz Felisiak
cbd1e913ef [5.0.x] Fixed #34978, Refs #31331 -- Added backward incompatibility note about raw aggregations on MySQL.
Thanks Matthew Somerville for the report.

Backport of a652f07596 from main
2023-11-27 12:45:23 -03:00
Nathaniel Conroy
d9ba8fa397 [5.0.x] Fixed #34992 -- Fixed DatabaseFeatures.allows_group_by_selected_pks on MariaDB with ONLY_FULL_GROUP_BY sql mode.
Regression in 041551d716.

Backport of 0257426fe1 from main
2023-11-27 10:34:42 +01:00
Adam Johnson
4c74dff759 [5.0.x] Refs #34380 -- Improved docs for forms.URLField.assume_scheme.
Backport of 0203771b62 from main
2023-11-25 18:53:34 +01:00
Tom Carrick
4d33816ca6 [5.0.x] Fixed #34994 -- Fixed checkbox layout in admin's change page for narrow screen widths.
Regression in d687febce5.

Backport of a89c715c3b from main
2023-11-23 16:56:29 -03:00
Tom Carrick
15d49c8082 [5.0.x] Fixed #34991 -- Fixed pagination links and input layout in admin's change list page when using list_editable.
Regression in b4817d20b9.

Thanks Tom Carrick for the report and fix.

Backport of 4eb9c3d90a from main
2023-11-23 10:23:31 -03:00
Simon Charette
95dec210e8 [5.0.x] Fixed #34987 -- Fixed queryset crash when mixing aggregate and window annotations.
Regression in f387d024fc.

Just like `OrderByList` the `ExpressionList` expression used to wrap
`Window.partition_by` must implement `get_group_by_cols` to ensure the
necessary grouping when mixing window expressions with aggregate
annotations is performed against the partition members and not the
partition expression itself.

This is necessary because while `partition_by` is implemented as
a source expression of `Window` it's actually a fragment of the WINDOW
expression at the SQL level and thus it should result in a group by its
members and not the sum of them.

Thanks ElRoberto538 for the report.
Backport of e76cc93b01 from main
2023-11-23 06:09:58 +01:00
Mariusz Felisiak
f721fb937c [5.0.x] Refs #34118 -- Doc'd Python 3.12 compatibility in Django 4.2.x.
Backport of ecfea054ee from main
2023-11-19 16:33:01 +01:00
Simon Charette
49f1ced863 [5.0.x] Fixed #34975 -- Fixed crash of conditional aggregate() over aggregations.
Adjustments made to solve_lookup_type to defer the resolving of
references for summarized aggregates failed to account for similar
requirements for lookup values which can also reference annotations
through Aggregate.filter.

Regression in b181cae2e3.

Refs #25307.

Thanks Sergey Nesterenko for the report.

Backport of 7530cf3900 from main
2023-11-18 16:52:54 +01:00
David Smith
7f0275d8cb [5.0.x] Refs #32819 -- Used auto_id instead of id_for_label as unique identifier for the field.
`id_for_label` is blank for widgets with multiple inputs such as radios
and multiple checkboxes. Therefore , `help_text` for fields using these
widgets cannot currently be associated using `aria-describedby`.
`id_for_label` is being used as a guard to avoid incorrectly adding
`aria-describedby` to those widgets.

This change uses `auto_id` as the unique identified for the fields
`help_text`. A guard is added to avoid incorrectly adding
`aria-describedby` to inputs by checking the widget's `use_fieldset`
attribute. Fields rendered in a `<fieldset>` should have
`aria-describedby` added to the `<fieldset>` and not every `<input>`.

Backport of 292f1ea90f from main
2023-11-16 13:27:18 +01:00
Mariusz Felisiak
ddbe5c86e8 [5.0.x] Fixed #34944 -- Made GeneratedField.output_field required.
Regression in f333e3513e.

Backport of 5875f03ce6 from main
2023-11-14 20:22:33 +01:00
Adam Johnson
8eba6efbf0 [5.0.x] Fixed #34457 -- Restored output for makemigrations --check.
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>

Backport of f7389c4b07 from main
2023-11-09 10:44:07 -03:00
Mariusz Felisiak
fd593db2fa [5.0.x] Added stub release notes for 4.2.8.
Backport of 36173cf29d from main
2023-11-01 08:25:18 +01:00
Mariusz Felisiak
2d929dd2cc [5.0.x] Added CVE-2023-46695 to security archive.
Backport of 7caf262183 from main
2023-11-01 08:17:30 +01:00
Mariusz Felisiak
bb71d34551 [5.0.x] Fixed CVE-2023-46695 -- Fixed potential DoS in UsernameField on Windows.
Thanks MProgrammer (https://hackerone.com/mprogrammer) for the report.
2023-11-01 06:18:00 +01:00
Tom Carrick
602835202d [5.0.x] Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.
Regression in f3f9d03edf (4.2) and
8ed25d65ea (5.0).

Backport of 34b411762b from main
2023-10-30 11:08:03 +01:00
Mariusz Felisiak
3361668ff4 [5.0.x] Added stub release notes and release date for 4.2.7, 4.1.13, and 3.2.23.
Backport of fdd1323b9c from main
2023-10-25 05:43:00 +02:00
Claire Pritchard
4979e83d08 [5.0.x] Fixed typo in docs/releases/4.2.txt.
Backport of 61cc0e6f2c from main
2023-10-22 11:02:40 +02:00
Simon Charette
4ccca9eedc [5.0.x] Fixed #34798 -- Fixed QuerySet.aggregate() crash when referencing expressions containing subqueries.
Regression in 59bea9efd2,
complements e5c844d6f2.

Refs #28477, #34551.

Thanks Haldun Komsuoglu for the report.

Backport of 3b4a571275 from main
2023-10-16 06:15:08 +02:00