Commit Graph

32905 Commits

Author SHA1 Message Date
David Sanders 509763c799 Fixed #35638 -- Updated validate_constraints to consider db_default. 2024-08-05 17:33:12 +02:00
David Sanders 91a038754b Refs #35638 -- Avoided wrapping expressions with Value in _get_field_value_map() and renamed to _get_field_expression_map(). 2024-08-05 17:33:12 +02:00
Mariusz Felisiak 304d256674
Used :pypi: role in docs where appropriate. 2024-08-05 10:35:50 -03:00
John Parton 7f8d839722 Fixed #35628 -- Allowed compatible GeneratedFields for ModelAdmin.date_hierarchy. 2024-08-05 15:27:20 +02:00
Natalia 90adba85b2 Refs #35380 -- Updated screenshots in admin docs. 2024-08-05 09:02:01 -03:00
Natalia fb6050e784 Refs #35380 -- Updated screenshots in intro docs. 2024-08-05 09:02:01 -03:00
Natalia 6e66c77089 Fixed #35645, Refs #35558 -- Added "medium" color in the admin CSS to improve accessibility of headings. 2024-08-05 09:02:01 -03:00
Jake Howard d5bebc1c26 Refs #35537 -- Improved documentation and test coverage for email attachments and alternatives. 2024-08-05 09:21:44 +02:00
Sarah Boyce 5424151f96 Fixed #35655 -- Reverted "Fixed #35295 -- Used INSERT with multiple rows on Oracle 23c."
This reverts commit 175b04942a due to a crash when Oracle > 23.3.
2024-08-03 09:05:30 +02:00
Mariusz Felisiak 6d3464cff0
Refs #35601, Refs #35599 -- Made cosmetic edits to TelInput/ColorInput docs. 2024-08-02 17:40:53 -03:00
Simon Charette a16f13a866
Fixed #35643 -- Fixed a crash when ordering a QuerySet by a reference containing "__".
Regression in b0ad41198b.

Refs #34013. The initial logic did not consider that annotation aliases
can include lookup or transform separators.

Thanks Gert Van Gool for the report and Mariusz Felisiak for the review.
2024-08-02 16:21:12 -03:00
lucasesposito b478cae006 Fixed #35601 -- Added TelInput widget. 2024-08-02 11:31:54 +02:00
arjunomray 946c3cf734 Fixed #35599 -- Added ColorInput widget. 2024-08-02 09:51:49 +02:00
Vaarun Sinha 54e8b4e582 Fixed #35489 -- Fixed vertical alignment of raw_id_fields widget.
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-08-02 08:56:54 +02:00
Markus Holtermann aa90795050 Fixed #35646 -- Extended SafeExceptionReporterFilter.hidden_settings to treat `AUTH` as a sensitive match.
Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
2024-08-01 15:02:00 -03:00
Natalia 615c80aba6 Improved view_tests.tests.test_debug.ExceptionReporterFilterTests. 2024-08-01 15:02:00 -03:00
Bendeguz Csirmaz 1eac690d25 Refs #373 -- Added tuple lookups. 2024-08-01 17:26:09 +02:00
Sarah Boyce 3dac3271d2 Reverted "Fixed #28646 -- Prevented duplicate index when unique is set to True on PostgreSQL."
This reverts commit 9cf9c796be due to a crash on Oracle
as it didn't allow multiple indexes on the same field.
2024-08-01 09:25:33 +02:00
nessita 8cf931dd2f
Removed GitHub Actions for creating and checking reminders. 2024-07-31 10:07:57 -03:00
Jeremy Thompson 30a60e8492 Fixed #35598 -- Added SearchInput widget. 2024-07-31 13:11:45 +02:00
Sarah Boyce 3f88089069 Added stub release notes and release date for 5.0.8 and 4.2.15. 2024-07-31 11:21:32 +02:00
Ben Cail 9cf9c796be Fixed #28646 -- Prevented duplicate index when unique is set to True on PostgreSQL. 2024-07-30 17:27:10 +02:00
Maryam Yusuf 7e00fee3bd Fixed #35546 -- Emphasised accepted ticket requirement in contributing docs. 2024-07-29 15:12:43 +02:00
Maryam Yusuf 9d10c7ab33 Referenced joining the triage and review team as motivation to do PR reviews. 2024-07-29 14:46:10 +02:00
Mariusz Felisiak e3de574c1e Refs #35074 -- Simplified and unified adding spatial indexes on MySQL and Oracle.
This uses `deferred_sql` and `_field_indexes_sql()` instead of custom
hooks on MySQL.
2024-07-29 12:31:32 +02:00
Tim Graham b6ad8b687a Added missing skips in constraint tests. 2024-07-26 18:59:12 +02:00
nessita 1b277b45cc
Added dedicated test for invalid inputs in floatformat template filter tests.
Co-authored-by: Sarah Boyce <42296566+sarahboyce@users.noreply.github.com>
2024-07-25 16:15:53 -03:00
Lorenzo Peña 0e94f292cd Fixed #35627 -- Raised a LookupError rather than an unhandled ValueError in get_supported_language_variant().
LocaleMiddleware didn't handle the ValueError raised by
get_supported_language_variant() when language codes were
over 500 characters.

Regression in 9e9792228a.
2024-07-25 09:38:46 +02:00
Sarah Boyce 2c024c9ac0 Added contributor guidelines for performance optimizations. 2024-07-25 09:25:25 +02:00
Devin Cox cd0479ff76 Fixed #35331 -- Updated dropdown lists with entries added via the '+' sign from M2M field. 2024-07-25 08:52:24 +02:00
Simon Charette f359990e49 Fixed #35625 -- Fixed a crash when adding a field with db_default and check constraint.
This is the exact same issue as refs #30408 but for creating a model with a
constraint containing % escapes instead of column addition. All of these issues
stem from a lack of SQL and parameters separation from the BaseConstraint DDL
generating methods preventing them from being mixed with other parts of the
schema alteration logic that do make use of parametrization on some backends
(e.g. Postgres, MySQL for DEFAULT).

Prior to the addition of Field.db_default and GeneratedField in 5.0
parametrization of DDL was never exercised on model creation so this is
effectively a bug with db_default as the GeneratedField case was addressed by
refs #35336.

Thanks Julien Chaumont for the report and Mariusz Felisiak for the review.
2024-07-25 07:48:53 +02:00
Sarah Boyce 8d6a20b656 Fixed #35604, Refs #35326 -- Made FileSystemStorage.exists() behaviour independent from allow_overwrite.
Partially reverts 0b33a3abc2.

Storage.exists(name) was documented to "return False if
the name is available for a new file." but return True if
the file exists. This is ambiguous in the overwrite file
case. It will now always return whether the file exists.

Thank you to Natalia Bidart and Josh Schneier for the
review.
2024-07-24 14:55:10 +02:00
arjunomray 5559011c2b Fixed #35541 -- Fixed paginator border in admin CSS. 2024-07-24 12:28:23 +02:00
Mariusz Felisiak df35cf578f Updated asgiref dependency for 5.1 release series. 2024-07-24 08:21:07 +02:00
Mariusz Felisiak 6c89a53ab3 Bumped versions in pre-commit and npm configurations. 2024-07-24 08:09:29 +02:00
Mariusz Felisiak 9f5e2306e2
Refs #29049 -- Fixed isolation of BasicExpressionsTests._test_slicing_of_f_expressions() subtests.
Thanks Tim Graham for the report.
2024-07-23 14:29:14 -03:00
Flavio Curella f9bf616597
Fixed #35585 -- Corrected Query.exists() call in Query.has_results(). 2024-07-23 11:36:26 -03:00
Matthew Somerville fb7be022cb Updated example links in urlize docs.
goo.gl links are being removed in 2025:
https://developers.googleblog.com/en/google-url-shortener-links-will-no-longer-be-available/
2024-07-23 14:02:30 +02:00
nessita cf03aa4e94
Refs #10941 -- Reorganized querystring template tag docs. 2024-07-22 10:31:54 -03:00
Mariusz Felisiak b06cf62c88 Cleaned up temporary test directories in tests. 2024-07-22 08:51:01 +02:00
sobolevn 2ff917fd06 Applied optimizations to template.utils.get_app_template_dirs(). 2024-07-22 08:38:46 +02:00
Jacob Walls 1029a4694e Fixed typo in django/test/testcases.py docstring. 2024-07-22 08:36:13 +02:00
Bendeguz Csirmaz bdd538488c Fixed #35614 -- Prevented SQLCompiler.as_subquery_condition() from mutating a query. 2024-07-22 08:34:29 +02:00
Ellen b21f6d7ee4 Fixed broken link in django.core.files.temp docstring. 2024-07-22 08:29:21 +02:00
Muhammad N. Fadhil ee20e2d038 Fixed typos in Atomic docstring. 2024-07-22 08:27:27 +02:00
Simon Charette 9cb8baa0c4 Fixed #35559 -- Avoided unnecessary query on sliced union of empty queries.
While refs #34125 focused on the SQL correctness of slicing of union of
potentially empty queries it missed an optimization opportunity to avoid
performing a query at all when all queries are empty.

Thanks Lucidiot for the report.
2024-07-19 08:54:47 +02:00
Simon Charette 6b3f55446f Fixed #35603 -- Prevented F.__contains__() from hanging.
Regression in 94b6f101f7.
2024-07-18 08:39:10 +02:00
Hisham Mahmood 182f262b15 Fixed #35606, Refs #34045 -- Fixed rendering of ModelAdmin.action_checkbox for models with a __html__ method.
Thank you Claude Paroz for the report.

Regression in 85366fbca7.
2024-07-18 08:09:37 +02:00
Simon Charette 0e49a8c3bd Refs #34701 -- Moved UniqueConstraint(nulls_distinct) validation tests.
The original tests required the creation of a model that is no longer necessary
and were exercising Model.full_clean(validate_constraints) which has nothing
to do with the nulls_distinct feature.
2024-07-17 12:52:17 +02:00
Simon Charette adc0b6aac3 Fixed #35594 -- Added unique nulls distinct validation for expressions.
Thanks Mark Gensler for the report.
2024-07-17 12:52:17 +02:00