mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-23 01:25:58 +00:00
Code Issues 25 Releases Wiki Activity
29,116 Commits 28 Branches 426 Tags 666 MiB
3071660acf
Commit Graph

406 Commits

Author SHA1 Message Date
Tim Graham
b5f0b3478d Fixed #27579 -- Added aliases for Python 3's assertion names in SimpleTestCase. 2016-12-07 17:42:31 -05:00
Ramin Farajpour Cami
967be82443 Fixed E305 flake8 warnings. 2016-11-14 12:30:46 -05:00
Jacob Rief
b3162cab94 Fixed #27386 -- Wrapped admin's readonly fields in <div> rather than <p>. 2016-11-12 10:02:57 -05:00
za
321e94fa41 Refs #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings. 2016-11-10 21:30:21 -05:00
Halil Kaya
2027d6acf7 Fixed #26954 -- Prevented ModelAdmin.has_module_permission()=False from blocking access to the app index page. 2016-10-13 09:11:36 -04:00
Denis Cornehl
a840710e1e Fixed #26447 -- Deprecated settings.USE_ETAGS in favor of ConditionalGetMiddleware. 2016-10-10 14:55:59 -04:00
Tim Graham
6f3c78dbe6 Fixed #27266 -- Allowed using assertFormError()/assertFormsetError() in admin forms and formsets. 
Thanks Diego Andrés Sanabria Martín for the report and review.
 2016-09-27 09:56:19 -04:00
Jon Dufresne
2c716c1dc7 Fixed #27256 -- Changed Select widget's selected attribute to use HTML5 boolean syntax. 2016-09-21 15:12:13 -07:00
Tim Graham
8119b679eb Refs #27025 -- Fixed "invalid escape sequence" warnings in Python 3.6. 
http://bugs.python.org/issue27364
 2016-09-17 15:44:06 -04:00
Jibodeah
9459ec82aa Fixed #26170 -- Made ModelAdmin views run transactions on the correct database. 
Thanks juntatalor for the initial patch.
 2016-09-14 16:06:39 -04:00
Jon Dufresne
8b050cf9dc Refs #26524 -- Added a test for a <OneToOneField>_id reference in ModelAdmin.list_display. 2016-09-12 19:20:35 -07:00
Jon Dufresne
e24c0a2d7c Fixed #26524 -- Fixed crash in admin change view when displaying many to many forward refs. 
Thanks Tim Graham for the regression test.
 2016-09-12 19:20:35 -07:00
Alexander Gaevsky
2d26b4637f Fixed #27207 -- Replaced <p> tag with <div> in admin help texts. 2016-09-10 16:54:10 -04:00
Tim Graham
ef021412d5 Normalized spelling of ETag. 2016-09-09 11:00:21 -04:00
Stanislav Karpov
b387189d86 Fixed #26919 -- Added the action form's media in the changelist view. 2016-08-11 19:35:31 -04:00
Adam Chainz
a757c68129 Fixed admin_views clashing field check error. 
admin_views.Recommendation.recommender: (models.E006) The field 'recommender'
clashes with the field 'recommender' from model 'admin_views.title'.
 2016-08-10 15:54:29 -04:00
Tim Graham
93c538694e Fixed XSS in admin's add/change related popup. 
This is a security fix.
 2016-07-18 11:17:01 -04:00
Kenneth
2f587737d7 Fixed #26872 -- Fixed text overflow in ModelAdmin.list_filter. 2016-07-09 08:06:42 -04:00
Tim Graham
c9ae09addf Replaced use of TestCase.fail() with assertRaises(). 
Also removed try/except/fail antipattern that hides exceptions.
 2016-06-28 11:21:26 -04:00
Shabda Raaj
b0acb1e73e Fixed #26779 -- Added extra_context parameter to admin's i18n_javascript view. 2016-06-27 15:37:32 -04:00
Jon Dufresne
4f336f6652 Fixed #26747 -- Used more specific assertions in the Django test suite. 2016-06-16 14:19:18 -04:00
Oliver Sauder
5d8375fe66 Fixed #4548 -- Added username hint to admin's change_password form. 2016-06-09 12:18:15 -04:00
krishbharadwaj
f6681393d3 Fixing #26524 -- Made a foreign key id reference in ModelAdmin.list_display display the id. 2016-06-08 17:20:03 -04:00
Emad Mokhtar
c4980e28e5 Fixed #26290 -- Warned that paginating an unordered QuerySet may result in inconsistent results. 2016-06-08 14:09:24 -04:00
Vytis Banaitis
2f9c4e2b6f Fixed #19963 -- Added support for date_hierarchy across relations. 2016-06-04 12:14:02 -04:00
Dan Stephenson
1206eea11e Fixed #26558 -- Removed need for request context processor on admin login page. 2016-05-04 09:43:24 -04:00
Anssi Kääriäinen
7f51876f99 Fixed #26207 -- Replaced dynamic classes with non-data descriptors for deferred instance loading. 2016-04-29 13:06:32 -04:00
Jon Dufresne
ec6121693f Fixed #22383 -- Added support for HTML5 required attribute on required form fields. 2016-04-21 19:16:38 -04:00
Markus Amalthea Magnuson
08cd6a0e56 Fixed #16327 -- Redirected "Save as new" to change view instead of the changelist. 2016-04-20 11:31:44 -04:00
Tim Graham
92053acbb9 Fixed E128 flake8 warnings in tests/. 2016-04-08 10:12:33 -04:00
Akshesh
a7c813ba04 Fixed #21734 -- Handled ProtectedError in a POST to admin's delete_selected action. 2016-03-29 07:42:23 -04:00
Tim Graham
acfaec3db5 Fixed #26387 -- Restored the functionality of the admin's raw_id_fields in list_editable. 2016-03-25 13:47:42 -04:00
Tim Graham
4b510c3889 Removed unused variable. 2016-03-21 20:20:04 -04:00
Akshesh
49ac10b4de Fixed #26235 -- Handled ProtectedError in a POST to admin's delete_view(). 2016-03-21 19:25:27 -04:00
Akshesh
44c0ecdd92 Fixed #25364 -- Added generic way to test on all browsers supported by selenium. 
Browser names should be passed as a comma separated list to the --selenium flag.

Thanks Tim Graham, Simon Charette and Moritz Sichert for review and discussion.
 2016-03-15 13:10:32 -04:00
Tim Graham
004ba0f99e Removed unneeded hint=None/obj=None in system check messages. 2016-02-12 13:01:25 -05:00
Tim Graham
015fad9060 Fixed #26175 -- Removed SHA1 password hashes in tests. 2016-02-06 08:47:21 -05:00
Federico Capoano
e972a7d03d Fixed #13875 -- Made admin's submit_row template tag pass whole context. 2016-02-04 11:56:16 -05:00
Tim Graham
37f7ef41fb Fixed #24316 -- Made ModelAdmin.list_display callables use an appropriate CSS class name. 
Thanks Berker Peksag for the review.
 2016-02-02 10:22:59 -05:00
Myk Willis
62f3acc70a Fixed incorrect permissions check for admin's "Save as new". 
This is a security fix.
 2016-02-01 11:57:00 -05:00
Alexander Gaevsky
9a33d3d764 Fixed #26060 -- Fixed crash with reverse OneToOneField in ModelAdmin.readonly_fields. 2016-01-21 13:21:28 -05:00
Tim Graham
294d0d8815 Fixed #26048 -- Made admin selenium tests use implicitly_wait() 2016-01-11 14:16:17 -05:00
Tim Graham
2ed2db2ea3 Replaced selenium.find_element_by_css_selector where by_id is sufficient. 2016-01-11 09:16:23 -05:00
Tim Graham
3541ca1504 Refs #25165 -- Fixed JSON serialization for delete popup in the admin. 2016-01-09 13:35:58 -05:00
Alexander Gaevsky
5052f79df4 Added a test for adding a UUID pk object using the "Add related" admin popup. 
Follow up to refs #25997 but this case wasn't broken.
 2016-01-08 18:49:03 -05:00
Claude Paroz
cf7894be88 Fixed #21113 -- Made LogEntry.change_message language independent 
Thanks Tim Graham for the review.
 2016-01-08 20:34:59 +01:00
Alexander Gaevsky
ade54ffa34 Refs #25165 -- Fixed JSON serialization for add/edit popup in the admin. 
Forwardport of test in o839d71d8562abe0b245024e55ca1d02a45e58fd from stable/1.9.x
(refs #25997).
 2016-01-08 12:28:32 -05:00
Tim Graham
822a03b3e4 Refs #25165 -- Fixed failure of admin's "Add another" popup to close. 
Thanks Thomas Grainger for the fix.
 2016-01-08 11:41:01 -05:00
Scott Pashley
7cc2efc2d6 Fixed #26035 -- Prevented user-tools from appearing on admin logout page. 2016-01-06 13:48:02 -05:00
Marten Kenbeek
16411b8400 Fixed #26013 -- Moved django.core.urlresolvers to django.urls. 
Thanks to Tim Graham for the review.
 2015-12-31 14:21:29 -05:00
Alexander Gaevsky
69208a5a1c Fixed #25465 -- Restored line breaks conversion in admin readonly fields. 2015-12-29 19:31:43 -05:00
Claude Paroz
35c41987ec Moved LogEntry-related tests to their own test case 
Thanks Tim Graham for reviewing and contributing to the patch.
Refs #21113.
 2015-12-28 20:29:08 +01:00
Tim Graham
24a190d53c Fixed previous commit (e3d782fe80) on Python 3. 2015-12-28 12:26:39 -05:00
Tim Graham
e3d782fe80 Added the response to an admin_views test assertion to aid debugging. 2015-12-28 11:25:46 -05:00
Tim Graham
f18b08748a Fixed #25903 -- Fixed the admin's list_editable add/change buttons. 2015-12-21 09:29:57 -05:00
Sergey Fedoseev
8ab58b8052 Fixed #25883 -- Fixed admin deletion page summary counts for related objects. 2015-12-10 18:09:03 -05:00
Thomas Grainger
d638cdc42a Fixed #25165 -- Removed inline JavaScript from the admin. 
This allows setting a Content-Security-Policy HTTP header
(refs #15727).

Special thanks to blighj, the original author of this patch.
 2015-12-05 15:51:57 -05:00
Tim Graham
9350616211 Removed explicit User ids in tests. 2015-11-24 09:59:20 -05:00
Adam Wester
550107ff75 Fixed #25781 -- Simplified admin_views tests with client.force_login() 2015-11-21 17:21:32 -05:00
Alex Morozov
13dba4dba3 Fixed #25780 -- Removed redundant status code assertions from tests 2015-11-21 18:12:33 +01:00
Tim Graham
65764a9316 Renamed __unicode__() to __str__() in some test comments. 2015-11-19 16:44:16 -05:00
Anton Baklanov
80bcbecd4a Fixed #19361 -- Added link to object's change form in admin's post-save message. 
Thanks Roel Kramer for tests.
 2015-11-19 15:04:32 -05:00
Nick Sandford
5fa7b592b3 Fixed #22810 -- Corrected admin changelist count for list filters that filter by default. 2015-11-18 19:54:27 -05:00
Attila Tovt
0a2d3b7387 Fixed #25682 -- Removed bare except clauses. 2015-11-17 14:39:15 -05:00
Simon Charette
9dcfecb7c6 Fixed #25622 -- Accounted for generic relations in the admin to field validation 
Thanks to Jonathan Liuti for the report and Tim Graham for the review.
 2015-10-29 13:13:19 -04:00
Dheerendra Rathor
59e85f09c6 Fixed #25519 -- Made the admin "View site" link point to sites running on a subpath. 
Used request.META['SCRIPT_NAME'] as the site_url if it hasn't been
customized from the default value of '/'.
 2015-10-22 13:51:00 -04:00
John Vandenberg
9e3f6c7483 Fixed quad quoted ("""") docstring starts. 2015-10-20 12:19:17 -04:00
Tim Graham
849037af36 Refs #23957 -- Required session verification per deprecation timeline. 2015-09-23 19:31:10 -04:00
Dražen Odobašić
b1e33ceced Fixed #23395 -- Limited line lengths to 119 characters. 2015-09-12 11:40:50 -04:00
Malcolm Box
1d8eb0cae5 Fixed #25374 -- Made ModelAdmin checks work on instances instead of classes. 
This allows dynamically-generated attributes to be specified in
checked ModelAdmin attributes without triggering errors.
 2015-09-11 09:28:34 -04:00
Ola Sitarska
f2f8972def Fixed #25135 -- Deprecated the contrib.admin allow_tags attribute. 
Thanks Jaap Roes for the idea and initial patch.
 2015-09-08 19:13:43 -04:00
Tim Graham
d5bac7e449 Fixed #25353 -- Changed LogEntry.action_time to a "date created". 2015-09-04 12:33:11 -04:00
sarthakmeh
40bf18e702 Fixed #25058 -- Added GenericRelations with related_query_name to the admin's delete confirmation page. 2015-09-03 10:08:51 -04:00
Maxime Lorant
5153a3bfdc Fixed #25331 -- Removed trailing blank lines in docstrings. 2015-08-31 17:37:21 -04:00
Tim Graham
7ac0cd445e Fixed #25323 -- Fixed selenium test failures with chromedriver 2.18. 2015-08-28 13:54:03 -04:00
Tim Graham
9607a04041 Fixed #25299 -- Fixed crash with ModelAdmin.list_display value that clashes with a model reverse accessor. 2015-08-28 08:46:26 -04:00
elky
c32b61c6fd Fixed #20597 -- Replaced admin GIF/PNG icons by SVG 2015-08-27 17:21:02 -04:00
Luis Visintini
635ffc3c37 Fixed #25163 -- Added hint for non-staff users to admin login page. 2015-07-29 15:09:32 -04:00
Flavio Curella
c2e70f0265 Fixed #21127 -- Started deprecation toward requiring on_delete for ForeignKey/OneToOneField 2015-07-27 18:28:13 -04:00
Tim Graham
04e69598de Refs #24919 -- Made test models serializable for migrations. 2015-07-21 09:19:40 -04:00
Edward Henderson
f8cc464452 Fixed #16501 -- Added an allow_unicode parameter to SlugField. 
Thanks Flavio Curella and Berker Peksag for the initial patch.
 2015-07-17 13:48:58 -04:00
Tim Graham
e7c6a2cf9f Refs #4960 -- Fixed selenium test failures for CharField strip changes. 2015-07-06 08:52:50 -04:00
Jan Pazdziora
3353684102 Fixed #25032 -- Removed double redirect in admin login. 2015-07-03 08:53:10 -04:00
Luke Plant
aef2a0ec59 Fixed #25018 -- Changed simple_tag to apply conditional_escape() to its output. 
This is a security hardening fix to help prevent XSS (and incorrect HTML)
for the common use case of simple_tag.

Thanks to Tim Graham for the review.
 2015-06-29 08:16:19 -04:00
Marten Kenbeek
1e82094f1b Fixed #21927 -- Made application and instance namespaces more distinct. 
Made URL application namespaces be set in the included URLconf and
instance namespaces in the call to include(). Deprecated other ways
to set application and instance namespaces.
 2015-06-08 15:12:20 -04:00
Trey Hunner
788071e22d Moved jQuery to a vendor/jquery subdirectory. 2015-06-07 22:23:42 +02:00
Simon Charette
be67400b47 Refs #24652 -- Used SimpleTestCase where appropriate. 2015-05-20 13:46:13 -04:00
Riccardo Magliocchetti
bd53db5eab Fixed #24553 -- Added the list of available applications to AdminSite.each_context() 2015-05-11 12:07:36 -04:00
Adam Zapletal
0894643e40 Fixed #23387 -- Kept "Save as new" button after validation errors in admin. 
When "Save as new" is chosen and errors occur, only show the "Save as new"
button and not the other save buttons.

Thanks to Tino de Bruijn for doing the real work on this fix.
 2015-05-02 19:41:10 -04:00
Tim Graham
845817b039 Fixed #24466 -- Added JavaScript escaping in a couple places in the admin. 
Thanks Aymeric Augustin and Florian Apolloner for work on the patch.
 2015-03-30 19:07:17 -04:00
Varun Sharma
74f8110e74 Added test for LogEntry.get_edited_object(); refs #24244. 2015-03-23 08:51:43 -04:00
Karl Hobley
aea02ddfb7 Fixed #24490 -- Set LogEntry.change_message when adding an object. 2015-03-20 18:25:06 -04:00
Bas Peschier
0339844b70 Fixed #24476 -- Added context manager/decorator for overriding script prefix. 
Tests were using an undocumented keyword argument for easily overriding
script prefix while reversing. This is now changed into a test utility
which can be used as decorator or context manager.
 2015-03-18 13:03:25 -04:00
Baptiste Mispelon
82c9169077 Refs #24461 -- Added test/release notes for XSS issue in ModelAdmin.readonly_fields 
This issue was fixed by refs #24464.
 2015-03-09 10:12:21 -04:00
david
88c605e3e3 Fixed #23993 -- Added form.media to the admin login template. 2015-03-07 12:59:58 +01:00
Tim Graham
82f7bee1d5 Fixed admin selenium tests broken by removal of fixtures. 2015-03-05 17:51:17 -05:00
Josh Smeaton
39a7eed1bb Converted test fixtures to setUpTestData methods 2015-03-05 10:10:32 +11:00
Tim Graham
36a17be9f3 Fixed #24426 -- Displayed admin actions panel when show_full_result_count=False. 2015-03-04 12:00:12 -05:00
Andrei Kulakov
08572e8d12 Fixed #24294 -- Allowed staff_member_required decorator to handle args. 2015-03-02 13:15:34 -05:00
Aymeric Augustin
a8fe12417f Normalized usage of the tempfile module. 
Specifically stopped using the dir argument.
 2015-02-23 16:55:27 +01:00
Aymeric Augustin
934400759d Guaranteed removal of temporary files during tests. 
Dropped the DJANGO_TEST_TEMP_DIR environment variable.

Before this change, proper removal depended on the developer passing
dir=os.environ['DJANGO_TEST_TMP_DIR'] to tempfile functions.
 2015-02-23 16:55:26 +01:00
Claude Paroz
1791a7e75a Fixed #15779 -- Allowed 'add' primary key in admin edition 
Thanks Marwan Alsabbagh for the report, and Simon Charette and
Tim Graham for the reviews.
 2015-02-14 11:19:55 +01:00
Tim Graham
d64baaef3b Fixed #24333 -- Fixed admin history view crash with non-integer slug. 2015-02-12 14:19:44 -05:00
Simon Charette
5b75b01939 Refactored an admin_view test case. 
Used setUpTestData, client login/logout and manager's count() method.

Thanks to Tim for the review.
 2015-02-09 15:08:05 -05:00
Simon Charette
8a590c4b7b Moved a custom admin template test to a more appropriate case. 
Thanks to Tim for the review.
 2015-02-09 15:07:49 -05:00
Claude Paroz
32e6a7d3a5 Replaced hardcoded URLs in admin_* tests 
Refs #15779. This will allow easier admin URL changes, when needed.
Thanks Simon Charette for the review.
 2015-02-08 20:55:09 +01:00
Tim Graham
0ed7d15563 Sorted imports with isort; refs #23860. 2015-02-06 08:16:28 -05:00
Tim Graham
bbe28496d3 Removed old import aliases. 2015-02-05 19:37:01 -05:00
darkryder
9ec8aa5e5d Fixed #24149 -- Normalized tuple settings to lists. 2015-02-03 14:59:45 -05:00
Adam Taylor
039465a6a7 Fixed typos in code comments. 2015-01-20 12:18:03 -05:00
Tim Graham
67a76500a5 Removed support for admin validators per deprecation timeline; refs #16905. 2015-01-18 14:43:21 -05:00
Collin Anderson
a420f83e7d Fixed #24055 -- Keep reference to view class for resolve() 2015-01-17 22:09:10 +07:00
Claude Paroz
b4ac232907 Fixed #24099 -- Removed contenttype.name deprecated field 
This finsishes the work started on #16803.
Thanks Simon Charette, Tim Graham and Collin Anderson for the
reviews.
 2015-01-16 20:21:34 +01:00
Aymeric Augustin
5f7230e12f Fixed #24124 (again) -- Updated tests with new default context_processors. 
Thanks Collin for the review.
 2015-01-12 22:31:44 +01:00
Simon Charette
07988744b3 Fixed #13165 -- Added edit and delete links to admin foreign key widgets. 
Thanks to Collin Anderson for the review and suggestions and Tim for the
final review.
 2015-01-10 12:24:52 -05:00
Tim Graham
b8abfe141b Fixed #24101 -- Fixed flaky admin_views selenium tests; refs #7361. 2015-01-08 13:17:00 -05:00
Thomas Tanner
46068d850d Fixed #22295 -- Replaced permission check for displaying admin user-tools 2014-12-31 16:31:59 -05:00
Aymeric Augustin
9eb4f28e89 Deprecated TEMPLATE_CONTEXT_PROCESSORS. 2014-12-28 17:02:31 +01:00
Aymeric Augustin
d3205e3e2e Deprecated TEMPLATE_DIRS. 2014-12-28 17:02:30 +01:00
Aymeric Augustin
92e8f1f302 Moved context_processors from django.core to django.template. 2014-12-28 17:00:07 +01:00
Diego Guimarães
ca013e652f Fixed #23995 -- Removed unnecessary calls to self.client.logout() in tests. 2014-12-16 09:12:46 -05:00
Diego Guimarães
d8182f294a Refs #23947 -- Fixed admin_views test execution order dependency. 2014-12-15 10:48:42 -05:00
Tim Graham
c7a19f4203 Fixed #23857 -- Fixed admin crash with "save as new" and deleting inline. 
Thanks amarandon for the report.
 2014-12-12 10:24:39 -05:00
Kevin Marsh
e2868308bf Fixed template tag braces spacing. 2014-12-12 09:34:18 -05:00
Kamil Braun
0623f4dea4 Fixed #23934 -- Fixed regression in admin views obj parameter. 2014-12-02 08:42:17 -05:00
Tim Graham
43fcf3505e Fixed admin_views test from refs #7361 (name was too long). 2014-12-01 15:47:41 -05:00
Berker Peksag
c8dcded930 Fixed #17890 -- Added an extra_context parameter to AdminSite.password_change(). 2014-11-29 10:31:09 -05:00
wrwrwr
7cd3f1c295 Fixed cache state dependence for assertNumQueries in test_group_permission_performance. 
Refs #20432 and #23746.
 2014-11-27 13:02:21 -05:00
Simon Charette
3a9aa155e2 Fixed #23915 -- Made sure m2m fields through non-pk to_field are allowed in the admin. 
refs #23754, #23862
 2014-11-25 15:28:21 -05:00
Simon Charette
f9c4e14aec Fixed #23754 -- Always allowed reference to the primary key in the admin 
This change allows dynamically created inlines "Add related" button to work
correcly as long as their associated foreign key is pointing to the primary
key of the related model.

Thanks to amorce for the report, Julien Phalip for the initial patch,
and Collin Anderson for the review.
 2014-11-25 13:26:50 -05:00
Redouane Zait
8e7b384d89 Fixed #23898 -- Added missing context to admin's deleted_selected view. 
Thanks Redouane Zait for the report.
 2014-11-25 11:22:15 -05:00
Veres Lajos
a71a2ea756 Fixed typos using https://github.com/vlajos/misspell_fixer 2014-11-03 20:59:30 -05:00
Berker Peksag
f7969b0920 Fixed #23620 -- Used more specific assertions in the Django test suite. 2014-11-03 11:56:37 -05:00
Loic Bistuer
968510e5d7 Moved a test case that caused deprecation warnings. 
`cache.tests.TestEtagWithAdmin` loaded views from the `admin_views` test
package. This is problematic because when the `cache` test package is
run in isolation, `admin_views` isn't in INSTALLED_APPS, and therefore
loading its models isn't allowed since the app loading refactor.
 2014-10-20 00:22:48 +07:00
Thomas Chaumeny
825ea83858 Fixed #21196 -- Removed index on test field causing MySQL specific warning. 2014-10-19 13:44:39 +07:00
Emmanuelle Delescolle
a24cf21722 Fixed #23604 -- Allowed related m2m fields to be references in the admin. 
Thanks Simon Charette for review.
 2014-10-06 08:35:16 -04:00
Nick Sandford
f5cfd09c25 Fixed #7361 -- Added cancel link to admin delete views. 2014-09-30 08:45:04 -04:00
Thomas Chaumeny
17557d068c Fixed #8408 -- Added ModelAdmin.show_full_result_count to avoid COUNT() query. 
Thanks lidaobing for the suggestion.
 2014-09-26 12:12:40 -04:00
Simon Charette
342ccbddc1 Fixed #23431 -- Allowed inline and hidden references to admin fields. 
This fixes a regression introduced by the 53ff096982 security fix.

Thanks to @a1tus for the report and Tim for the review.

refs #23329.
 2014-09-08 13:49:07 -04:00
Simon Charette
3cbb7590cb Fixed #23329 -- Allowed inherited and m2m fields to be referenced in the admin. 
Thanks to Trac alias Markush2010 and ross for the detailed reports.
 2014-08-27 21:26:53 -04:00
areski
a81af7f49d Fixed #13749 -- Added link from admin site to front-end site. 
Thanks romankrv for the suggestion.
 2014-08-27 08:34:53 -04:00
Simon Charette
53ff096982 Prevented data leakage in contrib.admin via query string manipulation. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
areski
3021453285 Fixed #20133 -- Added summary to admin deletion confirmation pages. 
Thanks jonash for the suggestion and initial patch.
 2014-08-14 13:56:23 -04:00
Tim Graham
9b1515906e Removed usage of deprecated switch_to_*() selenium methods. 2014-07-24 08:25:15 -04:00
Anssi Kääriäinen
9cd5201abd Fixed #22994 -- regression with generic FK + admin list_view 
The reason for the regression was that the GenericForeignKey field isn't
something meta.get_field_by_name() should return. The reason is that a
couple of places in Django expects get_field_by_name() to work this way.
It could make sense to return GFKs from get_field_by_name(), but that
should likely be done as part of meta refactoring or virtual fields
refactoring patches.

Thanks to glicerinu@gmail.com for the report and to Tim for working on
the issue.
 2014-07-14 10:50:41 -04:00
Claude Paroz
22b2fb0ba1 Fixed #22939 -- Delayed admin_static backend detection 
Thanks generalov for the report.
 2014-07-12 18:49:43 +02:00
Claude Paroz
e167e96cfe Fixed #22223 -- Prevented over-escaping URLs in reverse() 
And follow more closely the class of characters defined in the
RFC 3986.
Thanks Erik van Zijst for the report and the initial patch, and
Tim Graham for the review.
 2014-07-09 09:54:34 +02:00
Tim Graham
89b9e6e5d6 Fixed #22909 -- Removed camelCasing in some tests. 
Thanks brylie.
 2014-07-07 19:08:42 -04:00
Riccardo Magliocchetti
68c9a72e29 Fixed #22894 -- Made admin add related/raw ID fields widgets customizable. 
Decoupled behavior and style from the RelatedFieldWidgetWrapper and
ForeignKeyRawIdWidget.
 2014-06-26 15:02:42 -04:00
Claude Paroz
c6a711d9e5 Removed some apps from ALWAYS_INSTALLED_APPS 2014-06-21 21:01:37 +02:00
Maxime Turcotte
504c89e800 Fixed #6327 -- Added has_module_permission method to BaseModelAdmin 
Thanks chrj for the suggestion.
 2014-06-13 09:31:40 -04:00
Tim Graham
99f5ea9cc8 Fixed #22653 -- Added some database feature flags to tests. 
Thanks Rahul Priyadarshi.
 2014-06-11 11:45:18 -04:00
Tim Graham
fea8ccdcc4 Removed unused import. 2014-06-09 18:41:35 -04:00
Aymeric Augustin
40bfd8561d Fixed #20420 -- Normalized query counts on Oracle. 
This is achieved by inserting a fake entry in connection.queries when
not releasing a savepoint (since Oracle doesn't support that operation.)

Also removed the can_release_savepoints feature that was recently added,
but is superseded by this solution.
 2014-06-09 21:38:10 +02:00
Nick Presta
11f0899bbe Fixed #11776 -- Added CSS class for non-field/top of form errors. 
Thanks Daniel Pope for the suggestion.
 2014-06-02 15:22:15 -04:00
Alex Gaynor
1dcc603eff Fixed several typos in Django 2014-05-28 17:39:14 -07:00
Stas Rudakou
ebd70d4d00 Fixed #22266 - quote PK before redirecting away from add_view (django.contrib.admin) 2014-05-16 18:33:17 +02:00
Claude Paroz
e520a73eee Harmonized some PEP 0263 coding preambles 2014-05-15 19:58:41 +02:00
Aymeric Augustin
c70a61eb49 Replaced vendor checks by three feature flags. 2014-05-08 22:11:15 +02:00
Alex Gaynor
2bcb8bfc8d Fix many many typos in comments throughout the codebase 2014-04-26 10:18:45 -07:00
Tim Graham
d238c58912 Fixed #22499 -- Fixed a typo in an admin_views test that caused failure on Oracle. 2014-04-24 07:06:02 -04:00
Alejandro Gómez
7a7f6fccae Fixed #21084 -- Used proxy model's content type for admin log entries. 2014-04-07 08:52:41 -04:00
Anubhav Joshi
cd914e31c9 Fixed #21977 -- Deprecated SimpleTestCase.urls 2014-04-06 17:33:43 -04:00
Tim Graham
d73d0e071c Fixed #22218 -- Deprecated django.conf.urls.patterns. 
Thanks Carl Meyer for the suggestion and Alex Gaynor and Carl for reviews.
 2014-04-03 07:28:10 -04:00
Loic Bistuer
4d996b8e69 Fixed #22360 -- Fixed two non-deterministic tests in Python 3.4. 
The order of admin's changelist filters in the querystring relied on
dict ordering.
 2014-03-31 08:19:43 -04:00
Loic Bistuer
4339e9a92d Fixed #21795 -- Made add_preserved_filters account for url prefixes. 
Thanks to trac username honyczek for the report. Refs #6903.
 2014-03-31 07:19:59 -04:00
Alex Gaynor
778ce245dd Corrected many style guide violations that the newest version of flake8 catches 2014-03-30 12:11:05 -07:00
Ben Davis
16afffffe8 Fixed #22087 -- Made AdminReadonlyField respect ModelForm Meta overrides. 2014-03-25 09:33:13 -04:00
Claude Paroz
c94bff2b26 Fixed #22241 -- Selectively added line breaks in admin read-only fields 
When content is supposed to contain HTML, we do not try to add
line breaks in read-only contents.
Thanks Alexander Todorov for the report.
 2014-03-22 17:00:50 +01:00
Rodolfo Carvalho
0d91225892 Fixed many typos in comments and docstrings. 
Thanks Piotr Kasprzyk for help with the patch.
 2014-03-03 07:38:09 -05:00
Greg Chapple
6acaa52386 Fixed #22135 -- Added ModelAdmin.get_changeform_initial_data(). 
Allows custom behavior for setting initial form data in ModelAdmin.
By default, initial data is set via GET params. The new method allows
this behavior to be overridden.

Thanks egasimus for the suggestion.
 2014-03-03 07:28:24 -05:00
Russell Keith-Magee
3c5fc708f1 Edited contrib.admin check messages for grammar and consistency. 2014-03-03 13:27:17 +08:00
Klemens Mantzos
f683cb90be Fixed #21924 -- Added the ability to specify a reverse order for admin_order_field. 
Thanks Klemens Mantzos for the report and initial patch.
 2014-02-14 19:53:44 -05:00
Christopher Adams
eefc88feef Fixed #2445 -- Allowed limit_choices_to attribute to be a callable. 
ForeignKey or ManyToManyField attribute ``limit_choices_to`` can now
be a callable that returns either a ``Q`` object or a dict.

Thanks michael at actrix.gen.nz for the original suggestion.
 2014-02-11 14:05:12 -05:00
julien 'pouete' Godin
f5123c7291 Fixed #21371 -- Added the block.super to admin bodyclass blocks. 
Thanks Keryn Knight for the report.
 2014-02-10 09:13:29 -05:00
Claude Paroz
343dfff133 Removed the this_is_the_login_form hack 
Refs #21911. Now that we have a more traditional login form, we
don't need any more a special field telling us we are dealing with
the login form.
 2014-02-04 20:02:28 +01:00
Claude Paroz
be0ad62994 Fixed #21911 -- Made admin views redirect to login when needed 
Historically, the Django admin used to pass through the request
from an unauthorized access to the login view directly. Now we
are using a proper redirection, which is also preventing
inadvertantly changing data when POSTing login data to an admin
view when user is already authorized.
Thanks Marc Tamlyn and Tim Graham for the reviews.
 2014-02-04 20:02:28 +01:00
Claude Paroz
5848bea9dc Made staff_member_required redirect to login 
Refs #21911.
 2014-02-04 20:02:28 +01:00
Simon Charette
10e3faf191 Fixed #19774 -- Deprecated the contenttypes.generic module. 
It contained models, forms and admin objects causing undesirable
import side effects. Refs #16368.

Thanks to Ramiro, Carl and Loïc for the review.
 2014-01-26 14:42:30 -05:00
Russell Keith-Magee
d818e0c9b2 Fixed #16905 -- Added extensible checks (nee validation) framework 
This is the result of Christopher Medrela's 2013 Summer of Code project.

Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.

Also: Fixes #8579, fixes #3055, fixes #19844.
 2014-01-20 10:45:21 +08:00
Aymeric Augustin
a7588e2e22 Removed useless model definitions. 
Surprisingly, this commit doesn't change any behavior at all. When a
model is defined with the same name as another model in the same app,
the definition of the first class is bound to the name of the class
regardless of the definition of the second class.
 2014-01-05 20:52:46 +01:00
Aymeric Augustin
e32095616c Imported override_settings from its new location. 2013-12-23 21:37:56 +01:00
Loic Bistuer
6685713869 Fixed E127 pep8 warnings. 2013-12-14 11:59:15 -05:00
Claude Paroz
c7c647419c Fixed #21510 -- Readded search reset link in changelist search bar 
Thanks moritz.pfeiffer at alp-phone.ch for the report and
Tim Graham for the initial patch.
 2013-12-11 15:30:20 +01:00
Jay Leadbetter
c74504c2dd Fixed #20522 - Allowed use of partially validated object in ModelAdmin.add_view formset validation. 
Updated ModelAdmin to use form.instance when passing parent model to
child inlines for add_view. There is effectively no change in the
change_view since the previously passed 'obj' is the same as form.instance.

Thanks to meshy for report, and EvilDMP and timo for review.
 2013-11-25 20:01:16 -05:00
Baptiste Mispelon
a739573e17 Fixed test breakage under python 3 introduced by a480f8320a. 2013-11-23 19:50:20 +01:00
Anssi Kääriäinen
752d3d70da Fixed #21431 -- GenRel->FK list_filter regression in admin 
Report, analysis and tests from stephenmcd.
 2013-11-21 14:52:00 +02:00
Loic Bistuer
8e670a0e50 Refs #8261 -- Fixed regression introduced by fd219fa. 
ModelAdmin displayed the "View on site" link even if the Model didn't
define the `get_absolute_url()` method.
 2013-11-21 16:26:49 +07:00
Jason Myers
7a61c68c50 PEP8 cleanup 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:50:49 -05:00
Jason Myers
3f115776e1 PEP8 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:50:38 -05:00
coagulant
8eec2d93b6 Fixed all E261 warnings 2013-11-02 23:50:33 -05:00
Tim Graham
36ded01527 Fixed #21302 -- Fixed unused imports and import *. 2013-11-02 15:24:56 -04:00
Unai Zalakain
fd219fa24c Fixed #8261 -- ModelAdmin hook for customising the "show on site" button 
``ModelAdmin.view_on_site`` defines wether to show a link to the object on the
admin detail page. If ``True``, cleverness (i.e. ``Model.get_absolute_url``) is
used to get the url. If it's a callable, the callable is called with the object
as the only parameter. If ``False``, not link is displayed.

With the aim of maitaining backwards compatibility, ``True`` is the default.
 2013-10-29 17:10:12 -04:00
Alex Gaynor
b35ff0d920 Fixed all the E203 violations 2013-10-26 18:27:42 -07:00
Renato Oliveira
43569647ab Fixed #21299 - Changed filters from title to capfirst on admin inline formsets. 
Previously there was a mixture of the two which resulted in inconsistent
casing.
 2013-10-24 14:44:07 -04:00
Alex Gaynor
9bf5610890 Start attacking E231 violations 2013-10-24 10:30:03 -07:00
Alasdair Nicol
c3aa2948c6 Fixed #21298 -- Fixed E301 pep8 warnings 2013-10-23 13:45:03 +01:00
Tim Graham
ae48d77ef8 Fixed E225 pep8 warnings. 2013-10-23 06:09:29 -04:00
Bouke Haarsma
3565efaa45 Removed some direct settings manipulations in tests; refs #21230. 2013-10-21 11:31:05 -04:00
Alasdair Nicol
b289fcf1bf Fixed #21288 -- Fixed E126 pep8 warnings 2013-10-21 08:31:30 -04:00