mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2024-12-23 01:25:58 +00:00
Code Issues 25 Releases Wiki Activity
33,160 Commits 28 Branches 426 Tags 666 MiB
1e05431881
Commit Graph

220 Commits

Author SHA1 Message Date
Nick Pope
4400d8296d
Fixed #30241 -- Added more system checks of translation settings. 2019-03-28 20:10:50 +01:00
Nick Pope
d4783048ef Refs #29713 -- Improved error message when LANGUAGE_CODE is invalid. 2019-03-28 20:04:24 +01:00
Hasan Ramezani
981dd6dd71
Fixed #28431 -- Added a system check for BinaryField to prevent strings defaults. 
Thanks Claude Paroz for the initial patch.
 2019-03-25 20:04:35 +01:00
Mariusz Felisiak
f69c7bbdce
Refs #29408 -- Cosmetic edits for validation of related fields and lookups in model Meta.ordering. 
Follow up to 440505cb2c.
 2019-03-01 19:38:21 +01:00
Hasan Ramezani
440505cb2c Fixed #29408 -- Added validation of related fields and lookups in model Meta.ordering. 2019-03-01 17:09:33 +01:00
Sanyam Khurana
5d25804eaf Fixed #20098 -- Added a check for model Meta.db_table collisions. 2018-12-24 10:40:11 -05:00
Nick Pope
c512912463 Refs #23801 -- Made integer field max_length warning show correct field type. 2018-11-23 14:40:46 -05:00
Artur Juraszek
817c6cdf0e Capitalized SecurityMiddleware headers for consistency with other headers. 
(No behavior change since HTTP headers are case insensitive.)
 2018-10-30 18:30:51 -04:00
Stefano Chiodino
6de7f9ec60 Fixed #29598 -- Deprecated FloatRangeField in favor of DecimalRangeField. 2018-10-02 19:17:23 -04:00
Przemysław Buczkowski
70d0a1ca02 Fixed #29711 -- Added a system check for uniquness of admin actions' __name__. 2018-10-02 09:17:23 -04:00
Paweł Kołodziej
05c578bc1f Fixed #29796 -- Added system check for STATICFILES_DIRS prefix ending with a slash. 2018-09-27 19:49:37 -04:00
Adam Johnson
245c36d7b6 Fixed #29642 -- Added check for arguments of custom error handler views. 2018-09-14 11:59:56 -04:00
Nick Pope
570402ffd7 Refs #29713 -- Improved error message from translation system check. 2018-09-06 13:49:25 +02:00
David
5db8d617c0 Fixed #29713 -- Added check that LANGUAGE_CODE uses standard language id format. 2018-09-03 10:43:55 +02:00
Simon Willison
586a9dc429 Fixed #26352 -- Made system check allow ManyToManyField to target the same model if through_fields differs. 2018-08-22 12:07:29 -04:00
Rodrigo
371ece2f06 Fixed #29695 -- Added system checks for admin's app dependencies and TEMPLATES setting. 2018-08-20 17:57:46 -04:00
Ian Foote
952f05a6db Fixed #11964 -- Added support for database check constraints. 2018-07-10 15:32:33 -04:00
Carlton Gibson
958c7b301e Fixed #29419 -- Allowed permissioning of admin actions. 2018-06-18 15:07:29 -04:00
Carlton Gibson
21fd8041c1
Refs #29358 -- Corrected wording in primary key check message. 2018-05-03 15:28:37 +02:00
Hasan Ramezani
816b8d9518 Fixed #29358 -- Added a system check to prohibit models with more than one primary_key field. 2018-05-03 09:08:29 +02:00
Tim Graham
5fa4f40f45 Fixed #29227 -- Allowed BooleanField to be null=True. 
Thanks Lynn Cyrin for contributing to the patch, and Nick Pope for review.
 2018-03-20 12:10:10 -04:00
shanghui
cc6bcc6ff5 Fixed #28867 -- Added system check for a model property that clashes with a related field accessor. 2018-01-03 10:34:31 -05:00
hui shang
f1aa58479c Fixed #28714 -- Added system checks for invalid model field names in Meta.indexes. 
Thanks Gabriel for the report and Adam Johnson for the review.
 2017-12-27 18:56:24 -05:00
Chris Lamb
998c9dd599 Fixed #28663 -- Add a check for likely incorrectly migrated django.urls.path() routes. 2017-11-07 11:39:59 -05:00
Adam Johnson
f8946fbb5d Removed docs for obsolete compatibility checks. 2017-10-30 12:39:42 -04:00
Flávio Juvenal
f6e1789654 Fixed #28577 -- Added checks for ArrayField and JSONField to prevent mutable defaults. 2017-10-20 13:17:22 -04:00
Flávio Juvenal
ea7ca5db30 Doc'd contrib.postgres system checks. 2017-09-27 10:58:48 -04:00
Sjoerd Job Postmus
df41b5a05d Fixed #28593 -- Added a simplified URL routing syntax per DEP 0201. 
Thanks Aymeric Augustin for shepherding the DEP and patch review.
Thanks Marten Kenbeek and Tim Graham for contributing to the code.
Thanks Tom Christie, Shai Berger, and Tim Graham for the docs.
 2017-09-20 18:04:42 -04:00
Johannes Hoppe
94cd8efc50 Fixed #14370 -- Allowed using a Select2 widget for ForeignKey and ManyToManyField in the admin. 
Thanks Florian Apolloner and Tim Graham for review and
contributing to the patch.
 2017-09-18 13:48:02 -04:00
michaldabski
d381914aef Fixed #28313 -- Added model name max length check of 100 characters in contrib.contentttypes. 2017-06-26 18:12:35 -04:00
Mariusz Felisiak
538bf43458 Fixed #27859 -- Ignored db_index for TextField/BinaryField on Oracle and MySQL. 
Thanks Zubair Alam for the initial patch and Tim Graham for the review.
 2017-05-23 17:02:40 +02:00
Mariusz Felisiak
a3af8c99d9 Removed extra characters in docs header underlines. 2017-03-20 18:30:32 -04:00
Adam Chainz
a452dddb25 Fixed #27904 -- Added a system check that Field.validators are callable. 2017-03-11 12:27:29 -05:00
Tim Graham
29f607927f Fixed spelling of "nonexistent". 2017-02-03 08:01:45 -05:00
Ling-Xiao Yang
0ec4dc91e0 Fixed #27661 -- Moved FileSystemFinder's ImproperlyConfigured exceptions to system checks. 
Thanks Simon Charette, Mariusz Felisiak, Tim Graham, and Adam Johnson
for review.
 2017-02-01 09:48:24 -05:00
Tim Graham
f6acd1d271 Refs #23919 -- Removed Python 2 notes in docs. 2017-01-18 11:51:29 -05:00
Tim Graham
6192bffb13 Refs #26601 -- Removed obsolete system check for MIDDLEWARE_CLASSES setting. 2017-01-17 20:52:05 -05:00
Tim Graham
98760ab0b2 Refs #25079 -- Removed obsolete system check for TEMPLATE_* settings. 2017-01-17 20:52:05 -05:00
Tim Graham
d334f46b7a Refs #26601 -- Removed support for old-style middleware using settings.MIDDLEWARE_CLASSES. 2017-01-17 20:52:04 -05:00
Tim Graham
bcf3532ede Refs #26154 -- Removed deprecated CommaSeparatedIntegerField. 2017-01-17 20:52:02 -05:00
Tim Graham
ab661e994b Alphabetized system check reference. 2017-01-05 11:04:44 -05:00
Adam Chainz
8669cf0e68 Fixed #27626 -- Moved MEDIA_URL/STATIC_URL validation to a system check. 2016-12-23 10:55:00 -05:00
Andrew Nester
24fa728a47 Fixed #27612 -- Added a check for duplicate URL instance namespaces. 2016-12-21 16:54:15 -05:00
Tim Graham
c27104a9c7 Fixed #27611 -- Doc'd that CSRF_COOKIE_HTTPONLY setting offers no security. 2016-12-19 17:56:58 -05:00
Henry Dang
6af23a4521 Fixed #27377 -- Clarified that prepopulated_fields doesn't work with OneToOneField. 2016-12-19 08:33:46 -05:00
Henry Dang
7cddd8a02e Fixed #27358 -- Added a system check to prevent FileField's upload_to from starting with a slash. 
Thanks Frank Bijlsma for the initial patch.
 2016-11-29 16:12:24 -05:00
Quentin Fulsher
f62abfc03d Fixed #27295 -- Added a system check to prohibit model names that start or end with an underscore or contain double underscores. 2016-11-22 10:14:10 -05:00
Michael Scott
ec9ed07488 Fixed #27188 -- Allowed using unique=True with FileField. 
Thanks Tim Graham for the initial patch.
 2016-10-28 20:11:03 -04:00
Nick Pope
81463ce0a1 Fixed typo in docs/ref/checks.txt. 2016-10-11 10:32:32 -04:00
Riccardo Magliocchetti
7ed8b98f42 Clarified URL regex check message with respect to include(). 2016-09-01 14:06:45 -04:00
Berker Peksag
426bca002c Fixed #26816 -- Corrected an admin check to require inlines to subclass InlineModelAdmin. 2016-08-24 17:34:32 -04:00
Collin Anderson
384f89f8f8 Fixed #26998 -- Reverted some admin checks from checking field.many_to_many back to isinstance(field, models.ManyToManyField). 
This partially reverts 983c158da7
 2016-08-23 16:00:12 -04:00
Ed Morley
7399fee6c3 Refs #26947 -- Added a deployment system check for SECURE_HSTS_PRELOAD. 2016-08-10 20:31:01 -04:00
Anderson Resende
ba53da894f Fixed #26796 -- Added a system check for m2m fields with ignored limit_choices_to. 2016-07-08 19:37:40 -04:00
Berker Peksag
0bce2f102c Fixed #12810 -- Added a check for clashing ManyToManyField.db_table names. 2016-06-10 10:57:22 -04:00
Michal Petrucha
686a593aaa Fixed #26648 -- Added a system check for invalid related_query_name's containing underscores. 2016-06-09 11:57:32 -04:00
Sergey Fedoseev
21130ce1a9 Fixed #26718 -- Added system check for existence of the fields specified by ForeignKey.to_field. 2016-06-09 10:19:09 -04:00
Vytis Banaitis
2f9c4e2b6f Fixed #19963 -- Added support for date_hierarchy across relations. 2016-06-04 12:14:02 -04:00
Alex Hill
779bb82f51 Fixed #26421 -- Refactored ModelSignal to use Apps.lazy_model_operation() 2016-05-19 21:33:36 -04:00
Alex Hill
2ff7ef15b0 Refs #26421 -- Refactored Apps.lazy_model_operation() for better checks and tests 2016-05-19 21:33:36 -04:00
Tim Graham
354acd04af Refs #26601 -- Added a warning if both MIDDLEWARE AND MIDDLEWARE_CLASSES are set. 2016-05-17 07:24:45 -04:00
Florian Apolloner
9baf692a58 Fixed #26601 -- Improved middleware per DEP 0005. 
Thanks Tim Graham for polishing the patch, updating the tests, and
writing documentation. Thanks Carl Meyer for shepherding the DEP.
 2016-05-17 07:22:22 -04:00
Tim Graham
03efa304bc Refs #25847 -- Added system check for UserModel.is_anonymous/is_authenticated methods. 2016-05-06 08:56:06 -04:00
Alasdair Nicol
eb5d7bc2f4 Fixed #26440 -- Added a warning for non-url()s in urlpatterns. 
Thanks Burhan Khalid for the initial patch and knbk/timgraham
for review.
 2016-04-30 20:09:31 -04:00
Claude Paroz
f9a2a7db17 Fixed #26351 -- Added MySQL check to warn about strict mode option 
Thanks Adam Chainz for the initial implementation in django-mysql.
Thanks Adam Chainz, Tim Graham, and Shai Berger for the reviews.
 2016-04-08 20:34:16 +02:00
Claude Paroz
0d3c616fbb Refs #26351 -- Added check hook to support database-related checks 
Thanks Tim Graham and Shai Berger for the reviews.
 2016-04-08 20:28:00 +02:00
Simon Charette
a872194802 Fixed #26470 -- Converted auth permission validation to system checks. 
Thanks Tim for the review.
 2016-04-06 22:40:43 -04:00
Vincenzo Pandolfo
abf07355aa Fixed #26365 -- Added a system check to ensure "string_is_invalid" is a string. 2016-03-21 13:01:38 -04:00
Claude Paroz
983c158da7 Refs #24227 -- Replaced M2M isinstance checks by field.many_to_many 
Thanks Markus Holtermann, Collin Anderson and Tim Graham for the reviews.
 2016-03-19 09:24:27 +01:00
Tim Graham
004ba0f99e Removed unneeded hint=None/obj=None in system check messages. 2016-02-12 13:01:25 -05:00
Brobin
dca8b916ff Fixed #26154 -- Deprecated CommaSeparatedIntegerField 2016-02-10 17:57:43 -05:00
rowanv
a6ef025dfb Fixed #26124 -- Added missing code formatting to docs headers. 2016-02-01 10:42:05 -05:00
Vincenzo Pandolfo
0490d72f2a Fixed #24116 -- Moved AdminSite.check_dependencies() to system checks. 2016-01-22 18:29:56 -05:00
Tim Graham
e519aab43a Fixed #23868 -- Added support for non-unique django-admin-options in docs. 
Also documented missing short command line options to fix #24134. This bumps
the minimum sphinx version required to build the docs to 1.3.4.

Thanks Simon Charette for review.
 2016-01-14 18:21:33 -05:00
Simon Charette
976bd519a8 Revert "Fixed #25417 -- Added a field check for invalid default values." 
This reverts commit 71ebcb85b9.
 2015-10-27 11:02:35 -04:00
Tim Graham
c7aff31397 Refs #25535 -- Minor edits to ForeignObject check changes. 2015-10-14 05:21:08 -07:00
Tim Graham
2a20ebe6a5 Removed deprecated TEMPLATE_* settings per deprecation timeline. 2015-09-23 19:31:11 -04:00
Tim Graham
04ee4059d7 Refs #24022 -- Removed the ssi tag per deprecation timeline. 2015-09-23 19:31:09 -04:00
Alasdair Nicol
fe3fc5210f Fixed #23813 -- Added checks for common URL pattern errors 
Thanks jwa and lamby for the suggestions, and timgraham and jarshwah
for their reviews.
 2015-09-21 23:46:21 +10:00
Simon Charette
71ebcb85b9 Fixed #25417 -- Added a field check for invalid default values. 2015-09-18 14:31:36 -04:00
Tom Christie
b02f08e02c Fixed #25034 -- Converted caches ImproperlyConfigured error to a system check. 2015-09-18 07:44:39 -04:00
Tim Graham
faa2a0f662 Fixed #25174 -- Moved some details of CheckMessage to the reference guide. 2015-07-31 08:21:34 -04:00
rroskam
ed514caed2 Fixed #24966 -- Added deployment system check for empty ALLOWED_HOSTS. 2015-07-15 09:18:58 -04:00
Daniel Roseman
24620d71f2 Fixed #25079 -- Added warning if both TEMPLATES and TEMPLATE_* settings are defined. 
Django ignores the value of the TEMPLATE_* settings if TEMPLATES is also
set, which is confusing for users following older tutorials. This change
adds a system check that warns if any of the TEMPLATE_* settings have
changed from their defaults but the TEMPLATES dict is also non-empty.

Removed the TEMPLATE_DIRS from the test settings file; this was marked
for removal in 1.10 but no tests fail if it is removed now.
 2015-07-13 17:50:22 -04:00
Tim Graham
b49e3ab92c Documented templates system check type. 2015-07-13 17:29:08 -04:00
Sergei Maertens
eaf4d8c0d8 Fixed #24922 -- Added system check for templates setting 
If `'loaders'` is present in the `TEMPLATES` options together with
`APP_DIRS` set to `True`, the template engine raises an exception. This
conflict is now detected by the system check templates.E001.
 2015-06-06 19:40:26 -04:00
Jon Dufresne
966a29c2b8 Fixed #24479 -- Added system check to prevent both ordering and order_wrt. 2015-03-21 08:16:28 -04:00
Tim Graham
c970018f41 Removed Django 1.7 MIDDLEWARE_CLASSES upgrade check. 2015-02-09 19:16:07 -05:00
Tim Graham
c79faae761 Removed versionadded/changed notes for 1.7. 2015-02-01 21:02:40 -05:00
Tim Graham
33457cd3b0 Removed IPAddressField per deprecation timeline; refs #20439. 2015-01-19 11:12:57 -05:00
Tim Graham
40a8504357 Fixed #23891 -- Moved deprecation of IPAddressField to system check framework. 
Thanks Markus Holtermann for review.
 2015-01-01 13:30:52 -05:00
Diego Guimarães
f39b0421b4 Fixed #23338 -- Added warning when unique=True on ForeigKey 
Thanks Jonathan Lindén for the initial patch, and Tim Graham
and Gabe Jackson for the suggestions.
 2014-11-27 19:42:30 -05:00
MattBlack85
e9d1f1182a Fixed #23801 -- Added warning when max_length is used with IntegerField 2014-11-26 18:41:54 -05:00
Tim Graham
c24a2e6cbd Fixed #23765 -- Removed BooleanField default check which often yielded false positives. 2014-11-13 20:12:29 +01:00
Tim Graham
098368d82f Added missing docs for 1_7.W001 check. 2014-11-13 17:56:29 +01:00
Tim Graham
7ae03204ac Fixed #23469 -- Removed test runner compatibility check which often yielded false positives. 2014-10-17 10:31:49 -04:00
Rigel Di Scala
a5c77417a6 Fixed #23615 -- Validate that a Model instance's "check" attribute is a method. 
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.

This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
 2014-10-16 23:49:21 +07:00
André Ericson
1e5e2a4707 Fixed #22064 -- Add check for related_name 
Validates that related_name is a valid Python id or ends with a '+' and
it's not a keyword. Without a check it passed silently leading to
unpredictable problems.

Thanks Konrad Świat for the initial work.
 2014-10-04 20:47:26 -03:00
Tim Graham
90761d00e3 Fixed spelling mistakes and added words to wordlist. 2014-09-29 17:43:16 -04:00
Tim Graham
52ef6a4726 Fixed #17101 -- Integrated django-secure and added check --deploy option 
Thanks Carl Meyer for django-secure and for reviewing.

Thanks also to Zach Borboa, Erik Romijn, Collin Anderson, and
Jorge Carleitao for reviews.
 2014-09-12 15:05:23 -04:00
Sébastien Fievet
5d04433903 Added missing periods in docs/ref/checks.txt. 2014-09-05 12:30:24 -04:00
Tim Graham
2ca244aae6 Fixed typo in docs/ref/checks.txt. 2014-09-04 12:31:33 -04:00
Anubhav Joshi
011abb7d96 Fixed #19671 -- Added warnings that null and validators are ignored for ManyToManyField. 
Thanks Loic Bistuer and Tim Graham for help and review.
 2014-07-09 16:01:09 -04:00
Anubhav Joshi
91f1b6dcdc Fixed #13711 -- Model check added to ensure that auto-generated column name is within limits of the database. 
Thanks russellm for report and Tim Graham for review.
 2014-06-17 16:16:02 -04:00
Tim Graham
5472bf4df0 Added formatting and line wrapping to checks reference doc. 2014-06-06 15:19:20 -04:00
Craig de Stigter
ce993efda8 Fixed #22690 -- Added a check for proxy models containing fields. 
Removed the FieldError raised by ModelBase.__new__ in this case.
 2014-06-02 09:32:38 -04:00
Markus Holtermann
9d8c73f6a1 Fixed #21905 -- Add info message if DateField or TimeField use a fixed value 2014-05-16 18:59:31 +02:00
Russell Keith-Magee
2c176eb95c Refs #21798 - Modified error number to provide room for future expansion. 2014-05-16 15:41:17 +02:00
Daniel Pyrathon
cb15231888 Fixed #21798 -- Added check for DateTime mutually exclusive options 
Added DateTimeCheckMixin to avoid the use of default, auto_now, and
auto_now_add options together. Added the fields.E151 Error that is raised
if one or more of these options are used together.
 2014-05-16 05:57:19 -04:00
Anders Steinlein
4ef10f245a Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin. 
Thanks Stephen Burrows for work on the patch as well.

Forwardport of 2914f66983 from stable/1.7.x
 2014-05-15 07:25:35 -04:00
Marc Egli
0bcc92c691 Fixed #22356 -- Added a check to make sure unique_together fields are local. 2014-04-14 16:49:40 -04:00
Akis Kesoglou
aaad3e27ac Fixed #22217 - ManyToManyField.through_fields fixes. 
- Docs description of arguments mix up.
- Keep it from erroneously masking E332 check.
- Add checks E338 and E339, tweak message of E337.
 2014-03-11 19:33:04 -03:00
Russell Keith-Magee
70ec4d776e Fixed #22034 -- Added a specific set of relation checks for GenericInlineModelAdmin. 
Thanks to jwa for the report.
 2014-03-08 11:25:23 +08:00
Tim Graham
8f9c3d0565 Fixed typo in docs/ref/checks.txt 2014-03-07 09:18:06 -05:00
Akis Kesoglou
c627da0ccc Fixed #14549 - Removed restriction of single FKs on intermediary tables 
Thanks to Loic Bistuer for review. Minor changes to error messages
done by committer.
 2014-03-05 22:33:58 +02:00
Russell Keith-Magee
c41335fa27 Added backwards compatibliity checks to reference documentation. 2014-03-03 19:20:48 +08:00
Russell Keith-Magee
5679fce87c Added first cut at reference documentation for the checks framework. 2014-03-03 18:56:11 +08:00
Baptiste Mispelon
ea4da8e63c Fixed some typos in the documentation. 
Thanks to Rodolfo Carvalho and Piotr Kasprzyk
for the patch.
 2014-03-02 17:05:57 +01:00
Szczepan Cieślik
e816198034 Fixed docs typos. 2014-02-25 10:28:32 -05:00
Russell Keith-Magee
d818e0c9b2 Fixed #16905 -- Added extensible checks (nee validation) framework 
This is the result of Christopher Medrela's 2013 Summer of Code project.

Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.

Also: Fixes #8579, fixes #3055, fixes #19844.
 2014-01-20 10:45:21 +08:00