mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-24 06:06:09 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #12241 -- Preserved query strings when using "Save and continue/add another" in admin.

Browse Source 
Co-authored-by: Grady Yu <gradyy@users.noreply.github.com>
Co-authored-by: David Sanders <shang.xiao.sanders@gmail.com>
Co-authored-by: Matthew Newton <matthewn@berkeley.edu>
This commit is contained in:
Mariana
2022-10-26 16:01:33 -07:00
committed by Mariusz Felisiak
parent 6e369f36f2
commit fc62e17778
3 changed files with 95 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

60
tests/admin_views/tests.py
View File

@@ -328,6 +328,66 @@ class AdminViewBasicTest(AdminViewBasicTestCase):
msg_prefix="Couldn't find an input with the right value in the response",
)
def test_add_query_string_persists(self):
save_options = [
{"_addanother": "1"}, # "Save and add another".
{"_continue": "1"}, # "Save and continue editing".
{"_saveasnew": "1"}, # "Save as new".
]
other_options = [
"",
"_changelist_filters=is_staff__exact%3D0",
f"{IS_POPUP_VAR}=1",
f"{TO_FIELD_VAR}=id",
]
url = reverse("admin:auth_user_add")
for i, save_option in enumerate(save_options):
for j, other_option in enumerate(other_options):
with self.subTest(save_option=save_option, other_option=other_option):
qsl = "username=newuser"
if other_option:
qsl = f"{qsl}&{other_option}"
response = self.client.post(
f"{url}?{qsl}",
{
"username": f"newuser{i}{j}",
"password1": "newpassword",
"password2": "newpassword",
**save_option,
},
)
parsed_url = urlparse(response.url)
self.assertEqual(parsed_url.query, qsl)
def test_change_query_string_persists(self):
save_options = [
{"_addanother": "1"}, # "Save and add another".
{"_continue": "1"}, # "Save and continue editing".
]
other_options = [
"",
"_changelist_filters=warm%3D1",
f"{IS_POPUP_VAR}=1",
f"{TO_FIELD_VAR}=id",
]
url = reverse("admin:admin_views_color_change", args=(self.color1.pk,))
for save_option in save_options:
for other_option in other_options:
with self.subTest(save_option=save_option, other_option=other_option):
qsl = "value=blue"
if other_option:
qsl = f"{qsl}&{other_option}"
response = self.client.post(
f"{url}?{qsl}",
{
"value": "gold",
"warm": True,
**save_option,
},
)
parsed_url = urlparse(response.url)
self.assertEqual(parsed_url.query, qsl)
def test_basic_edit_GET(self):
"""
A smoke test to ensure GET on the change_view works.