mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-31 09:41:08 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #32915 - Don't catch ImportErrors unless it's the settings module that can't be imported

Browse Source 
Based on work by Rohith PR and others in PR #14622
This commit is contained in:
Ben Cail
2022-11-01 14:55:40 -04:00
parent f05edb2b43
commit f992997fbe
4 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/settings_tests/tests.py
View File

@@ -338,6 +338,20 @@ class SettingsTests(SimpleTestCase):
with self.assertRaisesMessage(ValueError, "Incorrect timezone setting: test"):
settings._setup()
def test_unable_to_import_settings_module(self):
with self.assertRaisesMessage(
ImproperlyConfigured, "Settings module fake_settings_module could not be imported"
):
Settings('fake_settings_module')
def test_unable_to_import_a_random_module(self):
def mock_import_module(_):
raise ModuleNotFoundError("No module named 'fake_module'", name="fake_module")
with mock.patch("importlib.import_module", mock_import_module):
with self.assertRaisesMessage(ImportError, "No module named 'fake_module'"):
Settings('fake_settings_module')
class TestComplexSettingOverride(SimpleTestCase):
def setUp(self):