mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-10-23 21:59:11 +00:00
Code Issues 32 Releases Wiki Activity

Fixed #35839 -- Fixed crash when adding GeneratedField with db_comment on MySQL.

Browse Source 
Thanks Simon Charette for the test.

Signed-off-by: saJaeHyukc <wogur981208@gmail.com>
This commit is contained in:
saJaeHyukc
2025-02-22 18:47:03 +09:00
committed by Mariusz Felisiak
parent 87c5de3b7f
commit f7017db92c
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/schema/tests.py
View File

@@ -4861,6 +4861,24 @@ class SchemaTests(TransactionTestCase):
comment,
)
@skipUnlessDBFeature("supports_comments", "supports_stored_generated_columns")
def test_add_db_comment_generated_field(self):
comment = "Custom comment"
field = GeneratedField(
expression=Value(1),
db_persist=True,
output_field=IntegerField(),
db_comment=comment,
)
field.set_attributes_from_name("volume")
with connection.schema_editor() as editor:
editor.create_model(Author)
editor.add_field(Author, field)
self.assertEqual(
self.get_column_comment(Author._meta.db_table, "volume"),
comment,
)
@skipUnlessDBFeature("supports_comments")
def test_add_db_comment_and_default_charfield(self):
comment = "Custom comment with default"